[jira] [Assigned] (HIVE-24638) Redundant filter in scalar subquery
[
https://issues.apache.org/jira/browse/HIVE-24638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesus Camacho Rodriguez reassigned HIVE-24638:
--
Assignee: Soumyakanti Das (was: Vineet Garg)
> Redundant filter in scalar subquery
>
>
> Key: HIVE-24638
> URL: https://issues.apache.org/jira/browse/HIVE-24638
> Project: Hive
> Issue Type: Improvement
>Reporter: Mustafa İman
>Assignee: Soumyakanti Das
>Priority: Major
>
> Look at the query and CBO plan in
> https://issues.apache.org/jira/browse/HIVE-24595 .
> Note that there is a filter to guarantee that subquery returns only one row:
> "HiveFilter(condition=[<=(sq_count_check($0), 1)])" . This condition is
> redundant as either sq_count_check fails in runtime or condition is true for
> all rows.
> Look at the stacktrace
> {code:java}
> at
> org.apache.hadoop.hive.ql.udf.generic.GenericUDFSQCountCheck.evaluate(GenericUDFSQCountCheck.java:70)
> at
> org.apache.hadoop.hive.ql.udf.generic.GenericUDFSQCountCheck.evaluate(GenericUDFSQCountCheck.java:70)
> at
> org.apache.hadoop.hive.ql.exec.ExprNodeGenericFuncEvaluator._evaluate(ExprNodeGenericFuncEvaluator.java:197)
> at
> org.apache.hadoop.hive.ql.exec.ExprNodeEvaluator.evaluate(ExprNodeEvaluator.java:80)
> at
> org.apache.hadoop.hive.ql.exec.ExprNodeGenericFuncEvaluator$DeferredExprObject.get(ExprNodeGenericFuncEvaluator.java:88)
> at
> org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPEqualOrLessThan.evaluate(GenericUDFOPEqualOrLessThan.java:111)
> at
> org.apache.hadoop.hive.ql.exec.ExprNodeGenericFuncEvaluator._evaluate(ExprNodeGenericFuncEvaluator.java:197)
> at
> org.apache.hadoop.hive.ql.exec.ExprNodeEvaluator.evaluate(ExprNodeEvaluator.java:80)
> at
> org.apache.hadoop.hive.ql.exec.ExprNodeEvaluator.evaluate(ExprNodeEvaluator.java:68)
> at
> org.apache.hadoop.hive.ql.exec.FilterOperator.process(FilterOperator.java:113)
> at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:888) at
> org.apache.hadoop.hive.ql.exec.GroupByOperator.forward(GroupByOperator.java:1004)
> at
> org.apache.hadoop.hive.ql.exec.GroupByOperator.flush(GroupByOperator.java:1028)
> {code}
> GenericUDFOPEqualOrLessThan is redundant here as GenericUDFSQCountCheck does
> the same check.
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-24868) Support specifying Respect/Ignore Nulls in function parameter list
[
https://issues.apache.org/jira/browse/HIVE-24868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesus Camacho Rodriguez updated HIVE-24868:
---
Fix Version/s: 4.0.0
> Support specifying Respect/Ignore Nulls in function parameter list
> --
>
> Key: HIVE-24868
> URL: https://issues.apache.org/jira/browse/HIVE-24868
> Project: Hive
> Issue Type: Improvement
> Components: Parser
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code}
> select last_value(b ignore nulls) over(partition by a order by b) from t1;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24339) REPL LOAD command ignores config properties set by WITH clause
[
https://issues.apache.org/jira/browse/HIVE-24339?focusedWorklogId=569485=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569485
]
ASF GitHub Bot logged work on HIVE-24339:
-
Author: ASF GitHub Bot
Created on: 22/Mar/21 00:52
Start Date: 22/Mar/21 00:52
Worklog Time Spent: 10m
Work Description: github-actions[bot] closed pull request #1864:
URL: https://github.com/apache/hive/pull/1864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 569485)
Time Spent: 40m (was: 0.5h)
> REPL LOAD command ignores config properties set by WITH clause
> --
>
> Key: HIVE-24339
> URL: https://issues.apache.org/jira/browse/HIVE-24339
> Project: Hive
> Issue Type: Bug
>Reporter: László Bodor
>Assignee: Ayush Saxena
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> By debug messages we confirmed that REPL LOAD command ignored some config
> properties when they were provided in WITH clause, e.g.:
> {code}
> REPL LOAD bdpp01pub FROM
> 'hdfs://prdpdp01//apps/hive/repl/8237c7bd-ba26-4425-8659-3a0d32ab312c' WITH
> ('mapreduce.job.queuename'='default','hive.exec.parallel'='true','hive.exec.parallel.thread.number'='128',
> ...
> {code}
> We found that it was working on 16 threads, ignoring
> 'hive.exec.parallel.thread.number'='128'. Setting this property on session
> level worked.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24648) Clean up FetchTask and related classes
[ https://issues.apache.org/jira/browse/HIVE-24648?focusedWorklogId=569484=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569484 ] ASF GitHub Bot logged work on HIVE-24648: - Author: ASF GitHub Bot Created on: 22/Mar/21 00:52 Start Date: 22/Mar/21 00:52 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #1877: URL: https://github.com/apache/hive/pull/1877#issuecomment-803695891 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 569484) Time Spent: 20m (was: 10m) > Clean up FetchTask and related classes > -- > > Key: HIVE-24648 > URL: https://issues.apache.org/jira/browse/HIVE-24648 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > FetchTask is FetchOperator and FetchWork are messy, containing a lot off > unused codes too. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24396) [New Feature] Add data connector support for remote datasources
[
https://issues.apache.org/jira/browse/HIVE-24396?focusedWorklogId=569463=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569463
]
ASF GitHub Bot logged work on HIVE-24396:
-
Author: ASF GitHub Bot
Created on: 21/Mar/21 20:34
Start Date: 21/Mar/21 20:34
Worklog Time Spent: 10m
Work Description: vnhive commented on a change in pull request #2037:
URL: https://github.com/apache/hive/pull/2037#discussion_r598073734
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/database/desc/DescDatabaseOperation.java
##
@@ -52,14 +53,22 @@ public int execute() throws HiveException {
params = new TreeMap<>(database.getParameters());
}
- String location = database.getLocationUri();
- if (HiveConf.getBoolVar(context.getConf(),
HiveConf.ConfVars.HIVE_IN_TEST)) {
-location = "location/in/test";
- }
-
+ String location = "";
DescDatabaseFormatter formatter =
DescDatabaseFormatter.getFormatter(context.getConf());
- formatter.showDatabaseDescription(outStream, database.getName(),
database.getDescription(), location,
- database.getManagedLocationUri(), database.getOwnerName(),
database.getOwnerType(), params);
+ if (database.getType() == DatabaseType.NATIVE) {
+location = database.getLocationUri();
+if (HiveConf.getBoolVar(context.getConf(),
HiveConf.ConfVars.HIVE_IN_TEST)) {
+ location = "location/in/test";
+}
+// database.setRemote_dbname("");
+// database.setConnector_name("");
+
+formatter.showDatabaseDescription(outStream, database.getName(),
database.getDescription(), location,
+ database.getManagedLocationUri(), database.getOwnerName(),
database.getOwnerType(), params, "", "");
+ } else {
+formatter.showDatabaseDescription(outStream, database.getName(),
database.getDescription(), "", "",
+ database.getOwnerName(), database.getOwnerType(), params,
database.getConnector_name(), database.getRemote_dbname());
+ }
} catch (Exception e) {
throw new HiveException(e, ErrorMsg.GENERIC_ERROR);
Review comment:
showDatabaseDescription throws a HiveException, why are we casting it to
an Exception, then wrapping it in a HiveException? Can we please consider
skipping this?
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/dataconnector/alter/properties/AlterDataConnectorSetPropertiesDesc.java
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.ddl.dataconnector.alter.properties;
+
+import java.util.Map;
+
+import
org.apache.hadoop.hive.ql.ddl.dataconnector.alter.AbstractAlterDataConnectorDesc;
+import org.apache.hadoop.hive.ql.parse.ReplicationSpec;
+import org.apache.hadoop.hive.ql.plan.Explain;
+import org.apache.hadoop.hive.ql.plan.Explain.Level;
+
+/**
+ * DDL task description for ALTER CONNECTOR ... SET PROPERTIES ... commands.
+ */
+@Explain(displayName = "Set Connector Properties", explainLevels = {
Level.USER, Level.DEFAULT, Level.EXTENDED })
Review comment:
So the displayName "ALTER CONNECTOR ... SET PROPERTIES ... commands" is
the more appropriate semantics for the command isn't it ? Does this need to be
changed ?
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/dataconnector/alter/AbstractAlterDataConnectorOperation.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
[jira] [Work logged] (HIVE-24861) Hive JDBC driver doesn't consider the value of 'hasMoreRows'
[
https://issues.apache.org/jira/browse/HIVE-24861?focusedWorklogId=569445=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569445
]
ASF GitHub Bot logged work on HIVE-24861:
-
Author: ASF GitHub Bot
Created on: 21/Mar/21 18:29
Start Date: 21/Mar/21 18:29
Worklog Time Spent: 10m
Work Description: ellieMayVelasquez commented on a change in pull request
#2070:
URL: https://github.com/apache/hive/pull/2070#discussion_r598319032
##
File path:
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestHiveQueryResultSet.java
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hive.jdbc;
+
+import java.sql.ResultSet;
+import java.sql.Statement;
+import java.util.Properties;
+
+import org.junit.Test;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.api.FieldSchema;
+import org.apache.hadoop.hive.metastore.api.Schema;
+import org.apache.hive.service.cli.RowSet;
+import org.apache.hive.service.cli.RowSetFactory;
+import org.apache.hive.service.cli.TableSchema;
+import org.apache.hive.service.cli.thrift.EmbeddedThriftBinaryCLIService;
+import org.apache.hive.service.rpc.thrift.TFetchResultsReq;
+import org.apache.hive.service.rpc.thrift.TFetchResultsResp;
+import org.apache.hive.service.rpc.thrift.TRowSet;
+import org.apache.hive.service.rpc.thrift.TStatus;
+import org.apache.hive.service.rpc.thrift.TStatusCode;
+import org.apache.thrift.TException;
+
+import static
org.apache.hive.jdbc.EmbeddedCLIServicePortal.EMBEDDED_CLISERVICE;
+import static org.apache.hive.jdbc.Utils.URL_PREFIX;
+import static
org.apache.hive.service.rpc.thrift.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10;
+import static org.junit.Assert.assertEquals;
+
+public class TestHiveQueryResultSet {
+ private static final String EMIT_EMPTY_ROWS = "hive.test.emit.empty.rows";
+ private static final String EMIT_NUM_ROWS = "hive.test.emit.num.rows";
+
+ // Create subclass of EmbeddedThriftBinaryCLIService
+ public static class MyThriftBinaryCLIService extends
EmbeddedThriftBinaryCLIService {
+private TStatus success = new TStatus(TStatusCode.SUCCESS_STATUS);
+private boolean emitEmptyRows;
+private int numRows;
+private int position;
+private int emptyRowPos;
+
+@Override
+public synchronized void init(HiveConf hiveConf) {
+ hiveConf.setBoolean("hive.support.concurrency", false);
+ this.emitEmptyRows = hiveConf.getBoolean(EMIT_EMPTY_ROWS, false);
+ this.numRows = hiveConf.getInt(EMIT_NUM_ROWS, 10);
+ this.emptyRowPos = (numRows / 2);
+ this.position = 0;
+ super.init(hiveConf);
+}
+
+@Override
+public TFetchResultsResp FetchResults(TFetchResultsReq req) throws
TException {
Review comment:
I detect that this code is problematic. According to the [Bad practice
(BAD_PRACTICE)](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#bad-practice-bad-practice),
[Nm: Method names should start with a lower case letter
(NM_METHOD_NAMING_CONVENTION)](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#nm-method-names-should-start-with-a-lower-case-letter-nm-method-naming-convention).
Methods should be verbs, in mixed case with the first letter lowercase, with
the first letter of each internal word capitalized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 569445)
Time Spent: 20m (was: 10m)
> Hive JDBC driver doesn't consider the value of 'hasMoreRows'
>
>
> Key: HIVE-24861
> URL: https://issues.apache.org/jira/browse/HIVE-24861
> Project: Hive
> Issue Type: Bug
> Components: JDBC
>Reporter: Zoltán Borók-Nagy
>Priority: Major
>
[jira] [Work logged] (HIVE-24909) Skip the repl events from getting logged in notification log
[ https://issues.apache.org/jira/browse/HIVE-24909?focusedWorklogId=569408=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569408 ] ASF GitHub Bot logged work on HIVE-24909: - Author: ASF GitHub Bot Created on: 21/Mar/21 15:35 Start Date: 21/Mar/21 15:35 Worklog Time Spent: 10m Work Description: hmangla98 closed pull request #2096: URL: https://github.com/apache/hive/pull/2096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 569408) Time Spent: 20m (was: 10m) > Skip the repl events from getting logged in notification log > > > Key: HIVE-24909 > URL: https://issues.apache.org/jira/browse/HIVE-24909 > Project: Hive > Issue Type: Bug >Reporter: Haymant Mangla >Assignee: Haymant Mangla >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Currently REPL dump events are logged and replicated as a part of replication > policy. Whenever one replication cycle completed, we always have one > transaction left open on the target corresponding to repl dump operation. > This will never be caught up without manually dealing with the transaction on > target cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-24909) Skip the repl events from getting logged in notification log
[ https://issues.apache.org/jira/browse/HIVE-24909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-24909: -- Labels: pull-request-available (was: ) > Skip the repl events from getting logged in notification log > > > Key: HIVE-24909 > URL: https://issues.apache.org/jira/browse/HIVE-24909 > Project: Hive > Issue Type: Bug >Reporter: Haymant Mangla >Assignee: Haymant Mangla >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Currently REPL dump events are logged and replicated as a part of replication > policy. Whenever one replication cycle completed, we always have one > transaction left open on the target corresponding to repl dump operation. > This will never be caught up without manually dealing with the transaction on > target cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24909) Skip the repl events from getting logged in notification log
[ https://issues.apache.org/jira/browse/HIVE-24909?focusedWorklogId=569391=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569391 ] ASF GitHub Bot logged work on HIVE-24909: - Author: ASF GitHub Bot Created on: 21/Mar/21 14:08 Start Date: 21/Mar/21 14:08 Worklog Time Spent: 10m Work Description: hmangla98 opened a new pull request #2096: URL: https://github.com/apache/hive/pull/2096 What changes were proposed in this pull request? Skip the repl events from getting logged in notification log Why are the changes needed? Currently REPL dump events are logged and replicated as a part of replication policy. Whenever one replication cycle completed, we always have one transaction left open on the target corresponding to repl dump operation. This will never be caught up without manually dealing with the transaction on target cluster. Does this PR introduce any user-facing change? No How was this patch tested? Added one test => TestDbNotificationListener#testReplEvents -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 569391) Remaining Estimate: 0h Time Spent: 10m > Skip the repl events from getting logged in notification log > > > Key: HIVE-24909 > URL: https://issues.apache.org/jira/browse/HIVE-24909 > Project: Hive > Issue Type: Bug >Reporter: Haymant Mangla >Assignee: Haymant Mangla >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently REPL dump events are logged and replicated as a part of replication > policy. Whenever one replication cycle completed, we always have one > transaction left open on the target corresponding to repl dump operation. > This will never be caught up without manually dealing with the transaction on > target cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-24437) Add more removed configs for(Don't fail config validation for removed configs)
[ https://issues.apache.org/jira/browse/HIVE-24437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JiangZhu updated HIVE-24437: Description: When I upgrade the hive version from 1.x to 2.x. Some removed configs will report errors. Add more removed configs for(HIVE-14132 Don't fail config validation for removed configs) was:Add more removed configs for(HIVE-14132 Don't fail config validation for removed configs) > Add more removed configs for(Don't fail config validation for removed configs) > -- > > Key: HIVE-24437 > URL: https://issues.apache.org/jira/browse/HIVE-24437 > Project: Hive > Issue Type: Improvement >Affects Versions: 2.3.7 >Reporter: JiangZhu >Assignee: JiangZhu >Priority: Major > Attachments: HIVE-24437.1.patch > > > When I upgrade the hive version from 1.x to 2.x. Some removed configs will > report errors. > Add more removed configs for(HIVE-14132 Don't fail config validation for > removed configs) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24881) Abort old open replication txns
[
https://issues.apache.org/jira/browse/HIVE-24881?focusedWorklogId=569329=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569329
]
ASF GitHub Bot logged work on HIVE-24881:
-
Author: ASF GitHub Bot
Created on: 21/Mar/21 09:10
Start Date: 21/Mar/21 09:10
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #2068:
URL: https://github.com/apache/hive/pull/2068#discussion_r598247086
##
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##
@@ -5086,8 +5093,10 @@ public void performTimeOuts() {
while(true) {
stmt = dbConn.createStatement();
String s = " \"TXN_ID\" FROM \"TXNS\" WHERE \"TXN_STATE\" = " +
TxnStatus.OPEN +
-" AND \"TXN_LAST_HEARTBEAT\" < " + getEpochFn(dbProduct) + "-" +
timeout +
-" AND \"TXN_TYPE\" != " + TxnType.REPL_CREATED.getValue();
+" AND \"TXN_LAST_HEARTBEAT\" < " + getEpochFn(dbProduct) + "-" +
+(replication ? replicationTxnTimeout : timeout) +
+" AND \"TXN_TYPE\" " +
Review comment:
TXN_TYPE will always be REPL_CREATED for replication. This check looks
incorrect.
It could be something like if txn type is REPL_CREATED, use
replicationTxnTimeout else timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 569329)
Time Spent: 2.5h (was: 2h 20m)
> Abort old open replication txns
> ---
>
> Key: HIVE-24881
> URL: https://issues.apache.org/jira/browse/HIVE-24881
> Project: Hive
> Issue Type: Bug
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> We should auto-abort/remove open replication txns that are older than a time
> threshold (default: 24h).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24881) Abort old open replication txns
[
https://issues.apache.org/jira/browse/HIVE-24881?focusedWorklogId=569328=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569328
]
ASF GitHub Bot logged work on HIVE-24881:
-
Author: ASF GitHub Bot
Created on: 21/Mar/21 09:07
Start Date: 21/Mar/21 09:07
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #2068:
URL: https://github.com/apache/hive/pull/2068#discussion_r598246581
##
File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager.java
##
@@ -486,6 +505,8 @@ public void setUp() throws Exception {
conf.setTimeVar(HiveConf.ConfVars.HIVE_TIMEDOUT_TXN_REAPER_START, 0,
TimeUnit.SECONDS);
conf.setTimeVar(HiveConf.ConfVars.HIVE_TXN_TIMEOUT, 10, TimeUnit.SECONDS);
houseKeeperService = new AcidHouseKeeperService();
+MetastoreConf.setTimeVar(conf, MetastoreConf.ConfVars.REPL_TXN_TIMEOUT, 1,
TimeUnit.MINUTES);
Review comment:
Do we need the test time interval to be a min? Or it can be lesser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 569328)
Time Spent: 2h 20m (was: 2h 10m)
> Abort old open replication txns
> ---
>
> Key: HIVE-24881
> URL: https://issues.apache.org/jira/browse/HIVE-24881
> Project: Hive
> Issue Type: Bug
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We should auto-abort/remove open replication txns that are older than a time
> threshold (default: 24h).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
