[jira] [Work stopped] (HIVE-27361) Add table level comments to Hive tables in SYS & Information schema databases to make them self explanatory

2024-04-18 Thread Smruti Biswal (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HIVE-27361 stopped by Smruti Biswal.

> Add table level comments to Hive tables in SYS & Information schema databases 
> to make them self explanatory
> ---
>
> Key: HIVE-27361
> URL: https://issues.apache.org/jira/browse/HIVE-27361
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Taraka Rama Rao Lethavadla
>Assignee: Smruti Biswal
>Priority: Minor
>
> All the backend database tables are available to query in Hive as external 
> tables in SYS and information_schema databases. We can add a table level 
> comment to each of the table while creating them in Hive, so that users can 
> do desc formatted table_name to check the information about that table



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work started] (HIVE-27361) Add table level comments to Hive tables in SYS & Information schema databases to make them self explanatory

2024-04-18 Thread Smruti Biswal (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HIVE-27361 started by Smruti Biswal.

> Add table level comments to Hive tables in SYS & Information schema databases 
> to make them self explanatory
> ---
>
> Key: HIVE-27361
> URL: https://issues.apache.org/jira/browse/HIVE-27361
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Taraka Rama Rao Lethavadla
>Assignee: Smruti Biswal
>Priority: Minor
>
> All the backend database tables are available to query in Hive as external 
> tables in SYS and information_schema databases. We can add a table level 
> comment to each of the table while creating them in Hive, so that users can 
> do desc formatted table_name to check the information about that table



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (HIVE-27361) Add table level comments to Hive tables in SYS & Information schema databases to make them self explanatory

2024-04-18 Thread Smruti Biswal (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-27361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Smruti Biswal reassigned HIVE-27361:


Assignee: Smruti Biswal  (was: Taraka Rama Rao Lethavadla)

> Add table level comments to Hive tables in SYS & Information schema databases 
> to make them self explanatory
> ---
>
> Key: HIVE-27361
> URL: https://issues.apache.org/jira/browse/HIVE-27361
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Taraka Rama Rao Lethavadla
>Assignee: Smruti Biswal
>Priority: Minor
>
> All the backend database tables are available to query in Hive as external 
> tables in SYS and information_schema databases. We can add a table level 
> comment to each of the table while creating them in Hive, so that users can 
> do desc formatted table_name to check the information about that table



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work started] (HIVE-28205) Implement direct sql for get_partitions_ps_with_auth api

2024-04-18 Thread Wechar (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-28205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HIVE-28205 started by Wechar.
-
> Implement direct sql for get_partitions_ps_with_auth api
> 
>
> Key: HIVE-28205
> URL: https://issues.apache.org/jira/browse/HIVE-28205
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Wechar
>Assignee: Wechar
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HIVE-28205) Implement direct sql for get_partitions_ps_with_auth api

2024-04-18 Thread Wechar (Jira)
Wechar created HIVE-28205:
-

 Summary: Implement direct sql for get_partitions_ps_with_auth api
 Key: HIVE-28205
 URL: https://issues.apache.org/jira/browse/HIVE-28205
 Project: Hive
  Issue Type: Improvement
  Components: Hive
Reporter: Wechar
Assignee: Wechar






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HIVE-28082) HiveAggregateReduceFunctionsRule could generate an inconsistent result

2024-04-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-28082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HIVE-28082:
--
Labels: pull-request-available  (was: )

> HiveAggregateReduceFunctionsRule could generate an inconsistent result
> --
>
> Key: HIVE-28082
> URL: https://issues.apache.org/jira/browse/HIVE-28082
> Project: Hive
>  Issue Type: Bug
>  Components: CBO
>Affects Versions: 4.0.0-beta-1
>Reporter: Shohei Okumiya
>Assignee: Shohei Okumiya
>Priority: Major
>  Labels: pull-request-available
>
> HiveAggregateReduceFunctionsRule translates AVG, STDDEV_POP, STDDEV_SAMP, 
> VAR_POP, and VAR_SAMP. Those UDFs accept string types and try to decode them 
> as floating point values. It is possible that undecodable values exist.
> We found that it could cause inconsistent behaviors with or without CBO.
> {code:java}
> 0: jdbc:hive2://hive-hiveserver2:1/defaul> SELECT AVG('text');
> ...
> +--+
> | _c0  |
> +--+
> | 0.0  |
> +--+
> 1 row selected (18.229 seconds)
> 0: jdbc:hive2://hive-hiveserver2:1/defaul> set hive.cbo.enable=false;
> No rows affected (0.013 seconds)
> 0: jdbc:hive2://hive-hiveserver2:1/defaul> SELECT AVG('text');
> ...
> +---+
> |  _c0  |
> +---+
> | NULL  |
> +---+ {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HIVE-27102) Upgrade Calcite to 1.33.0 and Avatica to 1.23.0

2024-04-18 Thread Frank Grimes (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-27102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838656#comment-17838656
 ] 

Frank Grimes commented on HIVE-27102:
-

Any update on this? I see that Hive 4.0.0 has recently been released but it 
still uses calcite-1.2.5 which we believe is still vulnerable to the following:

  - [CVE-2020-13955 - Missing Authentication for Critical Function in Apache 
Calcite|https://nvd.nist.gov/vuln/detail/CVE-2020-13955]
  - [CVE-2022-39135 -Apache Calcite before 1.32.0 vulnerable to potential XML 
External Entity (XXE) attack|https://nvd.nist.gov/vuln/detail/CVE-2022-39135]

> Upgrade Calcite to 1.33.0 and Avatica to 1.23.0
> ---
>
> Key: HIVE-27102
> URL: https://issues.apache.org/jira/browse/HIVE-27102
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Stamatis Zampetakis
>Assignee: Stamatis Zampetakis
>Priority: Major
>
> New versions for Calcite and Avatica are available so we should upgrade to 
> them.
> I had some WIP in HIVE-26610 for upgrading calcite to 1.32.0 but given that 
> the work was not in very advanced state it is preferred to jump directly to 
> 1.33.0.
> Avatica must be inline with Calcite so both need to be updated at the same 
> time.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HIVE-28019) Fix query type information in proto files for load and explain queries

2024-04-18 Thread Stamatis Zampetakis (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-28019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838616#comment-17838616
 ] 

Stamatis Zampetakis commented on HIVE-28019:


Thanks for elaborating more and sharing your perspective [~rameshkumar].

The PREHOOK and POSTHOOK messages are emitted by the PreExecutePrinter and 
PostExecutePrinter hooks and by looking at the git history I get the impression 
that these were added only for testing purposes. I guess this hooks are not 
(and were not meant to be) used by end users. In principle, we could do any 
kind of change there that could facilitate testing without worrying too much 
about backwards compatibility. 

The {{commandType}} became part of the pre/post output in HIVE-854 but the 
respective JIRA and history do not have enough info on why this was done. Given 
that {{commandType}} was added in {{SessionState}} as part of HIVE-854, I 
assume that the intention of printing it in qtests was to verify that it is set 
correctly, and it reflects the authorization implications of each statement. In 
that sense, if we now change the type there to be EXPLAIN then in terms of 
testing we lose the information of what authorization mode applies to the 
statement under test.

Moreover, in terms of testing the {{PREHOOK: query:}} entry shows clearly if we 
are dealing with an EXPLAIN query (or not) so from my perspective changing also 
the type to EXPLAIN will lead to reduced test coverage so the proposed changed 
does not look as an improvement.

The same reasoning more or less applies to the HiveProtoLoggingHook but this 
class is something that is meant to be used in production so changes here will 
have more impact to the end-users.

In both cases, I would suggest to keep the type field in the output unchanged. 
If we need to distinguish if a query is an EXPLAIN this could be done by an 
additional field but I also feel that this is not strongly required since it 
can be easily inferred via a regular expression in the output.

As I wrote previously, the appropriate content for the type field in the hooks 
is a bit subjective so the best way to move forward is to gather opinions from 
more people. I am perfectly fine to follow the majority if others feels that 
the query type in the aforementioned hooks should change.


> Fix query type information in proto files for load and explain queries
> --
>
> Key: HIVE-28019
> URL: https://issues.apache.org/jira/browse/HIVE-28019
> Project: Hive
>  Issue Type: Task
>  Components: HiveServer2
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
>  Labels: pull-request-available
>
> Certain query types like LOAD, export, import and explain queries did not 
> produce the right Hive operation type



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HIVE-28203) Fix qtest mv_iceberg_orc5.q

2024-04-18 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-28203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa resolved HIVE-28203.
---
Fix Version/s: 4.1.0
   Resolution: Fixed

Merged to master. Thanks [~zhangbutao] for the patch and [~dkuzmenko] for 
review.

> Fix qtest mv_iceberg_orc5.q
> ---
>
> Key: HIVE-28203
> URL: https://issues.apache.org/jira/browse/HIVE-28203
> Project: Hive
>  Issue Type: Task
>  Components: Iceberg integration
>Reporter: Butao Zhang
>Assignee: Butao Zhang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.1.0
>
>
> [http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5190/3/tests]
> [http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5195/4/tests]
>  
> Flaky CI report:
> [http://ci.hive.apache.org/job/hive-flaky-check/837/testReport/] 
>  
> {code:java}
> Execution succeeded but contained differences (error code = 1) after 
> executing mv_iceberg_orc5.q 
> 101c101
> < HiveJoin(condition=[AND(IS NOT DISTINCT FROM($0, $5), IS NOT DISTINCT 
> FROM($1, $6))], joinType=[right], algorithm=[BucketJoin], cost=[not 
> available])
> ---
> > HiveJoin(condition=[AND(IS NOT DISTINCT FROM($0, $5), IS NOT DISTINCT 
> > FROM($1, $6))], joinType=[right], algorithm=[none], cost=[not available])
> 106c106
> <   HiveJoin(condition=[=($0, $3)], joinType=[inner], 
> algorithm=[CommonJoin], cost=[not available])
> ---
> >   HiveJoin(condition=[=($0, $3)], joinType=[inner], 
> > algorithm=[none], cost=[not available]) {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (HIVE-28203) Fix qtest mv_iceberg_orc5.q

2024-04-18 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-28203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa reassigned HIVE-28203:
-

Assignee: Butao Zhang

> Fix qtest mv_iceberg_orc5.q
> ---
>
> Key: HIVE-28203
> URL: https://issues.apache.org/jira/browse/HIVE-28203
> Project: Hive
>  Issue Type: Task
>  Components: Iceberg integration
>Reporter: Butao Zhang
>Assignee: Butao Zhang
>Priority: Major
>  Labels: pull-request-available
>
> [http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5190/3/tests]
> [http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5195/4/tests]
>  
> Flaky CI report:
> [http://ci.hive.apache.org/job/hive-flaky-check/837/testReport/] 
>  
> {code:java}
> Execution succeeded but contained differences (error code = 1) after 
> executing mv_iceberg_orc5.q 
> 101c101
> < HiveJoin(condition=[AND(IS NOT DISTINCT FROM($0, $5), IS NOT DISTINCT 
> FROM($1, $6))], joinType=[right], algorithm=[BucketJoin], cost=[not 
> available])
> ---
> > HiveJoin(condition=[AND(IS NOT DISTINCT FROM($0, $5), IS NOT DISTINCT 
> > FROM($1, $6))], joinType=[right], algorithm=[none], cost=[not available])
> 106c106
> <   HiveJoin(condition=[=($0, $3)], joinType=[inner], 
> algorithm=[CommonJoin], cost=[not available])
> ---
> >   HiveJoin(condition=[=($0, $3)], joinType=[inner], 
> > algorithm=[none], cost=[not available]) {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HIVE-28203) Fix qtest mv_iceberg_orc5.q

2024-04-18 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-28203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-28203:
--
Summary: Fix qtest mv_iceberg_orc5.q  (was: Flaky qtest mv_iceberg_orc5.q)

> Fix qtest mv_iceberg_orc5.q
> ---
>
> Key: HIVE-28203
> URL: https://issues.apache.org/jira/browse/HIVE-28203
> Project: Hive
>  Issue Type: Task
>  Components: Iceberg integration
>Reporter: Butao Zhang
>Priority: Major
>  Labels: pull-request-available
>
> [http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5190/3/tests]
> [http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5195/4/tests]
>  
> Flaky CI report:
> [http://ci.hive.apache.org/job/hive-flaky-check/837/testReport/] 
>  
> {code:java}
> Execution succeeded but contained differences (error code = 1) after 
> executing mv_iceberg_orc5.q 
> 101c101
> < HiveJoin(condition=[AND(IS NOT DISTINCT FROM($0, $5), IS NOT DISTINCT 
> FROM($1, $6))], joinType=[right], algorithm=[BucketJoin], cost=[not 
> available])
> ---
> > HiveJoin(condition=[AND(IS NOT DISTINCT FROM($0, $5), IS NOT DISTINCT 
> > FROM($1, $6))], joinType=[right], algorithm=[none], cost=[not available])
> 106c106
> <   HiveJoin(condition=[=($0, $3)], joinType=[inner], 
> algorithm=[CommonJoin], cost=[not available])
> ---
> >   HiveJoin(condition=[=($0, $3)], joinType=[inner], 
> > algorithm=[none], cost=[not available]) {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HIVE-28131) Iceberg: Add support for Replace Branch

2024-04-18 Thread Ayush Saxena (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-28131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayush Saxena resolved HIVE-28131.
-
Fix Version/s: 4.1.0
   Resolution: Fixed

> Iceberg: Add support for Replace Branch
> ---
>
> Key: HIVE-28131
> URL: https://issues.apache.org/jira/browse/HIVE-28131
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Ayush Saxena
>Assignee: Ayush Saxena
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.1.0
>
>
> Add support for Replace Iceberg Branch



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HIVE-28131) Iceberg: Add support for Replace Branch

2024-04-18 Thread Ayush Saxena (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-28131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838524#comment-17838524
 ] 

Ayush Saxena commented on HIVE-28131:
-

Committed to master.

Thanx [~zhangbutao] for the review!!!

> Iceberg: Add support for Replace Branch
> ---
>
> Key: HIVE-28131
> URL: https://issues.apache.org/jira/browse/HIVE-28131
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Ayush Saxena
>Assignee: Ayush Saxena
>Priority: Major
>  Labels: pull-request-available
>
> Add support for Replace Iceberg Branch



--
This message was sent by Atlassian Jira
(v8.20.10#820010)