[jira] [Updated] (HIVE-27145) Use StrictMath for remaining Math functions as followup of HIVE-23133
[
https://issues.apache.org/jira/browse/HIVE-27145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-27145:
---
Description:
[HIVE-23133|https://issues.apache.org/jira/browse/HIVE-23133] started using
{{StrictMath}} for {{cos, exp, log}} UDFs to fix QTests failing as results vary
based on hardware when using Math library.
Follow it up by using {{StrictMath}} for other Math functions that can have
same impact of underlying hardware namely, {{sin, tan, asin, acos, atan, sqrt,
pow, cbrt}}.
[JDK-4477961|https://bugs.openjdk.org/browse/JDK-4477961] (in Java 9) changed
radians and degrees calculation leading to Q Test failures when tests are run
on Java 9+, fix such tests.
was:
[HIVE-23133|https://issues.apache.org/jira/browse/HIVE-23133] started using
{{StrictMath}} for {{cos, exp, log}} UDFs to fix QTests failing as results vary
based on hardware when using Math library.
Follow it up by using {{StrictMath}} for other Math functions that can have
same impact of underlying hardware namely, {{sin, tan, asin, acos, atan, sqrt,
pow, cbrt}}.
[JDK-4477961](https://bugs.openjdk.org/browse/JDK-4477961) (in Java 9) changed
radians and degrees calculation leading to Q Test failures when tests are run
on Java 9+, fix such tests.
> Use StrictMath for remaining Math functions as followup of HIVE-23133
> -
>
> Key: HIVE-27145
> URL: https://issues.apache.org/jira/browse/HIVE-27145
> Project: Hive
> Issue Type: Task
> Components: UDF
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [HIVE-23133|https://issues.apache.org/jira/browse/HIVE-23133] started using
> {{StrictMath}} for {{cos, exp, log}} UDFs to fix QTests failing as results
> vary based on hardware when using Math library.
> Follow it up by using {{StrictMath}} for other Math functions that can have
> same impact of underlying hardware namely, {{sin, tan, asin, acos, atan,
> sqrt, pow, cbrt}}.
> [JDK-4477961|https://bugs.openjdk.org/browse/JDK-4477961] (in Java 9) changed
> radians and degrees calculation leading to Q Test failures when tests are run
> on Java 9+, fix such tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (HIVE-27145) Use StrictMath for remaining Math functions as followup of HIVE-23133
[
https://issues.apache.org/jira/browse/HIVE-27145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra reassigned HIVE-27145:
--
> Use StrictMath for remaining Math functions as followup of HIVE-23133
> -
>
> Key: HIVE-27145
> URL: https://issues.apache.org/jira/browse/HIVE-27145
> Project: Hive
> Issue Type: Task
> Components: UDF
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
>
> [HIVE-23133|https://issues.apache.org/jira/browse/HIVE-23133] started using
> {{StrictMath}} for {{cos, exp, log}} UDFs to fix QTests failing as results
> vary based on hardware when using Math library.
> Follow it up by using {{StrictMath}} for other Math functions that can have
> same impact of underlying hardware namely, {{sin, tan, asin, acos, atan,
> sqrt, pow, cbrt}}.
> [JDK-4477961](https://bugs.openjdk.org/browse/JDK-4477961) (in Java 9)
> changed radians and degrees calculation leading to Q Test failures when tests
> are run on Java 9+, fix such tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HIVE-22687) Query hangs indefinitely if LLAP daemon registers after the query is submitted
[
https://issues.apache.org/jira/browse/HIVE-22687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007080#comment-17007080
]
Himanshu Mishra commented on HIVE-22687:
Thanks [~gopalv] for looking into this.
The patch reorders registration of {{slot-000}} and {{worker-000}} zookeeper
nodes, ensuring that slot zk node must be present when we are registering
worker zk node.
On client side (Tez AM), we listen only on worker zk node and then schedule any
queued task in {{LlapTaskSchedulerService}}. To run the task we get list of all
the running LLAP daemon instances via
{{LlapZookeeperRegistryImpl#getAllInstancesOrdered}}, which returns only those
worker instances whose slot zk node is already present. With the patch we'll
always have associated slot zk node present for the newly registered worker zk
node, and this worker (LLAP Instance) will definitely be returned by this
method. This client side filtering was causing the issue in first place because
we were reaching this method even before the slot zk node got registered.
> Query hangs indefinitely if LLAP daemon registers after the query is submitted
> --
>
> Key: HIVE-22687
> URL: https://issues.apache.org/jira/browse/HIVE-22687
> Project: Hive
> Issue Type: Bug
> Components: llap
>Affects Versions: 3.1.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Attachments: HIVE-22687.01.patch, HIVE-22687.02.patch
>
>
> If a query is submitted and no LLAP daemon is running, it waits for 1 minute
> and times out with error {{SERVICE_UNAVAILABLE}}.
> While waiting, if a new LLAP Daemon starts, then the timeout is cancelled,
> and the tasks do not get scheduled as well. As a result, the query hangs
> indefinitely.
> This is due to the race condition where LLAP Daemon first registers the LLAP
> instance at {{.../workers/worker-}}, and afterwards registers
> {{.../workers/slot-}}. In the gap between two, Tez AM gets notified of
> worker zk node and while processing it checks if slot zk node is present, if
> not it rejects the LLAP Daemon. Error in Tez AM is:
> {code:java}
> [INFO] [LlapScheduler] |impl.LlapZookeeperRegistryImpl|: Unknown slot for
> 8ebfdc45-0382-4757-9416-52898885af90{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22687) Query hangs indefinitely if LLAP daemon registers after the query is submitted
[
https://issues.apache.org/jira/browse/HIVE-22687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22687:
---
Attachment: HIVE-22687.02.patch
Status: Patch Available (was: Open)
Resubmitting same patch to rerun unrelated test failure.
> Query hangs indefinitely if LLAP daemon registers after the query is submitted
> --
>
> Key: HIVE-22687
> URL: https://issues.apache.org/jira/browse/HIVE-22687
> Project: Hive
> Issue Type: Bug
> Components: llap
>Affects Versions: 3.1.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Attachments: HIVE-22687.01.patch, HIVE-22687.02.patch
>
>
> If a query is submitted and no LLAP daemon is running, it waits for 1 minute
> and times out with error {{SERVICE_UNAVAILABLE}}.
> While waiting, if a new LLAP Daemon starts, then the timeout is cancelled,
> and the tasks do not get scheduled as well. As a result, the query hangs
> indefinitely.
> This is due to the race condition where LLAP Daemon first registers the LLAP
> instance at {{.../workers/worker-}}, and afterwards registers
> {{.../workers/slot-}}. In the gap between two, Tez AM gets notified of
> worker zk node and while processing it checks if slot zk node is present, if
> not it rejects the LLAP Daemon. Error in Tez AM is:
> {code:java}
> [INFO] [LlapScheduler] |impl.LlapZookeeperRegistryImpl|: Unknown slot for
> 8ebfdc45-0382-4757-9416-52898885af90{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22687) Query hangs indefinitely if LLAP daemon registers after the query is submitted
[
https://issues.apache.org/jira/browse/HIVE-22687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22687:
---
Status: Open (was: Patch Available)
> Query hangs indefinitely if LLAP daemon registers after the query is submitted
> --
>
> Key: HIVE-22687
> URL: https://issues.apache.org/jira/browse/HIVE-22687
> Project: Hive
> Issue Type: Bug
> Components: llap
>Affects Versions: 3.1.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Attachments: HIVE-22687.01.patch
>
>
> If a query is submitted and no LLAP daemon is running, it waits for 1 minute
> and times out with error {{SERVICE_UNAVAILABLE}}.
> While waiting, if a new LLAP Daemon starts, then the timeout is cancelled,
> and the tasks do not get scheduled as well. As a result, the query hangs
> indefinitely.
> This is due to the race condition where LLAP Daemon first registers the LLAP
> instance at {{.../workers/worker-}}, and afterwards registers
> {{.../workers/slot-}}. In the gap between two, Tez AM gets notified of
> worker zk node and while processing it checks if slot zk node is present, if
> not it rejects the LLAP Daemon. Error in Tez AM is:
> {code:java}
> [INFO] [LlapScheduler] |impl.LlapZookeeperRegistryImpl|: Unknown slot for
> 8ebfdc45-0382-4757-9416-52898885af90{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22687) Query hangs indefinitely if LLAP daemon registers after the query is submitted
[
https://issues.apache.org/jira/browse/HIVE-22687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22687:
---
Attachment: HIVE-22687.01.patch
Status: Patch Available (was: Open)
> Query hangs indefinitely if LLAP daemon registers after the query is submitted
> --
>
> Key: HIVE-22687
> URL: https://issues.apache.org/jira/browse/HIVE-22687
> Project: Hive
> Issue Type: Bug
> Components: llap
>Affects Versions: 3.1.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Attachments: HIVE-22687.01.patch
>
>
> If a query is submitted and no LLAP daemon is running, it waits for 1 minute
> and times out with error {{SERVICE_UNAVAILABLE}}.
> While waiting, if a new LLAP Daemon starts, then the timeout is cancelled,
> and the tasks do not get scheduled as well. As a result, the query hangs
> indefinitely.
> This is due to the race condition where LLAP Daemon first registers the LLAP
> instance at {{.../workers/worker-}}, and afterwards registers
> {{.../workers/slot-}}. In the gap between two, Tez AM gets notified of
> worker zk node and while processing it checks if slot zk node is present, if
> not it rejects the LLAP Daemon. Error in Tez AM is:
> {code:java}
> [INFO] [LlapScheduler] |impl.LlapZookeeperRegistryImpl|: Unknown slot for
> 8ebfdc45-0382-4757-9416-52898885af90{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HIVE-22687) Query hangs indefinitely if LLAP daemon registers after the query is submitted
[
https://issues.apache.org/jira/browse/HIVE-22687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra reassigned HIVE-22687:
--
> Query hangs indefinitely if LLAP daemon registers after the query is submitted
> --
>
> Key: HIVE-22687
> URL: https://issues.apache.org/jira/browse/HIVE-22687
> Project: Hive
> Issue Type: Bug
> Components: llap
>Affects Versions: 3.1.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
>
> If a query is submitted and no LLAP daemon is running, it waits for 1 minute
> and times out with error {{SERVICE_UNAVAILABLE}}.
> While waiting, if a new LLAP Daemon starts, then the timeout is cancelled,
> and the tasks do not get scheduled as well. As a result, the query hangs
> indefinitely.
> This is due to the race condition where LLAP Daemon first registers the LLAP
> instance at {{.../workers/worker-}}, and afterwards registers
> {{.../workers/slot-}}. In the gap between two, Tez AM gets notified of
> worker zk node and while processing it checks if slot zk node is present, if
> not it rejects the LLAP Daemon. Error in Tez AM is:
> {code:java}
> [INFO] [LlapScheduler] |impl.LlapZookeeperRegistryImpl|: Unknown slot for
> 8ebfdc45-0382-4757-9416-52898885af90{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934021#comment-16934021
]
Himanshu Mishra commented on HIVE-22201:
[~ashutoshc] all tests passed now
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch,
> HIVE-22201.03.patch, HIVE-22201.04.patch, HIVE-22201.05.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Status: Open (was: Patch Available)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch,
> HIVE-22201.03.patch, HIVE-22201.04.patch, HIVE-22201.05.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Attachment: HIVE-22201.05.patch
Status: Patch Available (was: Open)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch,
> HIVE-22201.03.patch, HIVE-22201.04.patch, HIVE-22201.05.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Attachment: HIVE-22201.04.patch
Status: Patch Available (was: Open)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch,
> HIVE-22201.03.patch, HIVE-22201.04.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Status: Open (was: Patch Available)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch,
> HIVE-22201.03.patch, HIVE-22201.04.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Attachment: HIVE-22201.03.patch
Status: Patch Available (was: Open)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch,
> HIVE-22201.03.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Status: Open (was: Patch Available)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Fix Version/s: (was: 4.0.0)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932065#comment-16932065
]
Himanshu Mishra commented on HIVE-22201:
[~jcamachorodriguez] can you please review
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932062#comment-16932062
]
Himanshu Mishra commented on HIVE-22201:
Failures are not related to patch, they passed on the first run and failed on
second, without any code change.
[testPartitionDiscoveryTransactionalTable|https://builds.apache.org/job/PreCommit-HIVE-Build/18590/testReport/org.apache.hadoop.hive.metastore/TestPartitionManagement/testPartitionDiscoveryTransactionalTable/]
[loadDataNonAcid2AcidConversion|https://builds.apache.org/job/PreCommit-HIVE-Build/18590/testReport/org.apache.hadoop.hive.ql/TestTxnLoadData/loadDataNonAcid2AcidConversion/]
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Attachment: HIVE-22201.02.patch
Status: Patch Available (was: Open)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Status: Open (was: Patch Available)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22201.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Status: Patch Available (was: Open)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22201.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Status: Open (was: Patch Available)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22201.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Affects Version/s: 3.0.0
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22201.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Fix Version/s: 4.0.0
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22201.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Attachment: HIVE-22201.01.patch
Status: Patch Available (was: Open)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22201.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Status: Open (was: Patch Available)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra updated HIVE-22201:
---
Status: Patch Available (was: Open)
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work stopped] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-22201 stopped by Himanshu Mishra.
--
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work started] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-22201 started by Himanshu Mishra.
--
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[
https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Himanshu Mishra reassigned HIVE-22201:
--
Assignee: Himanshu Mishra
> ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws
> ArrayIndexOutOfBoundsException if no big table is selected
> --
>
> Key: HIVE-22201
> URL: https://issues.apache.org/jira/browse/HIVE-22201
> Project: Hive
> Issue Type: Bug
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end
> up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1,
> resulting in {{ArrayIndexOutOfBoundsException}}.
> Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HIVE-22056) Beeline started with -f , exit code is 0 even if unable to connect to HS2
[ https://issues.apache.org/jira/browse/HIVE-22056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Himanshu Mishra updated HIVE-22056: --- Resolution: Invalid Status: Resolved (was: Patch Available) Has been resolved by HIVE-19048 in master > Beeline started with -f , exit code is 0 even if unable to > connect to HS2 > -- > > Key: HIVE-22056 > URL: https://issues.apache.org/jira/browse/HIVE-22056 > Project: Hive > Issue Type: Bug > Components: Beeline >Affects Versions: 3.1.0, 4.0.0, 3.1.1 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22056.patch > > > When Beeline in hive 3 is started with -f argument, even if it > is not able to connect to HS2 server, it exits with success code i.e. 0. > Looks like this bug got introduced with the fix for HIVE-19744 > In previous versions it used to exit with code 2, fixing by exiting with > same code. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-22056) Beeline started with -f , exit code is 0 even if unable to connect to HS2
[
https://issues.apache.org/jira/browse/HIVE-22056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894485#comment-16894485
]
Himanshu Mishra commented on HIVE-22056:
Sorry I didn't run the unit test locally.
The unit test checks that shell commands should run even with failed
connection, but it tests only for script file provided with -f argument,
running same command with -e option also throws error.
{code:java}
❯ bin/beeline -e '!sh echo hello world'
Cannot run commands specified using -e. No current connection
{code}
The issue here is we check that that whether connection was successful or not
for throwing error, and not whether connection was required.
Updating the patch to check for whether we have URL either via argument or for
default connection before throwing the error.
> Beeline started with -f , exit code is 0 even if unable to
> connect to HS2
> --
>
> Key: HIVE-22056
> URL: https://issues.apache.org/jira/browse/HIVE-22056
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Affects Versions: 3.1.0, 4.0.0, 3.1.1
>Reporter: Himanshu Mishra
>Assignee: Himanshu Mishra
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22056.patch
>
>
> When Beeline in hive 3 is started with -f argument, even if it
> is not able to connect to HS2 server, it exits with success code i.e. 0.
> Looks like this bug got introduced with the fix for HIVE-19744
> In previous versions it used to exit with code 2, fixing by exiting with
> same code.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HIVE-22056) Beeline started with -f , exit code is 0 even if unable to connect to HS2
[ https://issues.apache.org/jira/browse/HIVE-22056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Himanshu Mishra updated HIVE-22056: --- Description: When Beeline in hive 3 is started with -f argument, even if it is not able to connect to HS2 server, it exits with success code i.e. 0. Looks like this bug got introduced with the fix for HIVE-19744 In previous versions it used to exit with code 2, fixing by exiting with same code. was: When Beeline in hive 3 is started with -f argument, even if it is not able to connect to HS2 server, it exits with success code i.e. 0. In previous versions it used to exit with code 2, fixing by exiting with same code. > Beeline started with -f , exit code is 0 even if unable to > connect to HS2 > -- > > Key: HIVE-22056 > URL: https://issues.apache.org/jira/browse/HIVE-22056 > Project: Hive > Issue Type: Bug > Components: Beeline >Affects Versions: 3.1.0, 4.0.0, 3.1.1 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22056.patch > > > When Beeline in hive 3 is started with -f argument, even if it > is not able to connect to HS2 server, it exits with success code i.e. 0. > Looks like this bug got introduced with the fix for HIVE-19744 > In previous versions it used to exit with code 2, fixing by exiting with > same code. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-22056) Beeline started with -f , exit code is 0 even if unable to connect to HS2
[ https://issues.apache.org/jira/browse/HIVE-22056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894420#comment-16894420 ] Himanshu Mishra commented on HIVE-22056: [~kgyrtkirk] can you please review ? > Beeline started with -f , exit code is 0 even if unable to > connect to HS2 > -- > > Key: HIVE-22056 > URL: https://issues.apache.org/jira/browse/HIVE-22056 > Project: Hive > Issue Type: Bug > Components: Beeline >Affects Versions: 3.1.0, 4.0.0, 3.1.1 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22056.patch > > > When Beeline in hive 3 is started with -f argument, even if it > is not able to connect to HS2 server, it exits with success code i.e. 0. > In previous versions it used to exit with code 2, fixing by exiting with > same code. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-22056) Beeline started with -f , exit code is 0 even if unable to connect to HS2
[ https://issues.apache.org/jira/browse/HIVE-22056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Himanshu Mishra updated HIVE-22056: --- Description: When Beeline in hive 3 is started with -f argument, even if it is not able to connect to HS2 server, it exits with success code i.e. 0. In previous versions it used to exit with code 2, fixing by exiting with same code. was: When Beeline in hive 3 is started with -f argument, even if it is not able to connect to HS2 server, it exits with success code i.e. 0. This is a regression of HIVE-19744. In previous versions it used to exit with code 2, fixing by exiting with same code. > Beeline started with -f , exit code is 0 even if unable to > connect to HS2 > -- > > Key: HIVE-22056 > URL: https://issues.apache.org/jira/browse/HIVE-22056 > Project: Hive > Issue Type: Bug > Components: Beeline >Affects Versions: 3.1.0, 4.0.0, 3.1.1 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22056.patch > > > When Beeline in hive 3 is started with -f argument, even if it > is not able to connect to HS2 server, it exits with success code i.e. 0. > In previous versions it used to exit with code 2, fixing by exiting with > same code. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-22056) Beeline started with -f , exit code is 0 even if unable to connect to HS2
[ https://issues.apache.org/jira/browse/HIVE-22056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Himanshu Mishra updated HIVE-22056: --- Fix Version/s: 4.0.0 Attachment: HIVE-22056.patch Status: Patch Available (was: Open) > Beeline started with -f , exit code is 0 even if unable to > connect to HS2 > -- > > Key: HIVE-22056 > URL: https://issues.apache.org/jira/browse/HIVE-22056 > Project: Hive > Issue Type: Bug > Components: Beeline >Affects Versions: 3.1.1, 3.1.0, 4.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22056.patch > > > When Beeline in hive 3 is started with -f argument, even if it > is not able to connect to HS2 server, it exits with success code i.e. 0. This > is a regression of HIVE-19744. > In previous versions it used to exit with code 2, fixing by exiting with same > code. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HIVE-22056) Beeline started with -f , exit code is 0 even if unable to connect to HS2
[ https://issues.apache.org/jira/browse/HIVE-22056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Himanshu Mishra reassigned HIVE-22056: -- > Beeline started with -f , exit code is 0 even if unable to > connect to HS2 > -- > > Key: HIVE-22056 > URL: https://issues.apache.org/jira/browse/HIVE-22056 > Project: Hive > Issue Type: Bug > Components: Beeline >Affects Versions: 3.1.1, 3.1.0, 4.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > > When Beeline in hive 3 is started with -f argument, even if it > is not able to connect to HS2 server, it exits with success code i.e. 0. This > is a regression of HIVE-19744. > In previous versions it used to exit with code 2, fixing by exiting with same > code. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-21707) Beeline always exits with fixed code
[ https://issues.apache.org/jira/browse/HIVE-21707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Himanshu Mishra updated HIVE-21707: --- Description: Beeline process internally knows when there was a connection error, what type of connection error (i.e. timed out, already open, etc. _Beeline#handleSQLException()_) or error while running query. When running a script via beeline, in case of any error the exit code is always 2. I wish to handle each error in different way from an external script and needed the Beeline to return different codes when it knows exactly what the error is. Should I return error codes like 10, 11, 12, ... ? was: Beeline process internally knows when there was a connection error, what type of connection error (i.e. timed out, already open, etc. _Beeline#handleSQLException()_) or error while running query. When running a script via beeline, in case of any error the exit code is always 2. I wish to handle each error in different way from an external script and needed the Beeline to return different codes when it knows exactly what the error is. Should I return error codes like -10, -11, -12 ? > Beeline always exits with fixed code > > > Key: HIVE-21707 > URL: https://issues.apache.org/jira/browse/HIVE-21707 > Project: Hive > Issue Type: Improvement > Components: Beeline >Reporter: Himanshu Mishra >Priority: Major > > Beeline process internally knows when there was a connection error, what type > of connection error (i.e. timed out, already open, etc. > _Beeline#handleSQLException()_) or error while running query. When running a > script via beeline, in case of any error the exit code is always 2. > I wish to handle each error in different way from an external script and > needed the Beeline to return different codes when it knows exactly what the > error is. Should I return error codes like 10, 11, 12, ... ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
