[jira] [Commented] (HIVE-24361) Insert overwrite with empty data is different in normal table then transactional table
[
https://issues.apache.org/jira/browse/HIVE-24361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228519#comment-17228519
]
Ivan Suller commented on HIVE-24361:
I totally agree that inconsistency is an issue - I was just arguing which one
is the correct behavior. Imho the first one is correct and the second one has
to be fixed.
> Insert overwrite with empty data is different in normal table then
> transactional table
> --
>
> Key: HIVE-24361
> URL: https://issues.apache.org/jira/browse/HIVE-24361
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 3.1.0
>Reporter: ABHISHEK KUMAR GUPTA
>Priority: Minor
>
> Steps:
> Use Case 1:
> create table test3(id int);
> insert into table test3 values(20);
> create table test4(id int);
> insert overwrite table test3 select * from test4;
> select * from test 3;
> Result: 0 rows
> Use Case 2:
> For transnational Table:
> create table test1(id int) stored as orc
> tblproperties('transactional'='true');
> insert into test1 values(20);
> create table test2(id int) stored as orc
> tblproperties('transactional'='true');
> insert overwrite table test1 select * from test2;
> select * from test 1;
> Result: 1 rows
> Expectation: Use Case 1 should behave as Use Case 2.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-24361) Insert overwrite with empty data is different in normal table then transactional table
[
https://issues.apache.org/jira/browse/HIVE-24361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228469#comment-17228469
]
Ivan Suller commented on HIVE-24361:
[~abhishek.akg] but the whole point of overwriting is to replace the data
currently in the table.
Btw, we had tickets similar to this one: HIVE-18702, HIVE-21714, HIVE-21784
where the expectation was to overwrite the data with the empty new one. Based
on that the correct behavior is the one with non-transaction table (Use Case 1).
> Insert overwrite with empty data is different in normal table then
> transactional table
> --
>
> Key: HIVE-24361
> URL: https://issues.apache.org/jira/browse/HIVE-24361
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 3.1.0
>Reporter: ABHISHEK KUMAR GUPTA
>Priority: Minor
>
> Steps:
> Use Case 1:
> create table test3(id int);
> insert into table test3 values(20);
> create table test4(id int);
> insert overwrite table test3 select * from test4;
> select * from test 3;
> Result: 0 rows
> Use Case 2:
> For transnational Table:
> create table test1(id int) stored as orc
> tblproperties('transactional'='true');
> insert into test1 values(20);
> create table test2(id int) stored as orc
> tblproperties('transactional'='true');
> insert overwrite table test1 select * from test2;
> select * from test 1;
> Result: 1 rows
> Expectation: Use Case 1 should behave as Use Case 2.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-24361) Insert overwrite with empty data is different in normal table then transactional table
[
https://issues.apache.org/jira/browse/HIVE-24361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228403#comment-17228403
]
Ivan Suller commented on HIVE-24361:
Why do you think the behavior for Use Case 2 is the right one? I expect that
after
{code:sql}
insert overwrite table test1 select * from test2;
{code}
The following two queries have the same result in every case:
{code:sql}
select count(*) from test1;
select count(*) from test2;
{code}
It seems you think that's not the case if "test2" table is empty. Why?
> Insert overwrite with empty data is different in normal table then
> transactional table
> --
>
> Key: HIVE-24361
> URL: https://issues.apache.org/jira/browse/HIVE-24361
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 3.1.0
>Reporter: ABHISHEK KUMAR GUPTA
>Priority: Minor
>
> Steps:
> Use Case 1:
> create table test3(id int);
> insert into table test3 values(20);
> create table test4(id int);
> insert overwrite table test3 select * from test4;
> select * from test 3;
> Result: 0 rows
> Use Case 2:
> For transnational Table:
> create table test1(id int) stored as orc
> tblproperties('transactional'='true');
> insert into test1 values(20);
> create table test2(id int) stored as orc
> tblproperties('transactional'='true');
> insert overwrite table test1 select * from test2;
> select * from test 1;
> Result: 1 rows
> Expectation: Use Case 1 should behave as Use Case 2.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23562) Upgrade thrift version in hive
[ https://issues.apache.org/jira/browse/HIVE-23562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119280#comment-17119280 ] Ivan Suller commented on HIVE-23562: This is actually an old effort and there's a ticket already to cover it: https://issues.apache.org/jira/browse/HIVE-21000 - so I think this ticket can be closed as duplicate. > Upgrade thrift version in hive > -- > > Key: HIVE-23562 > URL: https://issues.apache.org/jira/browse/HIVE-23562 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Naveen Gangam >Priority: Major > > Hive has been using thrift 0.9.3 for a long time. We might be able to avail > new features like deprecation support etc in the newer releases of thrift. > But this impacts interoperability between older clients and newer servers. We > need to assess what can break atleast for the purposes of documenting before > we make this change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-21170) Wrong (no) results of cross-product query executed on LLAP
[
https://issues.apache.org/jira/browse/HIVE-21170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Suller reassigned HIVE-21170:
--
Assignee: (was: Ivan Suller)
> Wrong (no) results of cross-product query executed on LLAP
> ---
>
> Key: HIVE-21170
> URL: https://issues.apache.org/jira/browse/HIVE-21170
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Hive distribution: HDP 3.1.0.
> LLAP execution engine in version:
> {code:java}
> $ beeline --version
> Hive 3.1.0.3.1.0.0-78
> Git
> git://ctr-e138-1518143905142-586755-01-15.hwx.site/grid/0/jenkins/workspace/HDP-parallel-centos7/SOURCES/hive
> -r 56673b027117d8cb3400675b1680a4d992360808
> Compiled by jenkins on Thu Dec 6 12:27:21 UTC 2018
> From source with checksum 97cc61f6acbe68b1fa988aa9f76b34cc{code}
>
>Reporter: Krzysztof Zarzycki
>Priority: Critical
>
> *In the environment:*
> {code:java}
> $ beeline --version
> Hive 3.1.0.3.1.0.0-78
> Git
> git://ctr-e138-1518143905142-586755-01-15.hwx.site/grid/0/jenkins/workspace/HDP-parallel-centos7/SOURCES/hive
> -r 56673b027117d8cb3400675b1680a4d992360808
> Compiled by jenkins on Thu Dec 6 12:27:21 UTC 2018
> From source with checksum 97cc61f6acbe68b1fa988aa9f76b34cc
> {code}
> *On LLAP execution engine*, the following query gives *wrong results*:
> {code:java}
> -- prepare test data
> set hive.query.results.cache.enabled=false;
> create table test1 (id int);
> insert into test1 values (1),(2),(3);
> -- query
> select * from test1 t1 cross join test1 t2;
> -- or any other cross join query, that involve 1 or more tables.{code}
> *Query result:*
> {code:java}
> 0: jdbc:hive2://hostname:> select t1.* from test1 t1 cross join test1 t2;
> INFO : Compiling
> command(queryId=hive_20190125215942_7df8062c-8511-4915-a0d9-5e7ac84030f6):
> select t1.* from test1 t1 cross join test1 t2
> INFO : Warning: Shuffle Join MERGEJOIN[9][tables = [$hdt$_0, $hdt$_1]] in
> Stage 'Reducer 2' is a cross product
> INFO : Semantic Analysis Completed (retrial = false)
> INFO : Returning Hive schema: Schema(fieldSchemas:[FieldSchema(name:t1.id,
> type:int, comment:null)], properties:null)
> INFO : Completed compiling
> command(queryId=hive_20190125215942_7df8062c-8511-4915-a0d9-5e7ac84030f6);
> Time taken: 0.229 seconds
> INFO : Executing
> command(queryId=hive_20190125215942_7df8062c-8511-4915-a0d9-5e7ac84030f6):
> select t1.* from test1 t1 cross join test1 t2
> INFO : Query ID = hive_20190125215942_7df8062c-8511-4915-a0d9-5e7ac84030f6
> INFO : Total jobs = 1
> INFO : Launching Job 1 out of 1
> INFO : Starting task [Stage-1:MAPRED] in parallel
>
> --
> VERTICES MODE STATUS TOTAL COMPLETED RUNNING PENDING FAILED KILLED
>
> --
> Map 1 .. llap SUCCEEDED 1 1 0 0 0 0
> Map 3 .. llap SUCCEEDED 1 1 0 0 0 0
> Reducer 2 llap SUCCEEDED 0 0 0 0 0 0
>
> --
> VERTICES: 02/03 [==>>] 100% ELAPSED TIME: 1.92 s
>
> --
> INFO : Completed executing
> command(queryId=hive_20190125215942_7df8062c-8511-4915-a0d9-5e7ac84030f6);
> Time taken: 2.006 seconds
> INFO : OK
> ++
> |t1.id|
> ++
> ++
> No rows selected (2.284 seconds)
> {code}
> *Expected result:*
> {code:java}
> ++
> |t1.id|
> ++
> |3|
> |3|
> |3|
> |2|
> |2|
> |2|
> |1|
> |1|
> |1|
> ++
> 9 rows selected
> {code}
> *What worked as a workaround:*
> {code:java}
> set hive.tez.cartesian-product.enabled=false; (default true)
> {code}
> Then query gave a correct result.
> *Difference in execution plans :*
> * With {{set hive.tez.cartesian-product.enabled=true;}}:
> {code:java}
> ++
> |Explain|
> ++
> |Plan optimized by CBO.|
> | |
> |Vertex dependency in root stage|
> |Reducer 2 <- Map 1 (XPROD_EDGE), Map 3 (XPROD_EDGE)|
> | |
> |Stage-0|
> |Fetch Operator|
> |limit:-1|
> |Stage-1|
> |Reducer 2 llap|
> |File Output Operator [FS_8]|
> |Merge Join Operator [MERGEJOIN_9] (rows=9 width=8)|
> |Conds:(Inner),Output:["_col0","_col1"]|
> |<-Map 1 [XPROD_EDGE] vectorized, llap|
> |XPROD_EDGE [RS_11]|
> |Select Operator [SEL_10] (rows=3 width=4)|
> |Output:["_col0"]|
> |TableScan [TS_0] (rows=3 width=4)|
> |zarz@test1,t1, ACID table,Tbl:COMPLETE,Col:COMPLETE,Output:["id"]|
> |<-Map 3 [XPROD_EDGE] vectorized, llap|
> |XPROD_EDGE [RS_13]|
> |Select Operator
[jira] [Commented] (HIVE-21000) Upgrade thrift to at least 0.10.0
[ https://issues.apache.org/jira/browse/HIVE-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105503#comment-17105503 ] Ivan Suller commented on HIVE-21000: [~belugabehr] As we have to redo the work we might as well upgrade to 0.14, but first we have to upgrade the Accumulo version. I don't have any time to work on that so please feel free to pick that up. > Upgrade thrift to at least 0.10.0 > - > > Key: HIVE-21000 > URL: https://issues.apache.org/jira/browse/HIVE-21000 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21000.01.patch, HIVE-21000.02.patch, > HIVE-21000.03.patch, HIVE-21000.04.patch, HIVE-21000.05.patch, > HIVE-21000.06.patch, HIVE-21000.07.patch, HIVE-21000.08.patch, > sampler_before.png > > > I was looking into some compile profiles for tables with lots of columns; and > it turned out that [thrift 0.9.3 is allocating a > List|https://github.com/apache/hive/blob/8e30b5e029570407d8a1db67d322a95db705750e/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java#L348] > during every hashcode calculation; but luckily THRIFT-2877 is improving on > that - so I propose to upgrade to at least 0.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-21000) Upgrade thrift to at least 0.10.0
[ https://issues.apache.org/jira/browse/HIVE-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-21000: -- Assignee: (was: Ivan Suller) > Upgrade thrift to at least 0.10.0 > - > > Key: HIVE-21000 > URL: https://issues.apache.org/jira/browse/HIVE-21000 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21000.01.patch, HIVE-21000.02.patch, > HIVE-21000.03.patch, HIVE-21000.04.patch, HIVE-21000.05.patch, > HIVE-21000.06.patch, HIVE-21000.07.patch, HIVE-21000.08.patch, > sampler_before.png > > > I was looking into some compile profiles for tables with lots of columns; and > it turned out that [thrift 0.9.3 is allocating a > List|https://github.com/apache/hive/blob/8e30b5e029570407d8a1db67d322a95db705750e/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java#L348] > during every hashcode calculation; but luckily THRIFT-2877 is improving on > that - so I propose to upgrade to at least 0.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22220) Upgrade Accumulo version to the latest 2.0 release
[ https://issues.apache.org/jira/browse/HIVE-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-0: -- Assignee: (was: Ivan Suller) > Upgrade Accumulo version to the latest 2.0 release > -- > > Key: HIVE-0 > URL: https://issues.apache.org/jira/browse/HIVE-0 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Priority: Major > > To make Thrift upgrade (HIVE-21000) possible we have to upgrade Accumulo to > at least 2.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23156) NPE if -f is used with HCatCLI
[ https://issues.apache.org/jira/browse/HIVE-23156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085444#comment-17085444 ] Ivan Suller commented on HIVE-23156: [~rameshkumar] just don't use -e in CLI and you'll get a NPE at https://github.com/apache/hive/blob/master/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatCli.java#L181 - it's very telling that the execString variable is checked for being null a few lines later. > NPE if -f is used with HCatCLI > -- > > Key: HIVE-23156 > URL: https://issues.apache.org/jira/browse/HIVE-23156 > Project: Hive > Issue Type: Bug > Components: HCatalog >Reporter: Ivan Suller >Priority: Critical > > After HIVE-22889 if there is no -e cli parameter then a NPE is thrown. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23156) NPE if -f is used with HCatCLI
[ https://issues.apache.org/jira/browse/HIVE-23156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084683#comment-17084683 ] Ivan Suller commented on HIVE-23156: [~rameshkumar] can you take a look at this? > NPE if -f is used with HCatCLI > -- > > Key: HIVE-23156 > URL: https://issues.apache.org/jira/browse/HIVE-23156 > Project: Hive > Issue Type: Bug > Components: HCatalog >Reporter: Ivan Suller >Priority: Critical > > After HIVE-22889 if there is no -e cli parameter then a NPE is thrown. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23156) NPE if -f is used with HCatCLI
[ https://issues.apache.org/jira/browse/HIVE-23156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-23156: --- Issue Type: Bug (was: Improvement) > NPE if -f is used with HCatCLI > -- > > Key: HIVE-23156 > URL: https://issues.apache.org/jira/browse/HIVE-23156 > Project: Hive > Issue Type: Bug > Components: HCatalog >Reporter: Ivan Suller >Priority: Critical > > After HIVE-22889 if there is no -e cli parameter then a NPE is thrown. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-21000) Upgrade thrift to at least 0.10.0
[ https://issues.apache.org/jira/browse/HIVE-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034208#comment-17034208 ] Ivan Suller commented on HIVE-21000: [~kgyrtkirk] [~q.xu] Accumulo 2 has been release and a ticket has been opened to upgrade to it: HIVE-0. I started working on it, but was way more complicated then I anticipated and had way less time for it so I could never finish. If someone could pick it up that would be a first step for Thrift upgrade. > Upgrade thrift to at least 0.10.0 > - > > Key: HIVE-21000 > URL: https://issues.apache.org/jira/browse/HIVE-21000 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Haindrich >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-21000.01.patch, HIVE-21000.02.patch, > HIVE-21000.03.patch, HIVE-21000.04.patch, HIVE-21000.05.patch, > HIVE-21000.06.patch, HIVE-21000.07.patch, HIVE-21000.08.patch, > sampler_before.png > > > I was looking into some compile profiles for tables with lots of columns; and > it turned out that [thrift 0.9.3 is allocating a > List|https://github.com/apache/hive/blob/8e30b5e029570407d8a1db67d322a95db705750e/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java#L348] > during every hashcode calculation; but luckily THRIFT-2877 is improving on > that - so I propose to upgrade to at least 0.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HIVE-22768) Remove the usages of the Utilities.makeList method call
[ https://issues.apache.org/jira/browse/HIVE-22768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller resolved HIVE-22768. Release Note: The resulted list should be mutable, so the proposed solution won't work Resolution: Won't Fix > Remove the usages of the Utilities.makeList method call > --- > > Key: HIVE-22768 > URL: https://issues.apache.org/jira/browse/HIVE-22768 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22768.1.patch > > > The aforementioned > org.apache.hadoop.hive.ql.exec.Utilities.makeList(Object...) method is non > generic and most of its usages can be replaced by a simple > Collections.singletonList(Object) call. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22768) Remove the usages of the Utilities.makeList method call
[ https://issues.apache.org/jira/browse/HIVE-22768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22768: --- Status: Open (was: Patch Available) That was a misunderstanding. > Remove the usages of the Utilities.makeList method call > --- > > Key: HIVE-22768 > URL: https://issues.apache.org/jira/browse/HIVE-22768 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22768.1.patch > > > The aforementioned > org.apache.hadoop.hive.ql.exec.Utilities.makeList(Object...) method is non > generic and most of its usages can be replaced by a simple > Collections.singletonList(Object) call. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22768) Remove the usages of the Utilities.makeList method call
[ https://issues.apache.org/jira/browse/HIVE-22768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22768: --- Assignee: Ivan Suller Status: Patch Available (was: Open) > Remove the usages of the Utilities.makeList method call > --- > > Key: HIVE-22768 > URL: https://issues.apache.org/jira/browse/HIVE-22768 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22768.1.patch > > > The aforementioned > org.apache.hadoop.hive.ql.exec.Utilities.makeList(Object...) method is non > generic and most of its usages can be replaced by a simple > Collections.singletonList(Object) call. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22768) Remove the usages of the Utilities.makeList method call
[ https://issues.apache.org/jira/browse/HIVE-22768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22768: --- Attachment: HIVE-22768.1.patch > Remove the usages of the Utilities.makeList method call > --- > > Key: HIVE-22768 > URL: https://issues.apache.org/jira/browse/HIVE-22768 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22768.1.patch > > > The aforementioned > org.apache.hadoop.hive.ql.exec.Utilities.makeList(Object...) method is non > generic and most of its usages can be replaced by a simple > Collections.singletonList(Object) call. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HIVE-22322) Remove Netty3 dependency of llap-server
[ https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller resolved HIVE-22322. Resolution: Won't Fix Much more complicated than anticipated - abandon till we have a plan to do this properly. > Remove Netty3 dependency of llap-server > --- > > Key: HIVE-22322 > URL: https://issues.apache.org/jira/browse/HIVE-22322 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-22322.1.patch > > > Llap-server depends on both Netty3 and Netty4. As Netty3 has known security > issues fixed only in Netty4 we should eliminate any dependency on Netty3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22322) Remove Netty3 dependency of llap-server
[ https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22322: --- Status: Open (was: Patch Available) > Remove Netty3 dependency of llap-server > --- > > Key: HIVE-22322 > URL: https://issues.apache.org/jira/browse/HIVE-22322 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-22322.1.patch > > > Llap-server depends on both Netty3 and Netty4. As Netty3 has known security > issues fixed only in Netty4 we should eliminate any dependency on Netty3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22322) Remove Netty3 dependency of llap-server
[ https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949290#comment-16949290 ] Ivan Suller commented on HIVE-22322: [~dlavati] true - it doesn't seem to be simple at all. Hive got Netty3 as a transitive dependency that's why it still builds without the explicit dependency in the pom.xml. I'm afraid this will be a big task involving other projects around Hadoop. > Remove Netty3 dependency of llap-server > --- > > Key: HIVE-22322 > URL: https://issues.apache.org/jira/browse/HIVE-22322 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-22322.1.patch > > > Llap-server depends on both Netty3 and Netty4. As Netty3 has known security > issues fixed only in Netty4 we should eliminate any dependency on Netty3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22322) Remove Netty3 dependency of llap-server
[ https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22322: --- Status: Patch Available (was: In Progress) > Remove Netty3 dependency of llap-server > --- > > Key: HIVE-22322 > URL: https://issues.apache.org/jira/browse/HIVE-22322 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-22322.1.patch > > > Llap-server depends on both Netty3 and Netty4. As Netty3 has known security > issues fixed only in Netty4 we should eliminate any dependency on Netty3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22322) Remove Netty3 dependency of llap-server
[ https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22322: --- Attachment: HIVE-22322.1.patch > Remove Netty3 dependency of llap-server > --- > > Key: HIVE-22322 > URL: https://issues.apache.org/jira/browse/HIVE-22322 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-22322.1.patch > > > Llap-server depends on both Netty3 and Netty4. As Netty3 has known security > issues fixed only in Netty4 we should eliminate any dependency on Netty3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HIVE-22322) Remove Netty3 dependency of llap-server
[ https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-22322 started by Ivan Suller. -- > Remove Netty3 dependency of llap-server > --- > > Key: HIVE-22322 > URL: https://issues.apache.org/jira/browse/HIVE-22322 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > > Llap-server depends on both Netty3 and Netty4. As Netty3 has known security > issues fixed only in Netty4 we should eliminate any dependency on Netty3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22322) Remove Netty3 dependency of llap-server
[ https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-22322: -- > Remove Netty3 dependency of llap-server > --- > > Key: HIVE-22322 > URL: https://issues.apache.org/jira/browse/HIVE-22322 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > > Llap-server depends on both Netty3 and Netty4. As Netty3 has known security > issues fixed only in Netty4 we should eliminate any dependency on Netty3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HIVE-22220) Upgrade Accumulo version to the latest 2.0 release
[ https://issues.apache.org/jira/browse/HIVE-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-0 started by Ivan Suller. -- > Upgrade Accumulo version to the latest 2.0 release > -- > > Key: HIVE-0 > URL: https://issues.apache.org/jira/browse/HIVE-0 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > > To make Thrift upgrade (HIVE-21000) possible we have to upgrade Accumulo to > at least 2.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22220) Upgrade Accumulo version to the latest 2.0 release
[ https://issues.apache.org/jira/browse/HIVE-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-0: -- Assignee: Ivan Suller > Upgrade Accumulo version to the latest 2.0 release > -- > > Key: HIVE-0 > URL: https://issues.apache.org/jira/browse/HIVE-0 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > > To make Thrift upgrade (HIVE-21000) possible we have to upgrade Accumulo to > at least 2.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-21000) Upgrade thrift to at least 0.10.0
[ https://issues.apache.org/jira/browse/HIVE-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934329#comment-16934329 ] Ivan Suller commented on HIVE-21000: Created the Accumulo upgrade ticket: HIVE-0 > Upgrade thrift to at least 0.10.0 > - > > Key: HIVE-21000 > URL: https://issues.apache.org/jira/browse/HIVE-21000 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Haindrich >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-21000.01.patch, HIVE-21000.02.patch, > HIVE-21000.03.patch, HIVE-21000.04.patch, HIVE-21000.05.patch, > HIVE-21000.06.patch, HIVE-21000.07.patch, HIVE-21000.08.patch, > sampler_before.png > > > I was looking into some compile profiles for tables with lots of columns; and > it turned out that [thrift 0.9.3 is allocating a > List|https://github.com/apache/hive/blob/8e30b5e029570407d8a1db67d322a95db705750e/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java#L348] > during every hashcode calculation; but luckily THRIFT-2877 is improving on > that - so I propose to upgrade to at least 0.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-21000) Upgrade thrift to at least 0.10.0
[ https://issues.apache.org/jira/browse/HIVE-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934166#comment-16934166 ] Ivan Suller commented on HIVE-21000: I don't know if I need to worry or not, but I do. It doesn't sound promising, but we will see how it'll turn out. > Upgrade thrift to at least 0.10.0 > - > > Key: HIVE-21000 > URL: https://issues.apache.org/jira/browse/HIVE-21000 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Haindrich >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-21000.01.patch, HIVE-21000.02.patch, > HIVE-21000.03.patch, HIVE-21000.04.patch, HIVE-21000.05.patch, > HIVE-21000.06.patch, HIVE-21000.07.patch, HIVE-21000.08.patch, > sampler_before.png > > > I was looking into some compile profiles for tables with lots of columns; and > it turned out that [thrift 0.9.3 is allocating a > List|https://github.com/apache/hive/blob/8e30b5e029570407d8a1db67d322a95db705750e/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java#L348] > during every hashcode calculation; but luckily THRIFT-2877 is improving on > that - so I propose to upgrade to at least 0.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-21000) Upgrade thrift to at least 0.10.0
[ https://issues.apache.org/jira/browse/HIVE-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934160#comment-16934160 ] Ivan Suller commented on HIVE-21000: Not yet, but will open a ticket for Accumulo upgrade. > Upgrade thrift to at least 0.10.0 > - > > Key: HIVE-21000 > URL: https://issues.apache.org/jira/browse/HIVE-21000 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Haindrich >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-21000.01.patch, HIVE-21000.02.patch, > HIVE-21000.03.patch, HIVE-21000.04.patch, HIVE-21000.05.patch, > HIVE-21000.06.patch, HIVE-21000.07.patch, HIVE-21000.08.patch, > sampler_before.png > > > I was looking into some compile profiles for tables with lots of columns; and > it turned out that [thrift 0.9.3 is allocating a > List|https://github.com/apache/hive/blob/8e30b5e029570407d8a1db67d322a95db705750e/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java#L348] > during every hashcode calculation; but luckily THRIFT-2877 is improving on > that - so I propose to upgrade to at least 0.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-21000) Upgrade thrift to at least 0.10.0
[ https://issues.apache.org/jira/browse/HIVE-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933195#comment-16933195 ] Ivan Suller commented on HIVE-21000: Accumulo 2.0.0 has been finally released: https://accumulo.apache.org/release/accumulo-2.0.0/ Unfortunately this patch is no longer appliable, so I have to redone it from scratch. > Upgrade thrift to at least 0.10.0 > - > > Key: HIVE-21000 > URL: https://issues.apache.org/jira/browse/HIVE-21000 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Haindrich >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-21000.01.patch, HIVE-21000.02.patch, > HIVE-21000.03.patch, HIVE-21000.04.patch, HIVE-21000.05.patch, > HIVE-21000.06.patch, HIVE-21000.07.patch, HIVE-21000.08.patch, > sampler_before.png > > > I was looking into some compile profiles for tables with lots of columns; and > it turned out that [thrift 0.9.3 is allocating a > List|https://github.com/apache/hive/blob/8e30b5e029570407d8a1db67d322a95db705750e/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java#L348] > during every hashcode calculation; but luckily THRIFT-2877 is improving on > that - so I propose to upgrade to at least 0.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22083: --- Attachment: HIVE-22083.6.patch > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22083.1.patch, HIVE-22083.2.patch, > HIVE-22083.3.patch, HIVE-22083.4.patch, HIVE-22083.4.patch, > HIVE-22083.4.patch, HIVE-22083.5.patch, HIVE-22083.6.patch > > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22083: --- Attachment: HIVE-22083.5.patch > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22083.1.patch, HIVE-22083.2.patch, > HIVE-22083.3.patch, HIVE-22083.4.patch, HIVE-22083.4.patch, > HIVE-22083.4.patch, HIVE-22083.5.patch > > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22083: --- Attachment: HIVE-22083.4.patch > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22083.1.patch, HIVE-22083.2.patch, > HIVE-22083.3.patch, HIVE-22083.4.patch, HIVE-22083.4.patch, HIVE-22083.4.patch > > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22083: --- Attachment: HIVE-22083.4.patch > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22083.1.patch, HIVE-22083.2.patch, > HIVE-22083.3.patch, HIVE-22083.4.patch, HIVE-22083.4.patch > > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22133) MS Power BI does not show Views anymore
[ https://issues.apache.org/jira/browse/HIVE-22133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912280#comment-16912280 ] Ivan Suller commented on HIVE-22133: In Hive 3.1 "SHOW TABLES" displays views as well (just tried it) and as far as I'm aware of this behaviour didn't change between 3.0 and 3.1 so it should work in 3.0 too. Maybe PowerBI doesn't use "show tables" at all. > MS Power BI does not show Views anymore > --- > > Key: HIVE-22133 > URL: https://issues.apache.org/jira/browse/HIVE-22133 > Project: Hive > Issue Type: Bug > Components: API, Hive, HiveServer2, ODBC >Affects Versions: 3.0.0 > Environment: HDP 3.1, Hive 3.0, CentOS 7, Windows 10, Power BI, ODBC >Reporter: Oliver Ricken >Priority: Major > > Dear experts, > We are currently testing a full HDP 3.1 stack including Hive 3.0.0.3.1. > Before, we used a HDP 2.6 stack with Hive 1.2.1000. Our current installation > foresees connections of Microsoft Power BI to Hive using ODBC. This worked > fine in the HDP 2.6 (Hive 1.2) environment but yields problems in the HDP 3.1 > (Hive 3.0) context. > Power BI does not show Hive Views to extract data from anymore but only > tables. I suspect the newly separation of "show tables" and "show views" in > Hive 3.0 to be behind this. While in Hive 1.2, "show tables" also showed > views (not just tables), listing the available views of a DB now requires > issueing "show views". My best guess is that Power BI issues "show tables" to > harvest the list of available sources and thus misses views in Hive 3.0. > For us it's crucial to be able to access Hive views and not just tables in > order to migrate existing BI processes to the new cluster environment. > Did anyone encounter this issue before and/or knows a solution or workaround? > Any help and input is very much appreciated. > Cheers > Oliver -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22083: --- Attachment: HIVE-22083.4.patch > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22083.1.patch, HIVE-22083.2.patch, > HIVE-22083.3.patch, HIVE-22083.4.patch > > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22083: --- Attachment: HIVE-22083.3.patch > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22083.1.patch, HIVE-22083.2.patch, > HIVE-22083.3.patch > > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22083: --- Attachment: HIVE-22083.2.patch > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22083.1.patch, HIVE-22083.2.patch > > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22083: --- Status: Patch Available (was: In Progress) > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22083.1.patch > > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22083: --- Attachment: HIVE-22083.1.patch > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22083.1.patch > > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-22083: -- Assignee: Ivan Suller > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work started] (HIVE-22083) Values of tag order cannot be null, so it can be "byte" instead of "Byte"
[ https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-22083 started by Ivan Suller. -- > Values of tag order cannot be null, so it can be "byte" instead of "Byte" > - > > Key: HIVE-22083 > URL: https://issues.apache.org/jira/browse/HIVE-22083 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > > Values of tag order cannot be null, so it can be "byte" instead of "Byte". > Switching between Byte and byte is "cheap" - the Byte objects are cached by > the JVM - but it still costs a bit more memory and CPU usage. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-22069) joda-time binary conflict between druid-handler and phoenix-hive jars.
[ https://issues.apache.org/jira/browse/HIVE-22069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898136#comment-16898136 ] Ivan Suller commented on HIVE-22069: It's also possible to simply use Java8 DateTime library which has a similar API to Joda Time. > joda-time binary conflict between druid-handler and phoenix-hive jars. > -- > > Key: HIVE-22069 > URL: https://issues.apache.org/jira/browse/HIVE-22069 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0, 4.0.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > > Hive's druid storage handler uses 2.8.1 version of the joda time library > where as the phoenix-hive.jar uses 1.6 version of this library. When both > jars are in the classpath, bad things happen. > Apache phoenix has its own release cycle and them uptaking a new version is > not what hive should count on. Besides they could decide to move to a new > version of this library and we would still have this problem. > So its best we use shaded jars in hive for the version we are on. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-22065) Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor
[ https://issues.apache.org/jira/browse/HIVE-22065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22065: --- Attachment: HIVE-22065.2.patch > Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor > -- > > Key: HIVE-22065 > URL: https://issues.apache.org/jira/browse/HIVE-22065 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22065.1.patch, HIVE-22065.2.patch > > > I addressed the following issues: > - replace explicit generic definitions with diamond operator where applicable > - fix field visibility > - use lambda expression instead of instantiating a custom interface > implementation > - remove unnecessary null checks -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-22065) Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor
[ https://issues.apache.org/jira/browse/HIVE-22065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22065: --- Status: Patch Available (was: In Progress) > Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor > -- > > Key: HIVE-22065 > URL: https://issues.apache.org/jira/browse/HIVE-22065 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22065.1.patch > > > I addressed the following issues: > - replace explicit generic definitions with diamond operator where applicable > - fix field visibility > - use lambda expression instead of instantiating a custom interface > implementation > - remove unnecessary null checks -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-22065) Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor
[ https://issues.apache.org/jira/browse/HIVE-22065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-22065: --- Attachment: HIVE-22065.1.patch > Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor > -- > > Key: HIVE-22065 > URL: https://issues.apache.org/jira/browse/HIVE-22065 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-22065.1.patch > > > I addressed the following issues: > - replace explicit generic definitions with diamond operator where applicable > - fix field visibility > - use lambda expression instead of instantiating a custom interface > implementation > - remove unnecessary null checks -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work started] (HIVE-22065) Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor
[ https://issues.apache.org/jira/browse/HIVE-22065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-22065 started by Ivan Suller. -- > Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor > -- > > Key: HIVE-22065 > URL: https://issues.apache.org/jira/browse/HIVE-22065 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > > I addressed the following issues: > - replace explicit generic definitions with diamond operator where applicable > - fix field visibility > - use lambda expression instead of instantiating a custom interface > implementation > - remove unnecessary null checks -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HIVE-22065) Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor
[ https://issues.apache.org/jira/browse/HIVE-22065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-22065: -- Assignee: Ivan Suller > Code cleanup around org.apache.hadoop.hive.ql.exec.tez.RecordProcessor > -- > > Key: HIVE-22065 > URL: https://issues.apache.org/jira/browse/HIVE-22065 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > > I addressed the following issues: > - replace explicit generic definitions with diamond operator where applicable > - fix field visibility > - use lambda expression instead of instantiating a custom interface > implementation > - remove unnecessary null checks -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-22060) Replacing "catch Throwable" with a more restricted exception class
[
https://issues.apache.org/jira/browse/HIVE-22060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897128#comment-16897128
]
Ivan Suller commented on HIVE-22060:
[~pvary] There's almost always a way to avoid catching Throwable. For example
I'd write the above issue from this:
{code:java}
try {
...
} catch (Exception e) {
LOG.error("Caught exception while trying to compact " + ci +
". Marking failed to avoid repeated failures, " +
StringUtils.stringifyException(e));
msc.markFailed(CompactionInfo.compactionInfoToStruct(ci));
msc.abortTxns(Collections.singletonList(compactorTxnId));
}
{code}
to this:
{code:java}
boolean successfulCompaction = false;
try {
...
successfulCompaction = true;
} finally {
if (!successfulCompaction) {
msc.markFailed(CompactionInfo.compactionInfoToStruct(ci));
msc.abortTxns(Collections.singletonList(compactorTxnId));
}
} catch (Exception e) {
LOG.error("Caught exception while trying to compact " + ci +
". Marking failed to avoid repeated failures, " +
StringUtils.stringifyException(e));
}
{code}
> Replacing "catch Throwable" with a more restricted exception class
> --
>
> Key: HIVE-22060
> URL: https://issues.apache.org/jira/browse/HIVE-22060
> Project: Hive
> Issue Type: Improvement
> Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Major
>
> Catching Throwable considered unsafe in Java. A Throwable can be any Error
> and those are JVM errors after the state of the JVM is not guaranteed thus
> the cleanest way to "handle" the error is to let it kill the current thread.
> I ran a quick scan and found almost 400 "catch Throwable" in the current
> codebase. I opened this ticket as a conversation starter to:
> - discuss if we want to eliminate this issue
> - if we want to do it what's the best way to do it
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HIVE-21944) Remove unused methods, fields and variables from Vectorizer
[ https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896790#comment-16896790 ] Ivan Suller commented on HIVE-21944: [~abstractdog] I deliberately didn't make the same change twice. This way the two patch could be tested separately. > Remove unused methods, fields and variables from Vectorizer > --- > > Key: HIVE-21944 > URL: https://issues.apache.org/jira/browse/HIVE-21944 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21944.1.patch, HIVE-21944.1.patch, > HIVE-21944.1.patch, HIVE-21944.1.patch > > > It seems there are many unused fields, variables and methods in > org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them > would make the code easier to understand. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HIVE-22060) Replacing "catch Throwable" with a more restricted exception class
[ https://issues.apache.org/jira/browse/HIVE-22060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-22060: -- > Replacing "catch Throwable" with a more restricted exception class > -- > > Key: HIVE-22060 > URL: https://issues.apache.org/jira/browse/HIVE-22060 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > > Catching Throwable considered unsafe in Java. A Throwable can be any Error > and those are JVM errors after the state of the JVM is not guaranteed thus > the cleanest way to "handle" the error is to let it kill the current thread. > I ran a quick scan and found almost 400 "catch Throwable" in the current > codebase. I opened this ticket as a conversation starter to: > - discuss if we want to eliminate this issue > - if we want to do it what's the best way to do it -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21944) Remove unused methods, fields and variables from Vectorizer
[ https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889980#comment-16889980 ] Ivan Suller commented on HIVE-21944: [~kgyrtkirk] passed this time. Thanks for the update. > Remove unused methods, fields and variables from Vectorizer > --- > > Key: HIVE-21944 > URL: https://issues.apache.org/jira/browse/HIVE-21944 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21944.1.patch, HIVE-21944.1.patch, > HIVE-21944.1.patch, HIVE-21944.1.patch > > > It seems there are many unused fields, variables and methods in > org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them > would make the code easier to understand. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-21944) Remove unused methods, fields and variables from Vectorizer
[ https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21944: --- Attachment: HIVE-21944.1.patch > Remove unused methods, fields and variables from Vectorizer > --- > > Key: HIVE-21944 > URL: https://issues.apache.org/jira/browse/HIVE-21944 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21944.1.patch, HIVE-21944.1.patch, > HIVE-21944.1.patch, HIVE-21944.1.patch > > > It seems there are many unused fields, variables and methods in > org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them > would make the code easier to understand. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork
[ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21962: --- Attachment: HIVE-21962.2.patch > Replacing ArrayList params with List in and around PlanUtils and MapWork > > > Key: HIVE-21962 > URL: https://issues.apache.org/jira/browse/HIVE-21962 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21962.1.patch, HIVE-21962.1.patch, > HIVE-21962.2.patch, HIVE-21962.2.patch > > > Using the implementing class is usually a bad practice. OO suggest to use the > least restrictive interface instead. ArrayList is used in many-many methods > as a parameter - this is just a tiny part of this work. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork
[ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21962: --- Attachment: HIVE-21962.2.patch > Replacing ArrayList params with List in and around PlanUtils and MapWork > > > Key: HIVE-21962 > URL: https://issues.apache.org/jira/browse/HIVE-21962 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21962.1.patch, HIVE-21962.1.patch, > HIVE-21962.2.patch > > > Using the implementing class is usually a bad practice. OO suggest to use the > least restrictive interface instead. ArrayList is used in many-many methods > as a parameter - this is just a tiny part of this work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork
[ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21962: --- Attachment: HIVE-21962.1.patch > Replacing ArrayList params with List in and around PlanUtils and MapWork > > > Key: HIVE-21962 > URL: https://issues.apache.org/jira/browse/HIVE-21962 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21962.1.patch, HIVE-21962.1.patch > > > Using the implementing class is usually a bad practice. OO suggest to use the > least restrictive interface instead. ArrayList is used in many-many methods > as a parameter - this is just a tiny part of this work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork
[ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21962: --- Attachment: HIVE-21962.1.patch > Replacing ArrayList params with List in and around PlanUtils and MapWork > > > Key: HIVE-21962 > URL: https://issues.apache.org/jira/browse/HIVE-21962 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21962.1.patch > > > Using the implementing class is usually a bad practice. OO suggest to use the > least restrictive interface instead. ArrayList is used in many-many methods > as a parameter - this is just a tiny part of this work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork
[ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21962: --- Status: Patch Available (was: In Progress) > Replacing ArrayList params with List in and around PlanUtils and MapWork > > > Key: HIVE-21962 > URL: https://issues.apache.org/jira/browse/HIVE-21962 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21962.1.patch > > > Using the implementing class is usually a bad practice. OO suggest to use the > least restrictive interface instead. ArrayList is used in many-many methods > as a parameter - this is just a tiny part of this work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork
[ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-21962: -- > Replacing ArrayList params with List in and around PlanUtils and MapWork > > > Key: HIVE-21962 > URL: https://issues.apache.org/jira/browse/HIVE-21962 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > > Using the implementing class is usually a bad practice. OO suggest to use the > least restrictive interface instead. ArrayList is used in many-many methods > as a parameter - this is just a tiny part of this work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork
[ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-21962 started by Ivan Suller. -- > Replacing ArrayList params with List in and around PlanUtils and MapWork > > > Key: HIVE-21962 > URL: https://issues.apache.org/jira/browse/HIVE-21962 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > > Using the implementing class is usually a bad practice. OO suggest to use the > least restrictive interface instead. ArrayList is used in many-many methods > as a parameter - this is just a tiny part of this work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21944) Remove unused methods, fields and variables from Vectorizer
[ https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21944: --- Attachment: HIVE-21944.1.patch > Remove unused methods, fields and variables from Vectorizer > --- > > Key: HIVE-21944 > URL: https://issues.apache.org/jira/browse/HIVE-21944 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21944.1.patch, HIVE-21944.1.patch, > HIVE-21944.1.patch > > > It seems there are many unused fields, variables and methods in > org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them > would make the code easier to understand. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21944) Remove unused methods, fields and variables from Vectorizer
[ https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21944: --- Attachment: HIVE-21944.1.patch > Remove unused methods, fields and variables from Vectorizer > --- > > Key: HIVE-21944 > URL: https://issues.apache.org/jira/browse/HIVE-21944 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21944.1.patch, HIVE-21944.1.patch > > > It seems there are many unused fields, variables and methods in > org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them > would make the code easier to understand. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21944) Remove unused methods, fields and variables from Vectorizer
[ https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21944: --- Status: Patch Available (was: In Progress) > Remove unused methods, fields and variables from Vectorizer > --- > > Key: HIVE-21944 > URL: https://issues.apache.org/jira/browse/HIVE-21944 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21944.1.patch > > > It seems there are many unused fields, variables and methods in > org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them > would make the code easier to understand. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21944) Remove unused methods, fields and variables from Vectorizer
[ https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21944: --- Attachment: HIVE-21944.1.patch > Remove unused methods, fields and variables from Vectorizer > --- > > Key: HIVE-21944 > URL: https://issues.apache.org/jira/browse/HIVE-21944 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21944.1.patch > > > It seems there are many unused fields, variables and methods in > org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them > would make the code easier to understand. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-21944) Remove unused methods, fields and variables from Vectorizer
[ https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-21944: -- > Remove unused methods, fields and variables from Vectorizer > --- > > Key: HIVE-21944 > URL: https://issues.apache.org/jira/browse/HIVE-21944 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > > It seems there are many unused fields, variables and methods in > org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them > would make the code easier to understand. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (HIVE-21944) Remove unused methods, fields and variables from Vectorizer
[ https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-21944 started by Ivan Suller. -- > Remove unused methods, fields and variables from Vectorizer > --- > > Key: HIVE-21944 > URL: https://issues.apache.org/jira/browse/HIVE-21944 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > > It seems there are many unused fields, variables and methods in > org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them > would make the code easier to understand. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21933) Remove unused methods from Utilities
[ https://issues.apache.org/jira/browse/HIVE-21933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21933: --- Attachment: HIVE-21933.1.patch > Remove unused methods from Utilities > > > Key: HIVE-21933 > URL: https://issues.apache.org/jira/browse/HIVE-21933 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Priority: Trivial > Attachments: HIVE-21933.1.patch > > > Over the years it seems org.apache.hadoop.hive.ql.exec.Utilities collected > many methods which are not used anymore. Removing them is the right thing to > do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21933) Remove unused methods from Utilities
[ https://issues.apache.org/jira/browse/HIVE-21933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21933: --- Status: Patch Available (was: Open) > Remove unused methods from Utilities > > > Key: HIVE-21933 > URL: https://issues.apache.org/jira/browse/HIVE-21933 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21933.1.patch > > > Over the years it seems org.apache.hadoop.hive.ql.exec.Utilities collected > many methods which are not used anymore. Removing them is the right thing to > do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-21933) Remove unused methods from Utilities
[ https://issues.apache.org/jira/browse/HIVE-21933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-21933: -- Assignee: Ivan Suller > Remove unused methods from Utilities > > > Key: HIVE-21933 > URL: https://issues.apache.org/jira/browse/HIVE-21933 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21933.1.patch > > > Over the years it seems org.apache.hadoop.hive.ql.exec.Utilities collected > many methods which are not used anymore. Removing them is the right thing to > do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21905) Generics improvement around the FetchOperator class
[ https://issues.apache.org/jira/browse/HIVE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21905: --- Attachment: HIVE-21905.2.patch > Generics improvement around the FetchOperator class > --- > > Key: HIVE-21905 > URL: https://issues.apache.org/jira/browse/HIVE-21905 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21905.1.patch, HIVE-21905.1.patch, > HIVE-21905.2.patch > > > In and around the org.apache.hadoop.hive.ql.exec.FetchOperator class the > generics are handled poorly. Lot's of declarations are missing generics, > which makes lots of noise in the IDE and makes it hard to be sure of the > correctness of the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21905) Generics improvement around the FetchOperator class
[ https://issues.apache.org/jira/browse/HIVE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21905: --- Attachment: HIVE-21905.1.patch > Generics improvement around the FetchOperator class > --- > > Key: HIVE-21905 > URL: https://issues.apache.org/jira/browse/HIVE-21905 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21905.1.patch, HIVE-21905.1.patch > > > In and around the org.apache.hadoop.hive.ql.exec.FetchOperator class the > generics are handled poorly. Lot's of declarations are missing generics, > which makes lots of noise in the IDE and makes it hard to be sure of the > correctness of the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21905) Generics improvement around the FetchOperator class
[ https://issues.apache.org/jira/browse/HIVE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21905: --- Attachment: HIVE-21905.1.patch > Generics improvement around the FetchOperator class > --- > > Key: HIVE-21905 > URL: https://issues.apache.org/jira/browse/HIVE-21905 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21905.1.patch > > > In and around the org.apache.hadoop.hive.ql.exec.FetchOperator class the > generics are handled poorly. Lot's of declarations are missing generics, > which makes lots of noise in the IDE and makes it hard to be sure of the > correctness of the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21905) Generics improvement around the FetchOperator class
[ https://issues.apache.org/jira/browse/HIVE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21905: --- Status: Patch Available (was: In Progress) > Generics improvement around the FetchOperator class > --- > > Key: HIVE-21905 > URL: https://issues.apache.org/jira/browse/HIVE-21905 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21905.1.patch > > > In and around the org.apache.hadoop.hive.ql.exec.FetchOperator class the > generics are handled poorly. Lot's of declarations are missing generics, > which makes lots of noise in the IDE and makes it hard to be sure of the > correctness of the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-21905) Generics improvement around the FetchOperator class
[ https://issues.apache.org/jira/browse/HIVE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-21905: -- > Generics improvement around the FetchOperator class > --- > > Key: HIVE-21905 > URL: https://issues.apache.org/jira/browse/HIVE-21905 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > > In and around the org.apache.hadoop.hive.ql.exec.FetchOperator class the > generics are handled poorly. Lot's of declarations are missing generics, > which makes lots of noise in the IDE and makes it hard to be sure of the > correctness of the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (HIVE-21905) Generics improvement around the FetchOperator class
[ https://issues.apache.org/jira/browse/HIVE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-21905 started by Ivan Suller. -- > Generics improvement around the FetchOperator class > --- > > Key: HIVE-21905 > URL: https://issues.apache.org/jira/browse/HIVE-21905 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > > In and around the org.apache.hadoop.hive.ql.exec.FetchOperator class the > generics are handled poorly. Lot's of declarations are missing generics, > which makes lots of noise in the IDE and makes it hard to be sure of the > correctness of the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HIVE-21542) Group by rollup returns with empty result when the grouped dataset is empty
[ https://issues.apache.org/jira/browse/HIVE-21542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller resolved HIVE-21542. Resolution: Duplicate Release Note: Duplicate of HIVE-21795 > Group by rollup returns with empty result when the grouped dataset is empty > --- > > Key: HIVE-21542 > URL: https://issues.apache.org/jira/browse/HIVE-21542 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Attachments: groupby_rollup_empty2.q > > > Running the attached q file the result is not what is expected: the rollup > group by missing the one summary row. The summary row should be there even if > the source dataset is empty. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21835) Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer
[ https://issues.apache.org/jira/browse/HIVE-21835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21835: --- Attachment: HIVE-21835.2.patch > Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer > - > > Key: HIVE-21835 > URL: https://issues.apache.org/jira/browse/HIVE-21835 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21835.1.patch, HIVE-21835.2.patch, > HIVE-21835.2.patch > > > There are several null checks in > org.apache.hadoop.hive.ql.optimizer.StatsOptimizer after Long.parseLong(...) > call. This method returns with a primitive long value, which cannot be null - > a null check after this call is redundant. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
[ https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21842: --- Attachment: HIVE-21842.1.patch > Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics > > > Key: HIVE-21842 > URL: https://issues.apache.org/jira/browse/HIVE-21842 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21842.1.patch, HIVE-21842.1.patch > > > There are several unnecessary or inefficient solution in the aforementioned > method. A little code cleanup could help to reduce the complexity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
[ https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21842: --- Status: Patch Available (was: In Progress) > Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics > > > Key: HIVE-21842 > URL: https://issues.apache.org/jira/browse/HIVE-21842 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21842.1.patch > > > There are several unnecessary or inefficient solution in the aforementioned > method. A little code cleanup could help to reduce the complexity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
[ https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21842: --- Attachment: HIVE-21842.1.patch > Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics > > > Key: HIVE-21842 > URL: https://issues.apache.org/jira/browse/HIVE-21842 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21842.1.patch > > > There are several unnecessary or inefficient solution in the aforementioned > method. A little code cleanup could help to reduce the complexity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
[ https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-21842 started by Ivan Suller. -- > Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics > > > Key: HIVE-21842 > URL: https://issues.apache.org/jira/browse/HIVE-21842 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > Attachments: HIVE-21842.1.patch > > > There are several unnecessary or inefficient solution in the aforementioned > method. A little code cleanup could help to reduce the complexity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
[ https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-21842: -- > Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics > > > Key: HIVE-21842 > URL: https://issues.apache.org/jira/browse/HIVE-21842 > Project: Hive > Issue Type: Improvement > Components: Hive >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Trivial > > There are several unnecessary or inefficient solution in the aforementioned > method. A little code cleanup could help to reduce the complexity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21835) Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer
[ https://issues.apache.org/jira/browse/HIVE-21835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21835: --- Attachment: HIVE-21835.2.patch > Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer > - > > Key: HIVE-21835 > URL: https://issues.apache.org/jira/browse/HIVE-21835 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21835.1.patch, HIVE-21835.2.patch > > > There are several null checks in > org.apache.hadoop.hive.ql.optimizer.StatsOptimizer after Long.parseLong(...) > call. This method returns with a primitive long value, which cannot be null - > a null check after this call is redundant. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21835) Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer
[ https://issues.apache.org/jira/browse/HIVE-21835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21835: --- Assignee: Ivan Suller Status: Patch Available (was: Open) > Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer > - > > Key: HIVE-21835 > URL: https://issues.apache.org/jira/browse/HIVE-21835 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21835.1.patch > > > There are several null checks in > org.apache.hadoop.hive.ql.optimizer.StatsOptimizer after Long.parseLong(...) > call. This method returns with a primitive long value, which cannot be null - > a null check after this call is redundant. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21835) Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer
[ https://issues.apache.org/jira/browse/HIVE-21835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21835: --- Attachment: HIVE-21835.1.patch > Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer > - > > Key: HIVE-21835 > URL: https://issues.apache.org/jira/browse/HIVE-21835 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Priority: Minor > Attachments: HIVE-21835.1.patch > > > There are several null checks in > org.apache.hadoop.hive.ql.optimizer.StatsOptimizer after Long.parseLong(...) > call. This method returns with a primitive long value, which cannot be null - > a null check after this call is redundant. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21835) Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer
[ https://issues.apache.org/jira/browse/HIVE-21835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21835: --- Priority: Minor (was: Major) > Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer > - > > Key: HIVE-21835 > URL: https://issues.apache.org/jira/browse/HIVE-21835 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Priority: Minor > > There are several null checks in > org.apache.hadoop.hive.ql.optimizer.StatsOptimizer after Long.parseLong(...) > call. This method returns with a primitive long value, which cannot be null - > a null check after this call is redundant. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21000) Upgrade thrift to at least 0.10.0
[ https://issues.apache.org/jira/browse/HIVE-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855644#comment-16855644 ] Ivan Suller commented on HIVE-21000: [~dlavati] I'm not sure we should upgrade to an alpha version. > Upgrade thrift to at least 0.10.0 > - > > Key: HIVE-21000 > URL: https://issues.apache.org/jira/browse/HIVE-21000 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Haindrich >Assignee: Ivan Suller >Priority: Major > Attachments: HIVE-21000.01.patch, HIVE-21000.02.patch, > HIVE-21000.03.patch, HIVE-21000.04.patch, HIVE-21000.05.patch, > HIVE-21000.06.patch, HIVE-21000.07.patch, HIVE-21000.08.patch, > sampler_before.png > > > I was looking into some compile profiles for tables with lots of columns; and > it turned out that [thrift 0.9.3 is allocating a > List|https://github.com/apache/hive/blob/8e30b5e029570407d8a1db67d322a95db705750e/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java#L348] > during every hashcode calculation; but luckily THRIFT-2877 is improving on > that - so I propose to upgrade to at least 0.10.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21784: --- Attachment: HIVE-21784.4.patch > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21784.1.patch, HIVE-21784.2.patch, > HIVE-21784.3.patch, HIVE-21784.3.patch, HIVE-21784.4.patch, > HIVE-21784.4.patch, HIVE-21784.4.patch > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21542) Group by rollup returns with empty result when the grouped dataset is empty
[ https://issues.apache.org/jira/browse/HIVE-21542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850755#comment-16850755 ] Ivan Suller commented on HIVE-21542: [~kgyrtkirk] you mean HIVE-21795 is a duplicate of this? But yes, it seems the two ticket is referring to the same issue. > Group by rollup returns with empty result when the grouped dataset is empty > --- > > Key: HIVE-21542 > URL: https://issues.apache.org/jira/browse/HIVE-21542 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Attachments: groupby_rollup_empty2.q > > > Running the attached q file the result is not what is expected: the rollup > group by missing the one summary row. The summary row should be there even if > the source dataset is empty. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21784: --- Attachment: HIVE-21784.4.patch > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21784.1.patch, HIVE-21784.2.patch, > HIVE-21784.3.patch, HIVE-21784.3.patch, HIVE-21784.4.patch, HIVE-21784.4.patch > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21789) HiveFileFormatUtils.getRecordWriter is unnecessary
[ https://issues.apache.org/jira/browse/HIVE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21789: --- Status: Patch Available (was: Open) > HiveFileFormatUtils.getRecordWriter is unnecessary > -- > > Key: HIVE-21789 > URL: https://issues.apache.org/jira/browse/HIVE-21789 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21789.1.patch > > > The method org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getRecordWriter > checks if the given outputFormat parameter is a HiveOutputFormat, but it is > always true. So this way the check and thus the method is unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21784: --- Attachment: HIVE-21784.4.patch > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21784.1.patch, HIVE-21784.2.patch, > HIVE-21784.3.patch, HIVE-21784.3.patch, HIVE-21784.4.patch > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21784: --- Attachment: HIVE-21784.3.patch > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21784.1.patch, HIVE-21784.2.patch, > HIVE-21784.3.patch, HIVE-21784.3.patch > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21789) HiveFileFormatUtils.getRecordWriter is unnecessary
[ https://issues.apache.org/jira/browse/HIVE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21789: --- Attachment: HIVE-21789.1.patch > HiveFileFormatUtils.getRecordWriter is unnecessary > -- > > Key: HIVE-21789 > URL: https://issues.apache.org/jira/browse/HIVE-21789 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > Attachments: HIVE-21789.1.patch > > > The method org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getRecordWriter > checks if the given outputFormat parameter is a HiveOutputFormat, but it is > always true. So this way the check and thus the method is unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21784: --- Attachment: HIVE-21784.3.patch > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21784.1.patch, HIVE-21784.2.patch, > HIVE-21784.3.patch > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21784: --- Attachment: HIVE-21784.2.patch > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21784.1.patch, HIVE-21784.2.patch > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-21789) HiveFileFormatUtils.getRecordWriter is unnecessary
[ https://issues.apache.org/jira/browse/HIVE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-21789: -- > HiveFileFormatUtils.getRecordWriter is unnecessary > -- > > Key: HIVE-21789 > URL: https://issues.apache.org/jira/browse/HIVE-21789 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Minor > > The method org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getRecordWriter > checks if the given outputFormat parameter is a HiveOutputFormat, but it is > always true. So this way the check and thus the method is unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-21784 started by Ivan Suller. -- > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21784.1.patch > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21784: --- Attachment: HIVE-21784.1.patch > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21784.1.patch > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller updated HIVE-21784: --- Status: Patch Available (was: In Progress) > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21784.1.patch > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-21784) Insert overwrite on an acid (not mm) table is ineffective if the input is empty
[ https://issues.apache.org/jira/browse/HIVE-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Suller reassigned HIVE-21784: -- > Insert overwrite on an acid (not mm) table is ineffective if the input is > empty > --- > > Key: HIVE-21784 > URL: https://issues.apache.org/jira/browse/HIVE-21784 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > Fix For: 4.0.0 > > > The issue of HIVE-18702 is present for ACID tables as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
