[jira] [Comment Edited] (HIVE-13617) LLAP: support non-vectorized execution in IO
[ https://issues.apache.org/jira/browse/HIVE-13617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280951#comment-15280951 ] Sergey Shelukhin edited comment on HIVE-13617 at 5/12/16 12:21 AM: --- Preliminary patch. I need to double check that results from simple types are correct. Also complex types do not appear to work in the elevator, would need to double check that too. I gave up on trying to make a universal converter because it's nigh impossible to substitute the OIs... attaching the terminated-in-progress patch for that too, in case it's ever needed. was (Author: sershe): Preliminary patch. I need to double check that results from simple types are correct. Also complex types do not appear to work in the elevator, would need to double check that too. I gave up on trying to make a universal converted because it's nigh impossible to substitute the OIs... attaching the terminated-in-progress patch for that too, in case it's ever needed. > LLAP: support non-vectorized execution in IO > > > Key: HIVE-13617 > URL: https://issues.apache.org/jira/browse/HIVE-13617 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-13617-wo-11417.patch, HIVE-13617.patch, > HIVE-15396-with-oi.patch > > > Two approaches - a separate decoding path, into rows instead of VRBs; or > decoding VRBs into rows on a higher level (the original LlapInputFormat). I > think the latter might be better - it's not a hugely important path, and perf > in non-vectorized case is not the best anyway, so it's better to make do with > much less new code and architectural disruption. > Some ORC patches in progress introduce an easy to reuse (or so I hope, > anyway) VRB-to-row conversion, so we should just use that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HIVE-13617) LLAP: support non-vectorized execution in IO
[ https://issues.apache.org/jira/browse/HIVE-13617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258879#comment-15258879 ] Sergey Shelukhin edited comment on HIVE-13617 at 4/26/16 8:42 PM: -- [~prasanth_j] [~hagleitn] fyi [~owen.omalley] what is the final JIRA that adds the vrb-to-row conversion? We would like to reuse that code after it goes in. Is it HIVE-11417? was (Author: sershe): [~prasanth_j] [~hagleitn] fyi [~owen.omalley] what is the final JIRA that adds the vrb-to-row conversion? We would like to reuse that code after it goes in. Is it hive-11417? > LLAP: support non-vectorized execution in IO > > > Key: HIVE-13617 > URL: https://issues.apache.org/jira/browse/HIVE-13617 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin > > Two approaches - a separate decoding path, into rows instead of VRBs; or > decoding VRBs into rows. I think the latter might be better - it's not a > hugely important path, and perf in non-vectorized case is not the best > anyway, so it's better to make do with much less new code and architectural > disruption. > Some ORC patches in progress introduce an easy to reuse (or so I hope, > anyway) VRB-to-row conversion, so we should just use that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HIVE-13617) LLAP: support non-vectorized execution in IO
[ https://issues.apache.org/jira/browse/HIVE-13617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258879#comment-15258879 ] Sergey Shelukhin edited comment on HIVE-13617 at 4/26/16 8:42 PM: -- [~prasanth_j] [~hagleitn] fyi [~owen.omalley] what is the final JIRA that adds the vrb-to-row conversion? We would like to reuse that code after it goes in. Is it hive-11417? was (Author: sershe): [~prasanth_j] [~hagleitn] fyi [~owen.omalley] what is the final JIRA that adds the vrb-to-row conversion? We would like to reuse that code after it goes in > LLAP: support non-vectorized execution in IO > > > Key: HIVE-13617 > URL: https://issues.apache.org/jira/browse/HIVE-13617 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin > > Two approaches - a separate decoding path, into rows instead of VRBs; or > decoding VRBs into rows. I think the latter might be better - it's not a > hugely important path, and perf in non-vectorized case is not the best > anyway, so it's better to make do with much less new code and architectural > disruption. > Some ORC patches in progress introduce an easy to reuse (or so I hope, > anyway) VRB-to-row conversion, so we should just use that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
