[jira] [Comment Edited] (HIVE-14793) Allow ptest branch to be specified, PROFILE override
[ https://issues.apache.org/jira/browse/HIVE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507755#comment-15507755 ] Siddharth Seth edited comment on HIVE-14793 at 9/20/16 9:58 PM: bq. 1. Can we create a new function that checks and/or initializes environment variables? I think this would be useful for new devs when looking at what config variables can be used. I don't think we should do this in the current jira. There's a lot more variables other than the ones added here. Beyond that, this may not be a great approach since it separates the logic for processing variables into multiple places. e.g. PTEST_GIT_BRANCH is only required while setting up the branch. I don't think a separate method to take care of this, along with initialization of other methods helps a lot. bq. --outputDir is not necessary anymore. Reverting the change and testing (this still leaves the outputDir, but I believe it's required by the ptest client). Will post a patch after testing with the reverted outputDir once it runs successfully. was (Author: sseth): bq. 1. Can we create a new function that checks and/or initializes environment variables? I think this would be useful for new devs when looking at what config variables can be used. I don't think we should do this in the current jira. There's a lot more variables other than the ones added here. Beyond that, this may not be a great approach since it separates the logic for processing variables into multiple places. e.g. PTEST_GIT_BRANCH is only required while setting up the branch. I don't think a separate method to take care of this, along with initialization of other methods helps a lot. bq .outputDir is not necessary anymore. Reverting the change and testing (this still leaves the outputDir, but I believe it's required by the ptest client). Will post a patch after testing with the reverted outputDir once it runs successfully. > Allow ptest branch to be specified, PROFILE override > > > Key: HIVE-14793 > URL: https://issues.apache.org/jira/browse/HIVE-14793 > Project: Hive > Issue Type: Sub-task > Components: Hive, Testing Infrastructure >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-14793.01.patch, HIVE-14793.02.patch > > > Post HIVE-14734 - the profile is automatically determined. Add an option to > override this via Jenkins. Also add an option to specify the branch from > which ptest is built (This is hardcoded to github.com/apache/hive) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HIVE-14793) Allow ptest branch to be specified, PROFILE override
[ https://issues.apache.org/jira/browse/HIVE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507755#comment-15507755 ] Siddharth Seth edited comment on HIVE-14793 at 9/20/16 9:57 PM: bq. 1. Can we create a new function that checks and/or initializes environment variables? I think this would be useful for new devs when looking at what config variables can be used. I don't think we should do this in the current jira. There's a lot more variables other than the ones added here. Beyond that, this may not be a great approach since it separates the logic for processing variables into multiple places. e.g. PTEST_GIT_BRANCH is only required while setting up the branch. I don't think a separate method to take care of this, along with initialization of other methods helps a lot. bq .outputDir is not necessary anymore. Reverting the change and testing (this still leaves the outputDir, but I believe it's required by the ptest client). Will post a patch after testing with the reverted outputDir once it runs successfully. was (Author: sseth): bq. 1. Can we create a new function that checks and/or initializes environment variables? I think this would be useful for new devs when looking at what config variables can be used. I don't think we should do this in the current jira. There's a lot more variables other than the ones added here. Beyond that, this may not be a great approach since it separates the logic for processing variables into multiple places. e.g. PTEST_GIT_BRANCH is only required while setting up the branch. I don't think a separate method to take care of this, along with initialization of other methods helps a lot. bq .--outputDir is not necessary anymore. Reverting the change and testing (this still leaves the outputDir, but I believe it's required by the ptest client). Will post a patch after testing with the reverted outputDir once it runs successfully. > Allow ptest branch to be specified, PROFILE override > > > Key: HIVE-14793 > URL: https://issues.apache.org/jira/browse/HIVE-14793 > Project: Hive > Issue Type: Sub-task > Components: Hive, Testing Infrastructure >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-14793.01.patch, HIVE-14793.02.patch > > > Post HIVE-14734 - the profile is automatically determined. Add an option to > override this via Jenkins. Also add an option to specify the branch from > which ptest is built (This is hardcoded to github.com/apache/hive) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HIVE-14793) Allow ptest branch to be specified, PROFILE override
[ https://issues.apache.org/jira/browse/HIVE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507755#comment-15507755 ] Siddharth Seth edited comment on HIVE-14793 at 9/20/16 8:49 PM: bq. 1. Can we create a new function that checks and/or initializes environment variables? I think this would be useful for new devs when looking at what config variables can be used. I don't think we should do this in the current jira. There's a lot more variables other than the ones added here. Beyond that, this may not be a great approach since it separates the logic for processing variables into multiple places. e.g. PTEST_GIT_BRANCH is only required while setting up the branch. I don't think a separate method to take care of this, along with initialization of other methods helps a lot. bq .--outputDir is not necessary anymore. Reverting the change and testing (this still leaves the outputDir, but I believe it's required by the ptest client). Will post a patch after testing with the reverted outputDir once it runs successfully. was (Author: sseth): bq. 1. Can we create a new function that checks and/or initializes environment variables? I think this would be useful for new devs when looking at what config variables can be used. I don't think we should do this in the current jira. There's a lot more variables other than the ones added here. Beyond that, this may not be a great approach since it separates the logic for processing variables into multiple places. e.g. PTEST_GIT_BRANCH is only required while setting up the branch. I don't think a separate method to take care of this, along with initialization of other methods helps a lot. bq .--outputDir is not necessary anymore. Reverting the change and testing (this still leaves the outputDir, but I believe it's required by the ptest client). Will post a patch after testing with the reverted outputDir. > Allow ptest branch to be specified, PROFILE override > > > Key: HIVE-14793 > URL: https://issues.apache.org/jira/browse/HIVE-14793 > Project: Hive > Issue Type: Sub-task > Components: Hive, Testing Infrastructure >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-14793.01.patch > > > Post HIVE-14734 - the profile is automatically determined. Add an option to > override this via Jenkins. Also add an option to specify the branch from > which ptest is built (This is hardcoded to github.com/apache/hive) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HIVE-14793) Allow ptest branch to be specified, PROFILE override
[ https://issues.apache.org/jira/browse/HIVE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505429#comment-15505429 ] Sergio Peña edited comment on HIVE-14793 at 9/20/16 3:13 AM: - Thanks [~sseth]. I couple of comments 1. Can we create a new function that checks and/or initializes environment variables? I think this would be useful for new devs when looking at what config variables can be used. 2. --outputDir is not necessary anymore. I fixed the test results issue in HIVE-14790, and also in the jenkins job config. was (Author: spena): Thanks [~sseth]. I couple of comments > Allow ptest branch to be specified, PROFILE override > > > Key: HIVE-14793 > URL: https://issues.apache.org/jira/browse/HIVE-14793 > Project: Hive > Issue Type: Sub-task > Components: Hive, Testing Infrastructure >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-14793.01.patch > > > Post HIVE-14734 - the profile is automatically determined. Add an option to > override this via Jenkins. Also add an option to specify the branch from > which ptest is built (This is hardcoded to github.com/apache/hive) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
