[jira] [Commented] (HIVE-10332) Use SortExchange rather than LogicalExchange for HiveOpConverter
[ https://issues.apache.org/jira/browse/HIVE-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495788#comment-14495788 ] Jesus Camacho Rodriguez commented on HIVE-10332: [~pxiong], given different requirements by different systems, IMO it makes sense to keep both on the Calcite side; LogicalExchange is an operator that (re)partitions data, while SortExchange (re)partitions data and enforces a certain order. CC'ing [~julianhyde] in case he has a different opinion Use SortExchange rather than LogicalExchange for HiveOpConverter Key: HIVE-10332 URL: https://issues.apache.org/jira/browse/HIVE-10332 Project: Hive Issue Type: Sub-task Components: CBO Reporter: Pengcheng Xiong Assignee: Pengcheng Xiong Fix For: cbo-branch Attachments: HIVE-10332.01.patch Right now HiveSortExchange extends SortExchange extends Exchange. LogicalExchange extends Exchange. LogicalExchange is expected in HiveOpConverter but HiveSortExchange is created. After discussion, we plan to change LogicalExchange to HiveSortExchange. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10332) Use SortExchange rather than LogicalExchange for HiveOpConverter
[ https://issues.apache.org/jira/browse/HIVE-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495820#comment-14495820 ] Julian Hyde commented on HIVE-10332: No reason to remove LogicalExchange from Calcite, even if Hive doesn't use it. We could create a LogicalSortExchange in Calcite if Hive would find it useful. (Unlike HiveSortExchange, it would have logical convention.) Use SortExchange rather than LogicalExchange for HiveOpConverter Key: HIVE-10332 URL: https://issues.apache.org/jira/browse/HIVE-10332 Project: Hive Issue Type: Sub-task Components: CBO Reporter: Pengcheng Xiong Assignee: Pengcheng Xiong Fix For: cbo-branch Attachments: HIVE-10332.01.patch Right now HiveSortExchange extends SortExchange extends Exchange. LogicalExchange extends Exchange. LogicalExchange is expected in HiveOpConverter but HiveSortExchange is created. After discussion, we plan to change LogicalExchange to HiveSortExchange. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10332) Use SortExchange rather than LogicalExchange for HiveOpConverter
[ https://issues.apache.org/jira/browse/HIVE-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14496066#comment-14496066 ] Jesus Camacho Rodriguez commented on HIVE-10332: I have created CALCITE-681 to follow up on this issue. Use SortExchange rather than LogicalExchange for HiveOpConverter Key: HIVE-10332 URL: https://issues.apache.org/jira/browse/HIVE-10332 Project: Hive Issue Type: Sub-task Components: CBO Reporter: Pengcheng Xiong Assignee: Pengcheng Xiong Fix For: cbo-branch Attachments: HIVE-10332.01.patch Right now HiveSortExchange extends SortExchange extends Exchange. LogicalExchange extends Exchange. LogicalExchange is expected in HiveOpConverter but HiveSortExchange is created. After discussion, we plan to change LogicalExchange to HiveSortExchange. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10332) Use SortExchange rather than LogicalExchange for HiveOpConverter
[ https://issues.apache.org/jira/browse/HIVE-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495448#comment-14495448 ] Pengcheng Xiong commented on HIVE-10332: [~ashutoshc], could u please review it and check it in? Thanks. Use SortExchange rather than LogicalExchange for HiveOpConverter Key: HIVE-10332 URL: https://issues.apache.org/jira/browse/HIVE-10332 Project: Hive Issue Type: Sub-task Components: CBO Reporter: Pengcheng Xiong Assignee: Pengcheng Xiong Fix For: 1.2.0 Attachments: HIVE-10332.01.patch Right now HiveSortExchange extends SortExchange extends Exchange. LogicalExchange extends Exchange. LogicalExchange is expected in HiveOpConverter but HiveSortExchange is created. After discussion, we plan to change LogicalExchange to HiveSortExchange. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10332) Use SortExchange rather than LogicalExchange for HiveOpConverter
[ https://issues.apache.org/jira/browse/HIVE-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495492#comment-14495492 ] Ashutosh Chauhan commented on HIVE-10332: - +1 Use SortExchange rather than LogicalExchange for HiveOpConverter Key: HIVE-10332 URL: https://issues.apache.org/jira/browse/HIVE-10332 Project: Hive Issue Type: Sub-task Components: CBO Reporter: Pengcheng Xiong Assignee: Pengcheng Xiong Fix For: 1.2.0 Attachments: HIVE-10332.01.patch Right now HiveSortExchange extends SortExchange extends Exchange. LogicalExchange extends Exchange. LogicalExchange is expected in HiveOpConverter but HiveSortExchange is created. After discussion, we plan to change LogicalExchange to HiveSortExchange. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
