[jira] [Commented] (HIVE-11025) In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly
[ https://issues.apache.org/jira/browse/HIVE-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002858#comment-15002858 ] Aihua Xu commented on HIVE-11025: - Yeah. It should be backported to branch-1. > In windowing spec, when the datatype is decimal, it's comparing the value > against NULL value incorrectly > > > Key: HIVE-11025 > URL: https://issues.apache.org/jira/browse/HIVE-11025 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Fix For: 2.0.0 > > Attachments: HIVE-11025.patch > > > Given data and the following query, > {noformat} > deptno empno bonussalary > 307698 NULL2850.0 > 307900 NULL950.0 > 307844 0 1500.0 > select avg(salary) over (partition by deptno order by bonus range 200 > preceding) from emp2; > {noformat} > It produces incorrect result for the row in which bonus=0 > 1900.0 > 1900.0 > 1766.7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11025) In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly
[ https://issues.apache.org/jira/browse/HIVE-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595954#comment-14595954 ] Aihua Xu commented on HIVE-11025: - [~ashutoshc] Can you help submit the patch? Thanks. In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly Key: HIVE-11025 URL: https://issues.apache.org/jira/browse/HIVE-11025 Project: Hive Issue Type: Sub-task Components: PTF-Windowing Affects Versions: 2.0.0 Reporter: Aihua Xu Assignee: Aihua Xu Attachments: HIVE-11025.patch Given data and the following query, {noformat} deptno empno bonussalary 307698 NULL2850.0 307900 NULL950.0 307844 0 1500.0 select avg(salary) over (partition by deptno order by bonus range 200 preceding) from emp2; {noformat} It produces incorrect result for the row in which bonus=0 1900.0 1900.0 1766.7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11025) In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly
[ https://issues.apache.org/jira/browse/HIVE-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591366#comment-14591366 ] Hive QA commented on HIVE-11025: {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12740235/HIVE-11025.patch {color:green}SUCCESS:{color} +1 9008 tests passed Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4297/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4297/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4297/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12740235 - PreCommit-HIVE-TRUNK-Build In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly Key: HIVE-11025 URL: https://issues.apache.org/jira/browse/HIVE-11025 Project: Hive Issue Type: Sub-task Components: PTF-Windowing Affects Versions: 2.0.0 Reporter: Aihua Xu Assignee: Aihua Xu Attachments: HIVE-11025.patch Given data and the following query, {noformat} deptno empno bonussalary 307698 NULL2850.0 307900 NULL950.0 307844 0 1500.0 select avg(salary) over (partition by deptno order by bonus range 200 preceding) from emp2; {noformat} It produces incorrect result for the row in which bonus=0 1900.0 1900.0 1766.7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11025) In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly
[ https://issues.apache.org/jira/browse/HIVE-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590788#comment-14590788 ] Ashutosh Chauhan commented on HIVE-11025: - +1 In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly Key: HIVE-11025 URL: https://issues.apache.org/jira/browse/HIVE-11025 Project: Hive Issue Type: Sub-task Components: PTF-Windowing Affects Versions: 2.0.0 Reporter: Aihua Xu Assignee: Aihua Xu Attachments: HIVE-11025.patch Given data and the following query, {noformat} deptno empno bonussalary 307698 NULL2850.0 307900 NULL950.0 307844 0 1500.0 select avg(salary) over (partition by deptno order by bonus range 200 preceding) from emp2; {noformat} It produces incorrect result for the row in which bonus=0 1900.0 1900.0 1766.7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11025) In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly
[ https://issues.apache.org/jira/browse/HIVE-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14589374#comment-14589374 ] Hive QA commented on HIVE-11025: {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12739957/HIVE-11025.patch {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 9000 tests executed *Failed tests:* {noformat} TestOperationLoggingAPIWithMr - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_join28 {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4282/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4282/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4282/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12739957 - PreCommit-HIVE-TRUNK-Build In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly Key: HIVE-11025 URL: https://issues.apache.org/jira/browse/HIVE-11025 Project: Hive Issue Type: Sub-task Components: PTF-Windowing Affects Versions: 2.0.0 Reporter: Aihua Xu Assignee: Aihua Xu Attachments: HIVE-11025.patch Given data and the following query, {noformat} deptno empno bonussalary 307698 NULL2850.0 307900 NULL950.0 307844 0 1500.0 select avg(salary) over (partition by deptno order by bonus range 200 preceding) from emp2; {noformat} It produces incorrect result for the row in which bonus=0 1900.0 1900.0 1766.7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11025) In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly
[ https://issues.apache.org/jira/browse/HIVE-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14589895#comment-14589895 ] Aihua Xu commented on HIVE-11025: - The test failures are not related to the patch. In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly Key: HIVE-11025 URL: https://issues.apache.org/jira/browse/HIVE-11025 Project: Hive Issue Type: Sub-task Components: PTF-Windowing Affects Versions: 2.0.0 Reporter: Aihua Xu Assignee: Aihua Xu Attachments: HIVE-11025.patch Given data and the following query, {noformat} deptno empno bonussalary 307698 NULL2850.0 307900 NULL950.0 307844 0 1500.0 select avg(salary) over (partition by deptno order by bonus range 200 preceding) from emp2; {noformat} It produces incorrect result for the row in which bonus=0 1900.0 1900.0 1766.7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11025) In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly
[ https://issues.apache.org/jira/browse/HIVE-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14589979#comment-14589979 ] Ashutosh Chauhan commented on HIVE-11025: - Left a comment on RB. In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly Key: HIVE-11025 URL: https://issues.apache.org/jira/browse/HIVE-11025 Project: Hive Issue Type: Sub-task Components: PTF-Windowing Affects Versions: 2.0.0 Reporter: Aihua Xu Assignee: Aihua Xu Attachments: HIVE-11025.patch Given data and the following query, {noformat} deptno empno bonussalary 307698 NULL2850.0 307900 NULL950.0 307844 0 1500.0 select avg(salary) over (partition by deptno order by bonus range 200 preceding) from emp2; {noformat} It produces incorrect result for the row in which bonus=0 1900.0 1900.0 1766.7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)