[jira] [Commented] (HIVE-11190) No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden
[ https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653305#comment-14653305 ] ASF GitHub Bot commented on HIVE-11190: --- Github user sundapeng closed the pull request at: https://github.com/apache/hive/pull/45 No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden -- Key: HIVE-11190 URL: https://issues.apache.org/jira/browse/HIVE-11190 Project: Hive Issue Type: Bug Reporter: Dapeng Sun Assignee: Dapeng Sun Fix For: 1.3.0, 2.0.0 Attachments: HIVE-11190.001.patch, HIVE-11190.002.patch, HIVE-11190.003.patch ConfVars.METASTORE_FILTER_HOOK in authorization V2 is will be override without prompting info or warning. it will cause user failed to customize the METASTORE_FILTER_HOOK. We should log information such as this value is ignored when override happens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11190) No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden
[ https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624240#comment-14624240 ] Dapeng Sun commented on HIVE-11190: --- Thank [~thejas] and [~Ferd] for your review. No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden -- Key: HIVE-11190 URL: https://issues.apache.org/jira/browse/HIVE-11190 Project: Hive Issue Type: Bug Reporter: Dapeng Sun Assignee: Dapeng Sun Fix For: 1.3.0, 2.0.0 Attachments: HIVE-11190.001.patch, HIVE-11190.002.patch, HIVE-11190.003.patch ConfVars.METASTORE_FILTER_HOOK in authorization V2 is will be override without prompting info or warning. it will cause user failed to customize the METASTORE_FILTER_HOOK. We should log information such as this value is ignored when override happens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11190) No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622237#comment-14622237
]
Hive QA commented on HIVE-11190:
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12744639/HIVE-11190.003.patch
{color:green}SUCCESS:{color} +1 9150 tests passed
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4569/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4569/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4569/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12744639 - PreCommit-HIVE-TRUNK-Build
No prompting info or warning provided when METASTORE_FILTER_HOOK in
authorization V2 is overridden
--
Key: HIVE-11190
URL: https://issues.apache.org/jira/browse/HIVE-11190
Project: Hive
Issue Type: Bug
Reporter: Dapeng Sun
Assignee: Dapeng Sun
Attachments: HIVE-11190.001.patch, HIVE-11190.002.patch,
HIVE-11190.003.patch
ConfVars.METASTORE_FILTER_HOOK in authorization V2 is will be override
without prompting info or warning.
it will cause user failed to customize the METASTORE_FILTER_HOOK. We should
log information such as this value is ignored when override happens.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11190) No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden
[ https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622589#comment-14622589 ] Thejas M Nair commented on HIVE-11190: -- +1 No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden -- Key: HIVE-11190 URL: https://issues.apache.org/jira/browse/HIVE-11190 Project: Hive Issue Type: Bug Reporter: Dapeng Sun Assignee: Dapeng Sun Attachments: HIVE-11190.001.patch, HIVE-11190.002.patch, HIVE-11190.003.patch ConfVars.METASTORE_FILTER_HOOK in authorization V2 is will be override without prompting info or warning. it will cause user failed to customize the METASTORE_FILTER_HOOK. We should log information such as this value is ignored when override happens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11190) No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620648#comment-14620648
]
Hive QA commented on HIVE-11190:
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12744398/HIVE-11190.002.patch
{color:green}SUCCESS:{color} +1 9138 tests passed
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4552/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4552/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4552/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12744398 - PreCommit-HIVE-TRUNK-Build
No prompting info or warning provided when METASTORE_FILTER_HOOK in
authorization V2 is overridden
--
Key: HIVE-11190
URL: https://issues.apache.org/jira/browse/HIVE-11190
Project: Hive
Issue Type: Bug
Reporter: Dapeng Sun
Assignee: Dapeng Sun
Attachments: HIVE-11190.001.patch, HIVE-11190.002.patch
ConfVars.METASTORE_FILTER_HOOK in authorization V2 is will be override
without prompting info or warning.
it will cause user failed to customize the METASTORE_FILTER_HOOK. We should
log information such as this value is ignored when override happens.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11190) No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden
[ https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621744#comment-14621744 ] Dapeng Sun commented on HIVE-11190: --- Update patch according [~thejas] 's comments. No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden -- Key: HIVE-11190 URL: https://issues.apache.org/jira/browse/HIVE-11190 Project: Hive Issue Type: Bug Reporter: Dapeng Sun Assignee: Dapeng Sun Attachments: HIVE-11190.001.patch, HIVE-11190.002.patch, HIVE-11190.003.patch ConfVars.METASTORE_FILTER_HOOK in authorization V2 is will be override without prompting info or warning. it will cause user failed to customize the METASTORE_FILTER_HOOK. We should log information such as this value is ignored when override happens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11190) No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden
[ https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621665#comment-14621665 ] Thejas M Nair commented on HIVE-11190: -- I didn't realize the config description already said that. So, no change required there. No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden -- Key: HIVE-11190 URL: https://issues.apache.org/jira/browse/HIVE-11190 Project: Hive Issue Type: Bug Reporter: Dapeng Sun Assignee: Dapeng Sun Attachments: HIVE-11190.001.patch, HIVE-11190.002.patch ConfVars.METASTORE_FILTER_HOOK in authorization V2 is will be override without prompting info or warning. it will cause user failed to customize the METASTORE_FILTER_HOOK. We should log information such as this value is ignored when override happens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11190) No prompting info or warning provided when METASTORE_FILTER_HOOK in authorization V2 is overridden
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621655#comment-14621655
]
Dapeng Sun commented on HIVE-11190:
---
Thank you for your comments, [~thejas] .
{quote}
replace the use of the string
org.apache.hadoop.hive.ql.security.authorization.plugin.AuthorizationMetaStoreFilterHook
with AuthorizationMetaStoreFilterHook.class.getName() ? (less chances of typos
happening).
{quote}
Good suggestion. I will update it in next patch.
{quote}
update the description of ConfVars.METASTORE_FILTER_HOOK to say that it gets
overridden when V2 auth is used ?
{quote}
The description of {{ConfVars.METASTORE_FILTER_HOOK}} is If
hive.security.authorization.manager is set to instance of
HiveAuthorizerFactory, then this value is ignored.. Do you think it still need
to update?
No prompting info or warning provided when METASTORE_FILTER_HOOK in
authorization V2 is overridden
--
Key: HIVE-11190
URL: https://issues.apache.org/jira/browse/HIVE-11190
Project: Hive
Issue Type: Bug
Reporter: Dapeng Sun
Assignee: Dapeng Sun
Attachments: HIVE-11190.001.patch, HIVE-11190.002.patch
ConfVars.METASTORE_FILTER_HOOK in authorization V2 is will be override
without prompting info or warning.
it will cause user failed to customize the METASTORE_FILTER_HOOK. We should
log information such as this value is ignored when override happens.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
