[jira] [Commented] (HIVE-11293) HiveConnection.setAutoCommit(true) throws exception
[
https://issues.apache.org/jira/browse/HIVE-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027910#comment-16027910
]
Josh Rosen commented on HIVE-11293:
---
+1 on backporting this to branch-1 as well; it's impacting many users there, as
you can see from https://youtrack.jetbrains.com/issue/DBE-3115
> HiveConnection.setAutoCommit(true) throws exception
> ---
>
> Key: HIVE-11293
> URL: https://issues.apache.org/jira/browse/HIVE-11293
> Project: Hive
> Issue Type: Bug
> Components: JDBC
>Affects Versions: 2.0.0
>Reporter: Andriy Shumylo
>Assignee: Michał Węgrzyn
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HIVE-11293.2.patch, HIVE-11293.patch
>
>
> Effectively autoCommit is always true for HiveConnection, however
> setAutoCommit(true) throws exception, causing problems in existing JDBC code.
> Should be
> {code}
> @Override
> public void setAutoCommit(boolean autoCommit) throws SQLException {
> if (!autoCommit) {
> throw new SQLException("disabling autocommit is not supported");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-11293) HiveConnection.setAutoCommit(true) throws exception
[
https://issues.apache.org/jira/browse/HIVE-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986901#comment-14986901
]
Michał Węgrzyn commented on HIVE-11293:
---
Great. Thanks Alan.
> HiveConnection.setAutoCommit(true) throws exception
> ---
>
> Key: HIVE-11293
> URL: https://issues.apache.org/jira/browse/HIVE-11293
> Project: Hive
> Issue Type: Bug
> Components: JDBC
>Affects Versions: 2.0.0
>Reporter: Andriy Shumylo
>Assignee: Michał Węgrzyn
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HIVE-11293.2.patch, HIVE-11293.patch
>
>
> Effectively autoCommit is always true for HiveConnection, however
> setAutoCommit(true) throws exception, causing problems in existing JDBC code.
> Should be
> {code}
> @Override
> public void setAutoCommit(boolean autoCommit) throws SQLException {
> if (!autoCommit) {
> throw new SQLException("disabling autocommit is not supported");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11293) HiveConnection.setAutoCommit(true) throws exception
[
https://issues.apache.org/jira/browse/HIVE-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986148#comment-14986148
]
Thejas M Nair commented on HIVE-11293:
--
+1
> HiveConnection.setAutoCommit(true) throws exception
> ---
>
> Key: HIVE-11293
> URL: https://issues.apache.org/jira/browse/HIVE-11293
> Project: Hive
> Issue Type: Bug
> Components: JDBC
>Affects Versions: 2.0.0
>Reporter: Andriy Shumylo
>Assignee: Michał Węgrzyn
>Priority: Minor
> Attachments: HIVE-11293.2.patch, HIVE-11293.patch
>
>
> Effectively autoCommit is always true for HiveConnection, however
> setAutoCommit(true) throws exception, causing problems in existing JDBC code.
> Should be
> {code}
> @Override
> public void setAutoCommit(boolean autoCommit) throws SQLException {
> if (!autoCommit) {
> throw new SQLException("disabling autocommit is not supported");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11293) HiveConnection.setAutoCommit(true) throws exception
[
https://issues.apache.org/jira/browse/HIVE-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983546#comment-14983546
]
Hive QA commented on HIVE-11293:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12769664/HIVE-11293.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 9746 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_queries
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testMetastoreProxyUser
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testSaslWithHiveMetaStore
org.apache.hive.jdbc.TestSSL.testSSLFetchHttp
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5868/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5868/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5868/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12769664 - PreCommit-HIVE-TRUNK-Build
> HiveConnection.setAutoCommit(true) throws exception
> ---
>
> Key: HIVE-11293
> URL: https://issues.apache.org/jira/browse/HIVE-11293
> Project: Hive
> Issue Type: Bug
> Components: JDBC
>Affects Versions: 2.0.0
>Reporter: Andriy Shumylo
>Assignee: Michał Węgrzyn
>Priority: Minor
> Attachments: HIVE-11293.2.patch, HIVE-11293.patch
>
>
> Effectively autoCommit is always true for HiveConnection, however
> setAutoCommit(true) throws exception, causing problems in existing JDBC code.
> Should be
> {code}
> @Override
> public void setAutoCommit(boolean autoCommit) throws SQLException {
> if (!autoCommit) {
> throw new SQLException("disabling autocommit is not supported");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11293) HiveConnection.setAutoCommit(true) throws exception
[
https://issues.apache.org/jira/browse/HIVE-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983709#comment-14983709
]
Alan Gates commented on HIVE-11293:
---
TestHBaseCliDriver fails for me on master also. All of the others pass locally
for me in master and with my patch. So I don't think these are related.
> HiveConnection.setAutoCommit(true) throws exception
> ---
>
> Key: HIVE-11293
> URL: https://issues.apache.org/jira/browse/HIVE-11293
> Project: Hive
> Issue Type: Bug
> Components: JDBC
>Affects Versions: 2.0.0
>Reporter: Andriy Shumylo
>Assignee: Michał Węgrzyn
>Priority: Minor
> Attachments: HIVE-11293.2.patch, HIVE-11293.patch
>
>
> Effectively autoCommit is always true for HiveConnection, however
> setAutoCommit(true) throws exception, causing problems in existing JDBC code.
> Should be
> {code}
> @Override
> public void setAutoCommit(boolean autoCommit) throws SQLException {
> if (!autoCommit) {
> throw new SQLException("disabling autocommit is not supported");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11293) HiveConnection.setAutoCommit(true) throws exception
[
https://issues.apache.org/jira/browse/HIVE-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981485#comment-14981485
]
Alan Gates commented on HIVE-11293:
---
The spec doesn't seem to specify what to do if someone calls
setAutoCommit(false) and the engine doesn't support multi-statements
transactions. But it seems to me we should at least issue a warning in the
logs and in the SQLWarnings.
> HiveConnection.setAutoCommit(true) throws exception
> ---
>
> Key: HIVE-11293
> URL: https://issues.apache.org/jira/browse/HIVE-11293
> Project: Hive
> Issue Type: Bug
> Components: JDBC
>Reporter: Andriy Shumylo
>Assignee: Michał Węgrzyn
>Priority: Minor
> Attachments: HIVE-11293.patch
>
>
> Effectively autoCommit is always true for HiveConnection, however
> setAutoCommit(true) throws exception, causing problems in existing JDBC code.
> Should be
> {code}
> @Override
> public void setAutoCommit(boolean autoCommit) throws SQLException {
> if (!autoCommit) {
> throw new SQLException("disabling autocommit is not supported");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11293) HiveConnection.setAutoCommit(true) throws exception
[
https://issues.apache.org/jira/browse/HIVE-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679148#comment-14679148
]
Hive QA commented on HIVE-11293:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12749383/HIVE-11293.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 9344 tests executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.TestSSL.testSSLFetchHttp
org.apache.hive.spark.client.TestSparkClient.testSyncRpc
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4886/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4886/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4886/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12749383 - PreCommit-HIVE-TRUNK-Build
HiveConnection.setAutoCommit(true) throws exception
---
Key: HIVE-11293
URL: https://issues.apache.org/jira/browse/HIVE-11293
Project: Hive
Issue Type: Bug
Components: JDBC
Reporter: Andriy Shumylo
Assignee: Michał Węgrzyn
Priority: Minor
Attachments: HIVE-11293.patch
Effectively autoCommit is always true for HiveConnection, however
setAutoCommit(true) throws exception, causing problems in existing JDBC code.
Should be
{code}
@Override
public void setAutoCommit(boolean autoCommit) throws SQLException {
if (!autoCommit) {
throw new SQLException(disabling autocommit is not supported);
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11293) HiveConnection.setAutoCommit(true) throws exception
[
https://issues.apache.org/jira/browse/HIVE-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679179#comment-14679179
]
Michał Węgrzyn commented on HIVE-11293:
---
The cause of the tests failure is unrelated to the changes introduced in the
patch.
HiveConnection.setAutoCommit(true) throws exception
---
Key: HIVE-11293
URL: https://issues.apache.org/jira/browse/HIVE-11293
Project: Hive
Issue Type: Bug
Components: JDBC
Reporter: Andriy Shumylo
Assignee: Michał Węgrzyn
Priority: Minor
Attachments: HIVE-11293.patch
Effectively autoCommit is always true for HiveConnection, however
setAutoCommit(true) throws exception, causing problems in existing JDBC code.
Should be
{code}
@Override
public void setAutoCommit(boolean autoCommit) throws SQLException {
if (!autoCommit) {
throw new SQLException(disabling autocommit is not supported);
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
