[jira] [Commented] (HIVE-11671) Optimize RuleRegExp in DPP codepath
[ https://issues.apache.org/jira/browse/HIVE-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728185#comment-14728185 ] Hari Sankar Sivarama Subramaniyan commented on HIVE-11671: -- Tested the failures locally and they pass, the failures are not related to this patch Thanks Hari > Optimize RuleRegExp in DPP codepath > --- > > Key: HIVE-11671 > URL: https://issues.apache.org/jira/browse/HIVE-11671 > Project: Hive > Issue Type: Sub-task >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan > Attachments: HIVE-11671.1.patch, HIVE-11671.2.patch, > cpu_with_patch.png, cpu_without_patch.png, mem_with_patch.png, > mem_without_patch.png > > > When running a large query with DPP in its codepath, RuleRegExp came up as > hotspot. Creating this JIRA to optimize RuleRegExp.java. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11671) Optimize RuleRegExp in DPP codepath
[ https://issues.apache.org/jira/browse/HIVE-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727724#comment-14727724 ] Hari Sankar Sivarama Subramaniyan commented on HIVE-11671: -- Hi [~rajesh.balamohan] Can you please try the failed tests locally and see if they are related to this patch. Thanks Hari > Optimize RuleRegExp in DPP codepath > --- > > Key: HIVE-11671 > URL: https://issues.apache.org/jira/browse/HIVE-11671 > Project: Hive > Issue Type: Sub-task >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan > Attachments: HIVE-11671.1.patch, HIVE-11671.2.patch, > cpu_with_patch.png, cpu_without_patch.png, mem_with_patch.png, > mem_without_patch.png > > > When running a large query with DPP in its codepath, RuleRegExp came up as > hotspot. Creating this JIRA to optimize RuleRegExp.java. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11671) Optimize RuleRegExp in DPP codepath
[
https://issues.apache.org/jira/browse/HIVE-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727182#comment-14727182
]
Hive QA commented on HIVE-11671:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12753571/HIVE-11671.2.patch
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 9391 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_mergejoin
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vector_leftsemi_mapjoin
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vectorized_dynamic_partition_pruning
org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testRevokeTimedOutWorkers
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5144/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5144/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5144/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12753571 - PreCommit-HIVE-TRUNK-Build
> Optimize RuleRegExp in DPP codepath
> ---
>
> Key: HIVE-11671
> URL: https://issues.apache.org/jira/browse/HIVE-11671
> Project: Hive
> Issue Type: Sub-task
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
> Attachments: HIVE-11671.1.patch, HIVE-11671.2.patch,
> cpu_with_patch.png, cpu_without_patch.png, mem_with_patch.png,
> mem_without_patch.png
>
>
> When running a large query with DPP in its codepath, RuleRegExp came up as
> hotspot. Creating this JIRA to optimize RuleRegExp.java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11671) Optimize RuleRegExp in DPP codepath
[ https://issues.apache.org/jira/browse/HIVE-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723188#comment-14723188 ] Hari Sankar Sivarama Subramaniyan commented on HIVE-11671: -- [~rajesh.balamohan] Can you attach a new patch after rebasing with the master, even if it is same as the original patch, cancel patch and resubmit the patch. Thanks Hari > Optimize RuleRegExp in DPP codepath > --- > > Key: HIVE-11671 > URL: https://issues.apache.org/jira/browse/HIVE-11671 > Project: Hive > Issue Type: Sub-task >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan > Attachments: HIVE-11671.1.patch, cpu_with_patch.png, > cpu_without_patch.png, mem_with_patch.png, mem_without_patch.png > > > When running a large query with DPP in its codepath, RuleRegExp came up as > hotspot. Creating this JIRA to optimize RuleRegExp.java. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11671) Optimize RuleRegExp in DPP codepath
[ https://issues.apache.org/jira/browse/HIVE-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721928#comment-14721928 ] Rajesh Balamohan commented on HIVE-11671: - Thanks [~hsubramaniyan]. Not sure why the builds are not yet triggered. Should I cancel and hit resubmit to re-trigger the build? > Optimize RuleRegExp in DPP codepath > --- > > Key: HIVE-11671 > URL: https://issues.apache.org/jira/browse/HIVE-11671 > Project: Hive > Issue Type: Sub-task >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan > Attachments: HIVE-11671.1.patch, cpu_with_patch.png, > cpu_without_patch.png, mem_with_patch.png, mem_without_patch.png > > > When running a large query with DPP in its codepath, RuleRegExp came up as > hotspot. Creating this JIRA to optimize RuleRegExp.java. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11671) Optimize RuleRegExp in DPP codepath
[ https://issues.apache.org/jira/browse/HIVE-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717829#comment-14717829 ] Hari Sankar Sivarama Subramaniyan commented on HIVE-11671: -- +1 pending unit test run. > Optimize RuleRegExp in DPP codepath > --- > > Key: HIVE-11671 > URL: https://issues.apache.org/jira/browse/HIVE-11671 > Project: Hive > Issue Type: Sub-task >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan > Attachments: HIVE-11671.1.patch, cpu_with_patch.png, > cpu_without_patch.png, mem_with_patch.png, mem_without_patch.png > > > When running a large query with DPP in its codepath, RuleRegExp came up as > hotspot. Creating this JIRA to optimize RuleRegExp.java. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
