[jira] [Commented] (HIVE-11746) Connect command should not to be allowed from user[beeline-cli branch]
[
https://issues.apache.org/jira/browse/HIVE-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736657#comment-14736657
]
Hive QA commented on HIVE-11746:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12754840/HIVE-11746.3-beeline-cli.patch
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 9446 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_auto_sortmerge_join_2
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_auto_sortmerge_join_8
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-BEELINE-Build/35/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-BEELINE-Build/35/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-BEELINE-Build-35/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12754840 - PreCommit-HIVE-BEELINE-Build
> Connect command should not to be allowed from user[beeline-cli branch]
> --
>
> Key: HIVE-11746
> URL: https://issues.apache.org/jira/browse/HIVE-11746
> Project: Hive
> Issue Type: Sub-task
> Components: Beeline
>Reporter: Ferdinand Xu
>Assignee: Ferdinand Xu
> Fix For: beeline-cli-branch
>
> Attachments: HIVE-11746.1-beeline-cli.patch,
> HIVE-11746.2-beeline-cli.patch, HIVE-11746.3-beeline-cli.patch
>
>
> For new cli, user should not be allowed to connect a server or database.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11746) Connect command should not to be allowed from user[beeline-cli branch]
[ https://issues.apache.org/jira/browse/HIVE-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734308#comment-14734308 ] Ferdinand Xu commented on HIVE-11746: - Hi [~xuefuz], it's my fault. The name "isFromConsole" may be confusing. The name "isInternal" may be better. We need to use "!connect" when we try to connect the embedded hive server2. This is the only place we need connect. So I will rename the variable and attach the patch again. Thank you! > Connect command should not to be allowed from user[beeline-cli branch] > -- > > Key: HIVE-11746 > URL: https://issues.apache.org/jira/browse/HIVE-11746 > Project: Hive > Issue Type: Sub-task > Components: Beeline >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Attachments: HIVE-11746.1-beeline-cli.patch > > > For new cli, user should not be allowed to connect a server or database. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11746) Connect command should not to be allowed from user[beeline-cli branch]
[
https://issues.apache.org/jira/browse/HIVE-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734558#comment-14734558
]
Hive QA commented on HIVE-11746:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12754585/HIVE-11746.2-beeline-cli.patch
{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 9243 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cbo_rp_join0
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_auto_sortmerge_join_2
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_auto_sortmerge_join_8
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchEmptyCommit
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-BEELINE-Build/34/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-BEELINE-Build/34/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-BEELINE-Build-34/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12754585 - PreCommit-HIVE-BEELINE-Build
> Connect command should not to be allowed from user[beeline-cli branch]
> --
>
> Key: HIVE-11746
> URL: https://issues.apache.org/jira/browse/HIVE-11746
> Project: Hive
> Issue Type: Sub-task
> Components: Beeline
>Reporter: Ferdinand Xu
>Assignee: Ferdinand Xu
> Fix For: beeline-cli-branch
>
> Attachments: HIVE-11746.1-beeline-cli.patch,
> HIVE-11746.2-beeline-cli.patch
>
>
> For new cli, user should not be allowed to connect a server or database.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11746) Connect command should not to be allowed from user[beeline-cli branch]
[ https://issues.apache.org/jira/browse/HIVE-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736103#comment-14736103 ] Xuefu Zhang commented on HIVE-11746: [~Ferd], thanks for the explanation. The new changes seem working, but it still seems a little confusing. Dispatch() method now takes a new param, but this is only needed by embeddedConnect() and we have to burden other callers to pass a value to this param any way. Looking at embeddedConnect(), I'm wondering if we just call execCommandWithPrefix() directly. This is because when we connect in the embedded mode, the command is a constant, and we don't need any of the processing in dispatch(). This way, the dispatch() method becomes cleaner. What do you think? > Connect command should not to be allowed from user[beeline-cli branch] > -- > > Key: HIVE-11746 > URL: https://issues.apache.org/jira/browse/HIVE-11746 > Project: Hive > Issue Type: Sub-task > Components: Beeline >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11746.1-beeline-cli.patch, > HIVE-11746.2-beeline-cli.patch > > > For new cli, user should not be allowed to connect a server or database. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11746) Connect command should not to be allowed from user[beeline-cli branch]
[ https://issues.apache.org/jira/browse/HIVE-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734205#comment-14734205 ] Xuefu Zhang commented on HIVE-11746: Hi [~Ferd], thanks for working on this. I'm not sure if I understand the reason behind of introducing a variable isFromConsole. To me, it seems that !connect should be disabled for new Hive CLI regardless whether the command is from console or a script file. In addition, Thus, the variable should be really "isBeeline", which is already available. Any thoughts? > Connect command should not to be allowed from user[beeline-cli branch] > -- > > Key: HIVE-11746 > URL: https://issues.apache.org/jira/browse/HIVE-11746 > Project: Hive > Issue Type: Sub-task > Components: Beeline >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Attachments: HIVE-11746.1-beeline-cli.patch > > > For new cli, user should not be allowed to connect a server or database. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11746) Connect command should not to be allowed from user[beeline-cli branch]
[ https://issues.apache.org/jira/browse/HIVE-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734194#comment-14734194 ] Ferdinand Xu commented on HIVE-11746: - Hi [~xuefuz], can you help review this jira? Thank you! > Connect command should not to be allowed from user[beeline-cli branch] > -- > > Key: HIVE-11746 > URL: https://issues.apache.org/jira/browse/HIVE-11746 > Project: Hive > Issue Type: Sub-task > Components: Beeline >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Attachments: HIVE-11746.1-beeline-cli.patch > > > For new cli, user should not be allowed to connect a server or database. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
