[jira] [Commented] (HIVE-11892) UDTF run in local fetch task does not return rows forwarded during GenericUDTF.close()
[ https://issues.apache.org/jira/browse/HIVE-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957517#comment-14957517 ] Xuefu Zhang commented on HIVE-11892: Can we get "affected version" filled? Thanks. > UDTF run in local fetch task does not return rows forwarded during > GenericUDTF.close() > -- > > Key: HIVE-11892 > URL: https://issues.apache.org/jira/browse/HIVE-11892 > Project: Hive > Issue Type: Bug > Components: UDF >Reporter: Jason Dere >Assignee: Jason Dere > Attachments: HIVE-11892.1.patch, HIVE-11892.2.patch > > > Using the example UDTF GenericUDTFCount2, which is part of hive-contrib: > {noformat} > create temporary function udtfCount2 as > 'org.apache.hadoop.hive.contrib.udtf.example.GenericUDTFCount2'; > set hive.fetch.task.conversion=minimal; > -- Task created, correct output (2 rows) > select udtfCount2() from src; > set hive.fetch.task.conversion=more; > -- Runs in local task, incorrect output (0 rows) > select udtfCount2() from src; > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11892) UDTF run in local fetch task does not return rows forwarded during GenericUDTF.close()
[ https://issues.apache.org/jira/browse/HIVE-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957667#comment-14957667 ] Jason Dere commented on HIVE-11892: --- I'm guessing this was added in HIVE-5718, so 1.1.0? > UDTF run in local fetch task does not return rows forwarded during > GenericUDTF.close() > -- > > Key: HIVE-11892 > URL: https://issues.apache.org/jira/browse/HIVE-11892 > Project: Hive > Issue Type: Bug > Components: UDF >Reporter: Jason Dere >Assignee: Jason Dere > Attachments: HIVE-11892.1.patch, HIVE-11892.2.patch > > > Using the example UDTF GenericUDTFCount2, which is part of hive-contrib: > {noformat} > create temporary function udtfCount2 as > 'org.apache.hadoop.hive.contrib.udtf.example.GenericUDTFCount2'; > set hive.fetch.task.conversion=minimal; > -- Task created, correct output (2 rows) > select udtfCount2() from src; > set hive.fetch.task.conversion=more; > -- Runs in local task, incorrect output (0 rows) > select udtfCount2() from src; > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11892) UDTF run in local fetch task does not return rows forwarded during GenericUDTF.close()
[ https://issues.apache.org/jira/browse/HIVE-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955995#comment-14955995 ] Ashutosh Chauhan commented on HIVE-11892: - +1 > UDTF run in local fetch task does not return rows forwarded during > GenericUDTF.close() > -- > > Key: HIVE-11892 > URL: https://issues.apache.org/jira/browse/HIVE-11892 > Project: Hive > Issue Type: Bug > Components: UDF >Reporter: Jason Dere >Assignee: Jason Dere > Attachments: HIVE-11892.1.patch, HIVE-11892.2.patch > > > Using the example UDTF GenericUDTFCount2, which is part of hive-contrib: > {noformat} > create temporary function udtfCount2 as > 'org.apache.hadoop.hive.contrib.udtf.example.GenericUDTFCount2'; > set hive.fetch.task.conversion=minimal; > -- Task created, correct output (2 rows) > select udtfCount2() from src; > set hive.fetch.task.conversion=more; > -- Runs in local task, incorrect output (0 rows) > select udtfCount2() from src; > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11892) UDTF run in local fetch task does not return rows forwarded during GenericUDTF.close()
[ https://issues.apache.org/jira/browse/HIVE-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948939#comment-14948939 ] Hive QA commented on HIVE-11892: {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12765433/HIVE-11892.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 9656 tests executed *Failed tests:* {noformat} org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation org.apache.hive.jdbc.TestSSL.testSSLVersion {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5570/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5570/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5570/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12765433 - PreCommit-HIVE-TRUNK-Build > UDTF run in local fetch task does not return rows forwarded during > GenericUDTF.close() > -- > > Key: HIVE-11892 > URL: https://issues.apache.org/jira/browse/HIVE-11892 > Project: Hive > Issue Type: Bug > Components: UDF >Reporter: Jason Dere >Assignee: Jason Dere > Attachments: HIVE-11892.1.patch, HIVE-11892.2.patch > > > Using the example UDTF GenericUDTFCount2, which is part of hive-contrib: > {noformat} > create temporary function udtfCount2 as > 'org.apache.hadoop.hive.contrib.udtf.example.GenericUDTFCount2'; > set hive.fetch.task.conversion=minimal; > -- Task created, correct output (2 rows) > select udtfCount2() from src; > set hive.fetch.task.conversion=more; > -- Runs in local task, incorrect output (0 rows) > select udtfCount2() from src; > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11892) UDTF run in local fetch task does not return rows forwarded during GenericUDTF.close()
[ https://issues.apache.org/jira/browse/HIVE-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947291#comment-14947291 ] Jason Dere commented on HIVE-11892: --- Test failures are due to explain plan differences now that UDTFs will not use fetch task conversion. Will regenerate the golden files for these tests. > UDTF run in local fetch task does not return rows forwarded during > GenericUDTF.close() > -- > > Key: HIVE-11892 > URL: https://issues.apache.org/jira/browse/HIVE-11892 > Project: Hive > Issue Type: Bug > Components: UDF >Reporter: Jason Dere >Assignee: Jason Dere > Attachments: HIVE-11892.1.patch > > > Using the example UDTF GenericUDTFCount2, which is part of hive-contrib: > {noformat} > create temporary function udtfCount2 as > 'org.apache.hadoop.hive.contrib.udtf.example.GenericUDTFCount2'; > set hive.fetch.task.conversion=minimal; > -- Task created, correct output (2 rows) > select udtfCount2() from src; > set hive.fetch.task.conversion=more; > -- Runs in local task, incorrect output (0 rows) > select udtfCount2() from src; > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11892) UDTF run in local fetch task does not return rows forwarded during GenericUDTF.close()
[ https://issues.apache.org/jira/browse/HIVE-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947235#comment-14947235 ] Hive QA commented on HIVE-11892: {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12765242/HIVE-11892.1.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 9653 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_lateral_view_noalias org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_nonmr_fetch org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_select_dummy_source org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_explode org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_inline org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udtf_explode org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udtf_output_on_close org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_explainuser_1 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_explainuser_3 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_select_dummy_source org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation org.apache.hive.jdbc.TestSSL.testSSLVersion {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5559/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5559/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5559/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 12 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12765242 - PreCommit-HIVE-TRUNK-Build > UDTF run in local fetch task does not return rows forwarded during > GenericUDTF.close() > -- > > Key: HIVE-11892 > URL: https://issues.apache.org/jira/browse/HIVE-11892 > Project: Hive > Issue Type: Bug > Components: UDF >Reporter: Jason Dere >Assignee: Jason Dere > Attachments: HIVE-11892.1.patch > > > Using the example UDTF GenericUDTFCount2, which is part of hive-contrib: > {noformat} > create temporary function udtfCount2 as > 'org.apache.hadoop.hive.contrib.udtf.example.GenericUDTFCount2'; > set hive.fetch.task.conversion=minimal; > -- Task created, correct output (2 rows) > select udtfCount2() from src; > set hive.fetch.task.conversion=more; > -- Runs in local task, incorrect output (0 rows) > select udtfCount2() from src; > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11892) UDTF run in local fetch task does not return rows forwarded during GenericUDTF.close()
[ https://issues.apache.org/jira/browse/HIVE-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876712#comment-14876712 ] Jason Dere commented on HIVE-11892: --- As far as I can tell, it looks like GenericUDTF.close() isn't called until after CliDriver.processLocalCmd() has already finished going through the query results, so any rows added to the result at this point are never iterated over and printed. {noformat} ListSinkOperator.process(Object, int) line: 94 UDTFOperator(Operator).forward(Object, ObjectInspector) line: 813 UDTFOperator.forwardUDTFOutput(Object) line: 126 UDTFCollector.collect(Object) line: 45 GenericUDTFCount2(GenericUDTF).forward(Object) line: 107 GenericUDTFCount2.close() line: 48 UDTFOperator.closeOp(boolean) line: 145 UDTFOperator(Operator).close(boolean) line: 617 SelectOperator(Operator).close(boolean) line: 631 TableScanOperator(Operator).close(boolean) line: 631 FetchOperator.clearFetchContext() line: 523 FetchTask.clearFetch() line: 181 Driver.close() line: 1842 CliDriver.processLocalCmd(String, CommandProcessor, CliSessionState) line: 250 CliDriver.processCmd(String) line: 165 CliDriver.processLine(String, boolean) line: 376 CliDriver.executeDriver(CliSessionState, HiveConf, OptionsProcessor) line: 736 CliDriver.run(String[]) line: 681 CliDriver.main(String[]) line: 621 {noformat} > UDTF run in local fetch task does not return rows forwarded during > GenericUDTF.close() > -- > > Key: HIVE-11892 > URL: https://issues.apache.org/jira/browse/HIVE-11892 > Project: Hive > Issue Type: Bug > Components: UDF >Reporter: Jason Dere > > Using the example UDTF GenericUDTFCount2, which is part of hive-contrib: > {noformat} > create temporary function udtfCount2 as > 'org.apache.hadoop.hive.contrib.udtf.example.GenericUDTFCount2'; > set hive.fetch.task.conversion=minimal; > -- Task created, correct output (2 rows) > select udtfCount2() from src; > set hive.fetch.task.conversion=more; > -- Runs in local task, incorrect output (0 rows) > select udtfCount2() from src; > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)