[jira] [Commented] (HIVE-12209) Vectorized simple CASE expressions with nulls

2015-10-31 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984138#comment-14984138
 ] 

Hive QA commented on HIVE-12209:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12769930/HIVE-12209.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 9743 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_queries
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver
org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler.org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5881/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5881/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5881/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12769930 - PreCommit-HIVE-TRUNK-Build

> Vectorized simple CASE expressions with nulls
> -
>
> Key: HIVE-12209
> URL: https://issues.apache.org/jira/browse/HIVE-12209
> Project: Hive
>  Issue Type: Improvement
>  Components: Vectorization
>Affects Versions: 1.3.0, 1.2.1, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
> Attachments: HIVE-12209.1.patch, HIVE-12209.2.patch
>
>
> {{CASE when (d_day_name='Sunday') then ss_sales_price else null end}}
> {code}
> 2015-10-18T03:28:37,911 INFO  [main]: physical.Vectorizer 
> (Vectorizer.java:validateExprNodeDesc(1360)) - Failed to vectorize
> org.apache.hadoop.hive.ql.metadata.HiveException: Unable to vectorize custom 
> UDF. Custom udf containing constant null argument cannot be currently 
> vectorized.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-12209) Vectorized simple CASE expressions with nulls

2015-10-30 Thread Gopal V (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982302#comment-14982302
 ] 

Gopal V commented on HIVE-12209:


[~mmccline]: this sort of naturally came about from the removal of 
ExprNodeNullDesc - the nulls are typed & can be vectorized due to the presence 
of types.

> Vectorized simple CASE expressions with nulls
> -
>
> Key: HIVE-12209
> URL: https://issues.apache.org/jira/browse/HIVE-12209
> Project: Hive
>  Issue Type: Improvement
>  Components: Vectorization
>Affects Versions: 1.3.0, 1.2.1, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
>
> {{CASE when (d_day_name='Sunday') then ss_sales_price else null end}}
> {code}
> 2015-10-18T03:28:37,911 INFO  [main]: physical.Vectorizer 
> (Vectorizer.java:validateExprNodeDesc(1360)) - Failed to vectorize
> org.apache.hadoop.hive.ql.metadata.HiveException: Unable to vectorize custom 
> UDF. Custom udf containing constant null argument cannot be currently 
> vectorized.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-12209) Vectorized simple CASE expressions with nulls

2015-10-30 Thread Sergey Shelukhin (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983149#comment-14983149
 ] 

Sergey Shelukhin commented on HIVE-12209:
-

LGTM. Are test failures related?

> Vectorized simple CASE expressions with nulls
> -
>
> Key: HIVE-12209
> URL: https://issues.apache.org/jira/browse/HIVE-12209
> Project: Hive
>  Issue Type: Improvement
>  Components: Vectorization
>Affects Versions: 1.3.0, 1.2.1, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
> Attachments: HIVE-12209.1.patch
>
>
> {{CASE when (d_day_name='Sunday') then ss_sales_price else null end}}
> {code}
> 2015-10-18T03:28:37,911 INFO  [main]: physical.Vectorizer 
> (Vectorizer.java:validateExprNodeDesc(1360)) - Failed to vectorize
> org.apache.hadoop.hive.ql.metadata.HiveException: Unable to vectorize custom 
> UDF. Custom udf containing constant null argument cannot be currently 
> vectorized.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-12209) Vectorized simple CASE expressions with nulls

2015-10-30 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982933#comment-14982933
 ] 

Hive QA commented on HIVE-12209:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12769740/HIVE-12209.1.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 9728 tests executed
*Failed tests:*
{noformat}
TestCliDriver-auto_join18_multi_distinct.q-interval_udf.q-udf_repeat.q-and-12-more
 - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby3_map_multi_distinct
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_queries
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vectorized_case
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_vectorized_case
org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5864/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5864/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5864/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12769740 - PreCommit-HIVE-TRUNK-Build

> Vectorized simple CASE expressions with nulls
> -
>
> Key: HIVE-12209
> URL: https://issues.apache.org/jira/browse/HIVE-12209
> Project: Hive
>  Issue Type: Improvement
>  Components: Vectorization
>Affects Versions: 1.3.0, 1.2.1, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
> Attachments: HIVE-12209.1.patch
>
>
> {{CASE when (d_day_name='Sunday') then ss_sales_price else null end}}
> {code}
> 2015-10-18T03:28:37,911 INFO  [main]: physical.Vectorizer 
> (Vectorizer.java:validateExprNodeDesc(1360)) - Failed to vectorize
> org.apache.hadoop.hive.ql.metadata.HiveException: Unable to vectorize custom 
> UDF. Custom udf containing constant null argument cannot be currently 
> vectorized.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-12209) Vectorized simple CASE expressions with nulls

2015-10-30 Thread Gopal V (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983418#comment-14983418
 ] 

Gopal V commented on HIVE-12209:


Doesn't look like it, one failure looks like a float precision error.

I''ll fix the vectorized_case Spark/Tez out files.

> Vectorized simple CASE expressions with nulls
> -
>
> Key: HIVE-12209
> URL: https://issues.apache.org/jira/browse/HIVE-12209
> Project: Hive
>  Issue Type: Improvement
>  Components: Vectorization
>Affects Versions: 1.3.0, 1.2.1, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
> Attachments: HIVE-12209.1.patch
>
>
> {{CASE when (d_day_name='Sunday') then ss_sales_price else null end}}
> {code}
> 2015-10-18T03:28:37,911 INFO  [main]: physical.Vectorizer 
> (Vectorizer.java:validateExprNodeDesc(1360)) - Failed to vectorize
> org.apache.hadoop.hive.ql.metadata.HiveException: Unable to vectorize custom 
> UDF. Custom udf containing constant null argument cannot be currently 
> vectorized.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)