[jira] [Commented] (HIVE-12281) Vectorized MapJoin - use Operator::isLogDebugEnabled

2015-10-30 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982752#comment-14982752
 ] 

Hive QA commented on HIVE-12281:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12769734/HIVE-12281.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 9720 tests 
executed
*Failed tests:*
{noformat}
TestMiniTezCliDriver-vectorization_10.q-vector_partitioned_date_time.q-vector_non_string_partition.q-and-12-more
 - did not produce a TEST-*.xml file
TestSparkClient - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_queries
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver
org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testRevokeTimedOutWorkers
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testMetastoreProxyUser
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testSaslWithHiveMetaStore
org.apache.hive.jdbc.TestSSL.testSSLFetchHttp
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5863/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5863/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5863/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12769734 - PreCommit-HIVE-TRUNK-Build

> Vectorized MapJoin - use Operator::isLogDebugEnabled
> 
>
> Key: HIVE-12281
> URL: https://issues.apache.org/jira/browse/HIVE-12281
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 1.3.0, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: HIVE-12281.1.patch, HIVE-12281.2.patch, 
> vector-map-logging.png
>
>
> !vector-map-logging.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12281) Vectorized MapJoin - use Operator::isLogDebugEnabled

2015-10-28 Thread Matt McCline (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977912#comment-14977912
 ] 

Matt McCline commented on HIVE-12281:
-

+1 LGTM

> Vectorized MapJoin - use Operator::isLogDebugEnabled
> 
>
> Key: HIVE-12281
> URL: https://issues.apache.org/jira/browse/HIVE-12281
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 1.3.0, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: HIVE-12281.1.patch, vector-map-logging.png
>
>
> !vector-map-logging.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12281) Vectorized MapJoin - use Operator::isLogDebugEnabled

2015-10-28 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978915#comment-14978915
 ] 

Ashutosh Chauhan commented on HIVE-12281:
-

isLogEnabled() is an anti-pattern. Its actually slower if logging is enabled. 
Now that we have switched to slf4j, we can make use of parameterized messages. 
See: http://www.slf4j.org/faq.html#logging_performance

> Vectorized MapJoin - use Operator::isLogDebugEnabled
> 
>
> Key: HIVE-12281
> URL: https://issues.apache.org/jira/browse/HIVE-12281
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 1.3.0, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: HIVE-12281.1.patch, vector-map-logging.png
>
>
> !vector-map-logging.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12281) Vectorized MapJoin - use Operator::isLogDebugEnabled

2015-10-28 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978927#comment-14978927
 ] 

Sergey Shelukhin commented on HIVE-12281:
-

The logging call itself is expensive, at least before log4j2. With log4j2 it's 
supposed to be cheaper but we haven't really tested

> Vectorized MapJoin - use Operator::isLogDebugEnabled
> 
>
> Key: HIVE-12281
> URL: https://issues.apache.org/jira/browse/HIVE-12281
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 1.3.0, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: HIVE-12281.1.patch, vector-map-logging.png
>
>
> !vector-map-logging.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12281) Vectorized MapJoin - use Operator::isLogDebugEnabled

2015-10-28 Thread Gopal V (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978907#comment-14978907
 ] 

Gopal V commented on HIVE-12281:


There's an HTTP UI interface in LLAP which lets you turn on logging for a 
specific Operator class in LLAP.

It's exactly as fast now, so leave that in place just in case we ever have to 
debug it without restarting?

> Vectorized MapJoin - use Operator::isLogDebugEnabled
> 
>
> Key: HIVE-12281
> URL: https://issues.apache.org/jira/browse/HIVE-12281
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 1.3.0, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: HIVE-12281.1.patch, vector-map-logging.png
>
>
> !vector-map-logging.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12281) Vectorized MapJoin - use Operator::isLogDebugEnabled

2015-10-28 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978895#comment-14978895
 ] 

Sergey Shelukhin commented on HIVE-12281:
-

Any reason to not have isLogDebugEnabled static, since LOG is static? +1, can 
be fixed on commit if necessary

> Vectorized MapJoin - use Operator::isLogDebugEnabled
> 
>
> Key: HIVE-12281
> URL: https://issues.apache.org/jira/browse/HIVE-12281
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 1.3.0, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: HIVE-12281.1.patch, vector-map-logging.png
>
>
> !vector-map-logging.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-12281) Vectorized MapJoin - use Operator::isLogDebugEnabled

2015-10-28 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979767#comment-14979767
 ] 

Hive QA commented on HIVE-12281:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12769222/HIVE-12281.1.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5841/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5841/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5841/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]]
+ export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera
+ JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera
+ export 
PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+ 
PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost 
-Dhttp.proxyPort=3128'
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost 
-Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-TRUNK-Build-5841/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 99a043a HIVE-12245: Support column comments for an HBase backed 
table (Chaoyu Tang, reviewed by Jimmy Xiang)
+ git clean -f -d
+ git checkout master
Already on 'master'
+ git reset --hard origin/master
HEAD is now at 99a043a HIVE-12245: Support column comments for an HBase backed 
table (Chaoyu Tang, reviewed by Jimmy Xiang)
+ git merge --ff-only origin/master
Already up-to-date.
+ git gc
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh 
/data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12769222 - PreCommit-HIVE-TRUNK-Build

> Vectorized MapJoin - use Operator::isLogDebugEnabled
> 
>
> Key: HIVE-12281
> URL: https://issues.apache.org/jira/browse/HIVE-12281
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 1.3.0, 2.0.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: HIVE-12281.1.patch, vector-map-logging.png
>
>
> !vector-map-logging.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)