[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991963#comment-14991963 ] Aihua Xu commented on HIVE-12304: - Thanks Jason for reviewing the code. It has been pushed to master branch. > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Fix For: 2.0.0 > > Attachments: HIVE-12304.2.patch, HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990745#comment-14990745 ] Jason Dere commented on HIVE-12304: --- +1 So this removes the registered functions for the database, on the client that drops the database. This fixes the behavior for the client that runs the drop database command, including HS2 if the DB is dropped from HS2. But another HiveCLI client that has already loaded the functions for this DB will still have the permanent functions in its FunctionRegistry if the DB is dropped from a different HiveCLI client. But, this is probably the best we can do. > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12304.2.patch, HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990288#comment-14990288 ] Aihua Xu commented on HIVE-12304: - Seems the test cases are not related. The first two have the age of 1. But they do pass locally. > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12304.2.patch, HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[
https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989545#comment-14989545
]
Hive QA commented on HIVE-12304:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12770473/HIVE-12304.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 9754 tests executed
*Failed tests:*
{noformat}
TestMiniTezCliDriver-auto_sortmerge_join_13.q-tez_self_join.q-orc_vectorization_ppd.q-and-12-more
- did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_tez_union_with_udf
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_transform_acid
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_queries
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_tez_union_with_udf
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver
org.apache.hive.jdbc.TestSSL.testSSLVersion
org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithTez.testFetchResultsOfLogWithPerformanceMode
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5915/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5915/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5915/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12770473 - PreCommit-HIVE-TRUNK-Build
> "drop database cascade" needs to unregister functions
> -
>
> Key: HIVE-12304
> URL: https://issues.apache.org/jira/browse/HIVE-12304
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 2.0.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-12304.2.patch, HIVE-12304.patch
>
>
> Currently "drop database cascade" command doesn't unregister the functions
> under the database. If the functions are not unregistered, in some cases like
> "describe db1.func1" will still show the info for the function; or if the
> same database is recreated, "drop if exists db1.func1" will throw an
> exception since the function is considered existing from the registry while
> it doesn't exist in metastore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988541#comment-14988541 ] Aihua Xu commented on HIVE-12304: - I'm sorry. I haven't checked that yet. Let me take a look. > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12304.2.patch, HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988538#comment-14988538 ] Jason Dere commented on HIVE-12304: --- [~aihuaxu] do you know what broke the tests here? > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12304.2.patch, HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988610#comment-14988610 ] Aihua Xu commented on HIVE-12304: - hmm. Not sure what's happening there. Somehow it's said 2850 tests are added with the build. Local test of some tests passed. Reattached the same patch. > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12304.2.patch, HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985961#comment-14985961 ] Aihua Xu commented on HIVE-12304: - Attached the new patch to address the comments. > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12304.2.patch, HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985523#comment-14985523 ] Aihua Xu commented on HIVE-12304: - Those test failures don't look related. [~jdere] Can you review the code? > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[
https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983300#comment-14983300
]
Hive QA commented on HIVE-12304:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12769816/HIVE-12304.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 9745 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_queries
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testMetastoreProxyUser
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testSaslWithHiveMetaStore
org.apache.hive.jdbc.TestSSL.testSSLFetchHttp
org.apache.hive.jdbc.TestSSL.testSSLVersion
org.apache.hive.spark.client.TestSparkClient.testSyncRpc
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5867/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5867/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5867/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12769816 - PreCommit-HIVE-TRUNK-Build
> "drop database cascade" needs to unregister functions
> -
>
> Key: HIVE-12304
> URL: https://issues.apache.org/jira/browse/HIVE-12304
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
>Affects Versions: 2.0.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-12304.patch
>
>
> Currently "drop database cascade" command doesn't unregister the functions
> under the database. If the functions are not unregistered, in some cases like
> "describe db1.func1" will still show the info for the function; or if the
> same database is recreated, "drop if exists db1.func1" will throw an
> exception since the function is considered existing from the registry while
> it doesn't exist in metastore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983114#comment-14983114 ] Thejas M Nair commented on HIVE-12304: -- cc [~jdere] > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12304) "drop database cascade" needs to unregister functions
[ https://issues.apache.org/jira/browse/HIVE-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982945#comment-14982945 ] Aihua Xu commented on HIVE-12304: - Attach the patch to unregister functions and add a new unit test. > "drop database cascade" needs to unregister functions > - > > Key: HIVE-12304 > URL: https://issues.apache.org/jira/browse/HIVE-12304 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12304.patch > > > Currently "drop database cascade" command doesn't unregister the functions > under the database. If the functions are not unregistered, in some cases like > "describe db1.func1" will still show the info for the function; or if the > same database is recreated, "drop if exists db1.func1" will throw an > exception since the function is considered existing from the registry while > it doesn't exist in metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
