[jira] [Commented] (HIVE-12405) Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
[
https://issues.apache.org/jira/browse/HIVE-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014523#comment-15014523
]
Ashutosh Chauhan commented on HIVE-12405:
-
Pushed to master. Thanks, Aleksei!
> Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
> ---
>
> Key: HIVE-12405
> URL: https://issues.apache.org/jira/browse/HIVE-12405
> Project: Hive
> Issue Type: Bug
> Components: Tez
>Affects Versions: 2.0.0
>Reporter: Aleksei Statkevich
>Assignee: Aleksei Statkevich
> Attachments: HIVE-12405.patch
>
>
> "compare()" method in HiveSplitGenerator.InputSplitComparator has the
> following condition on line 281 which is always false and is most likely a
> typo:
> {code}
> if (startPos1 > startPos1) {
> {code}
> As a result, in certain conditions splits might be sorted in incorrect order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12405) Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
[
https://issues.apache.org/jira/browse/HIVE-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006169#comment-15006169
]
Aleksei Statkevich commented on HIVE-12405:
---
Test failures don't seem to be related.
> Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
> ---
>
> Key: HIVE-12405
> URL: https://issues.apache.org/jira/browse/HIVE-12405
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aleksei Statkevich
>Assignee: Aleksei Statkevich
> Attachments: HIVE-12405.patch
>
>
> "compare()" method in HiveSplitGenerator.InputSplitComparator has the
> following condition on line 281 which is always false and is most likely a
> typo:
> {code}
> if (startPos1 > startPos1) {
> {code}
> As a result, in certain conditions splits might be sorted in incorrect order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12405) Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
[
https://issues.apache.org/jira/browse/HIVE-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004365#comment-15004365
]
Aleksei Statkevich commented on HIVE-12405:
---
I already checked. In branch-1 splits are not sorted, so there's no comparator
and no such bug as a result.
> Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
> ---
>
> Key: HIVE-12405
> URL: https://issues.apache.org/jira/browse/HIVE-12405
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aleksei Statkevich
>Assignee: Aleksei Statkevich
> Attachments: HIVE-12405.patch
>
>
> "compare()" method in HiveSplitGenerator.InputSplitComparator has the
> following condition on line 281 which is always false and is most likely a
> typo:
> {code}
> if (startPos1 > startPos1) {
> {code}
> As a result, in certain conditions splits might be sorted in incorrect order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12405) Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
[
https://issues.apache.org/jira/browse/HIVE-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004746#comment-15004746
]
Hive QA commented on HIVE-12405:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12772134/HIVE-12405.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 9781 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cbo_rp_annotate_stats_groupby
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver
org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler.org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6030/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6030/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6030/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12772134 - PreCommit-HIVE-TRUNK-Build
> Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
> ---
>
> Key: HIVE-12405
> URL: https://issues.apache.org/jira/browse/HIVE-12405
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aleksei Statkevich
>Assignee: Aleksei Statkevich
> Attachments: HIVE-12405.patch
>
>
> "compare()" method in HiveSplitGenerator.InputSplitComparator has the
> following condition on line 281 which is always false and is most likely a
> typo:
> {code}
> if (startPos1 > startPos1) {
> {code}
> As a result, in certain conditions splits might be sorted in incorrect order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12405) Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
[
https://issues.apache.org/jira/browse/HIVE-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003651#comment-15003651
]
Gopal V commented on HIVE-12405:
Good catch - the patch looks good - +1.
This might need a backport to branch-1 for consistency.
> Comparison bug in HiveSplitGenerator.InputSplitComparator#compare()
> ---
>
> Key: HIVE-12405
> URL: https://issues.apache.org/jira/browse/HIVE-12405
> Project: Hive
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aleksei Statkevich
>Assignee: Aleksei Statkevich
> Attachments: HIVE-12405.patch
>
>
> "compare()" method in HiveSplitGenerator.InputSplitComparator has the
> following condition on line 281 which is always false and is most likely a
> typo:
> {code}
> if (startPos1 > startPos1) {
> {code}
> As a result, in certain conditions splits might be sorted in incorrect order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
