[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[ https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132486#comment-15132486 ] Aihua Xu commented on HIVE-12958: - Those tests are not related to the patch. > Make embedded Jetty server more configurable > > > Key: HIVE-12958 > URL: https://issues.apache.org/jira/browse/HIVE-12958 > Project: Hive > Issue Type: Improvement > Components: HCatalog >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12958.1.patch, HIVE-12958.2.patch, > HIVE-12958.3.patch > > > Currently you can't configure embedded jetty within HCatalog. Propose to > support an xml configuration which Jetty already supports. A new Web-hcat > property will be added to specify the configure file location. If the file > doesn't exist, falls back to old behavior. If it exists, such configuration > will be loaded to configure embedded Jetty server. > Some default parameters for Jetty may not be sufficient for some cases such > as request/response buffer size. This improvement allows to make such change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[
https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131287#comment-15131287
]
Hive QA commented on HIVE-12958:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12785813/HIVE-12958.3.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10051 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hive.jdbc.TestSSL.testSSLVersion
org.apache.hive.service.cli.TestEmbeddedThriftBinaryCLIService.testExecuteStatementAsync
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6856/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6856/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6856/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12785813 - PreCommit-HIVE-TRUNK-Build
> Make embedded Jetty server more configurable
>
>
> Key: HIVE-12958
> URL: https://issues.apache.org/jira/browse/HIVE-12958
> Project: Hive
> Issue Type: Improvement
> Components: HCatalog
>Affects Versions: 2.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-12958.1.patch, HIVE-12958.2.patch,
> HIVE-12958.3.patch
>
>
> Currently you can't configure embedded jetty within HCatalog. Propose to
> support add an xml configuration which Jetty already supports. A new Web-hcat
> configuration will be added to specify the configure file location. If the
> file doesn't exist, falls back to old behavior. If it exists, load such
> configuration to configure Jetty server.
> Some default parameters may not be sufficient such as request/response buffer
> size. This improvement allows to make such configuration change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[ https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128775#comment-15128775 ] Yongzhi Chen commented on HIVE-12958: - The new patch LGTM +1 > Make embedded Jetty server more configurable > > > Key: HIVE-12958 > URL: https://issues.apache.org/jira/browse/HIVE-12958 > Project: Hive > Issue Type: Improvement > Components: HCatalog >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12958.1.patch, HIVE-12958.2.patch, > HIVE-12958.3.patch > > > Currently you can't configure embedded jetty within HCatalog. Propose to > support add an xml configuration which Jetty already supports. A new Web-hcat > configuration will be added to specify the configure file location. If the > file doesn't exist, falls back to old behavior. If it exists, load such > configuration to configure Jetty server. > Some default parameters may not be sufficient such as request/response buffer > size. This improvement allows to make such configuration change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[ https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128734#comment-15128734 ] Aihua Xu commented on HIVE-12958: - I will change it back. I was making some changes but forgot to change it back. > Make embedded Jetty server more configurable > > > Key: HIVE-12958 > URL: https://issues.apache.org/jira/browse/HIVE-12958 > Project: Hive > Issue Type: Improvement > Components: HCatalog >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12958.1.patch, HIVE-12958.2.patch > > > Currently you can't configure embedded jetty within HCatalog. Propose to > support add an xml configuration which Jetty already supports. A new Web-hcat > configuration will be added to specify the configure file location. If the > file doesn't exist, falls back to old behavior. If it exists, load such > configuration to configure Jetty server. > Some default parameters may not be sufficient such as request/response buffer > size. This improvement allows to make such configuration change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[ https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128320#comment-15128320 ] Aihua Xu commented on HIVE-12958: - The tests are not related to the patch. > Make embedded Jetty server more configurable > > > Key: HIVE-12958 > URL: https://issues.apache.org/jira/browse/HIVE-12958 > Project: Hive > Issue Type: Improvement > Components: HCatalog >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12958.1.patch, HIVE-12958.2.patch > > > Currently you can't configure embedded jetty within HCatalog. Propose to > support add an xml configuration which Jetty already supports. A new Web-hcat > configuration will be added to specify the configure file location. If the > file doesn't exist, falls back to old behavior. If it exists, load such > configuration to configure Jetty server. > Some default parameters may not be sufficient such as request/response buffer > size. This improvement allows to make such configuration change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[ https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128523#comment-15128523 ] Yongzhi Chen commented on HIVE-12958: - The change looks fine. Just one question, why do you change port to Integer for runServer? > Make embedded Jetty server more configurable > > > Key: HIVE-12958 > URL: https://issues.apache.org/jira/browse/HIVE-12958 > Project: Hive > Issue Type: Improvement > Components: HCatalog >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12958.1.patch, HIVE-12958.2.patch > > > Currently you can't configure embedded jetty within HCatalog. Propose to > support add an xml configuration which Jetty already supports. A new Web-hcat > configuration will be added to specify the configure file location. If the > file doesn't exist, falls back to old behavior. If it exists, load such > configuration to configure Jetty server. > Some default parameters may not be sufficient such as request/response buffer > size. This improvement allows to make such configuration change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[
https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125008#comment-15125008
]
Hive QA commented on HIVE-12958:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12785170/HIVE-12958.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10046 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hive.jdbc.TestSSL.testSSLVersion
org.apache.hive.service.cli.TestEmbeddedThriftBinaryCLIService.testExecuteStatementAsync
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6802/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6802/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6802/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12785170 - PreCommit-HIVE-TRUNK-Build
> Make embedded Jetty server more configurable
>
>
> Key: HIVE-12958
> URL: https://issues.apache.org/jira/browse/HIVE-12958
> Project: Hive
> Issue Type: Improvement
> Components: HCatalog
>Affects Versions: 2.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-12958.1.patch, HIVE-12958.2.patch
>
>
> Currently you can't configure embedded jetty within HCatalog. Propose to
> support add an xml configuration which Jetty already supports. A new Web-hcat
> configuration will be added to specify the configure file location. If the
> file doesn't exist, falls back to old behavior. If it exists, load such
> configuration to configure Jetty server.
> Some default parameters may not be sufficient such as request/response buffer
> size. This improvement allows to make such configuration change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[
https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123575#comment-15123575
]
Aihua Xu commented on HIVE-12958:
-
Attach patch-2: this patch will take all the configuration from the
configuration file including the port. I feel maybe this is less confusing. One
sample configuration is as follows, which set the port to and change
requestHeaderSize size of the connection.
{noformat}
http://www.eclipse.org/jetty/configure.dtd;>
65535
{noformat}
> Make embedded Jetty server more configurable
>
>
> Key: HIVE-12958
> URL: https://issues.apache.org/jira/browse/HIVE-12958
> Project: Hive
> Issue Type: Improvement
> Components: HCatalog
>Affects Versions: 2.1.0
>Reporter: Aihua Xu
>Assignee: Aihua Xu
> Attachments: HIVE-12958.1.patch, HIVE-12958.2.patch
>
>
> Currently you can't configure embedded jetty within HCatalog. Propose to
> support add an xml configuration which Jetty already supports. A new Web-hcat
> configuration will be added to specify the configure file location. If the
> file doesn't exist, falls back to old behavior. If it exists, load such
> configuration to configure Jetty server.
> Some default parameters may not be sufficient such as request/response buffer
> size. This improvement allows to make such configuration change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[ https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122313#comment-15122313 ] Aihua Xu commented on HIVE-12958: - [~ctang.ma], [~ychena] and [~szehon] can you help review the code? > Make embedded Jetty server more configurable > > > Key: HIVE-12958 > URL: https://issues.apache.org/jira/browse/HIVE-12958 > Project: Hive > Issue Type: Improvement > Components: HCatalog >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12958.1.patch > > > Currently you can't configure embedded jetty within HCatalog. Propose to > support add an xml configuration which Jetty already supports. A new Web-hcat > configuration will be added to specify the configure file location. If the > file doesn't exist, falls back to old behavior. If it exists, load such > configuration to configure Jetty server. > Some default parameters may not be sufficient such as request/response buffer > size. This improvement allows to make such configuration change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12958) Make embedded Jetty server more configurable
[ https://issues.apache.org/jira/browse/HIVE-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122309#comment-15122309 ] Aihua Xu commented on HIVE-12958: - Attached patch1: added a new configuration for Web-Hcat which allows you to do more configuration for Jetty. We will still use the port from templeton.port to be consistent with existing behavior. > Make embedded Jetty server more configurable > > > Key: HIVE-12958 > URL: https://issues.apache.org/jira/browse/HIVE-12958 > Project: Hive > Issue Type: Improvement > Components: HCatalog >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12958.1.patch > > > Currently you can't configure embedded jetty within HCatalog. Propose to > support add an xml configuration which Jetty already supports. A new Web-hcat > configuration will be added to specify the configure file location. If the > file doesn't exist, falls back to old behavior. If it exists, load such > configuration to configure Jetty server. > Some default parameters may not be sufficient such as request/response buffer > size. This improvement allows to make such configuration change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
