[jira] [Commented] (HIVE-13645) Beeline needs null-guard around hiveVars and hiveConfVars read
[
https://issues.apache.org/jira/browse/HIVE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267377#comment-15267377
]
Sushanth Sowmyan commented on HIVE-13645:
-
Thanks, pushed to branch-2.0 as well.
> Beeline needs null-guard around hiveVars and hiveConfVars read
> --
>
> Key: HIVE-13645
> URL: https://issues.apache.org/jira/browse/HIVE-13645
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Affects Versions: 2.1.0
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
>Priority: Minor
> Fix For: 1.3.0, 1.2.2, 2.1.0, 2.0.1
>
> Attachments: HIVE-13645.patch
>
>
> Beeline has a bug wherein if a user does a !save ever, then on next load, if
> beeline.hiveVariables or beeline.hiveconfvariables are empty, i.e. \{\} or
> unspecified, then it loads it as null, and then, on next connect, there is no
> null-check on these variables leading to an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13645) Beeline needs null-guard around hiveVars and hiveConfVars read
[
https://issues.apache.org/jira/browse/HIVE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267366#comment-15267366
]
Sergey Shelukhin commented on HIVE-13645:
-
it's open for commits since RC is blocked
> Beeline needs null-guard around hiveVars and hiveConfVars read
> --
>
> Key: HIVE-13645
> URL: https://issues.apache.org/jira/browse/HIVE-13645
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Affects Versions: 2.1.0
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
>Priority: Minor
> Fix For: 1.3.0, 1.2.2, 2.1.0
>
> Attachments: HIVE-13645.patch
>
>
> Beeline has a bug wherein if a user does a !save ever, then on next load, if
> beeline.hiveVariables or beeline.hiveconfvariables are empty, i.e. \{\} or
> unspecified, then it loads it as null, and then, on next connect, there is no
> null-check on these variables leading to an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13645) Beeline needs null-guard around hiveVars and hiveConfVars read
[
https://issues.apache.org/jira/browse/HIVE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267301#comment-15267301
]
Sushanth Sowmyan commented on HIVE-13645:
-
[~sershe], Is branch-2.0 okay for commits right now, or should we hold off?
> Beeline needs null-guard around hiveVars and hiveConfVars read
> --
>
> Key: HIVE-13645
> URL: https://issues.apache.org/jira/browse/HIVE-13645
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Affects Versions: 2.1.0
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
>Priority: Minor
> Fix For: 1.3.0, 1.2.2, 2.1.0
>
> Attachments: HIVE-13645.patch
>
>
> Beeline has a bug wherein if a user does a !save ever, then on next load, if
> beeline.hiveVariables or beeline.hiveconfvariables are empty, i.e. \{\} or
> unspecified, then it loads it as null, and then, on next connect, there is no
> null-check on these variables leading to an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13645) Beeline needs null-guard around hiveVars and hiveConfVars read
[
https://issues.apache.org/jira/browse/HIVE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267291#comment-15267291
]
Sushanth Sowmyan commented on HIVE-13645:
-
None of the test failures reported here are related, going ahead and committing.
> Beeline needs null-guard around hiveVars and hiveConfVars read
> --
>
> Key: HIVE-13645
> URL: https://issues.apache.org/jira/browse/HIVE-13645
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Affects Versions: 2.1.0
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
>Priority: Minor
> Attachments: HIVE-13645.patch
>
>
> Beeline has a bug wherein if a user does a !save ever, then on next load, if
> beeline.hiveVariables or beeline.hiveconfvariables are empty, i.e. \{\} or
> unspecified, then it loads it as null, and then, on next connect, there is no
> null-check on these variables leading to an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13645) Beeline needs null-guard around hiveVars and hiveConfVars read
[
https://issues.apache.org/jira/browse/HIVE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265687#comment-15265687
]
Hive QA commented on HIVE-13645:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12801302/HIVE-13645.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 43 failed/errored test(s), 9990 tests
executed
*Failed tests:*
{noformat}
TestHWISessionManager - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby1_limit
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_auto_mult_tables
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_nomore_ambiguous_table_col
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_regexp_extract
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_clustern3
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_clustern4
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_nonkey_groupby
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_selectDistinctStarNeg_2
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_subquery_shared_alias
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_udtf_not_supported1
org.apache.hadoop.hive.metastore.TestAuthzApiEmbedAuthorizerInRemote.org.apache.hadoop.hive.metastore.TestAuthzApiEmbedAuthorizerInRemote
org.apache.hadoop.hive.metastore.TestFilterHooks.org.apache.hadoop.hive.metastore.TestFilterHooks
org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfDefault
org.apache.hadoop.hive.metastore.TestMetaStoreEndFunctionListener.testEndFunctionListener
org.apache.hadoop.hive.metastore.TestMetaStoreEventListenerOnlyOnCommit.testEventStatus
org.apache.hadoop.hive.metastore.TestMetaStoreInitListener.testMetaStoreInitListener
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAddPartitionWithUnicode
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAddPartitionWithValidPartVal
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAppendPartitionWithCommas
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAppendPartitionWithUnicode
org.apache.hadoop.hive.metastore.TestPartitionNameWhitelistValidation.testAppendPartitionWithValidCharacters
org.apache.hadoop.hive.metastore.TestRemoteUGIHiveMetaStoreIpAddress.testIpAddress
org.apache.hadoop.hive.metastore.TestRetryingHMSHandler.testRetryingHMSHandler
org.apache.hadoop.hive.ql.security.TestClientSideAuthorizationProvider.testSimplePrivileges
org.apache.hadoop.hive.ql.security.TestExtendedAcls.org.apache.hadoop.hive.ql.security.TestExtendedAcls
org.apache.hadoop.hive.ql.security.TestFolderPermissions.org.apache.hadoop.hive.ql.security.TestFolderPermissions
org.apache.hadoop.hive.ql.security.TestMetastoreAuthorizationProvider.testSimplePrivileges
org.apache.hadoop.hive.ql.security.TestMultiAuthorizationPreEventListener.org.apache.hadoop.hive.ql.security.TestMultiAuthorizationPreEventListener
org.apache.hadoop.hive.ql.security.TestStorageBasedClientSideAuthorizationProvider.testSimplePrivileges
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationDrops.testDropDatabase
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationDrops.testDropPartition
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationProvider.testSimplePrivileges
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationProviderWithACL.testSimplePrivileges
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationReads.testReadTableFailure
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testDelegationTokenSharedStore
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testMetastoreProxyUser
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testSaslWithHiveMetaStore
org.apache.hive.hcatalog.listener.TestDbNotificationListener.cleanupNotifs
org.apache.hive.hcatalog.listener.TestDbNotificationListener.sqlInsertPartition
org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.org.apache.hive.service.TestHS2ImpersonationWithRemoteMS
org.apache.hive.spark.client.TestSparkClient.testSyncRpc
{noformat}
Test results:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/139/testReport
Console output:
http://ec2-54-177-240-2.us-west-1.compute.amazonaws.com/job/PreCommit-HIVE-MASTER-Build/139/console
Test logs:
http://ec2-50-18-27-0.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-139/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing
[jira] [Commented] (HIVE-13645) Beeline needs null-guard around hiveVars and hiveConfVars read
[
https://issues.apache.org/jira/browse/HIVE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263039#comment-15263039
]
Thejas M Nair commented on HIVE-13645:
--
+1
> Beeline needs null-guard around hiveVars and hiveConfVars read
> --
>
> Key: HIVE-13645
> URL: https://issues.apache.org/jira/browse/HIVE-13645
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Affects Versions: 2.1.0
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
>Priority: Minor
> Attachments: HIVE-13645.patch
>
>
> Beeline has a bug wherein if a user does a !save ever, then on next load, if
> beeline.hiveVariables or beeline.hiveconfvariables are empty, i.e. \{\} or
> unspecified, then it loads it as null, and then, on next connect, there is no
> null-check on these variables leading to an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-13645) Beeline needs null-guard around hiveVars and hiveConfVars read
[
https://issues.apache.org/jira/browse/HIVE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262815#comment-15262815
]
Sushanth Sowmyan commented on HIVE-13645:
-
[~thejas], could you please take a look - this is a near-trivial patch.
> Beeline needs null-guard around hiveVars and hiveConfVars read
> --
>
> Key: HIVE-13645
> URL: https://issues.apache.org/jira/browse/HIVE-13645
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Affects Versions: 2.1.0
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
> Attachments: HIVE-13645.patch
>
>
> Beeline has a bug wherein if a user does a !save ever, then on next load, if
> beeline.hiveVariables or beeline.hiveconfvariables are empty, i.e. \{\} or
> unspecified, then it loads it as null, and then, on next connect, there is no
> null-check on these variables leading to an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
