[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[
https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849935#comment-15849935
]
Hive QA commented on HIVE-13667:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12850617/HIVE-13667.5.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 11023 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_char_simple]
(batchId=147)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple]
(batchId=153)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=223)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3325/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3325/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3325/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12850617 - PreCommit-HIVE-Build
> Improve performance for ServiceInstanceSet.getByHost
>
>
> Key: HIVE-13667
> URL: https://issues.apache.org/jira/browse/HIVE-13667
> Project: Hive
> Issue Type: Improvement
>Reporter: Siddharth Seth
>Assignee: Rajesh Balamohan
> Attachments: HIVE-13667.1.patch, HIVE-13667.2.patch,
> HIVE-13667.3.patch, HIVE-13667.4.patch, HIVE-13667.5.patch
>
>
> ServiceInstanceSet.getByHost is used for scheduling local tasks as well as
> constructing the log URL.
> It ends up traversing all hosts on each lookup. This should be avoided.
> cc [~prasanth_j]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[
https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849591#comment-15849591
]
Hive QA commented on HIVE-13667:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12850583/HIVE-13667.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 11023 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple]
(batchId=153)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=223)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23]
(batchId=223)
org.apache.hive.jdbc.TestJdbcWithMiniLlap.testEscapedStrings (batchId=217)
org.apache.hive.jdbc.TestJdbcWithMiniLlap.testLlapInputFormatEndToEnd
(batchId=217)
org.apache.hive.jdbc.TestJdbcWithMiniLlap.testNonAsciiStrings (batchId=217)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3320/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3320/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3320/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12850583 - PreCommit-HIVE-Build
> Improve performance for ServiceInstanceSet.getByHost
>
>
> Key: HIVE-13667
> URL: https://issues.apache.org/jira/browse/HIVE-13667
> Project: Hive
> Issue Type: Improvement
>Reporter: Siddharth Seth
>Assignee: Rajesh Balamohan
> Attachments: HIVE-13667.1.patch, HIVE-13667.2.patch
>
>
> ServiceInstanceSet.getByHost is used for scheduling local tasks as well as
> constructing the log URL.
> It ends up traversing all hosts on each lookup. This should be avoided.
> cc [~prasanth_j]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[
https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849561#comment-15849561
]
Siddharth Seth commented on HIVE-13667:
---
The hascode and equals can use the worker identity alone. Does not need to be
all the fields. More efficient and, I'm not completely sure about the
correctness of Objects.hashCode in this case (ServiceRecord does not implement
a hashCode or equals)
{code}
public String getWorkerIdentity() {
com.google.common.base.Objects.hashCode(srv, null);
return srv.get(UNIQUE_IDENTIFIER);
}
{code}
> Improve performance for ServiceInstanceSet.getByHost
>
>
> Key: HIVE-13667
> URL: https://issues.apache.org/jira/browse/HIVE-13667
> Project: Hive
> Issue Type: Improvement
>Reporter: Siddharth Seth
>Assignee: Rajesh Balamohan
> Attachments: HIVE-13667.1.patch, HIVE-13667.2.patch
>
>
> ServiceInstanceSet.getByHost is used for scheduling local tasks as well as
> constructing the log URL.
> It ends up traversing all hosts on each lookup. This should be avoided.
> cc [~prasanth_j]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[ https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849489#comment-15849489 ] Prasanth Jayachandran commented on HIVE-13667: -- lgtm, +1 > Improve performance for ServiceInstanceSet.getByHost > > > Key: HIVE-13667 > URL: https://issues.apache.org/jira/browse/HIVE-13667 > Project: Hive > Issue Type: Improvement >Reporter: Siddharth Seth >Assignee: Rajesh Balamohan > Attachments: HIVE-13667.1.patch, HIVE-13667.2.patch > > > ServiceInstanceSet.getByHost is used for scheduling local tasks as well as > constructing the log URL. > It ends up traversing all hosts on each lookup. This should be avoided. > cc [~prasanth_j] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[ https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848836#comment-15848836 ] Sergey Shelukhin commented on HIVE-13667: - It would be nice to run cluster tests on this, and flex/kill LLAP containers while some long query is running. > Improve performance for ServiceInstanceSet.getByHost > > > Key: HIVE-13667 > URL: https://issues.apache.org/jira/browse/HIVE-13667 > Project: Hive > Issue Type: Improvement >Reporter: Siddharth Seth >Assignee: Rajesh Balamohan > Attachments: HIVE-13667.1.patch > > > ServiceInstanceSet.getByHost is used for scheduling local tasks as well as > constructing the log URL. > It ends up traversing all hosts on each lookup. This should be avoided. > cc [~prasanth_j] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[
https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848261#comment-15848261
]
Hive QA commented on HIVE-13667:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12850379/HIVE-13667.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10983 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
TestSparkCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=110)
[groupby_grouping_id2.q,input17.q,bucketmapjoin12.q,ppd_gby_join.q,auto_join10.q,ptf_rcfile.q,vector_elt.q,multi_insert.q,ppd_join5.q,ppd_join.q,join_filters_overlap.q,join_cond_pushdown_1.q,timestamp_3.q,load_dyn_part6.q,stats_noscan_2.q]
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver
(batchId=161)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=223)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23]
(batchId=223)
org.apache.hive.jdbc.TestJdbcWithMiniLlap.testEscapedStrings (batchId=217)
org.apache.hive.jdbc.TestJdbcWithMiniLlap.testLlapInputFormatEndToEnd
(batchId=217)
org.apache.hive.jdbc.TestJdbcWithMiniLlap.testNonAsciiStrings (batchId=217)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3301/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3301/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3301/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12850379 - PreCommit-HIVE-Build
> Improve performance for ServiceInstanceSet.getByHost
>
>
> Key: HIVE-13667
> URL: https://issues.apache.org/jira/browse/HIVE-13667
> Project: Hive
> Issue Type: Improvement
>Reporter: Siddharth Seth
>Assignee: Rajesh Balamohan
> Attachments: HIVE-13667.1.patch
>
>
> ServiceInstanceSet.getByHost is used for scheduling local tasks as well as
> constructing the log URL.
> It ends up traversing all hosts on each lookup. This should be avoided.
> cc [~prasanth_j]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[ https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848115#comment-15848115 ] Rajesh Balamohan commented on HIVE-13667: - RB link: https://reviews.apache.org/r/56159/ > Improve performance for ServiceInstanceSet.getByHost > > > Key: HIVE-13667 > URL: https://issues.apache.org/jira/browse/HIVE-13667 > Project: Hive > Issue Type: Improvement >Reporter: Siddharth Seth >Assignee: Rajesh Balamohan > Attachments: HIVE-13667.1.patch > > > ServiceInstanceSet.getByHost is used for scheduling local tasks as well as > constructing the log URL. > It ends up traversing all hosts on each lookup. This should be avoided. > cc [~prasanth_j] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[ https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303740#comment-15303740 ] Jesus Camacho Rodriguez commented on HIVE-13667: Removing 2.1.0 target. Please feel free to commit to branch-2.1 anyway and fix for 2.1.0 if this happens before the release. > Improve performance for ServiceInstanceSet.getByHost > > > Key: HIVE-13667 > URL: https://issues.apache.org/jira/browse/HIVE-13667 > Project: Hive > Issue Type: Improvement >Reporter: Siddharth Seth >Assignee: Prasanth Jayachandran > > ServiceInstanceSet.getByHost is used for scheduling local tasks as well as > constructing the log URL. > It ends up traversing all hosts on each lookup. This should be avoided. > cc [~prasanth_j] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[ https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303709#comment-15303709 ] Prasanth Jayachandran commented on HIVE-13667: -- Not a highest priority item yet. If no patch by next week we can defer this. > Improve performance for ServiceInstanceSet.getByHost > > > Key: HIVE-13667 > URL: https://issues.apache.org/jira/browse/HIVE-13667 > Project: Hive > Issue Type: Improvement >Reporter: Siddharth Seth >Assignee: Prasanth Jayachandran > > ServiceInstanceSet.getByHost is used for scheduling local tasks as well as > constructing the log URL. > It ends up traversing all hosts on each lookup. This should be avoided. > cc [~prasanth_j] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13667) Improve performance for ServiceInstanceSet.getByHost
[ https://issues.apache.org/jira/browse/HIVE-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299820#comment-15299820 ] Jesus Camacho Rodriguez commented on HIVE-13667: [~prasanth_j], will this go into 2.1.0? > Improve performance for ServiceInstanceSet.getByHost > > > Key: HIVE-13667 > URL: https://issues.apache.org/jira/browse/HIVE-13667 > Project: Hive > Issue Type: Improvement >Reporter: Siddharth Seth >Assignee: Prasanth Jayachandran > > ServiceInstanceSet.getByHost is used for scheduling local tasks as well as > constructing the log URL. > It ends up traversing all hosts on each lookup. This should be avoided. > cc [~prasanth_j] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
