[jira] [Commented] (HIVE-14364) Update timeouts for llap comparator tests

2016-07-27 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396663#comment-15396663
 ] 

Siddharth Seth commented on HIVE-14364:
---

bq. Why cannot classloader stuff be moved into pre-test by touching the same 
classes? That way the test timeout doesn't need to increase. -0
The entire test will hang if there's a disk issue (or take a really long time). 
It's better to fail fast instead of running forever because of bad hardware.
Touching classes as a part of a test because of slow classloading is going to 
be extremely confusing for anyone looking at this code later. Not maintainable 
at all. It should not be restricted to this test only.

> Update timeouts for llap comparator tests
> -
>
> Key: HIVE-14364
> URL: https://issues.apache.org/jira/browse/HIVE-14364
> Project: Hive
>  Issue Type: Task
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
> Attachments: HIVE-14364.01.patch
>
>
> The tests timeout occasionally. Increasing to 60 seconds from 5 seconds. 
> NO_PRECOMMIT_TESTS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14364) Update timeouts for llap comparator tests

2016-07-27 Thread Sergey Shelukhin (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396634#comment-15396634
 ] 

Sergey Shelukhin commented on HIVE-14364:
-

Why cannot classloader stuff be moved into pre-test by touching the same 
classes? That way the test timeout doesn't need to increase. -0

> Update timeouts for llap comparator tests
> -
>
> Key: HIVE-14364
> URL: https://issues.apache.org/jira/browse/HIVE-14364
> Project: Hive
>  Issue Type: Task
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
> Attachments: HIVE-14364.01.patch
>
>
> The tests timeout occasionally. Increasing to 60 seconds from 5 seconds. 
> NO_PRECOMMIT_TESTS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14364) Update timeouts for llap comparator tests

2016-07-27 Thread Gunther Hagleitner (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396615#comment-15396615
 ] 

Gunther Hagleitner commented on HIVE-14364:
---

+1

> Update timeouts for llap comparator tests
> -
>
> Key: HIVE-14364
> URL: https://issues.apache.org/jira/browse/HIVE-14364
> Project: Hive
>  Issue Type: Task
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
> Attachments: HIVE-14364.01.patch
>
>
> The tests timeout occasionally. Increasing to 60 seconds from 5 seconds. 
> NO_PRECOMMIT_TESTS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)