[jira] [Commented] (HIVE-14446) Adjust bloom filter for hybrid grace hash join when row count exceeds certain limit
[ https://issues.apache.org/jira/browse/HIVE-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434394#comment-15434394 ] Gopal V commented on HIVE-14446: LGTM - +1. > Adjust bloom filter for hybrid grace hash join when row count exceeds certain > limit > --- > > Key: HIVE-14446 > URL: https://issues.apache.org/jira/browse/HIVE-14446 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 1.3.0, 2.2.0, 2.1.1 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-14446.1.patch, HIVE-14446.2.patch > > > When row count exceeds certain limit, it doesn't make sense to generate a > bloom filter, since its size will be a few hundred MB or even a few GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14446) Adjust bloom filter for hybrid grace hash join when row count exceeds certain limit
[ https://issues.apache.org/jira/browse/HIVE-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434214#comment-15434214 ] Wei Zheng commented on HIVE-14446: -- [~gopalv] Test failures not related. > Adjust bloom filter for hybrid grace hash join when row count exceeds certain > limit > --- > > Key: HIVE-14446 > URL: https://issues.apache.org/jira/browse/HIVE-14446 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 1.3.0, 2.2.0, 2.1.1 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-14446.1.patch, HIVE-14446.2.patch > > > When row count exceeds certain limit, it doesn't make sense to generate a > bloom filter, since its size will be a few hundred MB or even a few GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14446) Adjust bloom filter for hybrid grace hash join when row count exceeds certain limit
[ https://issues.apache.org/jira/browse/HIVE-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434111#comment-15434111 ] Hive QA commented on HIVE-14446: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12825144/HIVE-14446.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10487 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_mapjoin] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char] org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[acid_bucket_pruning] org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] org.apache.hive.service.cli.operation.TestOperationLoggingLayout.testSwitchLogLayout {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/972/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/972/console Test logs: http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-972/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12825144 - PreCommit-HIVE-MASTER-Build > Adjust bloom filter for hybrid grace hash join when row count exceeds certain > limit > --- > > Key: HIVE-14446 > URL: https://issues.apache.org/jira/browse/HIVE-14446 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 1.3.0, 2.2.0, 2.1.1 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-14446.1.patch, HIVE-14446.2.patch > > > When row count exceeds certain limit, it doesn't make sense to generate a > bloom filter, since its size will be a few hundred MB or even a few GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14446) Adjust bloom filter for hybrid grace hash join when row count exceeds certain limit
[ https://issues.apache.org/jira/browse/HIVE-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429248#comment-15429248 ] Wei Zheng commented on HIVE-14446: -- Test failures unrelated. [~gopalv] Can you take a look? > Adjust bloom filter for hybrid grace hash join when row count exceeds certain > limit > --- > > Key: HIVE-14446 > URL: https://issues.apache.org/jira/browse/HIVE-14446 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 1.3.0, 2.2.0, 2.1.1 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-14446.1.patch > > > When row count exceeds certain limit, it doesn't make sense to generate a > bloom filter, since its size will be a few hundred MB or even a few GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14446) Adjust bloom filter for hybrid grace hash join when row count exceeds certain limit
[ https://issues.apache.org/jira/browse/HIVE-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429220#comment-15429220 ] Hive QA commented on HIVE-14446: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12824631/HIVE-14446.1.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 10445 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_mapjoin] org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_1] org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_2] org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[load_dyn_part1] org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[transform_ppr1] org.apache.hive.service.cli.operation.TestOperationLoggingLayout.testSwitchLogLayout {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/942/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/942/console Test logs: http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-942/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12824631 - PreCommit-HIVE-MASTER-Build > Adjust bloom filter for hybrid grace hash join when row count exceeds certain > limit > --- > > Key: HIVE-14446 > URL: https://issues.apache.org/jira/browse/HIVE-14446 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 1.3.0, 2.2.0, 2.1.1 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-14446.1.patch > > > When row count exceeds certain limit, it doesn't make sense to generate a > bloom filter, since its size will be a few hundred MB or even a few GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)