[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-19 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504975#comment-15504975
 ] 

Siddharth Seth commented on HIVE-14734:
---

Sure. If you think that's what it is. I'm not sure the outputDir is set 
correctly either.

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Fix For: 2.2.0
>
> Attachments: HIVE-14734.2.patch, HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-19 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504831#comment-15504831
 ] 

Sergio Peña commented on HIVE-14734:


[~sseth] I know what it is. 

This is the last part of the script.
{noformat}
call_ptest_server --testHandle "$TEST_HANDLE" --endpoint "$PTEST_API_ENDPOINT" 
--logsEndpoint "$PTEST_LOG_ENDPOINT" \
--profile "$BUILD_PROFILE" ${optionalArgs[@]} "$@"

ret=$?

unpack_test_results

exit $ret
{noformat}

The {{set -e}} at the beginning of the file is aborting the script when 
{{call_ptest_server}} returns a non-zero value, and he script does not unpack 
the test results.
I'll create a quick patch to remove this.

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Fix For: 2.2.0
>
> Attachments: HIVE-14734.2.patch, HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-19 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504614#comment-15504614
 ] 

Siddharth Seth commented on HIVE-14734:
---

[~spena] - test results are no longer available on Hadoop. Investigating, but I 
suspect it may be because of this jira.

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Fix For: 2.2.0
>
> Attachments: HIVE-14734.2.patch, HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-19 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504294#comment-15504294
 ] 

Siddharth Seth commented on HIVE-14734:
---

Very useful. Thankyou. 
https://builds.apache.org/view/H-L/view/Hive/job/PreCommit-HIVE-Build/ is the 
new url for the job. (instead of PreCommit-HIVE-master-Build)

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Fix For: 2.2.0
>
> Attachments: HIVE-14734.2.patch, HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-17 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499716#comment-15499716
 ] 

Sergio Peña commented on HIVE-14734:


Thanks [~sseth] for the review.
I did the change on Jenkins to the PreCommit-HIVE-Build. It will now display 
the JIRA and PROFILE on the build description.

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Fix For: 2.2.0
>
> Attachments: HIVE-14734.2.patch, HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-17 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499253#comment-15499253
 ] 

Hive QA commented on HIVE-14734:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12828267/HIVE-14734.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10553 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler.org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching
{noformat}

Test results: 
https://builds.apache.org/job/jenkins-PreCommit-HIVE-Build-2/5/testReport
Console output: 
https://builds.apache.org/job/jenkins-PreCommit-HIVE-Build-2/5/console
Test logs: 
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/jenkins-PreCommit-HIVE-Build-2-5/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12828267 - jenkins-PreCommit-HIVE-Build-2

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-16 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497556#comment-15497556
 ] 

Sergio Peña commented on HIVE-14734:


Thanks [~sseth]. I will commit it and change the jenkins job next week.

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-16 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497554#comment-15497554
 ] 

Sergio Peña commented on HIVE-14734:


Th

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-16 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497551#comment-15497551
 ] 

Siddharth Seth commented on HIVE-14734:
---

+1 Looks good.

Four changes needed on the jenkinst script.

Password changes
TEST_HANDLE
PTEST_API_ENDPOINT
PTEST_LOGS_ENDPOINT

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-16 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497536#comment-15497536
 ] 

Sergio Peña commented on HIVE-14734:


Better names. I did not understand what those names meant when I just started 
working on ptest, and now I know, but I'd like others understand that quickly 
without looking at the code.

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-16 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497529#comment-15497529
 ] 

Siddharth Seth commented on HIVE-14734:
---

API_ENDPOINT renamed to PTEST_API_ENDPOINT
LOGS_ENDPOINT renamed to PTEST_LOGS_ENDPOINT

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-16 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497004#comment-15497004
 ] 

Sergio Peña commented on HIVE-14734:


Yeah, sorry. It will. Jenkins will set it up once we start using this script.

This would be a line to add in Jenkins. Seems easier to know what is happening, 
instead of the script dependeing on variables we don't know.
export TEST_HANDLE=$BUILD_TAG

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-16 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496996#comment-15496996
 ] 

Siddharth Seth commented on HIVE-14734:
---

Won't TEST_HANDLE be setup by jenkins as well?

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-16 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496962#comment-15496962
 ] 

Sergio Peña commented on HIVE-14734:


Currently, the test handle name uses the $BUILD_TAG environment variable that 
Jenkins generates. I don't want to depend on Jenkins env variables.
I can try to use a default TEST_HANDLE value in case nothing is provided.

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-16 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496951#comment-15496951
 ] 

Siddharth Seth commented on HIVE-14734:
---

Looks like TEST_HANDLE needs to be setup somewhere. Can that be inferred from 
the information in the script?

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-15 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495058#comment-15495058
 ] 

Siddharth Seth commented on HIVE-14734:
---

OK. I'll try out the patch later today or tomorrow on a local setup.

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-14 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491420#comment-15491420
 ] 

Sergio Peña commented on HIVE-14734:


{{read -s -p}} will ask you for a password, and it won't show the password on 
console. I wanted to get rid of environment variables and use parameters, but I 
don't like to pass passwords as parameters, so I used that approach. It is a 
common command used on applications that ask for passwords. I used before, and 
I wanted to include it here.

In jenkins, we will do this to call the script with a password:
$ echo ${JIRA_API_PASSWORD} | jenkins-build-execute.sh

Jenkins already has a plugin to hide the password on the Jenkins log console.

Regarding the profiles, they will continue working as usual. For instance, 
HIVE-14734.1.branch-2.1.patch, HIVE-14734.1.branch-1-mr1.patch, etc. If you use 
HIVE-1434.patch, then it will use the default profile that is master-mr2. If no 
mr2 or mr1 is passed, then mr2 is used as default too.

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-14734) Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh

2016-09-14 Thread Siddharth Seth (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491384#comment-15491384
 ] 

Siddharth Seth commented on HIVE-14734:
---

[~spena] - Most of the refactor looks good to me. The password handling has 
changed to be a "read -s -p". Why the change? Also, could you provide some more 
details on how branch handling works after the patch. (Assumes profile = 
master-mr2 / "${branch}-mr2" unless some other explicit branch with mr1/mr2 is 
specified in the patch?

> Detect ptest profile and submit to ptest-server from jenkins-execute-build.sh
> -
>
> Key: HIVE-14734
> URL: https://issues.apache.org/jira/browse/HIVE-14734
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, Testing Infrastructure
>Reporter: Sergio Peña
>Assignee: Sergio Peña
> Attachments: HIVE-14734.patch
>
>
> NO PRECOMMIT TESTS
> Currently, to execute tests on a new branch, a manual process must be done:
> 1. Create a new Jenkins job with the new branch name
> 2. Create a patch to jenkins-submit-build.sh with the new branch
> 3. Create a profile properties file on the ptest master with the new branch
> This jira will attempt to automate steps 1 and 2 by detecting the branch 
> profile from a patch to test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)