[jira] [Commented] (HIVE-14891) Parallelize TestHCatStorer
[ https://issues.apache.org/jira/browse/HIVE-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583144#comment-15583144 ] Vaibhav Gumashta commented on HIVE-14891: - For future reference: new formats won't need a new testcase. The class TestHCatStorer still works as a parameterized class, with all tests disabled for Avro, RC, Text, SequenceFile, Orc and Parquet. In case a new format is added, which HCat supports, we'll need to add a new testcase if we wish to parallelize it like others. > Parallelize TestHCatStorer > -- > > Key: HIVE-14891 > URL: https://issues.apache.org/jira/browse/HIVE-14891 > Project: Hive > Issue Type: Sub-task > Components: HCatalog, Testing Infrastructure >Affects Versions: 2.1.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Fix For: 2.2.0 > > Attachments: HIVE-14891.1.patch, HIVE-14891.1.patch, > HIVE-14891.1.patch > > > Currently TestHCatStorer runs as a parameterized test, where it runs the same > tests for each storage format but within the same junit test case. This > prevents it from being parallelized using ptest where parallelism granularity > is at a test case level. Instead of using parameterized tests, it makes sense > to create a new test case for each storage format. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14891) Parallelize TestHCatStorer
[ https://issues.apache.org/jira/browse/HIVE-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583047#comment-15583047 ] Siddharth Seth commented on HIVE-14891: --- HIVE-14973 to HIVE-14978, along with HIVE-14910 cover the flaky tests. They're not related to the patch. +1 for the patch. There's one downside which is that any new formats would need to explicitly add a test class (earlier this was discovered). I think that's acceptable for now. > Parallelize TestHCatStorer > -- > > Key: HIVE-14891 > URL: https://issues.apache.org/jira/browse/HIVE-14891 > Project: Hive > Issue Type: Sub-task > Components: HCatalog, Testing Infrastructure >Affects Versions: 2.1.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-14891.1.patch, HIVE-14891.1.patch, > HIVE-14891.1.patch > > > Currently TestHCatStorer runs as a parameterized test, where it runs the same > tests for each storage format but within the same junit test case. This > prevents it from being parallelized using ptest where parallelism granularity > is at a test case level. Instead of using parameterized tests, it makes sense > to create a new test case for each storage format. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14891) Parallelize TestHCatStorer
[ https://issues.apache.org/jira/browse/HIVE-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576972#comment-15576972 ] Hive QA commented on HIVE-14891: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12833469/HIVE-14891.1.patch {color:green}SUCCESS:{color} +1 due to 8 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10564 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_globallimit] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[order_null] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_fast_stats] org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJarWithoutAddDriverClazz[0] org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[0] org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[1] org.apache.hive.jdbc.authorization.TestJdbcWithSQLAuthorization.testBlackListedUdfUsage org.apache.hive.spark.client.TestSparkClient.testJobSubmission {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1573/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1573/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1573/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12833469 - PreCommit-HIVE-Build > Parallelize TestHCatStorer > -- > > Key: HIVE-14891 > URL: https://issues.apache.org/jira/browse/HIVE-14891 > Project: Hive > Issue Type: Sub-task > Components: HCatalog, Testing Infrastructure >Affects Versions: 2.1.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-14891.1.patch, HIVE-14891.1.patch, > HIVE-14891.1.patch > > > Currently TestHCatStorer runs as a parameterized test, where it runs the same > tests for each storage format but within the same junit test case. This > prevents it from being parallelized using ptest where parallelism granularity > is at a test case level. Instead of using parameterized tests, it makes sense > to create a new test case for each storage format. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14891) Parallelize TestHCatStorer
[ https://issues.apache.org/jira/browse/HIVE-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574692#comment-15574692 ] Hive QA commented on HIVE-14891: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12833289/HIVE-14891.1.patch {color:green}SUCCESS:{color} +1 due to 8 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 10522 tests executed *Failed tests:* {noformat} TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_globallimit] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[order_null] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[reloadJar] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_fast_stats] org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJarWithoutAddDriverClazz[0] org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[0] org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[1] org.apache.hive.jdbc.TestNoSaslAuth.org.apache.hive.jdbc.TestNoSaslAuth org.apache.hive.jdbc.authorization.TestHS2AuthzContext.org.apache.hive.jdbc.authorization.TestHS2AuthzContext org.apache.hive.jdbc.authorization.TestHS2AuthzSessionContext.org.apache.hive.jdbc.authorization.TestHS2AuthzSessionContext org.apache.hive.jdbc.authorization.TestJdbcMetadataApiAuth.org.apache.hive.jdbc.authorization.TestJdbcMetadataApiAuth org.apache.hive.jdbc.authorization.TestJdbcWithSQLAuthUDFBlacklist.testBlackListedUdfUsage org.apache.hive.jdbc.authorization.TestJdbcWithSQLAuthorization.org.apache.hive.jdbc.authorization.TestJdbcWithSQLAuthorization {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1559/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1559/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1559/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 14 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12833289 - PreCommit-HIVE-Build > Parallelize TestHCatStorer > -- > > Key: HIVE-14891 > URL: https://issues.apache.org/jira/browse/HIVE-14891 > Project: Hive > Issue Type: Sub-task > Components: HCatalog, Testing Infrastructure >Affects Versions: 2.1.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-14891.1.patch, HIVE-14891.1.patch > > > Currently TestHCatStorer runs as a parameterized test, where it runs the same > tests for each storage format but within the same junit test case. This > prevents it from being parallelized using ptest where parallelism granularity > is at a test case level. Instead of using parameterized tests, it makes sense > to create a new test case for each storage format. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14891) Parallelize TestHCatStorer
[ https://issues.apache.org/jira/browse/HIVE-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574000#comment-15574000 ] Hive QA commented on HIVE-14891: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12833268/HIVE-14891.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1553/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1553/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1553/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2016-10-14 03:11:13.999 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-1553/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2016-10-14 03:11:14.001 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 5353161 HIVE-14835: Improve ptest2 build time (Prasanth Jayachandran reviewed by Sergio Pena) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 5353161 HIVE-14835: Improve ptest2 build time (Prasanth Jayachandran reviewed by Sergio Pena) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2016-10-14 03:11:14.835 + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Going to apply patch with: patch -p1 patching file hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatStorerTest.java patching file hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestAvroHCatStorer.java patching file hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorer.java patching file hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorer.java patching file hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestParquetHCatStorer.java patching file hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestRCFileHCatStorer.java patching file hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestSequenceFileHCatStorer.java patching file hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatStorer.java + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven [ERROR] Failed to execute goal on project hive-shims-scheduler: Could not resolve dependencies for project org.apache.hive.shims:hive-shims-scheduler:jar:2.2.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.hadoop:hadoop-yarn-server-resourcemanager:jar:2.7.2, org.apache.hadoop:hadoop-yarn-server-nodemanager:jar:2.7.2: Failure to find org.apache.hadoop:hadoop-yarn-server-resourcemanager:jar:2.7.2 in http://www.datanucleus.org/downloads/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of datanucleus has elapsed or updates are forced -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1]
[jira] [Commented] (HIVE-14891) Parallelize TestHCatStorer
[ https://issues.apache.org/jira/browse/HIVE-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573989#comment-15573989 ] Hive QA commented on HIVE-14891: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12833268/HIVE-14891.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1552/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1552/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1552/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2016-10-14 03:04:58.615 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-1552/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2016-10-14 03:04:58.618 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 5353161 HIVE-14835: Improve ptest2 build time (Prasanth Jayachandran reviewed by Sergio Pena) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 5353161 HIVE-14835: Improve ptest2 build time (Prasanth Jayachandran reviewed by Sergio Pena) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2016-10-14 03:04:59.479 + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch /data/hiveptest/working/scratch/smart-apply-patch.sh: line 44: patch: command not found /data/hiveptest/working/scratch/smart-apply-patch.sh: line 82: patch: command not found /data/hiveptest/working/scratch/smart-apply-patch.sh: line 84: patch: command not found error: a/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorer.java: No such file or directory The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12833268 - PreCommit-HIVE-Build > Parallelize TestHCatStorer > -- > > Key: HIVE-14891 > URL: https://issues.apache.org/jira/browse/HIVE-14891 > Project: Hive > Issue Type: Sub-task > Components: HCatalog, Testing Infrastructure >Affects Versions: 2.1.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-14891.1.patch > > > Currently TestHCatStorer runs as a parameterized test, where it runs the same > tests for each storage format but within the same junit test case. This > prevents it from being parallelized using ptest where parallelism granularity > is at a test case level. Instead of using parameterized tests, it makes sense > to create a new test case for each storage format. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14891) Parallelize TestHCatStorer
[ https://issues.apache.org/jira/browse/HIVE-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573764#comment-15573764 ] Vaibhav Gumashta commented on HIVE-14891: - cc [~sseth] [~sushanth] > Parallelize TestHCatStorer > -- > > Key: HIVE-14891 > URL: https://issues.apache.org/jira/browse/HIVE-14891 > Project: Hive > Issue Type: Sub-task > Components: HCatalog, Testing Infrastructure >Affects Versions: 2.1.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-14891.1.patch > > > Currently TestHCatStorer runs as a parameterized test, where it runs the same > tests for each storage format but within the same junit test case. This > prevents it from being parallelized using ptest where parallelism granularity > is at a test case level. Instead of using parameterized tests, it makes sense > to create a new test case for each storage format. -- This message was sent by Atlassian JIRA (v6.3.4#6332)