[jira] [Commented] (HIVE-15013) Config dir generated for tests should not be under the test tmp directory
[ https://issues.apache.org/jira/browse/HIVE-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591007#comment-15591007 ] Siddharth Seth commented on HIVE-15013: --- Test failures are unrelated (HIVE-14964). Committing. Thanks for the review. > Config dir generated for tests should not be under the test tmp directory > - > > Key: HIVE-15013 > URL: https://issues.apache.org/jira/browse/HIVE-15013 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-15013.01.patch, HIVE-15013.02.patch > > > mvn is used to clean up tmp directories created for tests, and to setup the > config directory. The current structure is > target/tmp > target/tmp/config > All of this is setup when mvn test is executed. > Tests generate data under tmp - warehouse, metastore, etc. Having the conf > dir there (generated by mvn) makes it complicate to add per test cleanup - > since the entire tmp directory cannot be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15013) Config dir generated for tests should not be under the test tmp directory
[ https://issues.apache.org/jira/browse/HIVE-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15590986#comment-15590986 ] Prasanth Jayachandran commented on HIVE-15013: -- lgtm, +1 > Config dir generated for tests should not be under the test tmp directory > - > > Key: HIVE-15013 > URL: https://issues.apache.org/jira/browse/HIVE-15013 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-15013.01.patch, HIVE-15013.02.patch > > > mvn is used to clean up tmp directories created for tests, and to setup the > config directory. The current structure is > target/tmp > target/tmp/config > All of this is setup when mvn test is executed. > Tests generate data under tmp - warehouse, metastore, etc. Having the conf > dir there (generated by mvn) makes it complicate to add per test cleanup - > since the entire tmp directory cannot be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15013) Config dir generated for tests should not be under the test tmp directory
[ https://issues.apache.org/jira/browse/HIVE-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15590200#comment-15590200 ] Siddharth Seth commented on HIVE-15013: --- cc [~prasanth_j] for review. > Config dir generated for tests should not be under the test tmp directory > - > > Key: HIVE-15013 > URL: https://issues.apache.org/jira/browse/HIVE-15013 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-15013.01.patch, HIVE-15013.02.patch > > > mvn is used to clean up tmp directories created for tests, and to setup the > config directory. The current structure is > target/tmp > target/tmp/config > All of this is setup when mvn test is executed. > Tests generate data under tmp - warehouse, metastore, etc. Having the conf > dir there (generated by mvn) makes it complicate to add per test cleanup - > since the entire tmp directory cannot be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15013) Config dir generated for tests should not be under the test tmp directory
[ https://issues.apache.org/jira/browse/HIVE-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15590133#comment-15590133 ] Hive QA commented on HIVE-15013: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12834202/HIVE-15013.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10564 tests executed *Failed tests:* {noformat} TestBeelineWithHS2ConnectionFile - did not produce a TEST-*.xml file (likely timed out) (batchId=199) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJarWithoutAddDriverClazz[0] (batchId=157) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[0] (batchId=157) org.apache.hive.beeline.TestBeelineArgParsing.testAddLocalJar[1] (batchId=157) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1670/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1670/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1670/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12834202 - PreCommit-HIVE-Build > Config dir generated for tests should not be under the test tmp directory > - > > Key: HIVE-15013 > URL: https://issues.apache.org/jira/browse/HIVE-15013 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-15013.01.patch, HIVE-15013.02.patch > > > mvn is used to clean up tmp directories created for tests, and to setup the > config directory. The current structure is > target/tmp > target/tmp/config > All of this is setup when mvn test is executed. > Tests generate data under tmp - warehouse, metastore, etc. Having the conf > dir there (generated by mvn) makes it complicate to add per test cleanup - > since the entire tmp directory cannot be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15013) Config dir generated for tests should not be under the test tmp directory
[ https://issues.apache.org/jira/browse/HIVE-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588317#comment-15588317 ] Hive QA commented on HIVE-15013: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12834104/HIVE-15013.01.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1655/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1655/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1655/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2016-10-19 10:29:03.322 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-1655/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2016-10-19 10:29:03.324 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 044f1fa HIVE-14974: TestBeeLineHistory throws NPE in ShutdownHook (Prasanth Jayachandran reviewed by Siddharth Seth) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 044f1fa HIVE-14974: TestBeeLineHistory throws NPE in ShutdownHook (Prasanth Jayachandran reviewed by Siddharth Seth) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2016-10-19 10:29:04.274 + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Going to apply patch with: patch -p0 patching file pom.xml + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run (setup-test-dirs) on project hive: An Ant BuildException has occured: Syntax error in property: ${project.build.directory/testconf [ERROR] around Ant part .. @ 5:53 in /data/hiveptest/working/apache-github-source-source/target/antrun/build-main.xml [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12834104 - PreCommit-HIVE-Build > Config dir generated for tests should not be under the test tmp directory > - > > Key: HIVE-15013 > URL: https://issues.apache.org/jira/browse/HIVE-15013 > Project: Hive > Issue Type: Sub-task >Reporter: Siddharth Seth >Assignee: Siddharth Seth > Attachments: HIVE-15013.01.patch > > > mvn is used to clean up tmp directories created for tests, and to setup the > config directory. The current structure is > target/tmp > target/tmp/config > All of this is setup when mvn test is executed. > Tests generate data under tmp - warehouse, metastore, etc. Having the conf > dir there (generated by mvn) makes it complicate to add per test cleanup - > since the entire tmp directory cannot be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)