[jira] [Commented] (HIVE-15119) Support standard syntax for ROLLUP & CUBE
[ https://issues.apache.org/jira/browse/HIVE-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648133#comment-15648133 ] Vineet Garg commented on HIVE-15119: [~jcamachorodriguez] Yes that's my mistake. I wasn't able to apply your patch using patch or git apply so had to manually make changes and accidentally left an extra rule in grammar. I am updating the patch and will upload the new one > Support standard syntax for ROLLUP & CUBE > - > > Key: HIVE-15119 > URL: https://issues.apache.org/jira/browse/HIVE-15119 > Project: Hive > Issue Type: Task > Components: Parser, SQL >Reporter: Vineet Garg >Assignee: Vineet Garg > Attachments: HIVE-15119.03.patch, HIVE-15119.2.patch, > HIVE-15119.4.patch, HIVE-15119.patch > > > Standard ROLLUP and CUBE syntax is GROUP BY ROLLUP (expression list)... and > GROUP BY CUBE (expression list) respectively. > Currently HIVE only allows GROUP BY WITH ROLLUP/CUBE syntax. > > We would like HIVE to support standard ROLLUP/CUBE syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15119) Support standard syntax for ROLLUP & CUBE
[ https://issues.apache.org/jira/browse/HIVE-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646874#comment-15646874 ] Jesus Camacho Rodriguez commented on HIVE-15119: [~vgarg], there seem to be errors now that I did not see with the third patch. I saw an additional rule in the parser, i.e., _groupByExpressions_. Maybe that is the reason for those errors? I saw it is not referenced, why was it added? Thanks > Support standard syntax for ROLLUP & CUBE > - > > Key: HIVE-15119 > URL: https://issues.apache.org/jira/browse/HIVE-15119 > Project: Hive > Issue Type: Task > Components: Parser, SQL >Reporter: Vineet Garg >Assignee: Vineet Garg > Attachments: HIVE-15119.03.patch, HIVE-15119.2.patch, > HIVE-15119.4.patch, HIVE-15119.patch > > > Standard ROLLUP and CUBE syntax is GROUP BY ROLLUP (expression list)... and > GROUP BY CUBE (expression list) respectively. > Currently HIVE only allows GROUP BY WITH ROLLUP/CUBE syntax. > > We would like HIVE to support standard ROLLUP/CUBE syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15119) Support standard syntax for ROLLUP & CUBE
[
https://issues.apache.org/jira/browse/HIVE-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646825#comment-15646825
]
Hive QA commented on HIVE-15119:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12837912/HIVE-15119.4.patch
{color:green}SUCCESS:{color} +1 due to 16 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 18 failed/errored test(s), 10628 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_groupby]
(batchId=43)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_annotate_stats_groupby]
(batchId=76)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_cube_multi_gby]
(batchId=11)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_id3]
(batchId=24)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_sets1]
(batchId=62)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_sets6]
(batchId=64)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_sets_limit]
(batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_window]
(batchId=29)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_bucket_sort_grouping_operators]
(batchId=49)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_bulk]
(batchId=89)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_acid_non_acid]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats]
(batchId=145)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_4]
(batchId=91)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[groupby_grouping_sets1]
(batchId=83)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[groupby_grouping_sets2]
(batchId=83)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[groupby_grouping_sets3]
(batchId=83)
org.apache.hive.hcatalog.pig.TestAvroHCatStorer.testWriteDate2 (batchId=170)
org.apache.hive.hcatalog.pig.TestSequenceFileHCatStorer.testWriteTinyint
(batchId=170)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2020/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2020/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2020/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 18 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12837912 - PreCommit-HIVE-Build
> Support standard syntax for ROLLUP & CUBE
> -
>
> Key: HIVE-15119
> URL: https://issues.apache.org/jira/browse/HIVE-15119
> Project: Hive
> Issue Type: Task
> Components: Parser, SQL
>Reporter: Vineet Garg
>Assignee: Vineet Garg
> Attachments: HIVE-15119.03.patch, HIVE-15119.2.patch,
> HIVE-15119.4.patch, HIVE-15119.patch
>
>
> Standard ROLLUP and CUBE syntax is GROUP BY ROLLUP (expression list)... and
> GROUP BY CUBE (expression list) respectively.
> Currently HIVE only allows GROUP BY WITH ROLLUP/CUBE syntax.
>
> We would like HIVE to support standard ROLLUP/CUBE syntax.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15119) Support standard syntax for ROLLUP & CUBE
[ https://issues.apache.org/jira/browse/HIVE-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644820#comment-15644820 ] Vineet Garg commented on HIVE-15119: Thanks Jesus. I'll check and regenerate the q file changes > Support standard syntax for ROLLUP & CUBE > - > > Key: HIVE-15119 > URL: https://issues.apache.org/jira/browse/HIVE-15119 > Project: Hive > Issue Type: Task > Components: Parser, SQL >Reporter: Vineet Garg >Assignee: Vineet Garg > Attachments: HIVE-15119.03.patch, HIVE-15119.2.patch, HIVE-15119.patch > > > Standard ROLLUP and CUBE syntax is GROUP BY ROLLUP (expression list)... and > GROUP BY CUBE (expression list) respectively. > Currently HIVE only allows GROUP BY WITH ROLLUP/CUBE syntax. > > We would like HIVE to support standard ROLLUP/CUBE syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15119) Support standard syntax for ROLLUP & CUBE
[ https://issues.apache.org/jira/browse/HIVE-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644236#comment-15644236 ] Jesus Camacho Rodriguez commented on HIVE-15119: [~vgarg], latest patch should solve the issues you were experiencing. Could you check/regenerate the remaining q file changes in the latest ptest run? Thanks > Support standard syntax for ROLLUP & CUBE > - > > Key: HIVE-15119 > URL: https://issues.apache.org/jira/browse/HIVE-15119 > Project: Hive > Issue Type: Task > Components: Parser, SQL >Reporter: Vineet Garg >Assignee: Vineet Garg > Attachments: HIVE-15119.03.patch, HIVE-15119.2.patch, HIVE-15119.patch > > > Standard ROLLUP and CUBE syntax is GROUP BY ROLLUP (expression list)... and > GROUP BY CUBE (expression list) respectively. > Currently HIVE only allows GROUP BY WITH ROLLUP/CUBE syntax. > > We would like HIVE to support standard ROLLUP/CUBE syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15119) Support standard syntax for ROLLUP & CUBE
[
https://issues.apache.org/jira/browse/HIVE-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644207#comment-15644207
]
Hive QA commented on HIVE-15119:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12837733/HIVE-15119.03.patch
{color:green}SUCCESS:{color} +1 due to 16 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10628 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[columnstats_part_coltype]
(batchId=148)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_acid_non_acid]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats]
(batchId=145)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3]
(batchId=90)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_4]
(batchId=91)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_cube1]
(batchId=93)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_grouping_id2]
(batchId=107)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_rollup1]
(batchId=106)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2001/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2001/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2001/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12837733 - PreCommit-HIVE-Build
> Support standard syntax for ROLLUP & CUBE
> -
>
> Key: HIVE-15119
> URL: https://issues.apache.org/jira/browse/HIVE-15119
> Project: Hive
> Issue Type: Task
> Components: Parser, SQL
>Reporter: Vineet Garg
>Assignee: Vineet Garg
> Attachments: HIVE-15119.03.patch, HIVE-15119.2.patch, HIVE-15119.patch
>
>
> Standard ROLLUP and CUBE syntax is GROUP BY ROLLUP (expression list)... and
> GROUP BY CUBE (expression list) respectively.
> Currently HIVE only allows GROUP BY WITH ROLLUP/CUBE syntax.
>
> We would like HIVE to support standard ROLLUP/CUBE syntax.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15119) Support standard syntax for ROLLUP & CUBE
[
https://issues.apache.org/jira/browse/HIVE-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634008#comment-15634008
]
Hive QA commented on HIVE-15119:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12836899/HIVE-15119.patch
{color:green}SUCCESS:{color} +1 due to 16 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10628 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[subquery_in_having]
(batchId=52)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[subquery_unqualcolumnrefs]
(batchId=16)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_acid_non_acid]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats]
(batchId=145)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_cube1]
(batchId=93)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_grouping_id2]
(batchId=107)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_rollup1]
(batchId=106)
org.apache.hadoop.hive.ql.parse.TestParseDriver.testParse (batchId=250)
org.apache.hive.spark.client.TestSparkClient.testJobSubmission (batchId=272)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1951/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1951/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1951/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12836899 - PreCommit-HIVE-Build
> Support standard syntax for ROLLUP & CUBE
> -
>
> Key: HIVE-15119
> URL: https://issues.apache.org/jira/browse/HIVE-15119
> Project: Hive
> Issue Type: Task
> Components: Parser, SQL
>Reporter: Vineet Garg
>Assignee: Vineet Garg
> Attachments: HIVE-15119.patch
>
>
> Standard ROLLUP and CUBE syntax is GROUP BY ROLLUP (expression list)... and
> GROUP BY CUBE (expression list) respectively.
> Currently HIVE only allows GROUP BY WITH ROLLUP/CUBE syntax.
>
> We would like HIVE to support standard ROLLUP/CUBE syntax.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15119) Support standard syntax for ROLLUP & CUBE
[ https://issues.apache.org/jira/browse/HIVE-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633669#comment-15633669 ] Vineet Garg commented on HIVE-15119: cc [~jcamachorodriguez] > Support standard syntax for ROLLUP & CUBE > - > > Key: HIVE-15119 > URL: https://issues.apache.org/jira/browse/HIVE-15119 > Project: Hive > Issue Type: Task > Components: Parser, SQL >Reporter: Vineet Garg >Assignee: Vineet Garg > Attachments: HIVE-15119.patch > > > Standard ROLLUP and CUBE syntax is GROUP BY ROLLUP (expression list)... and > GROUP BY CUBE (expression list) respectively. > Currently HIVE only allows GROUP BY WITH ROLLUP/CUBE syntax. > > We would like HIVE to support standard ROLLUP/CUBE syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
