[jira] [Commented] (HIVE-15414) Fix batchSize for TestNegativeCliDriver
[
https://issues.apache.org/jira/browse/HIVE-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797363#comment-15797363
]
Siddharth Seth commented on HIVE-15414:
---
As [~pvary] pointed out, the batch size was increased to the excessive setup /
teardown cost - as compared to the actual time taken to run the tests. If the
single batch is taking 717 seconds, I think splitting this up would make sense
given we normally have some stragglers at the end, and a lot of empty nodes.
> Fix batchSize for TestNegativeCliDriver
> ---
>
> Key: HIVE-15414
> URL: https://issues.apache.org/jira/browse/HIVE-15414
> Project: Hive
> Issue Type: Sub-task
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
>
> While analyzing the console output of pre-commit console logs, I noticed that
> TestNegativeCliDriver batchSize ~770 qfiles which doesn't look right.
> 2016-12-09 22:23:58,945 DEBUG [TestExecutor] ExecutionPhase.execute:96
> PBatch: QFileTestBatch [batchId=84, size=774, driver=TestNegativeCliDriver,
> queryFilesProperty=qfile,
> name=84-TestNegativeCliDriver-nopart_insert.q-input41.q-having1.q-and-771-more..
>
> I think {{qFileTest.clientNegative.batchSize = 1000}} in
> {{test-configuration2.properties}} is probably the reason.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15414) Fix batchSize for TestNegativeCliDriver
[
https://issues.apache.org/jira/browse/HIVE-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755766#comment-15755766
]
Vihang Karajgaonkar commented on HIVE-15414:
Hi [~spena] I checked the results on couple of the latest pre-commit runs. Each
batch of TestNegativeCliDriver now takes between ~400-470 sec which is about
~250-300 sec faster for this batch when compared to before.
[pre-commit-2614 | https://builds.apache.org/job/PreCommit-HIVE-Build/2614/]
{noformat}
2016-12-16 19:22:08,193 INFO [HostExecutor 26] LocalCommand.:45 Starting
LocalCommandId=273266: ssh -v -i /home/hiveptest/.ssh/hive-ptest-user-key -l
hiveptest 107.178.216.213 'bash
/home/hiveptest/107.178.216.213-hiveptest-1/scratch/hiveptest-84-TestNegativeCliDriver-nopart_insert.q-insert_into_with_schema.q-input41.q-and-397-more.sh'
2016-12-16 19:22:08,924 INFO [HostExecutor 39] LocalCommand.:45 Starting
LocalCommandId=273268: ssh -v -i /home/hiveptest/.ssh/hive-ptest-user-key -l
hiveptest 104.154.143.187 'bash
/home/hiveptest/104.154.143.187-hiveptest-0/scratch/hiveptest-85-TestNegativeCliDriver-udf_array_contains_wrong2.q-udf_invalid.q-authorization_rolehierarchy_privs.q-and-374-more.sh'
2016-12-16 19:29:02,702 INFO [HostExecutor 39]
LocalCommand.awaitProcessCompletion:67 Finished LocalCommandId=273268.
ElapsedTime(ms)=413777
2016-12-16 19:30:00,510 INFO [HostExecutor 26]
LocalCommand.awaitProcessCompletion:67 Finished LocalCommandId=273266.
ElapsedTime(ms)=472316
{noformat}
[pre-commit-2613 | https://builds.apache.org/job/PreCommit-HIVE-Build/2613/]
{noformat}
2016-12-16 18:36:15,845 INFO [HostExecutor 36] LocalCommand.:45 Starting
LocalCommandId=272258: ssh -v -i /home/hiveptest/.ssh/hive-ptest-user-key -l
hiveptest 35.184.12.165 'bash
/home/hiveptest/35.184.12.165-hiveptest-1/scratch/hiveptest-84-TestNegativeCliDriver-nopart_insert.q-insert_into_with_schema.q-input41.q-and-397-more.sh'
2016-12-16 18:36:16,066 INFO [HostExecutor 13] LocalCommand.:45 Starting
LocalCommandId=272259: ssh -v -i /home/hiveptest/.ssh/hive-ptest-user-key -l
hiveptest 104.154.143.187 'bash
/home/hiveptest/104.154.143.187-hiveptest-0/scratch/hiveptest-85-TestNegativeCliDriver-udf_array_contains_wrong2.q-udf_invalid.q-authorization_rolehierarchy_privs.q-and-370-more.sh'
2016-12-16 18:43:29,647 INFO [HostExecutor 36]
HostExecutor.executeTestBatch:261 Completed executing tests for batch
[84-TestNegativeCliDriver-nopart_insert.q-insert_into_with_schema.q-input41.q-and-397-more]
on host 35.184.12.165. ElapsedTime(ms)=433802
2016-12-16 18:42:53,365 INFO [HostExecutor 13]
HostExecutor.executeTestBatch:261 Completed executing tests for batch
[85-TestNegativeCliDriver-udf_array_contains_wrong2.q-udf_invalid.q-authorization_rolehierarchy_privs.q-and-370-more]
on host 104.154.143.187. ElapsedTime(ms)=397299
{noformat}
> Fix batchSize for TestNegativeCliDriver
> ---
>
> Key: HIVE-15414
> URL: https://issues.apache.org/jira/browse/HIVE-15414
> Project: Hive
> Issue Type: Sub-task
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
>
> While analyzing the console output of pre-commit console logs, I noticed that
> TestNegativeCliDriver batchSize ~770 qfiles which doesn't look right.
> 2016-12-09 22:23:58,945 DEBUG [TestExecutor] ExecutionPhase.execute:96
> PBatch: QFileTestBatch [batchId=84, size=774, driver=TestNegativeCliDriver,
> queryFilesProperty=qfile,
> name=84-TestNegativeCliDriver-nopart_insert.q-input41.q-having1.q-and-771-more..
>
> I think {{qFileTest.clientNegative.batchSize = 1000}} in
> {{test-configuration2.properties}} is probably the reason.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15414) Fix batchSize for TestNegativeCliDriver
[
https://issues.apache.org/jira/browse/HIVE-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742752#comment-15742752
]
Sergio Peña commented on HIVE-15414:
Thanks. I did the change on the profile to use 400
qFileTest.clientNegative.driver = TestNegativeCliDriver
qFileTest.clientNegative.directory = ql/src/test/queries/clientnegative
qFileTest.clientNegative.batchSize = 400
We should see the results later after the last Jenkins build finishes.
> Fix batchSize for TestNegativeCliDriver
> ---
>
> Key: HIVE-15414
> URL: https://issues.apache.org/jira/browse/HIVE-15414
> Project: Hive
> Issue Type: Sub-task
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
>
> While analyzing the console output of pre-commit console logs, I noticed that
> TestNegativeCliDriver batchSize ~770 qfiles which doesn't look right.
> 2016-12-09 22:23:58,945 DEBUG [TestExecutor] ExecutionPhase.execute:96
> PBatch: QFileTestBatch [batchId=84, size=774, driver=TestNegativeCliDriver,
> queryFilesProperty=qfile,
> name=84-TestNegativeCliDriver-nopart_insert.q-input41.q-having1.q-and-771-more..
>
> I think {{qFileTest.clientNegative.batchSize = 1000}} in
> {{test-configuration2.properties}} is probably the reason.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15414) Fix batchSize for TestNegativeCliDriver
[
https://issues.apache.org/jira/browse/HIVE-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742728#comment-15742728
]
Vihang Karajgaonkar commented on HIVE-15414:
Thanks [~pvary]. I think you may be right but I thought of checking it either
ways in the hope that it might improve the run time further :)
[~spena] Based on these logs on the latest run:
2016-12-12 17:21:30,903 INFO [HostExecutor 46] LocalCommand.:45 Starting
LocalCommandId=205113: ssh -v -i /home/hiveptest/.ssh/hive-ptest-user-key -l
hiveptest 104.154.105.18 'bash
/home/hiveptest/104.154.105.18-hiveptest-0/scratch/hiveptest-84-TestNegativeCliDriver-nopart_insert.q-input41.q-having1.q-and-771-more.sh'
2016-12-12 17:33:28,341 INFO [HostExecutor 46]
LocalCommand.awaitProcessCompletion:67 Finished LocalCommandId=205113.
ElapsedTime(ms)=717437
2016-12-12 17:33:28,341 INFO [HostExecutor 46]
HostExecutor.executeTestBatch:261 Completed executing tests for batch
[84-TestNegativeCliDriver-nopart_insert.q-input41.q-having1.q-and-771-more] on
host 104.154.105.18. ElapsedTime(ms)=717437
It takes about ~700 sec.
I did a quick search of the logs and it looks like most other batches take
between 200-300 sec so we may see some benefits if we reduce the limit from
1000 to 400 so that the tests are divided into 2 batches.
> Fix batchSize for TestNegativeCliDriver
> ---
>
> Key: HIVE-15414
> URL: https://issues.apache.org/jira/browse/HIVE-15414
> Project: Hive
> Issue Type: Sub-task
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
>
> While analyzing the console output of pre-commit console logs, I noticed that
> TestNegativeCliDriver batchSize ~770 qfiles which doesn't look right.
> 2016-12-09 22:23:58,945 DEBUG [TestExecutor] ExecutionPhase.execute:96
> PBatch: QFileTestBatch [batchId=84, size=774, driver=TestNegativeCliDriver,
> queryFilesProperty=qfile,
> name=84-TestNegativeCliDriver-nopart_insert.q-input41.q-having1.q-and-771-more..
>
> I think {{qFileTest.clientNegative.batchSize = 1000}} in
> {{test-configuration2.properties}} is probably the reason.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15414) Fix batchSize for TestNegativeCliDriver
[
https://issues.apache.org/jira/browse/HIVE-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742416#comment-15742416
]
Sergio Peña commented on HIVE-15414:
How much does it take for the drone to run all negative tests in our Jenkins
job?
> Fix batchSize for TestNegativeCliDriver
> ---
>
> Key: HIVE-15414
> URL: https://issues.apache.org/jira/browse/HIVE-15414
> Project: Hive
> Issue Type: Sub-task
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
>
> While analyzing the console output of pre-commit console logs, I noticed that
> TestNegativeCliDriver batchSize ~770 qfiles which doesn't look right.
> 2016-12-09 22:23:58,945 DEBUG [TestExecutor] ExecutionPhase.execute:96
> PBatch: QFileTestBatch [batchId=84, size=774, driver=TestNegativeCliDriver,
> queryFilesProperty=qfile,
> name=84-TestNegativeCliDriver-nopart_insert.q-input41.q-having1.q-and-771-more..
>
> I think {{qFileTest.clientNegative.batchSize = 1000}} in
> {{test-configuration2.properties}} is probably the reason.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15414) Fix batchSize for TestNegativeCliDriver
[
https://issues.apache.org/jira/browse/HIVE-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741640#comment-15741640
]
Peter Vary commented on HIVE-15414:
---
Hi [~vihangk1],
The negative tests are very-very fast, since they do not change anything on the
underlying database. Typically they are subsecond tests. There are some 20s
long ones, but the whole group could be run in ~15 min on my laptop. The
biggest time sink is the test setup and teardown.
I think this is the reason why these tests are run on a single Drone.
But of course I do not know the history of the ptest framework, so I might be
wrong here, so it would be good if the others could clarify this.
Thanks,
Peter
> Fix batchSize for TestNegativeCliDriver
> ---
>
> Key: HIVE-15414
> URL: https://issues.apache.org/jira/browse/HIVE-15414
> Project: Hive
> Issue Type: Sub-task
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
>
> While analyzing the console output of pre-commit console logs, I noticed that
> TestNegativeCliDriver batchSize ~770 qfiles which doesn't look right.
> 2016-12-09 22:23:58,945 DEBUG [TestExecutor] ExecutionPhase.execute:96
> PBatch: QFileTestBatch [batchId=84, size=774, driver=TestNegativeCliDriver,
> queryFilesProperty=qfile,
> name=84-TestNegativeCliDriver-nopart_insert.q-input41.q-having1.q-and-771-more..
>
> I think {{qFileTest.clientNegative.batchSize = 1000}} in
> {{test-configuration2.properties}} is probably the reason.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15414) Fix batchSize for TestNegativeCliDriver
[
https://issues.apache.org/jira/browse/HIVE-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736979#comment-15736979
]
Vihang Karajgaonkar commented on HIVE-15414:
[~sseth] [~spena] Do you know if batchSize is kept as 1000 intentionally?
> Fix batchSize for TestNegativeCliDriver
> ---
>
> Key: HIVE-15414
> URL: https://issues.apache.org/jira/browse/HIVE-15414
> Project: Hive
> Issue Type: Sub-task
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Minor
>
> While analyzing the console output of pre-commit console logs, I noticed that
> TestNegativeCliDriver batchSize ~770 qfiles which doesn't look right.
> 2016-12-09 22:23:58,945 DEBUG [TestExecutor] ExecutionPhase.execute:96
> PBatch: QFileTestBatch [batchId=84, size=774, driver=TestNegativeCliDriver,
> queryFilesProperty=qfile,
> name=84-TestNegativeCliDriver-nopart_insert.q-input41.q-having1.q-and-771-more..
>
> I think {{qFileTest.clientNegative.batchSize = 1000}} in
> {{test-configuration2.properties}} is probably the batchSize is the reason.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
