[jira] [Commented] (HIVE-15436) Enhancing metastore APIs to retrieve only materialized views
[ https://issues.apache.org/jira/browse/HIVE-15436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326584#comment-16326584 ] Daniel Dai commented on HIVE-15436: --- Hit some error after the patch, seems we need the following change: {code:java} --- a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java +++ b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java @@ -408,8 +408,8 @@ public Database getDatabase(String dbName) throws MetaException{ queryParams, pms.toArray(), queryText)); if (!sqlResult.isEmpty()) { - for (Object[] line : sqlResult) { - ret.add(extractSqlString(line[0])); + for (Object line : sqlResult) { + ret.add(extractSqlString(line)); } } return ret; {code} > Enhancing metastore APIs to retrieve only materialized views > > > Key: HIVE-15436 > URL: https://issues.apache.org/jira/browse/HIVE-15436 > Project: Hive > Issue Type: Sub-task > Components: Materialized views >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-15436.patch > > > Enhancing metastore APIs such that, instead of returning all tables, it can > return only: > - views > - materialized views -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-15436) Enhancing metastore APIs to retrieve only materialized views
[ https://issues.apache.org/jira/browse/HIVE-15436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254216#comment-16254216 ] Aihua Xu commented on HIVE-15436: - [~jcamachorodriguez] Seems the query for getTables call is not correct. There is an extra ','. See the failure https://builds.apache.org/job/PreCommit-HIVE-Build/7812/testReport/org.apache.hadoop.hive.cli/TestAccumuloCliDriver/testCliDriver_accumulo_queries_/. {noformat} 2017-11-14T15:35:09,416 WARN [main] metastore.MetaStoreDirectSql: Failed to execute [SELECT "TBLS"."TBL_NAME", FROM "TBLS" INNER JOIN "DBS" ON "TBLS"."DB_ID" = "DBS"."DB_ID" WHERE "DBS"."NAME" = ? ] with parameters [default] javax.jdo.JDODataStoreException: Error executing SQL query "SELECT "TBLS"."TBL_NAME", FROM "TBLS" INNER JOIN "DBS" ON "TBLS"."DB_ID" = "DBS"."DB_ID" WHERE "DBS"."NAME" = ?". {noformat} > Enhancing metastore APIs to retrieve only materialized views > > > Key: HIVE-15436 > URL: https://issues.apache.org/jira/browse/HIVE-15436 > Project: Hive > Issue Type: Sub-task > Components: Materialized views >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez > Fix For: 3.0.0 > > Attachments: HIVE-15436.patch > > > Enhancing metastore APIs such that, instead of returning all tables, it can > return only: > - views > - materialized views -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-15436) Enhancing metastore APIs to retrieve only materialized views
[ https://issues.apache.org/jira/browse/HIVE-15436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250586#comment-16250586 ] Ashutosh Chauhan commented on HIVE-15436: - Please remove unneeded public method. +1 pending that change. > Enhancing metastore APIs to retrieve only materialized views > > > Key: HIVE-15436 > URL: https://issues.apache.org/jira/browse/HIVE-15436 > Project: Hive > Issue Type: Sub-task > Components: Materialized views >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez > Attachments: HIVE-15436.patch > > > Enhancing metastore APIs such that, instead of returning all tables, it can > return only: > - views > - materialized views -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-15436) Enhancing metastore APIs to retrieve only materialized views
[ https://issues.apache.org/jira/browse/HIVE-15436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250241#comment-16250241 ] Hive QA commented on HIVE-15436: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12897357/HIVE-15436.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 11374 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2] (batchId=47) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dbtxnmgr_showlocks] (batchId=77) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] (batchId=146) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=156) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=102) org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc] (batchId=94) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=111) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=206) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7791/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7791/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7791/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 10 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12897357 - PreCommit-HIVE-Build > Enhancing metastore APIs to retrieve only materialized views > > > Key: HIVE-15436 > URL: https://issues.apache.org/jira/browse/HIVE-15436 > Project: Hive > Issue Type: Sub-task > Components: Materialized views >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez > Attachments: HIVE-15436.patch > > > Enhancing metastore APIs such that, instead of returning all tables, it can > return only: > - views > - materialized views -- This message was sent by Atlassian JIRA (v6.4.14#64029)