[jira] [Commented] (HIVE-15558) fix char whitespace handling for vectorization
[ https://issues.apache.org/jira/browse/HIVE-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812769#comment-15812769 ] Matt McCline commented on HIVE-15558: - For this change, +1 LGTM. > fix char whitespace handling for vectorization > -- > > Key: HIVE-15558 > URL: https://issues.apache.org/jira/browse/HIVE-15558 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-15558.01.patch, HIVE-15558.02.patch, > HIVE-15558.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15558) fix char whitespace handling for vectorization
[ https://issues.apache.org/jira/browse/HIVE-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812768#comment-15812768 ] Matt McCline commented on HIVE-15558: - Ok, for the changes in schema_evol_text_vec_table.q The test for table_change_string_group_string_group_string takes input STRING columns and converts to CHAR / VARCHAR. For example, for insert_num 102, the STRINGs are "ox". The changed output shows more CHAR fields being padded out. Comparing schema_evol_text_vec_table.q.out to schema_evol_text_nonvec_table.q.out shows no real differences. Same for schema_evol_text_vecrow_table.q.out However, it has me wonder if there are other places where this is broken in vectorization. > fix char whitespace handling for vectorization > -- > > Key: HIVE-15558 > URL: https://issues.apache.org/jira/browse/HIVE-15558 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-15558.01.patch, HIVE-15558.02.patch, > HIVE-15558.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15558) fix char whitespace handling for vectorization
[
https://issues.apache.org/jira/browse/HIVE-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806709#comment-15806709
]
Hive QA commented on HIVE-15558:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12846134/HIVE-15558.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 10918 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=233)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[case_sensitivity]
(batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input_testxpath]
(batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_coalesce]
(batchId=75)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=134)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a]
(batchId=135)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part]
(batchId=148)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_primitive]
(batchId=149)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_primitive]
(batchId=149)
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testWriteVarchar
(batchId=172)
org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery
(batchId=215)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2829/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2829/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2829/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 12 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12846134 - PreCommit-HIVE-Build
> fix char whitespace handling for vectorization
> --
>
> Key: HIVE-15558
> URL: https://issues.apache.org/jira/browse/HIVE-15558
> Project: Hive
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-15558.01.patch, HIVE-15558.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15558) fix char whitespace handling for vectorization
[
https://issues.apache.org/jira/browse/HIVE-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806542#comment-15806542
]
Hive QA commented on HIVE-15558:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12846134/HIVE-15558.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 13 failed/errored test(s), 10904 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=233)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[case_sensitivity]
(batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input_testxpath]
(batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_coalesce]
(batchId=75)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_llap_counters]
(batchId=136)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a]
(batchId=135)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[offset_limit_ppd_optimizer]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part]
(batchId=148)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_primitive]
(batchId=149)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_primitive]
(batchId=149)
org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver
(batchId=96)
org.apache.hive.service.server.TestHS2HttpServer.testContextRootUrlRewrite
(batchId=185)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2827/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2827/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2827/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 13 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12846134 - PreCommit-HIVE-Build
> fix char whitespace handling for vectorization
> --
>
> Key: HIVE-15558
> URL: https://issues.apache.org/jira/browse/HIVE-15558
> Project: Hive
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-15558.01.patch, HIVE-15558.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15558) fix char whitespace handling for vectorization
[ https://issues.apache.org/jira/browse/HIVE-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806229#comment-15806229 ] Sergey Shelukhin commented on HIVE-15558: - [~mmccline] can you take a look? Some other out files might need updated, we'll see what fails. > fix char whitespace handling for vectorization > -- > > Key: HIVE-15558 > URL: https://issues.apache.org/jira/browse/HIVE-15558 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-15558.01.patch, HIVE-15558.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
