[jira] [Commented] (HIVE-15826) Add 'serialization.encoding' To All SerDes

2023-02-28 Thread Shailesh Gupta (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694459#comment-17694459
 ] 

Shailesh Gupta commented on HIVE-15826:
---

[~abstractdog] [~kkasa] Can you please review the PR?

> Add 'serialization.encoding' To All SerDes
> --
>
> Key: HIVE-15826
> URL: https://issues.apache.org/jira/browse/HIVE-15826
> Project: Hive
>  Issue Type: Improvement
>  Components: Serializers/Deserializers
>Reporter: David Mollitor
>Assignee: Teddy Choi
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-15826.1.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The feature of 'serialization.encoding' has been implemented for the 
> following SerDes:
> MultiDelimitSerDe, LazySimpleSerDe
> Please extend this feature to:
> JSON, CSV, and RegexSerDe



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HIVE-15826) Add 'serialization.encoding' To All SerDes

2023-02-27 Thread Shailesh Gupta (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693866#comment-17693866
 ] 

Shailesh Gupta commented on HIVE-15826:
---

[~teddy.choi] [~belugabehr]  Is it ok if i update the patch and submit pr?

> Add 'serialization.encoding' To All SerDes
> --
>
> Key: HIVE-15826
> URL: https://issues.apache.org/jira/browse/HIVE-15826
> Project: Hive
>  Issue Type: Improvement
>  Components: Serializers/Deserializers
>Reporter: David Mollitor
>Assignee: Teddy Choi
>Priority: Major
> Attachments: HIVE-15826.1.patch
>
>
> The feature of 'serialization.encoding' has been implemented for the 
> following SerDes:
> MultiDelimitSerDe, LazySimpleSerDe
> Please extend this feature to:
> JSON, CSV, and RegexSerDe



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HIVE-15826) Add 'serialization.encoding' To All SerDes

2019-10-15 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952373#comment-16952373
 ] 

Hive QA commented on HIVE-15826:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12854897/HIVE-15826.1.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19005/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19005/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19005/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-10-15 23:23:37.435
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-19005/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-10-15 23:23:37.438
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at fbabad1 HIVE-22239: Scale data size using column value ranges 
(Jesus Camacho Rodriguez, reviewed by Zoltan Haindrich)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at fbabad1 HIVE-22239: Scale data size using column value ranges 
(Jesus Camacho Rodriguez, reviewed by Zoltan Haindrich)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-10-15 23:23:38.639
+ rm -rf ../yetus_PreCommit-HIVE-Build-19005
+ mkdir ../yetus_PreCommit-HIVE-Build-19005
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-19005
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-19005/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: patch failed: contrib/src/test/queries/clientpositive/serde_regex.q:39
Falling back to three-way merge...
Applied patch to 'contrib/src/test/queries/clientpositive/serde_regex.q' with 
conflicts.
error: patch failed: 
hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/JsonSerDe.java:38
Falling back to three-way merge...
Applied patch to 
'hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/JsonSerDe.java' with 
conflicts.
error: patch failed: ql/src/test/queries/clientpositive/json_serde1.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/json_serde1.q' with 
conflicts.
error: patch failed: ql/src/test/results/clientpositive/json_serde1.q.out:6
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/json_serde1.q.out' with 
conflicts.
error: patch failed: ql/src/test/results/clientpositive/serde_opencsv.q.out:12
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/serde_opencsv.q.out' with 
conflicts.
Going to apply patch with: git apply -p0
error: patch failed: contrib/src/test/queries/clientpositive/serde_regex.q:39
Falling back to three-way merge...
Applied patch to 'contrib/src/test/queries/clientpositive/serde_regex.q' with 
conflicts.
error: patch failed: 
hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/JsonSerDe.java:38
Falling back to three-way merge...
Applied patch to 
'hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/JsonSerDe.java' with 
conflicts.
error: patch failed: ql/src/test/queries/clientpositive/json_serde1.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/json_serde1.q' with 
conflicts.
error: patch failed: ql/src/test/results/clientpositive/json_serde1.q.out:6
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/json_serde1.q.out' with 
conflicts.

[jira] [Commented] (HIVE-15826) Add 'serialization.encoding' To All SerDes

2018-01-11 Thread BELUGA BEHR (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322677#comment-16322677
 ] 

BELUGA BEHR commented on HIVE-15826:


[~teddy.choi] Any chance of updating the patch? :)

> Add 'serialization.encoding' To All SerDes
> --
>
> Key: HIVE-15826
> URL: https://issues.apache.org/jira/browse/HIVE-15826
> Project: Hive
>  Issue Type: Improvement
>  Components: Serializers/Deserializers
>Reporter: BELUGA BEHR
>Assignee: Teddy Choi
> Attachments: HIVE-15826.1.patch
>
>
> The feature of 'serialization.encoding' has been implemented for the 
> following SerDes:
> MultiDelimitSerDe, LazySimpleSerDe
> Please extend this feature to:
> JSON, CSV, and RegexSerDe



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-15826) Add 'serialization.encoding' To All SerDes

2018-01-11 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322087#comment-16322087
 ] 

Hive QA commented on HIVE-15826:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12854897/HIVE-15826.1.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8567/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8567/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8567/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-01-11 11:40:55.165
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-8567/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-01-11 11:40:55.168
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at f0dc5c6 HIVE-18400 : load data should rename files consistent 
with insert statements (bucketed tables only) Part2 (Deepak Jaiswal, reviewed 
by Eugene Koifman)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at f0dc5c6 HIVE-18400 : load data should rename files consistent 
with insert statements (bucketed tables only) Part2 (Deepak Jaiswal, reviewed 
by Eugene Koifman)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-01-11 11:40:59.097
+ rm -rf ../yetus
+ mkdir ../yetus
+ cp -R . ../yetus
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-8567/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: patch failed: contrib/src/test/queries/clientpositive/serde_regex.q:39
Falling back to three-way merge...
Applied patch to 'contrib/src/test/queries/clientpositive/serde_regex.q' with 
conflicts.
Going to apply patch with: git apply -p0
error: patch failed: contrib/src/test/queries/clientpositive/serde_regex.q:39
Falling back to three-way merge...
Applied patch to 'contrib/src/test/queries/clientpositive/serde_regex.q' with 
conflicts.
U contrib/src/test/queries/clientpositive/serde_regex.q
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12854897 - PreCommit-HIVE-Build

> Add 'serialization.encoding' To All SerDes
> --
>
> Key: HIVE-15826
> URL: https://issues.apache.org/jira/browse/HIVE-15826
> Project: Hive
>  Issue Type: Improvement
>  Components: Serializers/Deserializers
>Reporter: BELUGA BEHR
>Assignee: Teddy Choi
> Attachments: HIVE-15826.1.patch
>
>
> The feature of 'serialization.encoding' has been implemented for the 
> following SerDes:
> MultiDelimitSerDe, LazySimpleSerDe
> Please extend this feature to:
> JSON, CSV, and RegexSerDe



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-15826) Add 'serialization.encoding' To All SerDes

2018-01-10 Thread BELUGA BEHR (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321162#comment-16321162
 ] 

BELUGA BEHR commented on HIVE-15826:


[~teddy.choi] Thanks. :)

[~pvary] [~aihuaxu] Any thoughts?

> Add 'serialization.encoding' To All SerDes
> --
>
> Key: HIVE-15826
> URL: https://issues.apache.org/jira/browse/HIVE-15826
> Project: Hive
>  Issue Type: Improvement
>  Components: Serializers/Deserializers
>Reporter: BELUGA BEHR
>Assignee: Teddy Choi
> Attachments: HIVE-15826.1.patch
>
>
> The feature of 'serialization.encoding' has been implemented for the 
> following SerDes:
> MultiDelimitSerDe, LazySimpleSerDe
> Please extend this feature to:
> JSON, CSV, and RegexSerDe



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-15826) Add 'serialization.encoding' To All SerDes

2017-04-10 Thread David (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962937#comment-15962937
 ] 

David commented on HIVE-15826:
--

Could you add column coments in CSV SerDe just like in RegexSerDe?

> Add 'serialization.encoding' To All SerDes
> --
>
> Key: HIVE-15826
> URL: https://issues.apache.org/jira/browse/HIVE-15826
> Project: Hive
>  Issue Type: Improvement
>  Components: Serializers/Deserializers
>Reporter: BELUGA BEHR
>Assignee: Teddy Choi
> Attachments: HIVE-15826.1.patch
>
>
> The feature of 'serialization.encoding' has been implemented for the 
> following SerDes:
> MultiDelimitSerDe, LazySimpleSerDe
> Please extend this feature to:
> JSON, CSV, and RegexSerDe



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)