[jira] [Commented] (HIVE-15969) Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
[
https://issues.apache.org/jira/browse/HIVE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872531#comment-15872531
]
Hive QA commented on HIVE-15969:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12853307/HIVE-15969.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10244 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_auto_join1]
(batchId=3)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_arithmetic]
(batchId=43)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join31] (batchId=81)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin2]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=140)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=223)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join31]
(batchId=133)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3631/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3631/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3631/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12853307 - PreCommit-HIVE-Build
> Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
> ---
>
> Key: HIVE-15969
> URL: https://issues.apache.org/jira/browse/HIVE-15969
> Project: Hive
> Issue Type: Sub-task
>Affects Versions: 2.2.0
>Reporter: Thejas M Nair
>Assignee: slim bouguerra
> Attachments: HIVE-15969.2.patch, HIVE-15969.patch
>
>
> Looks like the additional failures in TestRemoteHiveMetaStore,
> TestSetUGIOnOnlyServer
> are related to this patch in HIVE-15877.
> I don't think that change was intended.
> {code}
> ---
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> +++
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext
> envContext) throws Already
> hook.commitCreateTable(tbl);
>}
>success = true;
> -} finally {
> +} catch (Exception e){
> + LOG.error("Got exception from createTable", e);
> +}
> +finally {
>if (!success && (hook != null)) {
> hook.rollbackCreateTable(tbl);
>}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-15969) Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
[
https://issues.apache.org/jira/browse/HIVE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872464#comment-15872464
]
Hive QA commented on HIVE-15969:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12853301/HIVE-15969.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 30 failed/errored test(s), 10244 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_auto_join1]
(batchId=3)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_arithmetic]
(batchId=43)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join31] (batchId=81)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin2]
(batchId=152)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[create_external_acid]
(batchId=86)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[create_not_acid]
(batchId=86)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[create_view_failure1]
(batchId=85)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[create_view_failure2]
(batchId=85)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[external1]
(batchId=85)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=223)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23]
(batchId=223)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join31]
(batchId=133)
org.apache.hadoop.hive.metastore.TestEmbeddedHiveMetaStore.testAlterTable
(batchId=194)
org.apache.hadoop.hive.metastore.TestEmbeddedHiveMetaStore.testTransactionalValidation
(batchId=194)
org.apache.hadoop.hive.metastore.TestRemoteHiveMetaStore.testAlterTable
(batchId=197)
org.apache.hadoop.hive.metastore.TestRemoteHiveMetaStore.testTransactionalValidation
(batchId=197)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testAlterTable
(batchId=193)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testTransactionalValidation
(batchId=193)
org.apache.hadoop.hive.metastore.TestSetUGIOnOnlyClient.testAlterTable
(batchId=191)
org.apache.hadoop.hive.metastore.TestSetUGIOnOnlyClient.testTransactionalValidation
(batchId=191)
org.apache.hadoop.hive.metastore.TestSetUGIOnOnlyServer.testAlterTable
(batchId=202)
org.apache.hadoop.hive.metastore.TestSetUGIOnOnlyServer.testTransactionalValidation
(batchId=202)
org.apache.hadoop.hive.ql.security.TestMetastoreAuthorizationProvider.testSimplePrivileges
(batchId=210)
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationProvider.testSimplePrivileges
(batchId=208)
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationProviderWithACL.testSimplePrivileges
(batchId=220)
org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgressParallel
(batchId=211)
org.apache.hive.hcatalog.api.TestHCatClient.testBasicDDLCommands (batchId=170)
org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure (batchId=170)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3630/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3630/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3630/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 30 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12853301 - PreCommit-HIVE-Build
> Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
> ---
>
> Key: HIVE-15969
> URL: https://issues.apache.org/jira/browse/HIVE-15969
> Project: Hive
> Issue Type: Sub-task
>Affects Versions: 2.2.0
>Reporter: Thejas M Nair
>Assignee: slim bouguerra
> Attachments: HIVE-15969.2.patch, HIVE-15969.patch
>
>
> Looks like the additional failures in TestRemoteHiveMetaStore,
> TestSetUGIOnOnlyServer
> are related to this patch in HIVE-15877.
> I don't think that change was intended.
> {code}
> ---
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> +++
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext
> envContext) throws Already
> hook.commitCreateTable(tb
[jira] [Commented] (HIVE-15969) Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
[
https://issues.apache.org/jira/browse/HIVE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872430#comment-15872430
]
Thejas M Nair commented on HIVE-15969:
--
+1
> Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
> ---
>
> Key: HIVE-15969
> URL: https://issues.apache.org/jira/browse/HIVE-15969
> Project: Hive
> Issue Type: Sub-task
>Affects Versions: 2.2.0
>Reporter: Thejas M Nair
>Assignee: slim bouguerra
> Attachments: HIVE-15969.2.patch, HIVE-15969.patch
>
>
> Looks like the additional failures in TestRemoteHiveMetaStore,
> TestSetUGIOnOnlyServer
> are related to this patch in HIVE-15877.
> I don't think that change was intended.
> {code}
> ---
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> +++
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext
> envContext) throws Already
> hook.commitCreateTable(tbl);
>}
>success = true;
> -} finally {
> +} catch (Exception e){
> + LOG.error("Got exception from createTable", e);
> +}
> +finally {
>if (!success && (hook != null)) {
> hook.rollbackCreateTable(tbl);
>}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-15969) Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
[
https://issues.apache.org/jira/browse/HIVE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872386#comment-15872386
]
slim bouguerra commented on HIVE-15969:
---
After talking with [~thejas] offline we decided it is better to catch the
exception from the final block and bubble up the exception from the create
table function.
> Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
> ---
>
> Key: HIVE-15969
> URL: https://issues.apache.org/jira/browse/HIVE-15969
> Project: Hive
> Issue Type: Sub-task
>Affects Versions: 2.2.0
>Reporter: Thejas M Nair
>Assignee: slim bouguerra
> Attachments: HIVE-15969.patch
>
>
> Looks like the additional failures in TestRemoteHiveMetaStore,
> TestSetUGIOnOnlyServer
> are related to this patch in HIVE-15877.
> I don't think that change was intended.
> {code}
> ---
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> +++
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext
> envContext) throws Already
> hook.commitCreateTable(tbl);
>}
>success = true;
> -} finally {
> +} catch (Exception e){
> + LOG.error("Got exception from createTable", e);
> +}
> +finally {
>if (!success && (hook != null)) {
> hook.rollbackCreateTable(tbl);
>}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-15969) Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
[
https://issues.apache.org/jira/browse/HIVE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872375#comment-15872375
]
Thejas M Nair commented on HIVE-15969:
--
Discussed offline with [~bslim]
The logging of exception happens at higher levels in Hive. Logging this in
metastore client would means the log message gets duplicated.
However, it seems in case of rollback in finally block of
HiveMetastoreClient.createTable giving an error the exception is lost. The
right fix would be to not throw an exception from finally block and just log
that one.
> Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
> ---
>
> Key: HIVE-15969
> URL: https://issues.apache.org/jira/browse/HIVE-15969
> Project: Hive
> Issue Type: Sub-task
>Affects Versions: 2.2.0
>Reporter: Thejas M Nair
>Assignee: slim bouguerra
> Attachments: HIVE-15969.patch
>
>
> Looks like the additional failures in TestRemoteHiveMetaStore,
> TestSetUGIOnOnlyServer
> are related to this patch in HIVE-15877.
> I don't think that change was intended.
> {code}
> ---
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> +++
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext
> envContext) throws Already
> hook.commitCreateTable(tbl);
>}
>success = true;
> -} finally {
> +} catch (Exception e){
> + LOG.error("Got exception from createTable", e);
> +}
> +finally {
>if (!success && (hook != null)) {
> hook.rollbackCreateTable(tbl);
>}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-15969) Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
[
https://issues.apache.org/jira/browse/HIVE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872321#comment-15872321
]
slim bouguerra commented on HIVE-15969:
---
[~thejas] that change is only logging the exception, not sure why is it failing
the UTs. will take a look.
If you want to remove it you can but i would like to have it in the future.
> Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
> ---
>
> Key: HIVE-15969
> URL: https://issues.apache.org/jira/browse/HIVE-15969
> Project: Hive
> Issue Type: Sub-task
>Affects Versions: 2.2.0
>Reporter: Thejas M Nair
>
> Looks like the additional failures in TestRemoteHiveMetaStore,
> TestSetUGIOnOnlyServer
> are related to this patch in HIVE-15877.
> I don't think that change was intended.
> {code}
> ---
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> +++
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext
> envContext) throws Already
> hook.commitCreateTable(tbl);
>}
>success = true;
> -} finally {
> +} catch (Exception e){
> + LOG.error("Got exception from createTable", e);
> +}
> +finally {
>if (!success && (hook != null)) {
> hook.rollbackCreateTable(tbl);
>}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
