[jira] [Commented] (HIVE-16110) Vectorization: Support 2 Value CASE WHEN instead of fall back to VectorUDFAdaptor
[ https://issues.apache.org/jira/browse/HIVE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931899#comment-15931899 ] Matt McCline commented on HIVE-16110: - Committed to master. > Vectorization: Support 2 Value CASE WHEN instead of fall back to > VectorUDFAdaptor > - > > Key: HIVE-16110 > URL: https://issues.apache.org/jira/browse/HIVE-16110 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Fix For: 2.2.0 > > Attachments: HIVE-16110.01.patch, HIVE-16110.02.patch, > HIVE-16110.03.patch, HIVE-16110.04.patch, HIVE-16110.05.patch > > > Vectorize more queries by converting a GenericUDFWhen that has 2 values that > are either a column or a constant into a GenericUDFIf, which has vectorized > classes. This eliminates one case so to speak where we use the > VectorUDFAdaptor. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16110) Vectorization: Support 2 Value CASE WHEN instead of fall back to VectorUDFAdaptor
[
https://issues.apache.org/jira/browse/HIVE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931832#comment-15931832
]
Hive QA commented on HIVE-16110:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12859469/HIVE-16110.04.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10475 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_grouping_id3]
(batchId=147)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3]
(batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_case]
(batchId=120)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4240/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4240/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4240/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12859469 - PreCommit-HIVE-Build
> Vectorization: Support 2 Value CASE WHEN instead of fall back to
> VectorUDFAdaptor
> -
>
> Key: HIVE-16110
> URL: https://issues.apache.org/jira/browse/HIVE-16110
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-16110.01.patch, HIVE-16110.02.patch,
> HIVE-16110.03.patch, HIVE-16110.04.patch
>
>
> Vectorize more queries by converting a GenericUDFWhen that has 2 values that
> are either a column or a constant into a GenericUDFIf, which has vectorized
> classes. This eliminates one case so to speak where we use the
> VectorUDFAdaptor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16110) Vectorization: Support 2 Value CASE WHEN instead of fall back to VectorUDFAdaptor
[ https://issues.apache.org/jira/browse/HIVE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900422#comment-15900422 ] Sergey Shelukhin commented on HIVE-16110: - +1 however the test has failed (case) > Vectorization: Support 2 Value CASE WHEN instead of fall back to > VectorUDFAdaptor > - > > Key: HIVE-16110 > URL: https://issues.apache.org/jira/browse/HIVE-16110 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Attachments: HIVE-16110.01.patch, HIVE-16110.02.patch, > HIVE-16110.03.patch > > > Vectorize more queries by converting a GenericUDFWhen that has 2 values that > are either a column or a constant into a GenericUDFIf, which has vectorized > classes. This eliminates one case so to speak where we use the > VectorUDFAdaptor. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16110) Vectorization: Support 2 Value CASE WHEN instead of fall back to VectorUDFAdaptor
[
https://issues.apache.org/jira/browse/HIVE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899357#comment-15899357
]
Hive QA commented on HIVE-16110:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12856445/HIVE-16110.03.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10328 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_table]
(batchId=147)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=140)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=224)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_between_in]
(batchId=119)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_case]
(batchId=119)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3992/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3992/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3992/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12856445 - PreCommit-HIVE-Build
> Vectorization: Support 2 Value CASE WHEN instead of fall back to
> VectorUDFAdaptor
> -
>
> Key: HIVE-16110
> URL: https://issues.apache.org/jira/browse/HIVE-16110
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-16110.01.patch, HIVE-16110.02.patch,
> HIVE-16110.03.patch
>
>
> Vectorize more queries by converting a GenericUDFWhen that has 2 values that
> are either a column or a constant into a GenericUDFIf, which has vectorized
> classes. This eliminates one case so to speak where we use the
> VectorUDFAdaptor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16110) Vectorization: Support 2 Value CASE WHEN instead of fall back to VectorUDFAdaptor
[ https://issues.apache.org/jira/browse/HIVE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898812#comment-15898812 ] Matt McCline commented on HIVE-16110: - Look at why vector_coalesce_3.q has one vertex not vectorizing now. Fix 3 golden files. > Vectorization: Support 2 Value CASE WHEN instead of fall back to > VectorUDFAdaptor > - > > Key: HIVE-16110 > URL: https://issues.apache.org/jira/browse/HIVE-16110 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Attachments: HIVE-16110.01.patch, HIVE-16110.02.patch > > > Vectorize more queries by converting a GenericUDFWhen that has 2 values that > are either a column or a constant into a GenericUDFIf, which has vectorized > classes. This eliminates one case so to speak where we use the > VectorUDFAdaptor. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16110) Vectorization: Support 2 Value CASE WHEN instead of fall back to VectorUDFAdaptor
[
https://issues.apache.org/jira/browse/HIVE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898795#comment-15898795
]
Hive QA commented on HIVE-16110:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12856370/HIVE-16110.02.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 10328 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments]
(batchId=229)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_between_columns]
(batchId=64)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce_3]
(batchId=53)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_case]
(batchId=53)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_table]
(batchId=147)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_between_columns]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_coalesce_3]
(batchId=149)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23]
(batchId=224)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_between_in]
(batchId=119)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_case]
(batchId=119)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3981/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3981/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3981/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12856370 - PreCommit-HIVE-Build
> Vectorization: Support 2 Value CASE WHEN instead of fall back to
> VectorUDFAdaptor
> -
>
> Key: HIVE-16110
> URL: https://issues.apache.org/jira/browse/HIVE-16110
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-16110.01.patch, HIVE-16110.02.patch
>
>
> Vectorize more queries by converting a GenericUDFWhen that has 2 values that
> are either a column or a constant into a GenericUDFIf, which has vectorized
> classes. This eliminates one case so to speak where we use the
> VectorUDFAdaptor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16110) Vectorization: Support 2 Value CASE WHEN instead of fall back to VectorUDFAdaptor
[ https://issues.apache.org/jira/browse/HIVE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898392#comment-15898392 ] Matt McCline commented on HIVE-16110: - [~sershe] Thanks for the review. I put the code into a separate method. Ready for a +1 tests pending > Vectorization: Support 2 Value CASE WHEN instead of fall back to > VectorUDFAdaptor > - > > Key: HIVE-16110 > URL: https://issues.apache.org/jira/browse/HIVE-16110 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Attachments: HIVE-16110.01.patch, HIVE-16110.02.patch > > > Vectorize more queries by converting a GenericUDFWhen that has 2 values that > are either a column or a constant into a GenericUDFIf, which has vectorized > classes. This eliminates one case so to speak where we use the > VectorUDFAdaptor. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16110) Vectorization: Support 2 Value CASE WHEN instead of fall back to VectorUDFAdaptor
[ https://issues.apache.org/jira/browse/HIVE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898291#comment-15898291 ] Sergey Shelukhin commented on HIVE-16110: - Looks good... can you put the code into a separate method too? Also need to wait for tests > Vectorization: Support 2 Value CASE WHEN instead of fall back to > VectorUDFAdaptor > - > > Key: HIVE-16110 > URL: https://issues.apache.org/jira/browse/HIVE-16110 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Attachments: HIVE-16110.01.patch > > > Vectorize more queries by converting a GenericUDFWhen that has 2 values that > are either a column or a constant into a GenericUDFIf, which has vectorized > classes. This eliminates one case so to speak where we use the > VectorUDFAdaptor. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
