[jira] [Commented] (HIVE-16130) Remove jackson classes from hive-jdbc standalone jar
[ https://issues.apache.org/jira/browse/HIVE-16130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949761#comment-15949761 ] Ashutosh Chauhan commented on HIVE-16130: - Is this ready for commit ? > Remove jackson classes from hive-jdbc standalone jar > > > Key: HIVE-16130 > URL: https://issues.apache.org/jira/browse/HIVE-16130 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-16130.1.patch, HIVE-16130.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16130) Remove jackson classes from hive-jdbc standalone jar
[
https://issues.apache.org/jira/browse/HIVE-16130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925216#comment-15925216
]
Hive QA commented on HIVE-16130:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12858754/HIVE-16130.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 10346 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=141)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4133/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4133/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4133/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12858754 - PreCommit-HIVE-Build
> Remove jackson classes from hive-jdbc standalone jar
>
>
> Key: HIVE-16130
> URL: https://issues.apache.org/jira/browse/HIVE-16130
> Project: Hive
> Issue Type: Bug
>Reporter: Tao Li
>Assignee: Tao Li
> Attachments: HIVE-16130.1.patch, HIVE-16130.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16130) Remove jackson classes from hive-jdbc standalone jar
[ https://issues.apache.org/jira/browse/HIVE-16130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925095#comment-15925095 ] Vaibhav Gumashta commented on HIVE-16130: - +1 > Remove jackson classes from hive-jdbc standalone jar > > > Key: HIVE-16130 > URL: https://issues.apache.org/jira/browse/HIVE-16130 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-16130.1.patch, HIVE-16130.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16130) Remove jackson classes from hive-jdbc standalone jar
[ https://issues.apache.org/jira/browse/HIVE-16130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924928#comment-15924928 ] Tao Li commented on HIVE-16130: --- Attached another patch to remove jackson classes shaded from parquet-hadoop-bundle.jar and log4j-core.jar, while keeping the other classes from these 2 artifacts. > Remove jackson classes from hive-jdbc standalone jar > > > Key: HIVE-16130 > URL: https://issues.apache.org/jira/browse/HIVE-16130 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-16130.1.patch, HIVE-16130.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16130) Remove jackson classes from hive-jdbc standalone jar
[ https://issues.apache.org/jira/browse/HIVE-16130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923021#comment-15923021 ] Tao Li commented on HIVE-16130: --- [~kgyrtkirk] The purpose is to remove as many unneeded classes as possible from the JDBC standalone jar. The unneeded classes not only increased the file size but may cause potential conflicts when user's library contains the same classes. We have removed a bunch of classes so far recently. Regarding the jackson related classes, they are being referenced from multiple artifacts which are needed. So the patch is just removing part of the jackson classes, a best effort thing. > Remove jackson classes from hive-jdbc standalone jar > > > Key: HIVE-16130 > URL: https://issues.apache.org/jira/browse/HIVE-16130 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-16130.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16130) Remove jackson classes from hive-jdbc standalone jar
[ https://issues.apache.org/jira/browse/HIVE-16130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898898#comment-15898898 ] Zoltan Haindrich commented on HIVE-16130: - [~taoli-hwx] I possibly doesn't know enough about this partwhat's the positive side of removing this from the jar? I see there are a lot of excludes already in this pom.xml file...I assume this module's purpose is to provide the jdbc driver - and the many excludes are present because much larger modules were added as dependencies than needed > Remove jackson classes from hive-jdbc standalone jar > > > Key: HIVE-16130 > URL: https://issues.apache.org/jira/browse/HIVE-16130 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-16130.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16130) Remove jackson classes from hive-jdbc standalone jar
[ https://issues.apache.org/jira/browse/HIVE-16130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898437#comment-15898437 ] Tao Li commented on HIVE-16130: --- + [~vgumashta] > Remove jackson classes from hive-jdbc standalone jar > > > Key: HIVE-16130 > URL: https://issues.apache.org/jira/browse/HIVE-16130 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-16130.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16130) Remove jackson classes from hive-jdbc standalone jar
[ https://issues.apache.org/jira/browse/HIVE-16130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898405#comment-15898405 ] Tao Li commented on HIVE-16130: --- We should be able to remove the artifacts from group "com.fasterxml.jackson.core" (see the patch). Local tests look good for both binary and http mode. However the below jackson classes are from parquet-hadoop-bundle-*.jar and log4j-core-*.jar, which I assume are required for the JDBC jar. So we have to keep these jackson classes in the uber jar. [~thejas] Can you please confirm? Here are some samples: 1502 Mon Mar 06 15:18:06 PST 2017 org/apache/logging/log4j/core/jackson/SimpleMessageDeserializer.class 867 Mon Mar 06 15:18:10 PST 2017 shaded/parquet/org/codehaus/jackson/map/AbstractTypeResolver.class > Remove jackson classes from hive-jdbc standalone jar > > > Key: HIVE-16130 > URL: https://issues.apache.org/jira/browse/HIVE-16130 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
