[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944260#comment-15944260 ] Lefty Leverenz commented on HIVE-16188: --- > I was still used to type 2.2 Yeah, there's a lot of that going around. ;) > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Fix For: 3.0.0 > > Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > Connection to HS2 using beeline tool on port 1 - > beeline -u > "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com" > Connection to ImpalaD using beeline tool on port 21050 - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944252#comment-15944252 ] Sergio Peña commented on HIVE-16188: Oh yes, sorry [~leftylev]. I was still used to type 2.2 > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > Connection to HS2 using beeline tool on port 1 - > beeline -u > "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com" > Connection to ImpalaD using beeline tool on port 21050 - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944246#comment-15944246 ] Lefty Leverenz commented on HIVE-16188: --- [~spena], the current plan is for master to become release 3.0.0 so this issue's fix version should be 3.0.0 instead of 2.2.0. * [About next 2.3 release | http://mail-archives.apache.org/mod_mbox/hive-dev/201703.mbox/%3ccams4yue4wn3zabeet-acn6smhup0k8ffgeu3w6m4y9wgjfs...@mail.gmail.com%3e] Please commit to branch-2 if you want this patch in 2.3.0, which is what we thought would be 2.2.0 but now that's going to be a special case: * [Re: Backward incompatible changes | http://mail-archives.apache.org/mod_mbox/hive-dev/201703.mbox/%3cCAHfHakEL-+C=q5rnrunxfcmqabnpm5m_h6qrokcrns24cv2...@mail.gmail.com%3e] > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > Connection to HS2 using beeline tool on port 1 - > beeline -u > "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com" > Connection to ImpalaD using beeline tool on port 21050 - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941042#comment-15941042 ] Sergio Peña commented on HIVE-16188: The patch looks good. +1 > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > Connection to HS2 using beeline tool on port 1 - > beeline -u > "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com" > Connection to ImpalaD using beeline tool on port 21050 - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938816#comment-15938816 ] Sahil Takiar commented on HIVE-16188: - [~spena] could you take a look at this patch? > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > Connection to HS2 using beeline tool on port 1 - > beeline -u > "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com" > Connection to ImpalaD using beeline tool on port 21050 - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[
https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929142#comment-15929142
]
Vihang Karajgaonkar commented on HIVE-16188:
Agreed. Initially I mistook this JIRA for Db name validation for cases where db
name after port number is not present Eg: {{-u jdbc:hive2://localhost:1 -n
hive}}. Please ignore my earlier comment. That patch looks good to me.
> beeline should block the connection if given invalid database name.
> ---
>
> Key: HIVE-16188
> URL: https://issues.apache.org/jira/browse/HIVE-16188
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Pavas Garg
>Assignee: Sahil Takiar
>Priority: Minor
> Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch
>
>
> When using beeline shell to connect to HS2 or impalaD as below -
> Connection to HS2 using beeline tool on port 1 -
> beeline -u
> "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com"
> Connection to ImpalaD using beeline tool on port 21050 -
> beeline -u
> "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com"
>
> Providing a invalid database name as XXX - the connection is made.
> It should ideally stop the connection to be successfull.
> Even though, the beeline tool does not allow to move forward, unless you
> provide a valid DB name, like
> Use ;
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[
https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929135#comment-15929135
]
Sahil Takiar commented on HIVE-16188:
-
We could do it client side, but it would have to be after the connection is
made. We have no way of knowing whether the database name exists or not without
making a {{HiveConnection}} and querying the metastore to see if the database
exists.
The only way I can think of doing it client side, would be to make the
connection, and then execute a {{describe database [db-name]}} command. If the
the query throws an exception, then it should exit. If it works then everything
executes normally.
> beeline should block the connection if given invalid database name.
> ---
>
> Key: HIVE-16188
> URL: https://issues.apache.org/jira/browse/HIVE-16188
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Pavas Garg
>Assignee: Sahil Takiar
>Priority: Minor
> Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch
>
>
> When using beeline shell to connect to HS2 or impalaD as below -
> Connection to HS2 using beeline tool on port 1 -
> beeline -u
> "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com"
> Connection to ImpalaD using beeline tool on port 21050 -
> beeline -u
> "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com"
>
> Providing a invalid database name as XXX - the connection is made.
> It should ideally stop the connection to be successfull.
> Even though, the beeline tool does not allow to move forward, unless you
> provide a valid DB name, like
> Use ;
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928951#comment-15928951 ] Vihang Karajgaonkar commented on HIVE-16188: I looked into code again and I think client side is better place to handle this validation than on the HiveServer2 side. In addition to this check in HiveSession I think we should also add this check in HiveDriver:parseURLforPropertyInfo() method. Since we know that connection request will fail there is no need to even attempt making a connection. What do you think [~stakiar]? > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > Connection to HS2 using beeline tool on port 1 - > beeline -u > "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com" > Connection to ImpalaD using beeline tool on port 21050 - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926818#comment-15926818 ] Sahil Takiar commented on HIVE-16188: - [~vihangk1] any other comments? > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > Connection to HS2 using beeline tool on port 1 - > beeline -u > "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com" > Connection to ImpalaD using beeline tool on port 21050 - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[
https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925482#comment-15925482
]
Hive QA commented on HIVE-16188:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12858772/HIVE-16188.2.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 13 failed/errored test(s), 10343 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucket_map_join_spark2]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucketmapjoin2]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[cbo_udf_udaf]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_cube1]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join_vc]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ptf_decimal]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[sample3]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[smb_mapjoin_19]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[stats16]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union23]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union31]
(batchId=97)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union] (batchId=97)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver
(batchId=232)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4138/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4138/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4138/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 13 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12858772 - PreCommit-HIVE-Build
> beeline should block the connection if given invalid database name.
> ---
>
> Key: HIVE-16188
> URL: https://issues.apache.org/jira/browse/HIVE-16188
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Pavas Garg
>Assignee: Sahil Takiar
>Priority: Minor
> Attachments: HIVE-16188.1.patch, HIVE-16188.2.patch
>
>
> When using beeline shell to connect to HS2 or impalaD as below -
> Connection to HS2 using beeline tool on port 1 -
> beeline -u
> "jdbc:hive2://HS2-host-name:1/default;principal=hive/hs2-host-n...@domain.example.com"
> Connection to ImpalaD using beeline tool on port 21050 -
> beeline -u
> "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com"
>
> Providing a invalid database name as XXX - the connection is made.
> It should ideally stop the connection to be successfull.
> Even though, the beeline tool does not allow to move forward, unless you
> provide a valid DB name, like
> Use ;
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924688#comment-15924688 ] Pavas Garg commented on HIVE-16188: --- Hello [~stakiar] Yes, In my case, I am trying to connect to impalaDaemon using beeline tool on port 21050 But your fix should work, because either way we are using Hive code to connect. Hope that makes sense. > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Attachments: HIVE-16188.1.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[
https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924611#comment-15924611
]
Sahil Takiar commented on HIVE-16188:
-
Looks like there are some related test failures:
TestJdbcWithMiniHS2.org.apache.hive.jdbc.TestJdbcWithMiniHS2
TestJdbcDriver2.testSetOnConnection
Will fix those + will add some new tests.
[~pgarg_impala_3a7b] - the fix I am working on may be Hive specific (the fix
requires a change to {{HiveSessionImpl}}). From your description it seems you
are trying to connect to Impala, correct? I'm not sure how Beeline connects to
Impala so I'm not 100% if this change will work for Impala too.
> beeline should block the connection if given invalid database name.
> ---
>
> Key: HIVE-16188
> URL: https://issues.apache.org/jira/browse/HIVE-16188
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Pavas Garg
>Assignee: Sahil Takiar
>Priority: Minor
> Attachments: HIVE-16188.1.patch
>
>
> When using beeline shell to connect to HS2 or impalaD as below -
> beeline -u
> "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com"
>
> Providing a invalid database name as XXX - the connection is made.
> It should ideally stop the connection to be successfull.
> Even though, the beeline tool does not allow to move forward, unless you
> provide a valid DB name, like
> Use ;
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924600#comment-15924600 ] Pavas Garg commented on HIVE-16188: --- 1. I don't think you can specify/select the database to start the connection with. 2. Hive CLI is deprecated, use beeline shell going forward. > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Attachments: HIVE-16188.1.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924561#comment-15924561 ] Vihang Karajgaonkar commented on HIVE-16188: Hi [~stakiar] Thanks for the patch. Does this change the behavior with HiveCLI too? Also, would be good if we can add a test case for this. > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Attachments: HIVE-16188.1.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924071#comment-15924071 ] Pavas Garg commented on HIVE-16188: --- Hello [~stakiar] no worries. > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > Attachments: HIVE-16188.1.patch > > > When using beeline shell to connect to HS2 or impalaD as below - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[
https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924060#comment-15924060
]
Hive QA commented on HIVE-16188:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12858630/HIVE-16188.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10305 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=141)
org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver
(batchId=100)
org.apache.hive.jdbc.TestJdbcDriver2.testSetOnConnection (batchId=217)
org.apache.hive.jdbc.TestJdbcWithMiniHS2.org.apache.hive.jdbc.TestJdbcWithMiniHS2
(batchId=219)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4124/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4124/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4124/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12858630 - PreCommit-HIVE-Build
> beeline should block the connection if given invalid database name.
> ---
>
> Key: HIVE-16188
> URL: https://issues.apache.org/jira/browse/HIVE-16188
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Pavas Garg
>Assignee: Sahil Takiar
>Priority: Minor
> Attachments: HIVE-16188.1.patch
>
>
> When using beeline shell to connect to HS2 or impalaD as below -
> beeline -u
> "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com"
>
> Providing a invalid database name as XXX - the connection is made.
> It should ideally stop the connection to be successfull.
> Even though, the beeline tool does not allow to move forward, unless you
> provide a valid DB name, like
> Use ;
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-16188) beeline should block the connection if given invalid database name.
[ https://issues.apache.org/jira/browse/HIVE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923679#comment-15923679 ] Sahil Takiar commented on HIVE-16188: - [~pgarg_impala_3a7b] I took a look at this today and think I have a fix. Assigning this to myself, let me know if you have any objections. Attaching a patch with initial approach to see what Hive QA thinks. > beeline should block the connection if given invalid database name. > --- > > Key: HIVE-16188 > URL: https://issues.apache.org/jira/browse/HIVE-16188 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Pavas Garg >Assignee: Sahil Takiar >Priority: Minor > > When using beeline shell to connect to HS2 or impalaD as below - > beeline -u > "jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com" > > Providing a invalid database name as XXX - the connection is made. > It should ideally stop the connection to be successfull. > Even though, the beeline tool does not allow to move forward, unless you > provide a valid DB name, like > Use ; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
