[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-06-04 Thread Lefty Leverenz (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036188#comment-16036188
 ] 

Lefty Leverenz commented on HIVE-16372:
---

Okay, thanks.

> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 2.0.0
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Fix For: 3.0.0
>
> Attachments: HIVE-16372.01.patch, HIVE-16372.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-06-04 Thread Pengcheng Xiong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036186#comment-16036186
 ] 

Pengcheng Xiong commented on HIVE-16372:


[~leftylev], current version on wiki does not say that we can not do that for 
non-native tables. Thus, i think we are ok.

> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 2.0.0
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Fix For: 3.0.0
>
> Attachments: HIVE-16372.01.patch, HIVE-16372.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-06-02 Thread Lefty Leverenz (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034241#comment-16034241
 ] 

Lefty Leverenz commented on HIVE-16372:
---

Does this need to be documented in the wiki?

* [DDL -- Alter Table/Partition/Column | 
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-AlterTable/Partition/Column]
** [DDL -- Alter Table Properties | 
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-AlterTableProperties]

> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 2.0.0
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Fix For: 3.0.0
>
> Attachments: HIVE-16372.01.patch, HIVE-16372.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-05-31 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031647#comment-16031647
 ] 

Ashutosh Chauhan commented on HIVE-16372:
-

+1

> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16372.01.patch, HIVE-16372.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-04-05 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957707#comment-15957707
 ] 

Hive QA commented on HIVE-16372:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12862133/HIVE-16372.02.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10579 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency]
 (batchId=235)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] 
(batchId=235)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_non_native]
 (batchId=87)
org.apache.hive.jdbc.TestJdbcDriver2.testResultSetMetaData (batchId=221)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4564/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4564/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4564/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12862133 - PreCommit-HIVE-Build

> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16372.01.patch, HIVE-16372.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-04-05 Thread Thejas M Nair (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957374#comment-15957374
 ] 

Thejas M Nair commented on HIVE-16372:
--

+1


> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16372.01.patch, HIVE-16372.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-04-04 Thread Pengcheng Xiong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956112#comment-15956112
 ] 

Pengcheng Xiong commented on HIVE-16372:


OK. i will resubmit the patch.

> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16372.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-04-04 Thread Thejas M Nair (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956110#comment-15956110
 ] 

Thejas M Nair commented on HIVE-16372:
--

In AlterTableDesc.java
Using guava immutable list would be better. ie -
 public static final List nonNativeTableAllowedTypes = 
ImmutableList.of(ADDPROPS, DROPPROPS); 

In ErrorMsg.java
 Arrays.toString(AlterTableTypes.nonNativeTableAllowedTypes.toArray()) can be 
replaced with simply -
AlterTableTypes.nonNativeTableAllowedTypes
(its same format)


> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16372.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-04-04 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956035#comment-15956035
 ] 

Hive QA commented on HIVE-16372:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12861945/HIVE-16372.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 10579 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency]
 (batchId=235)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] 
(batchId=235)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
 (batchId=143)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_non_native]
 (batchId=87)
org.apache.hadoop.hive.llap.security.TestLlapSignerImpl.testSigning 
(batchId=285)
org.apache.hive.jdbc.TestJdbcDriver2.testResultSetMetaData (batchId=221)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4548/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4548/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4548/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12861945 - PreCommit-HIVE-Build

> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16372.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16372) Enable DDL statement for non-native tables (add/remove table properties)

2017-04-04 Thread Pengcheng Xiong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955730#comment-15955730
 ] 

Pengcheng Xiong commented on HIVE-16372:


[~thejas], can u take a look? I will deal with the renaming in another patch.

> Enable DDL statement for non-native tables (add/remove table properties)
> 
>
> Key: HIVE-16372
> URL: https://issues.apache.org/jira/browse/HIVE-16372
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16372.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)