[jira] [Commented] (HIVE-16392) Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance logic

2018-02-02 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351200#comment-16351200
 ] 

Sergey Shelukhin commented on HIVE-16392:
-

Hmm... this makes permission management more complex for ppl still using FS 
based permissions. Is there particular reason to remove this? We could just 
have it false by default. cc [~ashutoshc]

> Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance 
> logic
> 
>
> Key: HIVE-16392
> URL: https://issues.apache.org/jira/browse/HIVE-16392
> Project: Hive
>  Issue Type: Task
>  Components: Security
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
>  Labels: backwards-incompatible
> Fix For: 3.0.0
>
> Attachments: HIVE-16392.1.patch, HIVE-16392.2.patch
>
>
> As discussed in HIVE-16346 we should remove the config 
> {{hive.warehouse.subdir.inherit.perms}} and all the permissions inheritance 
> logic.
> This feature is no longer needed in Hive as the traditional permission model 
> has largely been replaced by external security systems such as Ranger and 
> Sentry.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-16392) Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance logic

2017-05-07 Thread Sahil Takiar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1605#comment-1605
 ] 

Sahil Takiar commented on HIVE-16392:
-

I updated the wikis for the config hive.warehouse.subdir.inherit.perms, I'm not 
sure if hive.files.umask.value really needs to be updated. I also updated the 
https://cwiki.apache.org/confluence/display/Hive/Permission+Inheritance+in+Hive 
wiki.

> Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance 
> logic
> 
>
> Key: HIVE-16392
> URL: https://issues.apache.org/jira/browse/HIVE-16392
> Project: Hive
>  Issue Type: Task
>  Components: Security
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>  Labels: backwards-incompatible
> Fix For: 3.0.0
>
> Attachments: HIVE-16392.1.patch, HIVE-16392.2.patch
>
>
> As discussed in HIVE-16346 we should remove the config 
> {{hive.warehouse.subdir.inherit.perms}} and all the permissions inheritance 
> logic.
> This feature is no longer needed in Hive as the traditional permission model 
> has largely been replaced by external security systems such as Ranger and 
> Sentry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16392) Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance logic

2017-04-21 Thread Lefty Leverenz (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979693#comment-15979693
 ] 

Lefty Leverenz commented on HIVE-16392:
---

Doc note:  The removal of *hive.warehouse.subdir.inherit.perms* needs to be 
documented in the wiki.  It would be good to mention the use of external 
security systems and include Ashutosh's comment "user may also choose 
SQLStdAuth which ships with Hive if user doesn't want to use external security 
system."

Also, the wiki says that when *hive.files.umask.value* was removed in 0.9.0, it 
was replaced by *hive.warehouse.subdir.inherit.perms* -- perhaps that should be 
updated too.

* [Configuration Properties -- hive.warehouse.subdir.inherit.perms | 
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.warehouse.subdir.inherit.perms]
* [Configuration Properties -- hive.files.umask.value | 
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.files.umask.value]

Added a TODOC3.0 label.

> Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance 
> logic
> 
>
> Key: HIVE-16392
> URL: https://issues.apache.org/jira/browse/HIVE-16392
> Project: Hive
>  Issue Type: Task
>  Components: Security
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>  Labels: TODOC3.0, backwards-incompatible
> Fix For: 3.0.0
>
> Attachments: HIVE-16392.1.patch, HIVE-16392.2.patch
>
>
> As discussed in HIVE-16346 we should remove the config 
> {{hive.warehouse.subdir.inherit.perms}} and all the permissions inheritance 
> logic.
> This feature is no longer needed in Hive as the traditional permission model 
> has largely been replaced by external security systems such as Ranger and 
> Sentry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16392) Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance logic

2017-04-07 Thread Sahil Takiar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961007#comment-15961007
 ] 

Sahil Takiar commented on HIVE-16392:
-

Test failures are flaky:

HIVE-16345 - TestBeeLineDriver.testCliDriver[drop_with_concurrency]
HIVE-16320 - TestBeeLineDriver.testCliDriver[escape_comments]
HIVE-16387 - TestJdbcDriver2.testResultSetMetaData
HIVE-15535 - TestHS2HttpServer.testContextRootUrlRewrite

Should be ready to push.

> Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance 
> logic
> 
>
> Key: HIVE-16392
> URL: https://issues.apache.org/jira/browse/HIVE-16392
> Project: Hive
>  Issue Type: Task
>  Components: Security
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>  Labels: backwards-incompatible
> Attachments: HIVE-16392.1.patch, HIVE-16392.2.patch
>
>
> As discussed in HIVE-16346 we should remove the config 
> {{hive.warehouse.subdir.inherit.perms}} and all the permissions inheritance 
> logic.
> This feature is no longer needed in Hive as the traditional permission model 
> has largely been replaced by external security systems such as Ranger and 
> Sentry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16392) Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance logic

2017-04-07 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960382#comment-15960382
 ] 

Hive QA commented on HIVE-16392:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12862341/HIVE-16392.2.patch

{color:green}SUCCESS:{color} +1 due to 5 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10542 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency]
 (batchId=234)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] 
(batchId=234)
org.apache.hive.jdbc.TestJdbcDriver2.testResultSetMetaData (batchId=221)
org.apache.hive.service.server.TestHS2HttpServer.testContextRootUrlRewrite 
(batchId=191)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4598/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4598/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4598/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12862341 - PreCommit-HIVE-Build

> Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance 
> logic
> 
>
> Key: HIVE-16392
> URL: https://issues.apache.org/jira/browse/HIVE-16392
> Project: Hive
>  Issue Type: Task
>  Components: Security
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>  Labels: backwards-incompatible
> Attachments: HIVE-16392.1.patch, HIVE-16392.2.patch
>
>
> As discussed in HIVE-16346 we should remove the config 
> {{hive.warehouse.subdir.inherit.perms}} and all the permissions inheritance 
> logic.
> This feature is no longer needed in Hive as the traditional permission model 
> has largely been replaced by external security systems such as Ranger and 
> Sentry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16392) Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance logic

2017-04-06 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959893#comment-15959893
 ] 

Ashutosh Chauhan commented on HIVE-16392:
-

+1 
Would also like to point out that user may also choose SQLStdAuth which ships 
with Hive if user doesn't want to use external security system.

> Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance 
> logic
> 
>
> Key: HIVE-16392
> URL: https://issues.apache.org/jira/browse/HIVE-16392
> Project: Hive
>  Issue Type: Task
>  Components: Security
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>  Labels: backwards-incompatible
> Attachments: HIVE-16392.1.patch, HIVE-16392.2.patch
>
>
> As discussed in HIVE-16346 we should remove the config 
> {{hive.warehouse.subdir.inherit.perms}} and all the permissions inheritance 
> logic.
> This feature is no longer needed in Hive as the traditional permission model 
> has largely been replaced by external security systems such as Ranger and 
> Sentry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16392) Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance logic

2017-04-06 Thread Sahil Takiar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959522#comment-15959522
 ] 

Sahil Takiar commented on HIVE-16392:
-

[~ashutoshc] RB: https://issues.apache.org/jira/browse/HIVE-16392

Brief Summary:

* Deleted the config {{HIVE_WAREHOUSE_SUBDIR_INHERIT_PERMS}} - removed all 
usage of it
* Deleted the inheritPerms parameter of a few methods in {{FileUtils}}
* Changes to {{Hive.java}} ({{moveFile}}, {{copyFiles}}, etc.) to remove 
permissions inheritance logic
* Deleted a few tests that validated that permissions inheritance was working

> Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance 
> logic
> 
>
> Key: HIVE-16392
> URL: https://issues.apache.org/jira/browse/HIVE-16392
> Project: Hive
>  Issue Type: Task
>  Components: Security
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>  Labels: backwards-incompatible
> Attachments: HIVE-16392.1.patch, HIVE-16392.2.patch
>
>
> As discussed in HIVE-16346 we should remove the config 
> {{hive.warehouse.subdir.inherit.perms}} and all the permissions inheritance 
> logic.
> This feature is no longer needed in Hive as the traditional permission model 
> has largely been replaced by external security systems such as Ranger and 
> Sentry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16392) Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance logic

2017-04-06 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959439#comment-15959439
 ] 

Hive QA commented on HIVE-16392:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12862219/HIVE-16392.1.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10551 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency]
 (batchId=234)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] 
(batchId=234)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
 (batchId=143)
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationDrops.testDropDatabase
 (batchId=216)
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationDrops.testDropPartition
 (batchId=216)
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationDrops.testDropTable
 (batchId=216)
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationProviderWithACL.testSimplePrivileges
 (batchId=226)
org.apache.hive.jdbc.TestJdbcDriver2.testResultSetMetaData (batchId=221)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4583/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4583/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4583/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12862219 - PreCommit-HIVE-Build

> Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance 
> logic
> 
>
> Key: HIVE-16392
> URL: https://issues.apache.org/jira/browse/HIVE-16392
> Project: Hive
>  Issue Type: Task
>  Components: Security
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
> Attachments: HIVE-16392.1.patch
>
>
> As discussed in HIVE-16346 we should remove the config 
> {{hive.warehouse.subdir.inherit.perms}} and all the permissions inheritance 
> logic.
> This feature is no longer needed in Hive as the traditional permission model 
> has largely been replaced by external security systems such as Ranger and 
> Sentry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16392) Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance logic

2017-04-06 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959406#comment-15959406
 ] 

Ashutosh Chauhan commented on HIVE-16392:
-

Thanks [~stakiar] for working on this. Can you please create a RB for this?

> Remove hive.warehouse.subdir.inherit.perms and all permissions inheritance 
> logic
> 
>
> Key: HIVE-16392
> URL: https://issues.apache.org/jira/browse/HIVE-16392
> Project: Hive
>  Issue Type: Task
>  Components: Security
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
> Attachments: HIVE-16392.1.patch
>
>
> As discussed in HIVE-16346 we should remove the config 
> {{hive.warehouse.subdir.inherit.perms}} and all the permissions inheritance 
> logic.
> This feature is no longer needed in Hive as the traditional permission model 
> has largely been replaced by external security systems such as Ranger and 
> Sentry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)