[jira] [Commented] (HIVE-16706) Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when dump in progress.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026635#comment-16026635
 ] 

ASF GitHub Bot commented on HIVE-16706:
---

Github user sankarh closed the pull request at:

https://github.com/apache/hive/pull/187


> Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when 
> dump in progress.
> -
>
> Key: HIVE-16706
> URL: https://issues.apache.org/jira/browse/HIVE-16706
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, repl
>Affects Versions: 2.1.0
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
>  Labels: DR, replication
> Fix For: 3.0.0
>
> Attachments: HIVE-16706.01.patch
>
>
> Currently, bootstrap REPL DUMP gets the partitions in a batch and then 
> iterate through it. If any partition is dropped/renamed during iteration, it 
> may lead to failure/exception. In this case, the partition should be skipped 
> from dump and also need to ensure no failure of REPL DUMP and the subsequent 
> incremental dump should ensure the consistent state of the table.
> This bug is related to HIVE-16684.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16706) Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when dump in progress.

[Sankar Hariappan (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024287#comment-16024287
 ] 

Sankar Hariappan commented on HIVE-16706:
-

Thank you [~thejas] for the commit!

> Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when 
> dump in progress.
> -
>
> Key: HIVE-16706
> URL: https://issues.apache.org/jira/browse/HIVE-16706
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, repl
>Affects Versions: 2.1.0
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
>  Labels: DR, replication
> Fix For: 3.0.0
>
> Attachments: HIVE-16706.01.patch
>
>
> Currently, bootstrap REPL DUMP gets the partitions in a batch and then 
> iterate through it. If any partition is dropped/renamed during iteration, it 
> may lead to failure/exception. In this case, the partition should be skipped 
> from dump and also need to ensure no failure of REPL DUMP and the subsequent 
> incremental dump should ensure the consistent state of the table.
> This bug is related to HIVE-16684.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16706) Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when dump in progress.

[Thejas M Nair (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022162#comment-16022162
 ] 

Thejas M Nair commented on HIVE-16706:
--

+1


> Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when 
> dump in progress.
> -
>
> Key: HIVE-16706
> URL: https://issues.apache.org/jira/browse/HIVE-16706
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, repl
>Affects Versions: 2.1.0
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
>  Labels: DR, replication
> Attachments: HIVE-16706.01.patch
>
>
> Currently, bootstrap REPL DUMP gets the partitions in a batch and then 
> iterate through it. If any partition is dropped/renamed during iteration, it 
> may lead to failure/exception. In this case, the partition should be skipped 
> from dump and also need to ensure no failure of REPL DUMP and the subsequent 
> incremental dump should ensure the consistent state of the table.
> This bug is related to HIVE-16684.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16706) Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when dump in progress.

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021556#comment-16021556
 ] 

Hive QA commented on HIVE-16706:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12869494/HIVE-16706.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10750 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
 (batchId=144)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_join30]
 (batchId=149)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5401/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5401/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5401/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12869494 - PreCommit-HIVE-Build

> Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when 
> dump in progress.
> -
>
> Key: HIVE-16706
> URL: https://issues.apache.org/jira/browse/HIVE-16706
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, repl
>Affects Versions: 2.1.0
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
>  Labels: DR, replication
> Attachments: HIVE-16706.01.patch
>
>
> Currently, bootstrap REPL DUMP gets the partitions in a batch and then 
> iterate through it. If any partition is dropped/renamed during iteration, it 
> may lead to failure/exception. In this case, the partition should be skipped 
> from dump and also need to ensure no failure of REPL DUMP and the subsequent 
> incremental dump should ensure the consistent state of the table.
> This bug is related to HIVE-16684.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16706) Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when dump in progress.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021474#comment-16021474
 ] 

ASF GitHub Bot commented on HIVE-16706:
---

GitHub user sankarh opened a pull request:

https://github.com/apache/hive/pull/187

HIVE-16706: Bootstrap REPL DUMP shouldn't fail when a partition is 
dropped/renamed when dump in progress.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sankarh/hive HIVE-16706

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #187


commit 7e9ed26ef2bd5a89cfe6df0ad22552dad003c82b
Author: Sankar Hariappan 
Date:   2017-05-23T16:13:04Z

HIVE-16706: Bootstrap REPL DUMP shouldn't fail when a partition is 
dropped/renamed when dump in progress.




> Bootstrap REPL DUMP shouldn't fail when a partition is dropped/renamed when 
> dump in progress.
> -
>
> Key: HIVE-16706
> URL: https://issues.apache.org/jira/browse/HIVE-16706
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive, repl
>Affects Versions: 2.1.0
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
>  Labels: DR, replication
>
> Currently, bootstrap REPL DUMP gets the partitions in a batch and then 
> iterate through it. If any partition is dropped/renamed during iteration, it 
> may lead to failure/exception. In this case, the partition should be skipped 
> from dump and also need to ensure no failure of REPL DUMP and the subsequent 
> incremental dump should ensure the consistent state of the table.
> This bug is related to HIVE-16684.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)