[jira] [Commented] (HIVE-16774) Support position in ORDER BY when using SELECT *

2017-06-04 Thread Lefty Leverenz (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036190#comment-16036190
 ] 

Lefty Leverenz commented on HIVE-16774:
---

Thanks, good to know.

> Support position in ORDER BY when using SELECT *
> 
>
> Key: HIVE-16774
> URL: https://issues.apache.org/jira/browse/HIVE-16774
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 2.0.0
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Fix For: 3.0.0
>
> Attachments: HIVE-16774.01.patch, HIVE-16774.02.patch
>
>
> query47.q query57.q



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16774) Support position in ORDER BY when using SELECT *

2017-06-04 Thread Pengcheng Xiong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036187#comment-16036187
 ] 

Pengcheng Xiong commented on HIVE-16774:


[~leftylev], previously we do support order by position. This is an 
improvement. Thus i think we are ok.

> Support position in ORDER BY when using SELECT *
> 
>
> Key: HIVE-16774
> URL: https://issues.apache.org/jira/browse/HIVE-16774
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 2.0.0
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Fix For: 3.0.0
>
> Attachments: HIVE-16774.01.patch, HIVE-16774.02.patch
>
>
> query47.q query57.q



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16774) Support position in ORDER BY when using SELECT *

2017-06-04 Thread Lefty Leverenz (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036182#comment-16036182
 ] 

Lefty Leverenz commented on HIVE-16774:
---

Does this need to be documented in the wiki?

> Support position in ORDER BY when using SELECT *
> 
>
> Key: HIVE-16774
> URL: https://issues.apache.org/jira/browse/HIVE-16774
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 2.0.0
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Fix For: 3.0.0
>
> Attachments: HIVE-16774.01.patch, HIVE-16774.02.patch
>
>
> query47.q query57.q



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16774) Support position in ORDER BY when using SELECT *

2017-05-31 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031287#comment-16031287
 ] 

Ashutosh Chauhan commented on HIVE-16774:
-

+1

> Support position in ORDER BY when using SELECT *
> 
>
> Key: HIVE-16774
> URL: https://issues.apache.org/jira/browse/HIVE-16774
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16774.01.patch, HIVE-16774.02.patch
>
>
> query47.q query57.q



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16774) Support position in ORDER BY when using SELECT *

2017-05-30 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030610#comment-16030610
 ] 

Hive QA commented on HIVE-16774:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12870477/HIVE-16774.02.patch

{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10807 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[materialized_view_create_rewrite]
 (batchId=237)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[skewjoin_mapjoin1] 
(batchId=80)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar]
 (batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
 (batchId=145)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] 
(batchId=232)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5485/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5485/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5485/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12870477 - PreCommit-HIVE-Build

> Support position in ORDER BY when using SELECT *
> 
>
> Key: HIVE-16774
> URL: https://issues.apache.org/jira/browse/HIVE-16774
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16774.01.patch, HIVE-16774.02.patch
>
>
> query47.q query57.q



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16774) Support position in ORDER BY when using SELECT *

2017-05-30 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030205#comment-16030205
 ] 

Hive QA commented on HIVE-16774:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12870436/HIVE-16774.01.patch

{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 11 failed/errored test(s), 10789 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2] 
(batchId=46)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_position] 
(batchId=37)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_10] (batchId=40)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[position_alias_test_1] 
(batchId=41)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar]
 (batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
 (batchId=145)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.org.apache.hadoop.hive.cli.TestNegativeCliDriver
 (batchId=90)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[groupby_invalid_position]
 (batchId=89)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[orderby_position_unsupported]
 (batchId=89)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_position] 
(batchId=116)
org.apache.hive.jdbc.TestJdbcDriver2.testSelectExecAsync2 (batchId=224)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5478/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5478/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5478/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 11 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12870436 - PreCommit-HIVE-Build

> Support position in ORDER BY when using SELECT *
> 
>
> Key: HIVE-16774
> URL: https://issues.apache.org/jira/browse/HIVE-16774
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16774.01.patch
>
>
> query47.q query57.q



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16774) Support position in ORDER BY when using SELECT *

2017-05-30 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030194#comment-16030194
 ] 

Sergey Shelukhin commented on HIVE-16774:
-

Also I like ParseUtils.parse changes that move the duplicated code to one place 
:)

> Support position in ORDER BY when using SELECT *
> 
>
> Key: HIVE-16774
> URL: https://issues.apache.org/jira/browse/HIVE-16774
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16774.01.patch
>
>
> query47.q query57.q



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16774) Support position in ORDER BY when using SELECT *

2017-05-30 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030190#comment-16030190
 ] 

Sergey Shelukhin commented on HIVE-16774:
-

If this one works (e.g. union_pos_alias test passes) without that one, sure.

> Support position in ORDER BY when using SELECT *
> 
>
> Key: HIVE-16774
> URL: https://issues.apache.org/jira/browse/HIVE-16774
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16774.01.patch
>
>
> query47.q query57.q



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16774) Support position in ORDER BY when using SELECT *

2017-05-30 Thread Pengcheng Xiong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030113#comment-16030113
 ] 

Pengcheng Xiong commented on HIVE-16774:


[~sershe], do you think we should revert HIVE-15938? Thanks.

> Support position in ORDER BY when using SELECT *
> 
>
> Key: HIVE-16774
> URL: https://issues.apache.org/jira/browse/HIVE-16774
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-16774.01.patch
>
>
> query47.q query57.q



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)