[jira] [Commented] (HIVE-17301) Make JSONMessageFactory.getTObj method thread safe

2017-08-11 Thread Tao Li (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124479#comment-16124479
 ] 

Tao Li commented on HIVE-17301:
---

Test failures are tracked in HIVE-15058 and don't seem related to this change.

> Make JSONMessageFactory.getTObj method thread safe
> --
>
> Key: HIVE-17301
> URL: https://issues.apache.org/jira/browse/HIVE-17301
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Reporter: Tao Li
>Assignee: Tao Li
> Attachments: HIVE-17301.1.patch
>
>
> This static method is using a singleton instance of TDeserializer, which is 
> not thread safe. Instead we want to create a new instance per method call. 
> This class is lightweight, so it should be fine from perf perspective. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HIVE-17301) Make JSONMessageFactory.getTObj method thread safe

2017-08-11 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124401#comment-16124401
 ] 

Hive QA commented on HIVE-17301:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12881518/HIVE-17301.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 11004 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_dynamic_partitions_merge_move]
 (batchId=243)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_dynamic_partitions_merge_only]
 (batchId=243)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_dynamic_partitions_move_only]
 (batchId=243)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning]
 (batchId=169)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning_mapjoin_only]
 (batchId=170)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning]
 (batchId=169)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] 
(batchId=235)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema
 (batchId=180)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema
 (batchId=180)
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation 
(batchId=180)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6361/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6361/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6361/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12881518 - PreCommit-HIVE-Build

> Make JSONMessageFactory.getTObj method thread safe
> --
>
> Key: HIVE-17301
> URL: https://issues.apache.org/jira/browse/HIVE-17301
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Reporter: Tao Li
>Assignee: Tao Li
> Attachments: HIVE-17301.1.patch
>
>
> This static method is using a singleton instance of TDeserializer, which is 
> not thread safe. Instead we want to create a new instance per method call. 
> This class is lightweight, so it should be fine from perf perspective. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HIVE-17301) Make JSONMessageFactory.getTObj method thread safe

2017-08-11 Thread Daniel Dai (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124052#comment-16124052
 ] 

Daniel Dai commented on HIVE-17301:
---

+1 pending test.

> Make JSONMessageFactory.getTObj method thread safe
> --
>
> Key: HIVE-17301
> URL: https://issues.apache.org/jira/browse/HIVE-17301
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Reporter: Tao Li
>Assignee: Tao Li
> Attachments: HIVE-17301.1.patch
>
>
> This static method is using a singleton instance of TDeserializer, which is 
> not thread safe. Instead we want to create a new instance per method call. 
> This class is lightweight, so it should be fine from perf perspective. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)