[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261423#comment-16261423 ] ASF GitHub Bot commented on HIVE-17967: --- Github user asfgit closed the pull request at: https://github.com/apache/hive/pull/270 > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17967.2.patch, HIVE-17967.3.patch, > HIVE-17967.4.patch, HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261136#comment-16261136 ] Thejas M Nair commented on HIVE-17967: -- +1 > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17967.2.patch, HIVE-17967.3.patch, > HIVE-17967.4.patch, HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259742#comment-16259742 ] Alan Gates commented on HIVE-17967: --- All test failures age > 1. > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17967.2.patch, HIVE-17967.3.patch, > HIVE-17967.4.patch, HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257980#comment-16257980 ] Hive QA commented on HIVE-17967: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12898308/HIVE-17967.4.patch {color:green}SUCCESS:{color} +1 due to 10 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 11394 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dbtxnmgr_showlocks] (batchId=77) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] (batchId=146) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=162) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=102) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7901/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7901/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7901/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12898308 - PreCommit-HIVE-Build > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17967.2.patch, HIVE-17967.3.patch, > HIVE-17967.4.patch, HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241846#comment-16241846 ] Hive QA commented on HIVE-17967: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12896296/HIVE-17967.3.patch {color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 11373 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=62) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=156) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=102) org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc] (batchId=94) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=111) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=243) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query23] (batchId=243) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=206) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7677/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7677/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7677/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 9 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12896296 - PreCommit-HIVE-Build > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17967.2.patch, HIVE-17967.3.patch, HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239123#comment-16239123 ] Hive QA commented on HIVE-17967: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12895988/HIVE-17967.2.patch {color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 11361 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=62) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] (batchId=146) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=156) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[add_partition_with_whitelist] (batchId=92) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_partition_with_whitelist] (batchId=91) org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc] (batchId=94) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=111) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=206) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAmPoolInteractions (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanQpChanges (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanUserMapping (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAsyncSessionInitFailures (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testClusterFractions (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testDestroyAndReturn (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testQueueing (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReopen (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuse (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithDifferentPool (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithQueueing (batchId=281) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7639/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7639/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7639/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 20 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12895988 - PreCommit-HIVE-Build > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates >Priority: Major > Labels: pull-request-available > Attachments: HIVE-17967.2.patch, HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238552#comment-16238552 ] Alan Gates commented on HIVE-17967: --- Committed to standalone-metastore branch. > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates >Priority: Major > Labels: pull-request-available > Attachments: HIVE-17967.2.patch, HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238468#comment-16238468 ] Alan Gates commented on HIVE-17967: --- Most of the test failures are age > 1, but TestMetaStoreLimitPartitionRequest is real. One of the error messages changed slightly, breaking the test. I'll post a new version of the patch. > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates >Priority: Major > Labels: pull-request-available > Attachments: HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237526#comment-16237526 ] Hive QA commented on HIVE-17967: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12895467/HIVE-17967.patch {color:green}SUCCESS:{color} +1 due to 5 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 32 failed/errored test(s), 11360 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=62) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] (batchId=146) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast] (batchId=157) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=156) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning_2] (batchId=175) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=102) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[add_partition_with_whitelist] (batchId=92) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_partition_with_whitelist] (batchId=91) org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc] (batchId=94) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=111) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=206) org.apache.hadoop.hive.ql.TestMetaStoreLimitPartitionRequest.testMoreComplexQueryWithDirectSqlTooManyPartitions (batchId=223) org.apache.hadoop.hive.ql.TestMetaStoreLimitPartitionRequest.testQueryWithFallbackToORMTooManyPartitions1 (batchId=223) org.apache.hadoop.hive.ql.TestMetaStoreLimitPartitionRequest.testQueryWithFallbackToORMTooManyPartitions2 (batchId=223) org.apache.hadoop.hive.ql.TestMetaStoreLimitPartitionRequest.testQueryWithFallbackToORMTooManyPartitions3 (batchId=223) org.apache.hadoop.hive.ql.TestMetaStoreLimitPartitionRequest.testQueryWithFallbackToORMTooManyPartitions4 (batchId=223) org.apache.hadoop.hive.ql.TestMetaStoreLimitPartitionRequest.testQueryWithInWithFallbackToORMTooManyPartitions (batchId=223) org.apache.hadoop.hive.ql.TestMetaStoreLimitPartitionRequest.testQueryWithInWithFallbackToORMTooManyPartitions2 (batchId=223) org.apache.hadoop.hive.ql.TestMetaStoreLimitPartitionRequest.testQueryWithLikeWithFallbackToORMTooManyPartitions (batchId=223) org.apache.hadoop.hive.ql.TestMetaStoreLimitPartitionRequest.testSimpleQueryWithDirectSqlTooManyPartitions (batchId=223) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAmPoolInteractions (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanQpChanges (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanUserMapping (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAsyncSessionInitFailures (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testClusterFractions (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testDestroyAndReturn (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testQueueing (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReopen (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuse (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithDifferentPool (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithQueueing (batchId=281) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7608/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7608/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7608/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 32 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12895467 - PreCommit-HIVE-Build > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates >Priority: Major > Labels: pull-request-available > Attachments: HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236388#comment-16236388 ] ASF GitHub Bot commented on HIVE-17967: --- GitHub user alanfgates opened a pull request: https://github.com/apache/hive/pull/270 Hive17967 See https://issues.apache.org/jira/browse/HIVE-17967?focusedCommentId=16236387=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16236387 for a few important comments on this patch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alanfgates/hive hive17967 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hive/pull/270.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #270 commit 49e3ba4c13a9532fc872541536ed79ddfb744fab Author: Alan GatesDate: 2017-11-02T16:21:25Z WIP. Have moved HMS, but tests don't all pass yet. commit 3ff8517247286d1efcb0de5321a29859263c6639 Author: Alan Gates Date: 2017-10-17T16:19:22Z Fixes after rebase. Moved EventCleaner and DumpDirCleaner threads to ThreadPool. commit e1086463c2ae9e6df14150796f5e79ae37632b12 Author: Alan Gates Date: 2017-10-17T18:03:43Z Moved TestObjectStore2 back into TestObjectStore now that HiveMetaStore has moved. commit d476dd585976203bac77945ead708ba58492eac1 Author: Alan Gates Date: 2017-11-02T18:33:40Z Fixes after rebase. commit 54af42ad35501c8cd0ad3bb5bae256e6191fbe14 Author: Alan Gates Date: 2017-11-02T18:44:43Z Fixed warnings in pom. Added back deprecated method in ListenerEvent. > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates >Priority: Major > Labels: pull-request-available > Attachments: HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17967) Move HiveMetaStore class
[ https://issues.apache.org/jira/browse/HIVE-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236387#comment-16236387 ] Alan Gates commented on HIVE-17967: --- Per the discussion in HIVE-17812 I added back {{ListenerEvent.getHandler}} in this patch, and marked it deprecated. Also, since HIVE-17580 hasn't been resolved yet, for now I added a simple interface {{StorageSchemaReader}} that can be used to fetch schemas from files. {{SerDeStorageSchemaReader}} is an implementation of that interface that matches the current behavior. > Move HiveMetaStore class > > > Key: HIVE-17967 > URL: https://issues.apache.org/jira/browse/HIVE-17967 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates >Priority: Major > Attachments: HIVE-17967.patch > > > We need to move HiveMetaStore and a few tightly integrated classes into the > standalone metastore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)