[jira] [Commented] (HIVE-18109) Don't reserve pool and default as keywords

2017-11-21 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261956#comment-16261956
 ] 

Sergey Shelukhin commented on HIVE-18109:
-

The definition of show locks is:
{noformat}
| KW_SHOW KW_LOCKS 
  (
  (KW_DATABASE|KW_SCHEMA) => (KW_DATABASE|KW_SCHEMA) (dbName=Identifier) 
(isExtended=KW_EXTENDED)? -> ^(TOK_SHOWDBLOCKS $dbName $isExtended?)
  |
  (parttype=partTypeExpr)? (isExtended=KW_EXTENDED)? -> ^(TOK_SHOWLOCKS 
$parttype? $isExtended?)
  )
{noformat}

I think the problem is dbName=Identifier here; because
{noformat}
identifier
:
Identifier
| nonReserved -> Identifier[$nonReserved.start]
;
{noformat}
but Identifier is just some letters and numbers and stuff.


> Don't reserve pool and default as keywords
> --
>
> Key: HIVE-18109
> URL: https://issues.apache.org/jira/browse/HIVE-18109
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ashutosh Chauhan
>Assignee: Sergey Shelukhin
>
> HIVE-17902 broke this



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-18109) Don't reserve pool and default as keywords

2017-11-21 Thread Eugene Koifman (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261923#comment-16261923
 ] 

Eugene Koifman commented on HIVE-18109:
---

This is the error for dbtxnmgr_showlocks
{noformat}
show locks database default
2017-11-21T19:26:04,553 ERROR [d31f1352-252c-4248-9859-462012e4a065 main] 
ql.Driver: FAILED: ParseException line 3:20 mismatched input 'default' 
expecting Identifier\
 near 'database' in show statement
org.apache.hadoop.hive.ql.parse.ParseException: line 3:20 mismatched input 
'default' expecting Identifier near 'database' in show statement
at 
org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:211)
at org.apache.hadoop.hive.ql.parse.ParseUtils.parse(ParseUtils.java:74)
at org.apache.hadoop.hive.ql.parse.ParseUtils.parse(ParseUtils.java:67)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:544)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1457)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1589)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1356)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1346)
at 
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:239)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:187)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:409)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:342)
at 
org.apache.hadoop.hive.ql.QTestUtil.executeClientInternal(QTestUtil.java:1286)
at 
org.apache.hadoop.hive.ql.QTestUtil.executeClient(QTestUtil.java:1260)
at 
org.apache.hadoop.hive.cli.control.CoreCliDriver.runTest(CoreCliDriver.java:173)
at 
org.apache.hadoop.hive.cli.control.CliAdapter.runTest(CliAdapter.java:104)
at 
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver(TestCliDriver.java:59)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.apache.hadoop.hive.cli.control.CliAdapter$2$1.evaluate(CliAdapter.java:92)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
{noformat}

> Don't reserve pool and default as keywords
> --
>
> Key: HIVE-18109
> URL: https://issues.apache.org/jira/browse/HIVE-18109
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ashutosh Chauhan
>Assignee: Sergey Shelukhin
>
> HIVE-17902 broke this



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-18109) Don't reserve pool and default as keywords

2017-11-21 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261529#comment-16261529
 ] 

Ashutosh Chauhan commented on HIVE-18109:
-

Please take a look at TestCliDriver.testCliDriver[dbtxnmgr_showlocks] This test 
started failing after HIVE-17902 commit and is failing since for every run.

> Don't reserve pool and default as keywords
> --
>
> Key: HIVE-18109
> URL: https://issues.apache.org/jira/browse/HIVE-18109
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ashutosh Chauhan
>Assignee: Sergey Shelukhin
>
> HIVE-17902 broke this



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-18109) Don't reserve pool and default as keywords

2017-11-21 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261522#comment-16261522
 ] 

Sergey Shelukhin commented on HIVE-18109:
-

[~ashutoshc] can you elaborate? they are already added to the non-reserved list

> Don't reserve pool and default as keywords
> --
>
> Key: HIVE-18109
> URL: https://issues.apache.org/jira/browse/HIVE-18109
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ashutosh Chauhan
>Assignee: Sergey Shelukhin
>
> HIVE-17902 broke this



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)