[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297116#comment-16297116
]
Xuefu Zhang commented on HIVE-18283:
+1
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch, HIVE-18283.3.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297042#comment-16297042
]
Andrew Sherman commented on HIVE-18283:
---
Thanks [~csun]. The patch looks good to me. +1
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch, HIVE-18283.3.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296575#comment-16296575
]
Hive QA commented on HIVE-18283:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12902771/HIVE-18283.3.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 15 failed/errored test(s), 11529 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=35)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udaf_context_ngrams]
(batchId=73)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketsortoptimize_insert_2]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=157)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=165)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=169)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=160)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_part]
(batchId=93)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_10]
(batchId=138)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucketsortoptimize_insert_7]
(batchId=128)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=120)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=113)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=209)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=226)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8315/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8315/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8315/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 15 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12902771 - PreCommit-HIVE-Build
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch, HIVE-18283.3.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296489#comment-16296489
]
Hive QA commented on HIVE-18283:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
31s{color} | {color:red} ql: The patch generated 1 new + 72 unchanged - 2 fixed
= 73 total (was 74) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 9efed65 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8315/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8315/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch, HIVE-18283.3.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296059#comment-16296059
]
Hive QA commented on HIVE-18283:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12902712/HIVE-18283.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 16 failed/errored test(s), 11133 tests
executed
*Failed tests:*
{noformat}
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=93)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296005#comment-16296005
]
Hive QA commented on HIVE-18283:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
29s{color} | {color:red} ql: The patch generated 2 new + 72 unchanged - 2 fixed
= 74 total (was 74) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 6s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 9efed65 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8308/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8308/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295991#comment-16295991
]
Hive QA commented on HIVE-18283:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12902712/HIVE-18283.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 17 failed/errored test(s), 11529 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=35)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_udf2]
(batchId=73)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketsortoptimize_insert_2]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=157)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=165)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=169)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucketizedhiveinputformat]
(batchId=178)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_part]
(batchId=93)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[stats_aggregator_error_1]
(batchId=93)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_10]
(batchId=138)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucketsortoptimize_insert_7]
(batchId=128)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=120)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=113)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=209)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=226)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8307/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8307/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8307/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 17 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12902712 - PreCommit-HIVE-Build
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295967#comment-16295967
]
Andrew Sherman commented on HIVE-18283:
---
Patch looks good to me.
If you do rework it again you might
1) change the order of arguments to assertEquals as the expected value is
supposed to be first in junit
2) refactor out some of testGetHiveException() so that you can call
{noformat}
checkExpectedException("\t diagnostics: Application
application_1508358311878_3322732 "
+ "failed 1 times due to ApplicationMaster for attempt "
+ "appattempt_1508358311878_3322732_01 timed out. Failing
the application.",
ErrorMsg.SPARK_CREATE_CLIENT_TIMEOUT);
checkExpectedException("\t diagnostics: Application
application_1508358311878_333 "
+ "submitted by user hive to unknown queue: foo",
ErrorMsg.SPARK_CREATE_CLIENT_INVALID_QUEUE);
{noformat}
etc. as this would make it more readable and extendable.
But these are nits, the basic code is good and will be useful
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295922#comment-16295922
]
Hive QA commented on HIVE-18283:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
31s{color} | {color:red} ql: The patch generated 2 new + 72 unchanged - 2 fixed
= 74 total (was 74) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 9efed65 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8307/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8307/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295898#comment-16295898
]
Xuefu Zhang commented on HIVE-18283:
Patch looks good to me except for a minor improvement on a faster match() with
precompiled patterns.
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295876#comment-16295876
]
Chao Sun commented on HIVE-18283:
-
I don't think the test failures are related. [~xuefuz], [~asherman]: could you
take a look when you have time? Thanks!
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295718#comment-16295718
]
Hive QA commented on HIVE-18283:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12902702/HIVE-18283.1.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 17 failed/errored test(s), 11532 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_dynamic_partitions_move_only]
(batchId=249)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join25] (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=35)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketsortoptimize_insert_2]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=157)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=165)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=169)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=160)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_part]
(batchId=93)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_10]
(batchId=138)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucketsortoptimize_insert_7]
(batchId=128)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=120)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=113)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=209)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=226)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8303/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8303/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8303/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 17 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12902702 - PreCommit-HIVE-Build
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch,
> HIVE-18283.2.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295642#comment-16295642
]
Hive QA commented on HIVE-18283:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
31s{color} | {color:red} ql: The patch generated 18 new + 72 unchanged - 2
fixed = 90 total (was 74) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 8259022 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8303/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8303/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch, HIVE-18283.1.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292958#comment-16292958
]
Chao Sun commented on HIVE-18283:
-
[~asherman] Yes, this definitely deserves a test case, although it might be
tricky. Let me come up with one.
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18283) Better error message and error code for HoS exceptions
[
https://issues.apache.org/jira/browse/HIVE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292899#comment-16292899
]
Andrew Sherman commented on HIVE-18283:
---
As the new getHiveException() method could be fragile, is it worth having a
unit test that exercises it with some actual errror messages?
> Better error message and error code for HoS exceptions
> --
>
> Key: HIVE-18283
> URL: https://issues.apache.org/jira/browse/HIVE-18283
> Project: Hive
> Issue Type: Improvement
> Components: Spark
>Reporter: Chao Sun
>Assignee: Chao Sun
> Attachments: HIVE-18283.0.patch
>
>
> Right now HoS only use a few error codes. For the majority of the errors,
> user will see an error code 1 followed by a lengthy stacktrace. This is not
> ideal since:
> 1. It is often hard to find the root cause - sometimes it is hidden deeply
> inside the stacktrace.
> 2. After identifying the root cause, it is not easy to find a fix. Often user
> have to copy & paste the error message and google them.
> 3. It is not clear whether the error is transient or not, depending on which
> user may want to retry the query.
> To improve the above, this JIRA propose to assign error code & canonical
> error messages for different HoS errors. We can take advantage of the
> existing {{ErrorMsg}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
