[jira] [Commented] (HIVE-18356) Fixing license headers in checkstyle
[
https://issues.apache.org/jira/browse/HIVE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308631#comment-16308631
]
Andrew Sherman commented on HIVE-18356:
---
+1 LGTM. Thanks for doing this [~pvary]
> Fixing license headers in checkstyle
>
>
> Key: HIVE-18356
> URL: https://issues.apache.org/jira/browse/HIVE-18356
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Minor
> Attachments: HIVE-18356.patch
>
>
> The checkstyle header contains the following ASF header:
> {code}
> /**
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
> Even if we undecided what to do with the already existing headers
> (HIVE-17952), the new ones should use the proper one with 1 '*' in the first
> line:
> {code}
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18356) Fixing license headers in checkstyle
[
https://issues.apache.org/jira/browse/HIVE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308526#comment-16308526
]
Prasanth Jayachandran commented on HIVE-18356:
--
+1
> Fixing license headers in checkstyle
>
>
> Key: HIVE-18356
> URL: https://issues.apache.org/jira/browse/HIVE-18356
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Minor
> Attachments: HIVE-18356.patch
>
>
> The checkstyle header contains the following ASF header:
> {code}
> /**
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
> Even if we undecided what to do with the already existing headers
> (HIVE-17952), the new ones should use the proper one with 1 '*' in the first
> line:
> {code}
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18356) Fixing license headers in checkstyle
[
https://issues.apache.org/jira/browse/HIVE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308318#comment-16308318
]
Peter Vary commented on HIVE-18356:
---
The failures are not related
> Fixing license headers in checkstyle
>
>
> Key: HIVE-18356
> URL: https://issues.apache.org/jira/browse/HIVE-18356
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Minor
> Attachments: HIVE-18356.patch
>
>
> The checkstyle header contains the following ASF header:
> {code}
> /**
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
> Even if we undecided what to do with the already existing headers
> (HIVE-17952), the new ones should use the proper one with 1 '*' in the first
> line:
> {code}
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18356) Fixing license headers in checkstyle
[
https://issues.apache.org/jira/browse/HIVE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308294#comment-16308294
]
Hive QA commented on HIVE-18356:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12904223/HIVE-18356.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 22 failed/errored test(s), 11542 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join25] (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook]
(batchId=12)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=35)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketsortoptimize_insert_2]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_rp_lineage2]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lineage2]
(batchId=163)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lineage3]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_reduce_groupby_duplicate_cols]
(batchId=158)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_part]
(batchId=93)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=120)
org.apache.hadoop.hive.metastore.TestEmbeddedHiveMetaStore.testTransactionalValidation
(batchId=213)
org.apache.hadoop.hive.ql.TestAcidOnTez.testMapJoinOnTez (batchId=222)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=253)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=225)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=231)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=231)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=231)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8395/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8395/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8395/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 22 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12904223 - PreCommit-HIVE-Build
> Fixing license headers in checkstyle
>
>
> Key: HIVE-18356
> URL: https://issues.apache.org/jira/browse/HIVE-18356
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Minor
> Attachments: HIVE-18356.patch
>
>
> The checkstyle header contains the following ASF header:
> {code}
> /**
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
> Even if we undecided what to do with the already existing headers
> (HIVE-17952), the new ones should use the proper one with 1 '*' in the first
> line:
> {code}
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18356) Fixing license headers in checkstyle
[
https://issues.apache.org/jira/browse/HIVE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308181#comment-16308181
]
Hive QA commented on HIVE-18356:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 2m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 035eca3 |
| modules | C: storage-api standalone-metastore . U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8395/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Fixing license headers in checkstyle
>
>
> Key: HIVE-18356
> URL: https://issues.apache.org/jira/browse/HIVE-18356
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Minor
> Attachments: HIVE-18356.patch
>
>
> The checkstyle header contains the following ASF header:
> {code}
> /**
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
> Even if we undecided what to do with the already existing headers
> (HIVE-17952), the new ones should use the proper one with 1 '*' in the first
> line:
> {code}
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18356) Fixing license headers in checkstyle
[
https://issues.apache.org/jira/browse/HIVE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308040#comment-16308040
]
Peter Vary commented on HIVE-18356:
---
[~prasanth_j], [~asherman]: Could you please review?
Thanks,
Peter
> Fixing license headers in checkstyle
>
>
> Key: HIVE-18356
> URL: https://issues.apache.org/jira/browse/HIVE-18356
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Minor
> Attachments: HIVE-18356.patch
>
>
> The checkstyle header contains the following ASF header:
> {code}
> /**
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
> Even if we undecided what to do with the already existing headers
> (HIVE-17952), the new ones should use the proper one with 1 '*' in the first
> line:
> {code}
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> [..]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
