[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436079#comment-16436079
]
Aihua Xu commented on HIVE-18525:
-
+1.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, HIVE-18525.4.patch, Job-Page-Collapsed.png,
> Job-Page-Expanded.png, Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434322#comment-16434322
]
Sahil Takiar commented on HIVE-18525:
-
[~aihuaxu] any other comments?
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, HIVE-18525.4.patch, Job-Page-Collapsed.png,
> Job-Page-Expanded.png, Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427862#comment-16427862
]
Sahil Takiar commented on HIVE-18525:
-
[~aihuaxu] thanks for taking a look. I think the test failures are actually
unrelated. A Hive QA run on HIVE-19033 at a similar time showed an almost
identical list of test failures, with the exception of {{TestCliDriver}}
{{auto_sortmerge_join_2.q}} which I ran locally without any issues, so probably
another flaky test.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, HIVE-18525.4.patch, Job-Page-Collapsed.png,
> Job-Page-Expanded.png, Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425630#comment-16425630
]
BELUGA BEHR commented on HIVE-18525:
+1 on the idea
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, HIVE-18525.4.patch, Job-Page-Collapsed.png,
> Job-Page-Expanded.png, Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424665#comment-16424665
]
Aihua Xu commented on HIVE-18525:
-
[~stakiar] This enhancement looks great. Can you take a look the test failures?
Seems related to the change.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, HIVE-18525.4.patch, Job-Page-Collapsed.png,
> Job-Page-Expanded.png, Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424113#comment-16424113
]
Hive QA commented on HIVE-18525:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12917269/HIVE-18525.4.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 191 failed/errored test(s), 13299 tests
executed
*Failed tests:*
{noformat}
TestCopyUtils - did not produce a TEST-*.xml file (likely timed out)
(batchId=230)
TestDbNotificationListener - did not produce a TEST-*.xml file (likely timed
out) (batchId=246)
TestExportImport - did not produce a TEST-*.xml file (likely timed out)
(batchId=230)
TestHCatHiveCompatibility - did not produce a TEST-*.xml file (likely timed
out) (batchId=246)
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=95)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424026#comment-16424026
]
Hive QA commented on HIVE-18525:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
49s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
45s{color} | {color:red} ql: The patch generated 5 new + 75 unchanged - 1 fixed
= 80 total (was 76) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
14s{color} | {color:red} The patch generated 50 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9974/dev-support/hive-personality.sh
|
| git revision | master / ec17339 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9974/yetus/diff-checkstyle-ql.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9974/yetus/patch-asflicense-problems.txt
|
| modules | C: common ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9974/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, HIVE-18525.4.patch, Job-Page-Collapsed.png,
> Job-Page-Expanded.png, Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423239#comment-16423239
]
Sahil Takiar commented on HIVE-18525:
-
[~xuefuz], [~aihuaxu] could you take a look?
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, HIVE-18525.4.patch, Job-Page-Collapsed.png,
> Job-Page-Expanded.png, Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423233#comment-16423233
]
Sahil Takiar commented on HIVE-18525:
-
Attached updated patch with a few changes:
* Made the patch configurable, but turned on by default
* Truncate each stage of the explain plan at 100,000 characters
I made these changes to address any possible issues where the explain plans are
so big that they overwhelm the Spark Web UI. This could happen if a user
submits a very, very long query.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, HIVE-18525.4.patch, Job-Page-Collapsed.png,
> Job-Page-Expanded.png, Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419661#comment-16419661
]
Sahil Takiar commented on HIVE-18525:
-
I looked into doing that, but it seems that the Web UI collapses everything
onto a single line, so the formatting of the explain plan would be very off.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, Job-Page-Collapsed.png, Job-Page-Expanded.png,
> Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414268#comment-16414268
]
Xuefu Zhang commented on HIVE-18525:
{quote}
I haven't found a way to do that in the Spark Web UI yet. This might be
possible if we implement HIVE-18515, but that would require quite a bit of work.
{quote}
Maybe we can put the overall explain plan at the job description, similar to
what you do here for stages.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, Job-Page-Collapsed.png, Job-Page-Expanded.png,
> Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412939#comment-16412939
]
Hive QA commented on HIVE-18525:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12915970/HIVE-18525.3.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 23 failed/errored test(s), 13038 tests
executed
*Failed tests:*
{noformat}
TestMinimrCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=92)
[infer_bucket_sort_num_buckets.q,infer_bucket_sort_reducers_power_two.q,parallel_orderby.q,bucket_num_reducers_acid.q,infer_bucket_sort_map_operators.q,infer_bucket_sort_merge.q,root_dir_external_table.q,infer_bucket_sort_dyn_part.q,udf_using.q,bucket_num_reducers_acid2.q]
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=94)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412921#comment-16412921
]
Hive QA commented on HIVE-18525:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
38s{color} | {color:red} ql: The patch generated 4 new + 75 unchanged - 1 fixed
= 79 total (was 76) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
13s{color} | {color:red} The patch generated 50 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 16m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9817/dev-support/hive-personality.sh
|
| git revision | master / 5b222db |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9817/yetus/diff-checkstyle-ql.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9817/yetus/patch-asflicense-problems.txt
|
| modules | C: common ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9817/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, Job-Page-Collapsed.png, Job-Page-Expanded.png,
> Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411965#comment-16411965
]
Sahil Takiar commented on HIVE-18525:
-
Thanks for the feedback [~xuefuz]!
{quote} s a related question, do we show the plan at the job level? That is,
show the whole query plan for a spark job. That could be useful too. {quote}
That would be useful too. I haven't found a way to do that in the Spark Web UI
yet. This might be possible if we implement HIVE-18515, but that would require
quite a bit of work.
Attached an updated patch + RB link; new patch includes a unit test, PerLogger
integration, and some other cleanup.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> HIVE-18525.3.patch, Job-Page-Collapsed.png, Job-Page-Expanded.png,
> Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408965#comment-16408965
]
Xuefu Zhang commented on HIVE-18525:
The feature looks good and useful to me. I don't think generating the explain
plan costs too much. However, you might to put some perf logs so it can be
measured. For this, I don't think we need to make it configurable unless later
perf log shows otherwise.
As a related question, do we show the plan at the job level? That is, show the
whole query plan for a spark job. That could be useful too.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> Job-Page-Collapsed.png, Job-Page-Expanded.png, Map-Explain-Plan.png,
> Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408816#comment-16408816
]
Sahil Takiar commented on HIVE-18525:
-
[~xuefuz], [~aihuaxu], [~belugabehr] any thoughts on this feature? I've
attached multiple screenshots to show what the Web UI looks like.
Some things to note:
* Not sure whether to make this feature configurable, and not sure whether to
turn it on or off
* This change is mainly geared to users who use the Spark Web UI to visualize /
debug their queries
* Spark SQL has a similar-ish feature, so ideally the Web UI should be able to
handle the extra per-query info
* The patch is still a WIP, I need to profile how long it takes for the explain
plan to get generated
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> Job-Page-Collapsed.png, Job-Page-Expanded.png, Map-Explain-Plan.png,
> Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372584#comment-16372584
]
Hive QA commented on HIVE-18525:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12911486/HIVE-18525.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 40 failed/errored test(s), 13407 tests
executed
*Failed tests:*
{noformat}
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=94)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372539#comment-16372539
]
Hive QA commented on HIVE-18525:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
36s{color} | {color:red} ql: The patch generated 2 new + 75 unchanged - 1 fixed
= 77 total (was 76) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
13s{color} | {color:red} The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 5s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9306/dev-support/hive-personality.sh
|
| git revision | master / ec2378f |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9306/yetus/diff-checkstyle-ql.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9306/yetus/patch-asflicense-problems.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9306/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372340#comment-16372340
]
Sahil Takiar commented on HIVE-18525:
-
Rebasing patch
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, HIVE-18525.2.patch,
> Map-Explain-Plan.png, Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372311#comment-16372311
]
Hive QA commented on HIVE-18525:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12911464/Reduce-Explain-Plan.png
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9300/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9300/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9300/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-02-22 01:50:41.965
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-9300/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-02-22 01:50:41.968
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at dcb3817 HIVE-18573 : Use proper Calcite operator instead of UDFs
(Slim Bouguerra via Ashutosh Chauhan)
+ git clean -f -d
Removing ${project.basedir}/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at dcb3817 HIVE-18573 : Use proper Calcite operator instead of UDFs
(Slim Bouguerra via Ashutosh Chauhan)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-02-22 01:50:46.242
+ rm -rf ../yetus_PreCommit-HIVE-Build-9300
+ mkdir ../yetus_PreCommit-HIVE-Build-9300
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-9300
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-9300/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
fatal: unrecognized input
fatal: unrecognized input
fatal: unrecognized input
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12911464 - PreCommit-HIVE-Build
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, Map-Explain-Plan.png,
> Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18525) Add explain plan to Hive on Spark Web UI
[
https://issues.apache.org/jira/browse/HIVE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372268#comment-16372268
]
Sahil Takiar commented on HIVE-18525:
-
Attaching a POC patch. Attached a few screenshots of what the updated UI looks
like. There are some open questions I still need to work on:
* Does generating the explain plan for each query add additional overhead? If
so, how much?
* Whats the best way to make the code in {{ExplainTask}} useable in
{{SparkPlan}}?
* Should this be turned on by default, or disabled by default? Should it be
configurable? Should it be tied to the existing configuration
{{hive.log.explain.output}}?
> Add explain plan to Hive on Spark Web UI
>
>
> Key: HIVE-18525
> URL: https://issues.apache.org/jira/browse/HIVE-18525
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-18525.1.patch, Map-Explain-Plan.png,
> Reduce-Explain-Plan.png
>
>
> More of an investigation JIRA. The Spark UI has a "long description" of each
> stage in the Spark DAG. Typically one stage in the Spark DAG corresponds to
> either a {{MapWork}} or {{ReduceWork}} object. It would be useful if the long
> description contained the explain plan of the corresponding work object.
> I'm not sure how much additional overhead this would introduce. If not the
> full explain plan, then maybe a modified one that just lists out all the
> operator tree along with each operator name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
