[jira] [Commented] (HIVE-18531) Vectorization: Vectorized PTF operator should not set the initial type infos
[ https://issues.apache.org/jira/browse/HIVE-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340751#comment-16340751 ] Matt McCline commented on HIVE-18531: - Committed to master. [~teddy.choi] thank you for your review and PTF Q file check. > Vectorization: Vectorized PTF operator should not set the initial type infos > > > Key: HIVE-18531 > URL: https://issues.apache.org/jira/browse/HIVE-18531 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.0.0 >Reporter: Matt McCline >Priority: Critical > Fix For: 3.0.0 > > Attachments: HIVE-18531.01.patch > > > The Vectorized PTF operator is mistakenly setting the initial type infos for > its output VectorizationContext. It should not. It is only creating a > projection of the initial column names/type infos from ReduceSink (i.e. keys, > values) plus scratch columns for output columns for which the type infos are > already known. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18531) Vectorization: Vectorized PTF operator should not set the initial type infos
[ https://issues.apache.org/jira/browse/HIVE-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340732#comment-16340732 ] Matt McCline commented on HIVE-18531: - No related failures. > Vectorization: Vectorized PTF operator should not set the initial type infos > > > Key: HIVE-18531 > URL: https://issues.apache.org/jira/browse/HIVE-18531 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.0.0 >Reporter: Matt McCline >Priority: Critical > Attachments: HIVE-18531.01.patch > > > The Vectorized PTF operator is mistakenly setting the initial type infos for > its output VectorizationContext. It should not. It is only creating a > projection of the initial column names/type infos from ReduceSink (i.e. keys, > values) plus scratch columns for output columns for which the type infos are > already known. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18531) Vectorization: Vectorized PTF operator should not set the initial type infos
[
https://issues.apache.org/jira/browse/HIVE-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340610#comment-16340610
]
Hive QA commented on HIVE-18531:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12907595/HIVE-18531.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 11661 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook]
(batchId=12)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=35)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl]
(batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=165)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=169)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan]
(batchId=163)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_input_format_excludes]
(batchId=162)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_part]
(batchId=94)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[stats_aggregator_error_1]
(batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=121)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query64]
(batchId=246)
org.apache.hadoop.hive.metastore.TestMetastoreExpr.testPartitionExpr
(batchId=257)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=254)
org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=186)
org.apache.hive.hcatalog.common.TestHiveClientCache.testCloseAllClients
(batchId=198)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=232)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=232)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=232)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8843/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8843/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8843/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 20 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12907595 - PreCommit-HIVE-Build
> Vectorization: Vectorized PTF operator should not set the initial type infos
>
>
> Key: HIVE-18531
> URL: https://issues.apache.org/jira/browse/HIVE-18531
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 3.0.0
>Reporter: Matt McCline
>Priority: Critical
> Attachments: HIVE-18531.01.patch
>
>
> The Vectorized PTF operator is mistakenly setting the initial type infos for
> its output VectorizationContext. It should not. It is only creating a
> projection of the initial column names/type infos from ReduceSink (i.e. keys,
> values) plus scratch columns for output columns for which the type infos are
> already known.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18531) Vectorization: Vectorized PTF operator should not set the initial type infos
[
https://issues.apache.org/jira/browse/HIVE-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340590#comment-16340590
]
Hive QA commented on HIVE-18531:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
14s{color} | {color:red} The patch generated 6 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 26be99d |
| Default Java | 1.8.0_111 |
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8843/yetus/patch-asflicense-problems.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8843/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Vectorization: Vectorized PTF operator should not set the initial type infos
>
>
> Key: HIVE-18531
> URL: https://issues.apache.org/jira/browse/HIVE-18531
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 3.0.0
>Reporter: Matt McCline
>Priority: Critical
> Attachments: HIVE-18531.01.patch
>
>
> The Vectorized PTF operator is mistakenly setting the initial type infos for
> its output VectorizationContext. It should not. It is only creating a
> projection of the initial column names/type infos from ReduceSink (i.e. keys,
> values) plus scratch columns for output columns for which the type infos are
> already known.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18531) Vectorization: Vectorized PTF operator should not set the initial type infos
[ https://issues.apache.org/jira/browse/HIVE-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340409#comment-16340409 ] Matt McCline commented on HIVE-18531: - Change confirmed with a large query that triggered the issue. No small test case. > Vectorization: Vectorized PTF operator should not set the initial type infos > > > Key: HIVE-18531 > URL: https://issues.apache.org/jira/browse/HIVE-18531 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.0.0 >Reporter: Matt McCline >Priority: Critical > Attachments: HIVE-18531.01.patch > > > The Vectorized PTF operator is mistakenly setting the initial type infos for > its output VectorizationContext. It should not. It is only creating a > projection of the initial column names/type infos from ReduceSink (i.e. keys, > values) plus scratch columns for output columns for which the type infos are > already known. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18531) Vectorization: Vectorized PTF operator should not set the initial type infos
[ https://issues.apache.org/jira/browse/HIVE-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339046#comment-16339046 ] Teddy Choi commented on HIVE-18531: --- +1 with pending tests. I tried this patch with ptf.* q files and all of them passed. > Vectorization: Vectorized PTF operator should not set the initial type infos > > > Key: HIVE-18531 > URL: https://issues.apache.org/jira/browse/HIVE-18531 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.0.0 >Reporter: Matt McCline >Priority: Critical > Attachments: HIVE-18531.01.patch > > > The Vectorized PTF operator is mistakenly setting the initial type infos for > its output VectorizationContext. It should not. It is only creating a > projection of the initial column names/type infos from ReduceSink (i.e. keys, > values) plus scratch columns for output columns for which the type infos are > already known. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18531) Vectorization: Vectorized PTF operator should not set the initial type infos
[ https://issues.apache.org/jira/browse/HIVE-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338448#comment-16338448 ] Matt McCline commented on HIVE-18531: - Found with a large query. Need to come up with a small repro that can be made into a Q file. > Vectorization: Vectorized PTF operator should not set the initial type infos > > > Key: HIVE-18531 > URL: https://issues.apache.org/jira/browse/HIVE-18531 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.0.0 >Reporter: Matt McCline >Priority: Critical > > The Vectorized PTF operator is mistakenly setting the initial type infos for > its output VectorizationContext. It should not. It is only creating a > projection of the initial columns from ReduceSink (i.e. keys, values) plus > scratch columns for output columns. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
