[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[
https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359491#comment-16359491
]
Hive QA commented on HIVE-18627:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12909894/HIVE-18627.4.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 26 failed/errored test(s), 13151 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries]
(batchId=241)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=79)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1]
(batchId=172)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=167)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=162)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucketizedhiveinputformat]
(batchId=180)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucketmapjoin6]
(batchId=180)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[dynamic_rdd_cache]
(batchId=180)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_opt_shuffle_serde]
(batchId=180)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=122)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query1]
(batchId=251)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=222)
org.apache.hadoop.hive.metastore.TestHiveMetaTool.testListFSRoot (batchId=226)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartition[Embedded]
(batchId=206)
org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testSingleSourceMultipleFiltersOrdering1
(batchId=288)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=257)
org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=235)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=235)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=235)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9140/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9140/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9140/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 26 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12909894 - PreCommit-HIVE-Build
> PPD: Handle FLOAT boxing differently for single/double precision constants
> --
>
> Key: HIVE-18627
> URL: https://issues.apache.org/jira/browse/HIVE-18627
> Project: Hive
> Issue Type: Bug
> Components: Types
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-18627.1.patch, HIVE-18627.2.patch,
> HIVE-18627.3.patch, HIVE-18627.4.patch
>
>
> Constants like 0.1 and 0.3 are differently boxed based on intermediate
> precision of the compiler codepath.
> Disabling CBO produces 0.1BD constants which fail to box correctly to
> Double/Float.
> Enabling CBO fixes this issue, but cannot be applied all queries in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[
https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359462#comment-16359462
]
Hive QA commented on HIVE-18627:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
42s{color} | {color:red} ql: The patch generated 32 new + 71 unchanged - 17
fixed = 103 total (was 88) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 89e75c7 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9140/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9140/yetus/whitespace-eol.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9140/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> PPD: Handle FLOAT boxing differently for single/double precision constants
> --
>
> Key: HIVE-18627
> URL: https://issues.apache.org/jira/browse/HIVE-18627
> Project: Hive
> Issue Type: Bug
> Components: Types
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-18627.1.patch, HIVE-18627.2.patch,
> HIVE-18627.3.patch, HIVE-18627.4.patch
>
>
> Constants like 0.1 and 0.3 are differently boxed based on intermediate
> precision of the compiler codepath.
> Disabling CBO produces 0.1BD constants which fail to box correctly to
> Double/Float.
> Enabling CBO fixes this issue, but cannot be applied all queries in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[ https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357985#comment-16357985 ] Gopal V commented on HIVE-18627: Rebased and regenerated q.out with TestMiniLlapCliDriver instead of TestMiniLlapLocalCliDriver to fix the missing HDFS counters. > PPD: Handle FLOAT boxing differently for single/double precision constants > -- > > Key: HIVE-18627 > URL: https://issues.apache.org/jira/browse/HIVE-18627 > Project: Hive > Issue Type: Bug > Components: Types >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-18627.1.patch, HIVE-18627.2.patch, > HIVE-18627.3.patch, HIVE-18627.4.patch > > > Constants like 0.1 and 0.3 are differently boxed based on intermediate > precision of the compiler codepath. > Disabling CBO produces 0.1BD constants which fail to box correctly to > Double/Float. > Enabling CBO fixes this issue, but cannot be applied all queries in Hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[
https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357933#comment-16357933
]
Hive QA commented on HIVE-18627:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12909692/HIVE-18627.3.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 22 failed/errored test(s), 12995 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries]
(batchId=240)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=79)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=148)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1]
(batchId=172)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=167)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=162)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_opt_shuffle_serde]
(batchId=180)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=122)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query1]
(batchId=250)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=221)
org.apache.hadoop.hive.ql.exec.TestOperators.testNoConditionalTaskSizeForLlap
(batchId=282)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=256)
org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=234)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=234)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=234)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9107/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9107/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9107/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 22 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12909692 - PreCommit-HIVE-Build
> PPD: Handle FLOAT boxing differently for single/double precision constants
> --
>
> Key: HIVE-18627
> URL: https://issues.apache.org/jira/browse/HIVE-18627
> Project: Hive
> Issue Type: Bug
> Components: Types
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-18627.1.patch, HIVE-18627.2.patch,
> HIVE-18627.3.patch
>
>
> Constants like 0.1 and 0.3 are differently boxed based on intermediate
> precision of the compiler codepath.
> Disabling CBO produces 0.1BD constants which fail to box correctly to
> Double/Float.
> Enabling CBO fixes this issue, but cannot be applied all queries in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[
https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357907#comment-16357907
]
Hive QA commented on HIVE-18627:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 32 new + 71 unchanged - 17
fixed = 103 total (was 88) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 17s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 3464df4 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9107/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9107/yetus/whitespace-eol.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9107/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> PPD: Handle FLOAT boxing differently for single/double precision constants
> --
>
> Key: HIVE-18627
> URL: https://issues.apache.org/jira/browse/HIVE-18627
> Project: Hive
> Issue Type: Bug
> Components: Types
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-18627.1.patch, HIVE-18627.2.patch,
> HIVE-18627.3.patch
>
>
> Constants like 0.1 and 0.3 are differently boxed based on intermediate
> precision of the compiler codepath.
> Disabling CBO produces 0.1BD constants which fail to box correctly to
> Double/Float.
> Enabling CBO fixes this issue, but cannot be applied all queries in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[
https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355482#comment-16355482
]
Hive QA commented on HIVE-18627:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12909503/HIVE-18627.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 24 failed/errored test(s), 12978 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries]
(batchId=240)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook]
(batchId=13)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=79)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=148)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1]
(batchId=172)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=167)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=161)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=122)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=221)
org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCTAS (batchId=280)
org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCTAS (batchId=280)
org.apache.hadoop.hive.ql.exec.TestOperators.testNoConditionalTaskSizeForLlap
(batchId=282)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=256)
org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188)
org.apache.hive.hcatalog.mapreduce.TestHCatOutputFormat.testGetTableSchema
(batchId=200)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=234)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=234)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=234)
org.apache.hive.jdbc.TestTriggersMoveWorkloadManager.testTriggerMoveBackKill
(batchId=235)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9069/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9069/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9069/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 24 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12909503 - PreCommit-HIVE-Build
> PPD: Handle FLOAT boxing differently for single/double precision constants
> --
>
> Key: HIVE-18627
> URL: https://issues.apache.org/jira/browse/HIVE-18627
> Project: Hive
> Issue Type: Bug
> Components: Types
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-18627.1.patch, HIVE-18627.2.patch
>
>
> Constants like 0.1 and 0.3 are differently boxed based on intermediate
> precision of the compiler codepath.
> Disabling CBO produces 0.1BD constants which fail to box correctly to
> Double/Float.
> Enabling CBO fixes this issue, but cannot be applied all queries in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[
https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355418#comment-16355418
]
Hive QA commented on HIVE-18627:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
42s{color} | {color:red} ql: The patch generated 32 new + 71 unchanged - 17
fixed = 103 total (was 88) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 48s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / acc62e3 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9069/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9069/yetus/whitespace-eol.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9069/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> PPD: Handle FLOAT boxing differently for single/double precision constants
> --
>
> Key: HIVE-18627
> URL: https://issues.apache.org/jira/browse/HIVE-18627
> Project: Hive
> Issue Type: Bug
> Components: Types
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-18627.1.patch, HIVE-18627.2.patch
>
>
> Constants like 0.1 and 0.3 are differently boxed based on intermediate
> precision of the compiler codepath.
> Disabling CBO produces 0.1BD constants which fail to box correctly to
> Double/Float.
> Enabling CBO fixes this issue, but cannot be applied all queries in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[ https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354570#comment-16354570 ] Prasanth Jayachandran commented on HIVE-18627: -- +1. I wonder why the file system counters are removed for some tests. > PPD: Handle FLOAT boxing differently for single/double precision constants > -- > > Key: HIVE-18627 > URL: https://issues.apache.org/jira/browse/HIVE-18627 > Project: Hive > Issue Type: Bug > Components: Types >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-18627.1.patch, HIVE-18627.2.patch > > > Constants like 0.1 and 0.3 are differently boxed based on intermediate > precision of the compiler codepath. > Disabling CBO produces 0.1BD constants which fail to box correctly to > Double/Float. > Enabling CBO fixes this issue, but cannot be applied all queries in Hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[ https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354414#comment-16354414 ] Gopal V commented on HIVE-18627: This is the test that fails if I fix it by Boxing from Decimal -> Double. If I do Decimal -> Float -> Double, it passes. This test fails if I fixed it without the new Enum to box those two differently. I'll add a 1 row Double test, to cover the broken case. > PPD: Handle FLOAT boxing differently for single/double precision constants > -- > > Key: HIVE-18627 > URL: https://issues.apache.org/jira/browse/HIVE-18627 > Project: Hive > Issue Type: Bug > Components: Types >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-18627.1.patch > > > Constants like 0.1 and 0.3 are differently boxed based on intermediate > precision of the compiler codepath. > Disabling CBO produces 0.1BD constants which fail to box correctly to > Double/Float. > Enabling CBO fixes this issue, but cannot be applied all queries in Hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[ https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354395#comment-16354395 ] Prasanth Jayachandran commented on HIVE-18627: -- [~gopalv] how come the tests weren't failing then? can we add a test for the delete with filter 0.1 which was originally causing this issue? > PPD: Handle FLOAT boxing differently for single/double precision constants > -- > > Key: HIVE-18627 > URL: https://issues.apache.org/jira/browse/HIVE-18627 > Project: Hive > Issue Type: Bug > Components: Types >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-18627.1.patch > > > Constants like 0.1 and 0.3 are differently boxed based on intermediate > precision of the compiler codepath. > Disabling CBO produces 0.1BD constants which fail to box correctly to > Double/Float. > Enabling CBO fixes this issue, but cannot be applied all queries in Hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[
https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354352#comment-16354352
]
Gopal V commented on HIVE-18627:
[~prasanth_j]: the tests already have
{code}
set hive.optimize.index.filter=false;
-- when cbo is disabled constant gets converted to HiveDecimal
select count(*) from orc_ppd where f=74.72;
set hive.optimize.index.filter=true;
select count(*) from orc_ppd where f=74.72;
set hive.cbo.enable=true;
set hive.optimize.index.filter=false;
select count(*) from orc_ppd where f=74.72;
set hive.optimize.index.filter=true;
select count(*) from orc_ppd where f=74.72;
{code}
> PPD: Handle FLOAT boxing differently for single/double precision constants
> --
>
> Key: HIVE-18627
> URL: https://issues.apache.org/jira/browse/HIVE-18627
> Project: Hive
> Issue Type: Bug
> Components: Types
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-18627.1.patch
>
>
> Constants like 0.1 and 0.3 are differently boxed based on intermediate
> precision of the compiler codepath.
> Disabling CBO produces 0.1BD constants which fail to box correctly to
> Double/Float.
> Enabling CBO fixes this issue, but cannot be applied all queries in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[
https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353855#comment-16353855
]
Hive QA commented on HIVE-18627:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12909326/HIVE-18627.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 26 failed/errored test(s), 12974 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries]
(batchId=240)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2]
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook]
(batchId=13)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=79)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb]
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1]
(batchId=172)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=167)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucketizedhiveinputformat]
(batchId=180)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=122)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=221)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyDb[Embedded]
(batchId=206)
org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCTAS (batchId=280)
org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCTAS (batchId=280)
org.apache.hadoop.hive.ql.exec.TestOperators.testNoConditionalTaskSizeForLlap
(batchId=282)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=256)
org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=234)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=234)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=234)
org.apache.hive.jdbc.TestTriggersMoveWorkloadManager.testTriggerMoveAndKill
(batchId=235)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9040/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9040/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9040/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 26 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12909326 - PreCommit-HIVE-Build
> PPD: Handle FLOAT boxing differently for single/double precision constants
> --
>
> Key: HIVE-18627
> URL: https://issues.apache.org/jira/browse/HIVE-18627
> Project: Hive
> Issue Type: Bug
> Components: Types
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-18627.1.patch
>
>
> Constants like 0.1 and 0.3 are differently boxed based on intermediate
> precision of the compiler codepath.
> Disabling CBO produces 0.1BD constants which fail to box correctly to
> Double/Float.
> Enabling CBO fixes this issue, but cannot be applied all queries in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[
https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353783#comment-16353783
]
Hive QA commented on HIVE-18627:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
40s{color} | {color:red} ql: The patch generated 33 new + 71 unchanged - 17
fixed = 104 total (was 88) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 443b10b |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9040/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9040/yetus/whitespace-eol.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9040/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> PPD: Handle FLOAT boxing differently for single/double precision constants
> --
>
> Key: HIVE-18627
> URL: https://issues.apache.org/jira/browse/HIVE-18627
> Project: Hive
> Issue Type: Bug
> Components: Types
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-18627.1.patch
>
>
> Constants like 0.1 and 0.3 are differently boxed based on intermediate
> precision of the compiler codepath.
> Disabling CBO produces 0.1BD constants which fail to box correctly to
> Double/Float.
> Enabling CBO fixes this issue, but cannot be applied all queries in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants
[ https://issues.apache.org/jira/browse/HIVE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353566#comment-16353566 ] Prasanth Jayachandran commented on HIVE-18627: -- The logic looks good to me. Could you add test cases for these with/without CBO? > PPD: Handle FLOAT boxing differently for single/double precision constants > -- > > Key: HIVE-18627 > URL: https://issues.apache.org/jira/browse/HIVE-18627 > Project: Hive > Issue Type: Bug > Components: Types >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-18627.1.patch > > > Constants like 0.1 and 0.3 are differently boxed based on intermediate > precision of the compiler codepath. > Disabling CBO produces 0.1BD constants which fail to box correctly to > Double/Float. > Enabling CBO fixes this issue, but cannot be applied all queries in Hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
