[jira] [Commented] (HIVE-18628) Make tez dag status check interval configurable
[ https://issues.apache.org/jira/browse/HIVE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625015#comment-16625015 ] Prasanth Jayachandran commented on HIVE-18628: -- 2 polling interval (200ms and 1000ms) is changed to 1 configurable fixed interval (500ms). I think with HIVE-16635 the polling interval is 200ms until dag start. When dag goes to running state, the polling interval is changed to 1 second. Also when there are no WM triggers, there should be no counter aggregation in AM. [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java#L174] The making it configurable is intentional change, but making it slow isn't :) We can certainly change the default to 1000ms to get back the old behaviour (also not sure if the initial 200ms polling will be useful) > Make tez dag status check interval configurable > --- > > Key: HIVE-18628 > URL: https://issues.apache.org/jira/browse/HIVE-18628 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18628.1.patch > > > DAG status check interval in TezJobMonitor is not configurable. This can > cause cached data to be returned and fail some trigger validation tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18628) Make tez dag status check interval configurable
[ https://issues.apache.org/jira/browse/HIVE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624976#comment-16624976 ] Ashutosh Chauhan commented on HIVE-18628: - [~prasanth_j] This partly undid HIVE-16635 Was that intentional? Current default of 500ms may be too frequent to trigger counter computation in AM. HIVE-16635 was better as it progressively increased the interval. > Make tez dag status check interval configurable > --- > > Key: HIVE-18628 > URL: https://issues.apache.org/jira/browse/HIVE-18628 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18628.1.patch > > > DAG status check interval in TezJobMonitor is not configurable. This can > cause cached data to be returned and fail some trigger validation tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18628) Make tez dag status check interval configurable
[ https://issues.apache.org/jira/browse/HIVE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355167#comment-16355167 ] Prasanth Jayachandran commented on HIVE-18628: -- Test failures are unrelated. Committed patch to master. > Make tez dag status check interval configurable > --- > > Key: HIVE-18628 > URL: https://issues.apache.org/jira/browse/HIVE-18628 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18628.1.patch > > > DAG status check interval in TezJobMonitor is not configurable. This can > cause cached data to be returned and fail some trigger validation tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18628) Make tez dag status check interval configurable
[ https://issues.apache.org/jira/browse/HIVE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354474#comment-16354474 ] Prasanth Jayachandran commented on HIVE-18628: -- [~sershe] still discussing with tez team about aggregated counters when tasks are running. I will create a hive or tez ticket based on the response (not sure if there is a way in tez to get aggregated live counters when task is running, if there is a way it will be hive follow up else tez ticket) > Make tez dag status check interval configurable > --- > > Key: HIVE-18628 > URL: https://issues.apache.org/jira/browse/HIVE-18628 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-18628.1.patch > > > DAG status check interval in TezJobMonitor is not configurable. This can > cause cached data to be returned and fail some trigger validation tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18628) Make tez dag status check interval configurable
[ https://issues.apache.org/jira/browse/HIVE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354469#comment-16354469 ] Sergey Shelukhin commented on HIVE-18628: - +1. Should there be a Tez jira/follow up jira for the commented out test? That seems like a problem. > Make tez dag status check interval configurable > --- > > Key: HIVE-18628 > URL: https://issues.apache.org/jira/browse/HIVE-18628 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-18628.1.patch > > > DAG status check interval in TezJobMonitor is not configurable. This can > cause cached data to be returned and fail some trigger validation tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18628) Make tez dag status check interval configurable
[
https://issues.apache.org/jira/browse/HIVE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354311#comment-16354311
]
Hive QA commented on HIVE-18628:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12909392/HIVE-18628.1.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 24 failed/errored test(s), 12974 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries]
(batchId=240)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2]
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=79)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1]
(batchId=172)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=167)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mergejoin]
(batchId=166)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=161)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=122)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=221)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoDbName[Embedded]
(batchId=206)
org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCTAS (batchId=280)
org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCTAS (batchId=280)
org.apache.hadoop.hive.ql.exec.TestOperators.testNoConditionalTaskSizeForLlap
(batchId=282)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=256)
org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=234)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=234)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=234)
org.apache.hive.jdbc.TestTriggersMoveWorkloadManager.testTriggerMoveConflictKill
(batchId=235)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9052/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9052/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9052/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 24 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12909392 - PreCommit-HIVE-Build
> Make tez dag status check interval configurable
> ---
>
> Key: HIVE-18628
> URL: https://issues.apache.org/jira/browse/HIVE-18628
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-18628.1.patch
>
>
> DAG status check interval in TezJobMonitor is not configurable. This can
> cause cached data to be returned and fail some trigger validation tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18628) Make tez dag status check interval configurable
[
https://issues.apache.org/jira/browse/HIVE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354209#comment-16354209
]
Hive QA commented on HIVE-18628:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
38s{color} | {color:red} ql: The patch generated 3 new + 173 unchanged - 3
fixed = 176 total (was 176) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
15s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 27
unchanged - 0 fixed = 28 total (was 27) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 443b10b |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9052/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9052/yetus/diff-checkstyle-itests_hive-unit.txt
|
| modules | C: common ql itests/hive-unit U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9052/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Make tez dag status check interval configurable
> ---
>
> Key: HIVE-18628
> URL: https://issues.apache.org/jira/browse/HIVE-18628
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-18628.1.patch
>
>
> DAG status check interval in TezJobMonitor is not configurable. This can
> cause cached data to be returned and fail some trigger validation tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18628) Make tez dag status check interval configurable
[ https://issues.apache.org/jira/browse/HIVE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353563#comment-16353563 ] Prasanth Jayachandran commented on HIVE-18628: -- [~sershe] can you please take a look? > Make tez dag status check interval configurable > --- > > Key: HIVE-18628 > URL: https://issues.apache.org/jira/browse/HIVE-18628 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-18628.1.patch > > > DAG status check interval in TezJobMonitor is not configurable. This can > cause cached data to be returned and fail some trigger validation tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
