[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527014#comment-16527014
]
Hive QA commented on HIVE-18811:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12913564/changes.2
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12229/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12229/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12229/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-06-29 01:26:24.963
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-12229/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-06-29 01:26:24.966
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 1b3ac73 HIVE-20010: Fix create view over literals (Zoltan
Haindrich, reviewed by Ashutosh Chauhan, Daniel Dai)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 1b3ac73 HIVE-20010: Fix create view over literals (Zoltan
Haindrich, reviewed by Ashutosh Chauhan, Daniel Dai)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-06-29 01:26:25.559
+ rm -rf ../yetus_PreCommit-HIVE-Build-12229
+ mkdir ../yetus_PreCommit-HIVE-Build-12229
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-12229
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-12229/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
fatal: unrecognized input
fatal: unrecognized input
fatal: unrecognized input
The patch does not appear to apply with p0, p1, or p2
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-12229
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12913564 - PreCommit-HIVE-Build
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.2.0
>
> Attachments: HIVE_18811.2.patch, HIVE_18811.patch, changes, changes.2
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431840#comment-16431840
]
tartarus commented on HIVE-18811:
-
[~vgarg] Thank you for your reply! 3.1.0 is ok!
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.1.0
>
> Attachments: HIVE_18811.2.patch, HIVE_18811.patch, changes, changes.2
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391087#comment-16391087
]
tartarus commented on HIVE-18811:
-
[~pvary] I am not sure if I understand it correctly .
TestCliDriver's q.out is
{color:#d04437}ql/src/test/results/clientpositive/escape_comments.q.out{color}
and TestBeeLineDriver's q.out is
{color:#d04437}ql/src/test/results/clientpositive/beeline/escape_comments.q.out{color}
Because the Beeline original is right, only CLI is error when comment contain
'\t',
and the lastest patch I only fix error on CLI , what does your suggetion ? what
need I do next ?
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.2.patch, HIVE_18811.patch, changes, changes.2
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391050#comment-16391050
]
Peter Vary commented on HIVE-18811:
---
[~tartarus]: TestBeeLineDriver is not supposed to be running with the same
q.out files as the TestCliDriver only for specific tests. Escape-comments.q is
not one of these. If the q.out needs '\\' after the patch this means, that the
CLI output is changed and '\\' is added. I think this is a side-effect of the
patch, which needs to be addressed, if I am right.
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.2.patch, HIVE_18811.patch, changes, changes.2
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391035#comment-16391035
]
tartarus commented on HIVE-18811:
-
[~pvary] : Unfortunately this test case is faild original. You can test it
through
{code:java}
cd itests/qtest
mvn test -Dtest=TestBeeLineDriver -Dqfile=escape_comments.q
{code}
So I guess the original file
{color:#d04437}ql/src/test/results/clientpositive/beeline/escape_comments.q.out
{color}is error ！！
Please confirm it.
Thanks
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.2.patch, HIVE_18811.patch, changes, changes.2
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390982#comment-16390982
]
Peter Vary commented on HIVE-18811:
---
[~tartarus]: I am concerned because of this change:
- File: escape_comments.q.out
|81|col1 string a\\nb\\t\\'\\;|
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.2.patch, HIVE_18811.patch, changes, changes.2
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390930#comment-16390930
]
tartarus commented on HIVE-18811:
-
[~pvary] I have fix the bug, please take a look at
{color:#d04437}HIVE_18811.2.patch{color} and {color:#d04437}changes.2
{color:#33}.{color}{color}
{color:#33}Thanks.{color}
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.2.patch, HIVE_18811.patch, changes, changes.2
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390779#comment-16390779
]
tartarus commented on HIVE-18811:
-
[~pvary] sorry，I ignored the Beeline before. I will fix it.
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch, changes
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390320#comment-16390320
]
Peter Vary commented on HIVE-18811:
---
[~tartarus]: The following two output looks incorrect to me:
{code:java}
describe escape_column_comments;
Beeline patch
[..]
| col1 | string | test\\tcol1 |
[..]
| part1 | string | test\\tpart1 |
[..]
| part1 | string | test\\tpart1 |
describe formatted escape_column_comments;
Beeline patch
[..]
| col1 | string | test\\tcol1 |
[..]
| part1 | string | test\\tpart1 |
[..]{code}
What do you think?
Thanks,
Peter
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch, changes
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390220#comment-16390220
]
Hive QA commented on HIVE-18811:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12913372/changes
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9538/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9538/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9538/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-03-07 20:56:40.256
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-9538/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-03-07 20:56:40.259
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 0cfd4fe HIVE-17163: Microbenchmark for vector op processing
(Prasanth Jayachandran, reviewed by Matt McCline)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 0cfd4fe HIVE-17163: Microbenchmark for vector op processing
(Prasanth Jayachandran, reviewed by Matt McCline)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-03-07 20:56:42.444
+ rm -rf ../yetus_PreCommit-HIVE-Build-9538
+ mkdir ../yetus_PreCommit-HIVE-Build-9538
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-9538
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-9538/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
fatal: unrecognized input
fatal: unrecognized input
fatal: unrecognized input
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12913372 - PreCommit-HIVE-Build
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch, changes
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389459#comment-16389459
]
tartarus commented on HIVE-18811:
-
[~pvary] Thanks for your suggestions！Looking forward to your reply .
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch, changes
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389455#comment-16389455
]
tartarus commented on HIVE-18811:
-
[~pvary] please take a look，what need I do else？
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch, changes
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389453#comment-16389453
]
Peter Vary commented on HIVE-18811:
---
Will take a look at the file soon.
Thanks for working on this!
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch, changes
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389450#comment-16389450
]
Peter Vary commented on HIVE-18811:
---
Doh... pretty was removed by HIVE-17540 :)
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch, changes
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389445#comment-16389445
]
tartarus commented on HIVE-18811:
-
[~pvary] hello, Peter, I have upload my {color:#d04437}changes{color} file,
but execute
describe pretty escape_column_comments;
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch, changes
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389315#comment-16389315
]
Peter Vary commented on HIVE-18811:
---
[~tartarus]: More like create the "my_new_table" with '\t' in the comments and
run the following commands in BeeLine, and in HiveCLI manually, to see the
changes before and after the patch:
{code:java}
describe my_new_table;
describe formatted my_new_table;
describe pretty my_new_table;{code}
Creating a file like the [^changes] in HIVE-14146 to see what is changed after
the patch would be nice.
Thanks,
Peter
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389276#comment-16389276
]
tartarus commented on HIVE-18811:
-
[~pvary] Do you mean manually modify test BeeLine result file
{color:#d04437}ql/src/test/results/clientpositive/beeline/escape_comments.q.out{color}
?
I have test through execute such command :
{color:#d04437}cd itests/qtest{color}
{color:#d04437}mvn test -Dtest=TestCliDriver -Dqfile=escape_comments.q{color}
{color:#d04437}mvn test -Dtest=TestBeeLineDriver
-Dqfile=escape_comments.q{color}
I have update such files:
ql/src/test/results/clientpositive/beeline/escape_comments.q.out
ql/src/test/results/clientpositive/escape_comments.q.out
ql/src/test/queries/clientpositive/escape_comments.q
thanks for your review
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387908#comment-16387908
]
Peter Vary commented on HIVE-18811:
---
When I was working on this part of the code, I have found that the qtests are
checking only the HiveCLI output, and this part of the code is significantly
different between HiveCLI, and BeeLine.
When working on HIVE-14146 I ended up checking the output manually.
@tartarus: Could you please provide the output in both cases?
Thanks,
Peter
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385793#comment-16385793
]
tartarus commented on HIVE-18811:
-
[~vgarg] ，please take a look，I has fix failed tests and add new tests.
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384943#comment-16384943
]
Hive QA commented on HIVE-18811:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12912877/HIVE_18811.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 13038 tests
executed
*Failed tests:*
{noformat}
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=93)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384933#comment-16384933
]
Hive QA commented on HIVE-18811:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9468/dev-support/hive-personality.sh
|
| git revision | master / 05d4719 |
| Default Java | 1.8.0_111 |
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9468/yetus/patch-asflicense-problems.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9468/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384606#comment-16384606
]
tartarus commented on HIVE-18811:
-
[~vgarg] Thanks for your reminder ！{{escape_comments}} failure due to my
patch, and I have fix it.
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384476#comment-16384476
]
tartarus commented on HIVE-18811:
-
[~vgarg] Thanks for your reminder, I will confirm it again.
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384031#comment-16384031
]
Vineet Garg commented on HIVE-18811:
[~tartarus] Unfortunately the link to test report is invalid now but
{{escape_comments}} failure looked to be due to your patch.
bq. How can I provide test cases for this patch?
You can add the reproducer you provided to escape_comments.q and generate an
updated escape_comments.q.out. You can find more details at [Wiki
page|https://cwiki.apache.org/confluence/display/Hive/HiveDeveloperFAQ#HiveDeveloperFAQ-Testing]
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381625#comment-16381625
]
tartarus commented on HIVE-18811:
-
[~vgarg] I don't think this failed tests is related to my patch. How can I
provide test cases for this patch?
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381487#comment-16381487
]
Vineet Garg commented on HIVE-18811:
[~tartarus] Can you look into test failures? Can you also provide test for this
patch?
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381462#comment-16381462
]
tartarus commented on HIVE-18811:
-
[~vgumashta] hello, I have fix this issue , please review
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#ff}\t{color}zm');
> then execute : {color:#ff}desc zhangmang_test {color}
> {color:#ff}{color:#33}return :{color} name string
> name{color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378274#comment-16378274
]
Hive QA commented on HIVE-18811:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12912179/HIVE_18811.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 30 failed/errored test(s), 13016 tests
executed
*Failed tests:*
{noformat}
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=93)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378222#comment-16378222
]
Hive QA commented on HIVE-18811:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
12s{color} | {color:red} The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 17s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9382/dev-support/hive-personality.sh
|
| git revision | master / ea53203 |
| Default Java | 1.8.0_111 |
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9382/yetus/patch-asflicense-problems.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9382/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#FF}\t{color}zm');
> then execute : {color:#FF}desc zhangmang_test {color}
> {color:#FF}{color:#33}return : name string
> name{color}
> {color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378173#comment-16378173
]
merrily01 commented on HIVE-18811:
--
very useful
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#FF}\t{color}zm');
> then execute : {color:#FF}desc zhangmang_test {color}
> {color:#FF}{color:#33}return : name string
> name{color}
> {color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378133#comment-16378133
]
maobaolong commented on HIVE-18811:
---
LGTM. Thank you for your contribution.
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#FF}\t{color}zm');
> then execute : {color:#FF}desc zhangmang_test {color}
> {color:#FF}{color:#33}return : name string
> name{color}
> {color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378114#comment-16378114
]
leiqiang commented on HIVE-18811:
-
It's useful
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#FF}\t{color}zm');
> then execute : {color:#FF}desc zhangmang_test {color}
> {color:#FF}{color:#33}return : name string
> name{color}
> {color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-18811) Fix desc table, column comments are not displayed
[
https://issues.apache.org/jira/browse/HIVE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377921#comment-16377921
]
tartarus commented on HIVE-18811:
-
[~prasanth_j] hello , please review
> Fix desc table, column comments are not displayed
> -
>
> Key: HIVE-18811
> URL: https://issues.apache.org/jira/browse/HIVE-18811
> Project: Hive
> Issue Type: Bug
> Components: CLI
>Affects Versions: 1.2.1, 2.3.2
> Environment: CentOS 6.5
> Hive-1.2.1
> Hive-3.0.0
>Reporter: tartarus
>Assignee: tartarus
>Priority: Major
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HIVE_18811.patch
>
>
> when column comment contain \t
> eg: CREATE TABLE `zhangmang_test`(`name` string COMMENT
> 'name{color:#FF}\t{color}zm');
> then execute : {color:#FF}desc zhangmang_test {color}
> {color:#FF}{color:#33}return : name string
> name{color}
> {color}
> because \t is the separator, so we should translate it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
