[jira] [Commented] (HIVE-19404) Revise DDL Task Result Logging
[
https://issues.apache.org/jira/browse/HIVE-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526767#comment-16526767
]
Andrew Sherman commented on HIVE-19404:
---
Thanks [~ychena]
> Revise DDL Task Result Logging
> --
>
> Key: HIVE-19404
> URL: https://issues.apache.org/jira/browse/HIVE-19404
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Affects Versions: 3.0.0, 2.4.0
>Reporter: BELUGA BEHR
>Assignee: Andrew Sherman
>Priority: Trivial
> Labels: noob
> Fix For: 4.0.0
>
> Attachments: HIVE-19404.1.patch
>
>
> There is some logging in {{DDLTask}} that can be made better:
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: results : 706
> {code}
> This logging should either be demoted to _debug_ level logging and/or
> requires additional context.
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: Found 706 tables that match the
> SHOW DATABASE statement
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19404) Revise DDL Task Result Logging
[
https://issues.apache.org/jira/browse/HIVE-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525833#comment-16525833
]
Yongzhi Chen commented on HIVE-19404:
-
The change looks fine. +1
> Revise DDL Task Result Logging
> --
>
> Key: HIVE-19404
> URL: https://issues.apache.org/jira/browse/HIVE-19404
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Affects Versions: 3.0.0, 2.4.0
>Reporter: BELUGA BEHR
>Assignee: Andrew Sherman
>Priority: Trivial
> Labels: noob
> Attachments: HIVE-19404.1.patch
>
>
> There is some logging in {{DDLTask}} that can be made better:
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: results : 706
> {code}
> This logging should either be demoted to _debug_ level logging and/or
> requires additional context.
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: Found 706 tables that match the
> SHOW DATABASE statement
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19404) Revise DDL Task Result Logging
[
https://issues.apache.org/jira/browse/HIVE-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525006#comment-16525006
]
Hive QA commented on HIVE-19404:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12929268/HIVE-19404.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14609 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12186/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12186/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12186/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12929268 - PreCommit-HIVE-Build
> Revise DDL Task Result Logging
> --
>
> Key: HIVE-19404
> URL: https://issues.apache.org/jira/browse/HIVE-19404
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Affects Versions: 3.0.0, 2.4.0
>Reporter: BELUGA BEHR
>Assignee: Andrew Sherman
>Priority: Trivial
> Labels: noob
> Attachments: HIVE-19404.1.patch
>
>
> There is some logging in {{DDLTask}} that can be made better:
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: results : 706
> {code}
> This logging should either be demoted to _debug_ level logging and/or
> requires additional context.
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: Found 706 tables that match the
> SHOW DATABASE statement
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19404) Revise DDL Task Result Logging
[
https://issues.apache.org/jira/browse/HIVE-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524968#comment-16524968
]
Hive QA commented on HIVE-19404:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
1s{color} | {color:blue} ql in master has 2280 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12186/dev-support/hive-personality.sh
|
| git revision | master / c7fe4ef |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12186/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Revise DDL Task Result Logging
> --
>
> Key: HIVE-19404
> URL: https://issues.apache.org/jira/browse/HIVE-19404
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Affects Versions: 3.0.0, 2.4.0
>Reporter: BELUGA BEHR
>Assignee: Andrew Sherman
>Priority: Trivial
> Labels: noob
> Attachments: HIVE-19404.1.patch
>
>
> There is some logging in {{DDLTask}} that can be made better:
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: results : 706
> {code}
> This logging should either be demoted to _debug_ level logging and/or
> requires additional context.
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: Found 706 tables that match the
> SHOW DATABASE statement
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19404) Revise DDL Task Result Logging
[
https://issues.apache.org/jira/browse/HIVE-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520912#comment-16520912
]
Andrew Sherman commented on HIVE-19404:
---
Proposed new logging:
2018-06-22T17:00:17,048 INFO [bd2d27a2-0a87-4c9c-827a-628afe6fb741 main]
exec.DDLTask: Found 1 database(s) matching the SHOW DATABASES statement.
2018-06-22T17:00:17,078 INFO [bd2d27a2-0a87-4c9c-827a-628afe6fb741 main]
exec.DDLTask: Found 1 function(s) matching the SHOW FUNCTIONS statement.
2018-06-22T17:00:17,124 DEBUG [bd2d27a2-0a87-4c9c-827a-628afe6fb741 main]
exec.DDLTask: Found 2 tables/view(s) matching the SHOW TABLES/VIEWS statement.
2018-06-22T17:00:17,164 DEBUG [bd2d27a2-0a87-4c9c-827a-628afe6fb741 main]
exec.DDLTask: Found 0 tables/view(s) matching the SHOW TABLES/VIEWS statement.
2018-06-22T17:00:17,212 INFO [bd2d27a2-0a87-4c9c-827a-628afe6fb741 main]
exec.DDLTask: Found 1 table(s) matching the SHOW TABLE EXTENDED statement.
> Revise DDL Task Result Logging
> --
>
> Key: HIVE-19404
> URL: https://issues.apache.org/jira/browse/HIVE-19404
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Affects Versions: 3.0.0, 2.4.0
>Reporter: BELUGA BEHR
>Assignee: Andrew Sherman
>Priority: Trivial
> Labels: noob
>
> There is some logging in {{DDLTask}} that can be made better:
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: results : 706
> {code}
> This logging should either be demoted to _debug_ level logging and/or
> requires additional context.
> {code}
> 2018-05-03 03:08:32,524 INFO hive.ql.exec.DDLTask:
> [HiveServer2-Background-Pool: Thread-101980]: Found 706 tables that match the
> SHOW DATABASE statement
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
