[jira] [Commented] (HIVE-19560) Retry test runner and retry rule for flaky tests
[ https://issues.apache.org/jira/browse/HIVE-19560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476729#comment-16476729 ] Vineet Garg commented on HIVE-19560: Sounds good. > Retry test runner and retry rule for flaky tests > > > Key: HIVE-19560 > URL: https://issues.apache.org/jira/browse/HIVE-19560 > Project: Hive > Issue Type: Improvement > Components: Test >Affects Versions: 3.1.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Fix For: 3.1.0 > > Attachments: HIVE-19560.1.patch > > > Implement custom test runner that retries failed tests as a workaround for > flakiness. Also a test rule for retrying failed tests (for cases where custom > test runner is not possible, e.g ParametrizedTests which already is a > customer TestRunner). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19560) Retry test runner and retry rule for flaky tests
[ https://issues.apache.org/jira/browse/HIVE-19560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476444#comment-16476444 ] Jesus Camacho Rodriguez commented on HIVE-19560: [~vgarg], only two tests are currently being annotated, and the repetition only happens when there is a failure, hence we should be fine. Uploading patch again to retrigger run will cause more delay. +1 > Retry test runner and retry rule for flaky tests > > > Key: HIVE-19560 > URL: https://issues.apache.org/jira/browse/HIVE-19560 > Project: Hive > Issue Type: Improvement > Components: Test >Affects Versions: 3.1.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-19560.1.patch > > > Implement custom test runner that retries failed tests as a workaround for > flakiness. Also a test rule for retrying failed tests (for cases where custom > test runner is not possible, e.g ParametrizedTests which already is a > customer TestRunner). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19560) Retry test runner and retry rule for flaky tests
[ https://issues.apache.org/jira/browse/HIVE-19560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476442#comment-16476442 ] Prasanth Jayachandran commented on HIVE-19560: -- No this will not. Each test has to be explicitly annotated with RetryTestRunner or Retry test rule. In the patch I have annotated only 2 tests. > Retry test runner and retry rule for flaky tests > > > Key: HIVE-19560 > URL: https://issues.apache.org/jira/browse/HIVE-19560 > Project: Hive > Issue Type: Improvement > Components: Test >Affects Versions: 3.1.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-19560.1.patch > > > Implement custom test runner that retries failed tests as a workaround for > flakiness. Also a test rule for retrying failed tests (for cases where custom > test runner is not possible, e.g ParametrizedTests which already is a > customer TestRunner). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19560) Retry test runner and retry rule for flaky tests
[ https://issues.apache.org/jira/browse/HIVE-19560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476439#comment-16476439 ] Vineet Garg commented on HIVE-19560: I guess this will increase our ptest time? > Retry test runner and retry rule for flaky tests > > > Key: HIVE-19560 > URL: https://issues.apache.org/jira/browse/HIVE-19560 > Project: Hive > Issue Type: Improvement > Components: Test >Affects Versions: 3.1.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-19560.1.patch > > > Implement custom test runner that retries failed tests as a workaround for > flakiness. Also a test rule for retrying failed tests (for cases where custom > test runner is not possible, e.g ParametrizedTests which already is a > customer TestRunner). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19560) Retry test runner and retry rule for flaky tests
[ https://issues.apache.org/jira/browse/HIVE-19560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476431#comment-16476431 ] Prasanth Jayachandran commented on HIVE-19560: -- [~jcamachorodriguez] can you please take a look? > Retry test runner and retry rule for flaky tests > > > Key: HIVE-19560 > URL: https://issues.apache.org/jira/browse/HIVE-19560 > Project: Hive > Issue Type: Improvement > Components: Test >Affects Versions: 3.1.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-19560.1.patch > > > Implement custom test runner that retries failed tests as a workaround for > flakiness. Also a test rule for retrying failed tests (for cases where custom > test runner is not possible, ParametrizedTests already uses a TestRunner). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
